Re: [Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Aurelien Jarno
Avi Kivity a écrit : > On 07/12/2010 05:57 PM, Juan Quintela wrote: >> Please send in any agenda items you are interested in covering. >> >> > > 0.12.n+1 > I won't be at the KVM call, but I can work on that in the next days. Basically the stable tree already contains a lot of fixes and we c

Re: [Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Gleb Natapov
On Mon, Jul 12, 2010 at 06:00:20PM -0500, Anthony Liguori wrote: > On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: > >On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > >>On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >>>We do range check for size, and get size as buffer, > >

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Avi Kivity
On 07/12/2010 05:57 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. kvm testsuite -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-07-12 Thread Коренберг Марк
New links: http://dl3.ideco-software.ru/IdecoICS/IdecoICS_343_102.iso http://dl1.ideco-software.ru/IdecoICS/IdecoICS_343_102.iso http://dl2.ideco-software.ru/IdecoICS/IdecoICS_343_102.iso For some reason the fall of KVM are much rarer, though earlier it fell each time. I noticed that more often t

[Qemu-devel] Re: [PATCH 0/8] vlan cleanup

2010-07-12 Thread Jan Kiszka
Miguel Di Ciurcio Filho wrote: > This series removes the vlan stuff without mercy. I've tried to make the steps > as small as possible, but the last one is huge. I did some basic tests and > networking is still working, so reviews are welcome :-D Sorry, this is a bit too rude. This not only remove

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Avi Kivity
On 07/13/2010 01:08 AM, Anthony Liguori wrote: On 07/12/2010 05:07 PM, Anthony Liguori wrote: On 07/12/2010 04:57 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. 0.13 ;-) - vCPU limits; how much testing has

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Avi Kivity
On 07/12/2010 05:57 PM, Juan Quintela wrote: Please send in any agenda items you are interested in covering. 0.12.n+1 -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.

[Qemu-devel] [PATCH v3 0/4] pci: split out bridge code into pci_bridge and make it library

2010-07-12 Thread Isaku Yamahata
Changes v2 -> v1: - dropped first patch as it is merdged. - rebased to mst's pci branch. - eliminated pci_brdige_qdev_register(), pci_brdige_create(), pci_brdige_create_simple() by exporting PCIBus and PCIBridge. Patch description: Now pci.c has grown. So split bridge related code into dedicated

[Qemu-devel] [PATCH v3 1/4] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c

2010-07-12 Thread Isaku Yamahata
Move pci bridge related code into pci_bridge.c from pci.c for further enhancement. pci.c is big enough now, so split it out. No code change but exporting some accesser functions. In fact, few pci bridge functions stays in pci.c. Signed-off-by: Isaku Yamahata --- Makefile.objs |2 +- hw/ap

[Qemu-devel] [PATCH v3 4/4] pci_bridge: introduce pci bridge library.

2010-07-12 Thread Isaku Yamahata
introduce pci bridge library. convert apb bridge and dec p2p bridge to use new pci bridge library. save/restore is supported as a side effect. This is also preparation for pci express root/upstream/downstream port. Signed-off-by: Isaku Yamahata --- changes v2 -> v3: eliminate pci_bridge_qdev_reg

[Qemu-devel] [Bug 604872] Re: qemu-system-arm segfaults emulating versatile machine after running debootstrap --second-stage inside vm

2010-07-12 Thread Ricardo Salveti
I'm also able to reproduce with upstream Qemu, hash aa5fb7b3bf388d643bd9c6e6fee9ace5db2e590f I: Base system installed successfully. I: Starting basic services in VM Program received signal SIGSEGV, Segmentation fault. 0x8be2208b in ?? () (gdb) bt full #0 0x8be2208b in ?? () No sy

[Qemu-devel] [PATCH v3 3/4] pci_bridge: clean up: remove pci_{register, unregister}_secondary_bus()

2010-07-12 Thread Isaku Yamahata
Remove pci_{register, unregister}_secondary_bus() by open code. They are old stype API and aren't used any more by others. So eliminate it. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c | 32 ++-- 1 files changed, 10 insertions(+), 22 deletions(-) diff --git a/

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-07-12 Thread Ricardo Salveti
For the seg fault bug I've created the bug 604872. Meanwhile I'll try to reproduce the hang problem with Maverick and upstream Qemu. -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member

[Qemu-devel] [PATCH v3 2/4] pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.

2010-07-12 Thread Isaku Yamahata
To avoid confusion of primary bus with secondary bus, rename PCIBridge::bus to PCIBridge::sec_bus. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c| 10 -- hw/pci_internals.h |2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.

[Qemu-devel] [Bug 604872] Re: qemu-system-arm segfaults emulating versatile machine after running debootstrap --second-stage inside vm

2010-07-12 Thread Ricardo Salveti
If you're at Lucid or Maverick, you can also create the rootfs img by running the attached rootstock script. Please install all rootstock dependencies by installing the official version provided by the distro: sudo apt-get install rootstock Using the attached script: sudo bash ./rootstock --fqdn

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation.

2010-07-12 Thread Isaku Yamahata
On Mon, Jul 12, 2010 at 08:50:55PM -0400, Kevin O'Connor wrote: > On Mon, Jul 12, 2010 at 08:47:45PM +0900, Isaku Yamahata wrote: > > This patch set abstract out chipset specific operation, > > and spit out i440fx specific operation into dev-i440fx.c with it. > > Thus q35 specific register value/op

[Qemu-devel] Re: [PATCH] set proper migration status on ->write error (v3)

2010-07-12 Thread Luiz Capitulino
On Fri, 9 Jul 2010 15:18:51 -0300 Marcelo Tosatti wrote: > > If ->write fails, declare migration status as MIG_STATE_ERROR. > > Also, in buffered_file.c, ->close the object in case of an > error. > > Fixes "migrate -d "exec:dd of=file", where dd fails to open file. > > Signed-off-by: Marcel

[Qemu-devel] Re: [SeaBIOS] [PATCH 6/7] seabios: acpi: split out piix4 pm logic.

2010-07-12 Thread Kevin O'Connor
On Mon, Jul 12, 2010 at 08:47:51PM +0900, Isaku Yamahata wrote: > split out piix4 pm logic. [...] > @@ -202,11 +203,6 @@ static inline u16 cpu_to_le16(u16 x) > return x; > } > > -static inline u32 cpu_to_le32(u32 x) > -{ > -return x; > -} This is a nitpick, but if cpu_to_le32() is move

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/7] seabios: shadow: make device finding more generic.

2010-07-12 Thread Kevin O'Connor
On Mon, Jul 12, 2010 at 08:47:47PM +0900, Isaku Yamahata wrote: > pam register offset is north bridge specific. > So determine the offset based on found north bridge. Is it really just the offset that is north bridge specific? I thought the entire process was very north bridge specific. If so, I

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/7] abstract chipset(i440fx) specific register operation.

2010-07-12 Thread Kevin O'Connor
On Mon, Jul 12, 2010 at 08:47:45PM +0900, Isaku Yamahata wrote: > This patch set abstract out chipset specific operation, > and spit out i440fx specific operation into dev-i440fx.c with it. > Thus q35 specific register value/operation will be added easily. Hi Isaku, Can you give a brief overview

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 05:42 PM, Michael S. Tsirkin wrote: On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but pu

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >We do range check for size, and get size as buffer, > >but copy size + 4 bytes (4 is for FCS). > >Let's copy size bytes but put size + 4 in length. > > > >Signed-off-by: Michael S

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Anthony Liguori
On 07/12/2010 05:07 PM, Anthony Liguori wrote: On 07/12/2010 04:57 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. 0.13 ;-) - vCPU limits; how much testing has anyone done of 64-way guests? - Finding a way t

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Anthony Liguori
On 07/12/2010 04:57 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. 0.13 ;-) - vCPU limits; how much testing has anyone done of 64-way guests? - Finding a way to enable virtio by default; any cl

[Qemu-devel] Re: KVM Call agenda for July 13th

2010-07-12 Thread Chris Wright
* Juan Quintela (quint...@redhat.com) wrote: > > Please send in any agenda items you are interested in covering. 0.13 ;-)

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 04:30 PM, Michael S. Tsirkin wrote: On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but pu

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 04:07:21PM -0500, Anthony Liguori wrote: > On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: > >We do range check for size, and get size as buffer, > >but copy size + 4 bytes (4 is for FCS). > >Let's copy size bytes but put size + 4 in length. > > > >Signed-off-by: Michael S

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Anthony Liguori
On 07/12/2010 12:48 PM, Michael S. Tsirkin wrote: We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but put size + 4 in length. Signed-off-by: Michael S. Tsirkin I think I'd feel slightly better if we zero'd out the FCS before

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Josef Bacik
On Mon, Jul 12, 2010 at 10:23:14PM +0200, Giangiacomo Mariotti wrote: > On Mon, Jul 12, 2010 at 3:43 PM, Josef Bacik wrote: > > > > O_DIRECT support was just introduced recently, please try on the latest > > kernel > > with the normal settings (which IIRC uses O_DIRECT), that should make things >

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Giangiacomo Mariotti
On Mon, Jul 12, 2010 at 3:43 PM, Josef Bacik wrote: > > O_DIRECT support was just introduced recently, please try on the latest kernel > with the normal settings (which IIRC uses O_DIRECT), that should make things > suck alot less.  Thanks, > > Josef > With latest kernel do you mean the current Li

[Qemu-devel] Re: [PATCH RFC] e1000: secrc support

2010-07-12 Thread Alex Williamson
On Mon, 2010-07-12 at 20:49 +0300, Michael S. Tsirkin wrote: > Add support for secrc field. Reportedly needed by old RHEL guests. > > Signed-off-by: Michael S. Tsirkin > --- > hw/e1000.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > Anthony, Alex, please review. A

[Qemu-devel] Re: [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Alex Williamson
On Mon, 2010-07-12 at 20:48 +0300, Michael S. Tsirkin wrote: > We do range check for size, and get size as buffer, > but copy size + 4 bytes (4 is for FCS). > Let's copy size bytes but put size + 4 in length. > > Signed-off-by: Michael S. Tsirkin > --- > > Anthony, Alex, please review. Looks fi

[Qemu-devel] [PATCH 4/8] vlan cleanup: do not build socket and dump

2010-07-12 Thread Miguel Di Ciurcio Filho
--- Makefile.objs |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 67f1b21..5442901 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -23,8 +23,6 @@ block-obj-y += $(addprefix block/, $(block-nested-y)) net-obj-y = net.o net-nested-

[Qemu-devel] [PATCH 8/8] vlan cleanup: remove usage of VLANState

2010-07-12 Thread Miguel Di Ciurcio Filho
--- hw/qdev-properties.c | 39 -- hw/qdev.c|2 - hw/qdev.h|5 - hw/xen_devconfig.c |8 +- hw/xen_nic.c |1 - net.c| 323 + net.h| 10 -- net/slirp.c |

[Qemu-devel] [PATCH 2/8] vlan cleanup: update options

2010-07-12 Thread Miguel Di Ciurcio Filho
--- qemu-options.hx | 120 --- 1 files changed, 17 insertions(+), 103 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index d1d2272..1cf2bf2 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -956,24 +956,24 @@ DEF("smb", HAS_ARG

[Qemu-devel] [PATCH 7/8] vlan cleanup: remove legacy monitor commands

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net.c | 60 --- net.h |2 - qemu-monitor.hx | 28 - 3 files changed, 0 insertions(+), 90 deletions(-) diff --git a/net.c b/net.c index addd167..2c1c50f 100644 --- a/net.c +++ b/net.c @@ -10

[Qemu-devel] [PATCH 6/8] vlan cleanup: remove dump.h and dump.c

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net/dump.c | 159 net/dump.h | 33 2 files changed, 0 insertions(+), 192 deletions(-) diff --git a/net/dump.c b/net/dump.c deleted file mode 100644 index 6db7ecf..000 --- a/net/dump.c +++ /dev/null @@ -1,159 +0,0

[Qemu-devel] [PATCH 3/8] vlan cleanup: do not depend on socket and dump

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net.c | 42 -- 1 files changed, 0 insertions(+), 42 deletions(-) diff --git a/net.c b/net.c index 8ddf872..addd167 100644 --- a/net.c +++ b/net.c @@ -26,8 +26,6 @@ #include "config-host.h" #include "net/tap.h" -#include "net/socket.h" -#include "n

[Qemu-devel] [PATCH 5/8] vlan cleanup: remove socket.h and socket.c

2010-07-12 Thread Miguel Di Ciurcio Filho
--- net/socket.c | 573 -- net/socket.h | 33 2 files changed, 0 insertions(+), 606 deletions(-) diff --git a/net/socket.c b/net/socket.c deleted file mode 100644 index 1c4e153..000 --- a/net/socket.c +++ /dev/null @@ -1,573 +0,0

[Qemu-devel] [PATCH 1/8] vlan cleanup: update documentation

2010-07-12 Thread Miguel Di Ciurcio Filho
--- qemu-doc.texi | 24 +++- 1 files changed, 3 insertions(+), 21 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index e2c8e56..d5bf318 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -624,19 +624,7 @@ qemu linux2.img -hdb nbd:unix:/tmp/my_socket @section Network

[Qemu-devel] [PATCH 0/8] vlan cleanup

2010-07-12 Thread Miguel Di Ciurcio Filho
This series removes the vlan stuff without mercy. I've tried to make the steps as small as possible, but the last one is huge. I did some basic tests and networking is still working, so reviews are welcome :-D A next step would be to rename VLANClientState and other structures to more proper names

Re: [Qemu-devel] [PATCH 04/15] ebus: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
On Mon, Jul 12, 2010 at 7:03 PM, Artyom Tarasenko wrote: > 2010/7/12 Blue Swirl : >> Use pci_bar_map() instead of a mapping function. >> >> Signed-off-by: Blue Swirl >> --- >>  hw/isa.h      |    1 + >>  hw/isa_mmio.c |   17 +++-- >>  hw/sun4u.c    |   29 ++---

[Qemu-devel] [PATCH 09/15] cmd646: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/ide/cmd646.c | 149 ++- 1 files changed, 92 insertions(+), 57 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index ff80dd5..ec080e0 100644 --- a/hw

Re: [Qemu-devel] [PATCH 04/15] ebus: convert to pci_bar_map

2010-07-12 Thread Artyom Tarasenko
2010/7/12 Blue Swirl : > Use pci_bar_map() instead of a mapping function. > > Signed-off-by: Blue Swirl > --- >  hw/isa.h      |    1 + >  hw/isa_mmio.c |   17 +++-- >  hw/sun4u.c    |   29 ++--- >  3 files changed, 26 insertions(+), 21 deletions(-) > > diff --g

[Qemu-devel] [PATCH 14/15] usb-uhci: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/usb-uhci.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 1d83400..2e1f5ee 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.

[Qemu-devel] [PATCH 11/15] pcnet: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/pcnet.c | 62 +-- 1 files changed, 30 insertions(+), 32 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.c index 5e75930..deb6f6a 100644 --- a/hw/pcnet.c ++

[Qemu-devel] [PATCH 08/15] piix: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/ide/piix.c | 72 +++- 1 files changed, 45 insertions(+), 27 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 07483e8..959e061 100644 --- a/hw/ide/

[Qemu-devel] [PATCH 10/15] openpic: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/openpic.c | 36 +--- 1 files changed, 5 insertions(+), 31 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 01bf15f..3f97afd 100644 --- a/hw/openpic.c +++ b/hw/openpic.c

[Qemu-devel] [PATCH 07/15] via: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/ide/via.c | 65 - 1 files changed, 41 insertions(+), 24 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index b2c7cad..36901b3 100644 --- a/hw/ide/vi

[Qemu-devel] [PATCH 15/15] wdt_i6300esb: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/wdt_i6300esb.c | 38 ++ 1 files changed, 14 insertions(+), 24 deletions(-) diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c index 46e1df8..24409ec 100644 --- a/hw/wdt_i6300e

[Qemu-devel] [PATCH 05/15] macio: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/macio.c| 107 hw/ppc_mac.h |5 +- hw/ppc_newworld.c |2 +- hw/ppc_oldworld.c |4 +- 4 files changed, 39 insertions(+), 79 deletions(-)

[Qemu-devel] [PATCH 13/15] usb-ohci: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/usb-ohci.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index c60fd8d..992400e 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -1717,13 +1717,6 @

[Qemu-devel] [PATCH 03/15] es1370: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/es1370.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 40cb48c..df6b4d1 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -906

[Qemu-devel] [PATCH 12/15] rtl8139: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/rtl8139.c | 42 -- 1 files changed, 16 insertions(+), 26 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 441f0a9..18721dd 100644 --- a/hw/rtl8139.c +++ b/hw/rt

[Qemu-devel] [PATCH 02/15] pci: handle BAR mapping at PCI level

2010-07-12 Thread Blue Swirl
Move IOIO and MMIO BAR mapping to pci.c. Signed-off-by: Blue Swirl --- hw/pci.c | 166 -- hw/pci.h | 14 +- 2 files changed, 121 insertions(+), 59 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a3c2873..2234717 100644 --- a

[Qemu-devel] [PATCH 06/15] ne2000: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/ne2000.c | 66 +++--- 1 files changed, 44 insertions(+), 22 deletions(-) diff --git a/hw/ne2000.c b/hw/ne2000.c index 126e7cf..2b1e1ad 100644 --- a/hw/ne2000.c

[Qemu-devel] [PATCH 04/15] ebus: convert to pci_bar_map

2010-07-12 Thread Blue Swirl
Use pci_bar_map() instead of a mapping function. Signed-off-by: Blue Swirl --- hw/isa.h |1 + hw/isa_mmio.c | 17 +++-- hw/sun4u.c| 29 ++--- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/hw/isa.h b/hw/isa.h index aaf0272..6

[Qemu-devel] [PATCH 01/15] ioport: separate registration from mapping

2010-07-12 Thread Blue Swirl
Add I/O port registration functions which separate registration from the mapping stage. Signed-off-by: Blue Swirl --- ioport.c | 117 +++-- ioport.h |6 +++ 2 files changed, 111 insertions(+), 12 deletions(-) diff --git a/ioport.c b/i

[Qemu-devel] [PATCH v2 00/15] pci: handle BAR mapping at PCI level

2010-07-12 Thread Blue Swirl
In this version, map_func is retained for compatibility, so the patch set shouldn't break anything anymore. At least i386, Sparc64 and PPC seem to work. The original patch is now in small pieces. Compatibility also means that at this point I did not touch the harder stuff (virtio-pci/MSI-X, VGA, m

[Qemu-devel] [PATCH RFC] e1000: secrc support

2010-07-12 Thread Michael S. Tsirkin
Add support for secrc field. Reportedly needed by old RHEL guests. Signed-off-by: Michael S. Tsirkin --- hw/e1000.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) Anthony, Alex, please review. diff --git a/hw/e1000.c b/hw/e1000.c index 70aba11..8d87492 100644 --- a/hw/e1

[Qemu-devel] [PATCH RFC] e1000: fix access 4 bytes beyond buffer end

2010-07-12 Thread Michael S. Tsirkin
We do range check for size, and get size as buffer, but copy size + 4 bytes (4 is for FCS). Let's copy size bytes but put size + 4 in length. Signed-off-by: Michael S. Tsirkin --- Anthony, Alex, please review. hw/e1000.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] pci/multi function bit: fix v582c686.c.

2010-07-12 Thread Aurelien Jarno
On Mon, Jul 12, 2010 at 08:53:57PM +0900, Isaku Yamahata wrote: > The file, v582c686.c, was added after the change set of > b80d4a9887fa4b6cc63f8c3a13ab2a45054d3e5c and > fecb93c45c749a4c994d8d12bdee17ce2012de9e > are created, but before the patch series was commit. > So similar fix is needed to v5

[Qemu-devel] [PATCH] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-07-12 Thread Sripathi Kodi
From: M. Mohan Kumar This is a new version of getattr patch for 9P2000.L that I posted some time ago. This version adds 3 fields to the on-the-wire data: file creation time generation number data version It also adds a bit field to indicate which fields of the structure have valid data. Usually

[Qemu-devel] KVM Call agenda for July 13th

2010-07-12 Thread Juan Quintela
Please send in any agenda items you are interested in covering. Thanks, Juan.

[Qemu-devel] Re: [PATCH v2 5/5] pci_bridge: introduce pci bridge library.

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 10:28:24PM +0900, Isaku Yamahata wrote: > On Mon, Jul 12, 2010 at 03:10:00PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 12, 2010 at 07:36:44PM +0900, Isaku Yamahata wrote: > > > diff --git a/hw/pci_bridge.h b/hw/pci_bridge.h > > > index ddb2c82..4697c7a 100644 > > > --

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Josef Bacik
On Mon, Jul 12, 2010 at 05:42:04PM +0400, Michael Tokarev wrote: > Josef Bacik wrote: > [] > > O_DIRECT support was just introduced recently, please try on the latest > > kernel > > with the normal settings (which IIRC uses O_DIRECT), that should make things > > suck alot less. Thanks, > > Um.

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Michael Tokarev
Josef Bacik wrote: [] > O_DIRECT support was just introduced recently, please try on the latest kernel > with the normal settings (which IIRC uses O_DIRECT), that should make things > suck alot less. Thanks, Um. Do you mean it were introduced in BTRFS or general? :) Because, wel, O_DIRECT is he

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Michael Tokarev
Giangiacomo Mariotti wrote: > On Mon, Jul 12, 2010 at 9:09 AM, Michael Tokarev wrote: >> This looks quite similar to a problem with ext4 and O_SYNC which I >> reported earlier but no one cared to answer (or read?) - there: >> http://permalink.gmane.org/gmane.linux.file-systems/42758 >> (sent to qe

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Josef Bacik
On Mon, Jul 12, 2010 at 03:34:44PM +0200, Giangiacomo Mariotti wrote: > On Mon, Jul 12, 2010 at 9:09 AM, Michael Tokarev wrote: > > > > This looks quite similar to a problem with ext4 and O_SYNC which I > > reported earlier but no one cared to answer (or read?) - there: > > http://permalink.gmane.

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Giangiacomo Mariotti
On Mon, Jul 12, 2010 at 9:09 AM, Michael Tokarev wrote: > > This looks quite similar to a problem with ext4 and O_SYNC which I > reported earlier but no one cared to answer (or read?) - there: > http://permalink.gmane.org/gmane.linux.file-systems/42758 > (sent to qemu-devel and linux-fsdevel lists

[Qemu-devel] Re: [PATCH v2 5/5] pci_bridge: introduce pci bridge library.

2010-07-12 Thread Isaku Yamahata
On Mon, Jul 12, 2010 at 03:10:00PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 12, 2010 at 07:36:44PM +0900, Isaku Yamahata wrote: > > diff --git a/hw/pci_bridge.h b/hw/pci_bridge.h > > index ddb2c82..4697c7a 100644 > > --- a/hw/pci_bridge.h > > +++ b/hw/pci_bridge.h > > @@ -29,13 +29,27 @@ > >

[Qemu-devel] Re: [PATCH v2 2/5] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c

2010-07-12 Thread Isaku Yamahata
On Mon, Jul 12, 2010 at 03:16:02PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 12, 2010 at 07:36:41PM +0900, Isaku Yamahata wrote: > > Move pci bridge related code into pci_bridge.c from pci.c > > for further enhancement. pci.c is big enough now, so split it out. > > No code change but exporting

[Qemu-devel] Re: BTRFS: Unbelievably slow with kvm/qemu

2010-07-12 Thread Giangiacomo Mariotti
On Mon, Jul 12, 2010 at 9:17 AM, Justin P. Mattock wrote: > On 07/12/2010 12:09 AM, Michael Tokarev wrote: >> >> This looks quite similar to a problem with ext4 and O_SYNC which I >> reported earlier but no one cared to answer (or read?) - there: >> http://permalink.gmane.org/gmane.linux.file-syst

[Qemu-devel] Re: [PATCH v2 2/5] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 07:36:41PM +0900, Isaku Yamahata wrote: > Move pci bridge related code into pci_bridge.c from pci.c > for further enhancement. pci.c is big enough now, so split it out. > No code change but exporting some accesser functions. > > In fact, few pci bridge functions stays in pc

[Qemu-devel] Re: [PATCH v2 0/5] pci: split out bridge code into pci_bridge and make it library

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 07:36:39PM +0900, Isaku Yamahata wrote: > changes v1 -> v2: > - introduce pci_internals.h to accomodate pci internal strcutures to > share between pci.c and pci_bridge.c > - don't make PCIBridge::bus pointer as suggested by > Michael S. Tsirkin > - rename PCIBridge::bus

[Qemu-devel] Re: [PATCH v2 5/5] pci_bridge: introduce pci bridge library.

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 07:36:44PM +0900, Isaku Yamahata wrote: > diff --git a/hw/pci_bridge.h b/hw/pci_bridge.h > index ddb2c82..4697c7a 100644 > --- a/hw/pci_bridge.h > +++ b/hw/pci_bridge.h > @@ -29,13 +29,27 @@ > #include "pci.h" > > PCIDevice *pci_bridge_get_device(PCIBus *bus); > +PCIBus

[Qemu-devel] Re: [PATCH] pci/multi function bit: fix v582c686.c.

2010-07-12 Thread Isaku Yamahata
On Mon, Jul 12, 2010 at 07:18:16PM +0800, chen huacai wrote: > I have tested, this patch is OK. > The git repository of PMON is unavailable currently, so you can get a > binary version of PMON in the attachment. > BTW, the PCI_HEADER_TYPE setting in hw/ide/via.c can also be removed. Thank you for

[Qemu-devel] [PATCH v2] pci/multi function bit: fix v582c686.c.

2010-07-12 Thread Isaku Yamahata
The file, v582c686.c, was added after the change set of b80d4a9887fa4b6cc63f8c3a13ab2a45054d3e5c and fecb93c45c749a4c994d8d12bdee17ce2012de9e are created, but before the patch series was commit. So similar fix is needed to v582c686.c. Cc: Huacai Chen Cc: Aurelien Jarno Cc: Michael S. Tsirkin Cc

[Qemu-devel] [PATCH 6/7] seabios: acpi: split out piix4 pm logic.

2010-07-12 Thread Isaku Yamahata
split out piix4 pm logic. Signed-off-by: Isaku Yamahata --- src/acpi.c | 19 ++- src/acpi.h |5 + src/dev-i440fx.c | 15 +++ src/dev-i440fx.h |1 + 4 files changed, 31 insertions(+), 9 deletions(-) diff --git a/src/acpi.c b/src/acpi.c inde

[Qemu-devel] [PATCH 5/7] seabios: acpi: move acpi definitions to acpi.h from acpi.c

2010-07-12 Thread Isaku Yamahata
Move ACPI_TABLE_HEADER_DEF and struct fadt_descriptor_rev1 from acpi.h to acpi.c for later use. Signed-off-by: Isaku Yamahata --- src/acpi.c | 73 - src/acpi.h | 76 2 files c

[Qemu-devel] [PATCH 0/7] abstract chipset(i440fx) specific register operation.

2010-07-12 Thread Isaku Yamahata
This patch set abstract out chipset specific operation, and spit out i440fx specific operation into dev-i440fx.c with it. Thus q35 specific register value/operation will be added easily. Isaku Yamahata (7): seabios: pci: introduce helper function to find device from table and initialize it.

[Qemu-devel] [PATCH 1/7] seabios: pci: introduce helper function to find device from table and initialize it.

2010-07-12 Thread Isaku Yamahata
introduce helper function to find device from table and initialize it. pci_find_init_device(). This will be used later. Signed-off-by: Isaku Yamahata --- src/pci.c | 12 src/pci.h |1 + 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/pci.c b/src/pci.c index

[Qemu-devel] [PATCH 4/7] seabios: smm_init: move out i440fx smram operation into dev-i440fx.c

2010-07-12 Thread Isaku Yamahata
move out i440fx smram operation into dev-i440fx.c. Signed-off-by: Isaku Yamahata --- src/dev-i440fx.c |8 src/dev-i440fx.h |1 + src/post.h |5 + src/smm.c| 17 - 4 files changed, 26 insertions(+), 5 deletions(-) diff --git a/src/dev-i440

[Qemu-devel] [PATCH 7/7] seabios: acpi: clean up of finding pm device.

2010-07-12 Thread Isaku Yamahata
Make it table driven to other chip set. Signed-off-by: Isaku Yamahata --- src/acpi.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index 32d436f..fa07c37 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -527,6 +527,13 @@ build_srat(void)

[Qemu-devel] [PATCH 3/7] seabios: smm: move out piix4 specific logic to dev-i440fx.c

2010-07-12 Thread Isaku Yamahata
move out piix4 specific logic to dev-i440fx.c by using pci_find_init_device(). Signed-off-by: Isaku Yamahata --- src/dev-i440fx.c | 25 + src/dev-i440fx.h |1 + src/post.h |6 ++ src/smm.c| 18 +- 4 files changed, 45 insertion

[Qemu-devel] [PATCH 2/7] seabios: shadow: make device finding more generic.

2010-07-12 Thread Isaku Yamahata
pam register offset is north bridge specific. So determine the offset based on found north bridge. Signed-off-by: Isaku Yamahata --- src/dev-i440fx.c |9 + src/dev-i440fx.h |1 + src/post.h | 13 + src/shadow.c | 44 +-

[Qemu-devel] Re: [PATCH] pci/multi function bit: fix v582c686.c.

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 04:18:01PM +0900, Isaku Yamahata wrote: > The file, v582c686.c, was added after the change set of > b80d4a9887fa4b6cc63f8c3a13ab2a45054d3e5c and > fecb93c45c749a4c994d8d12bdee17ce2012de9e > are created, but before the patch series was commit. > So similar fix is needed to v5

[Qemu-devel] Re: [RFC PATCH 0/5] QEMU VFIO device assignment

2010-07-12 Thread Michael S. Tsirkin
On Mon, Jul 12, 2010 at 09:29:38AM +0300, Avi Kivity wrote: > On 07/11/2010 11:24 PM, Alex Williamson wrote: > > > >One other thing to be aware of is that vfio requires devices to be > >PCI-2.3 compliant in order to support DisINTx. This allows vfio to > >support devices making use of shared INTx

[Qemu-devel] [Bug 494500] Re: QEMU 0.12.0 does not support KVM with Kernel < 2.6.29, bug in ./configure and kvm-all.c

2010-07-12 Thread rowa
It works now: sudo apt-get remove kvm-source wget \ http://download.savannah.gnu.org/releases/qemu/qemu-0.12.4.tar.gz tar xzvf qemu-0.12.4.tar.gz cd qemu-0.12.4 ./configure --enable-kvm make sudo checkinstall --pkgname=qemu-self-compiled qemu -monitor stdio -enable-kvm (qemu) info kvm ** Chang

[Qemu-devel] [PATCH v2 2/5] pci/bridge: split out pci bridge code into pci_bridge.c from pci.c

2010-07-12 Thread Isaku Yamahata
Move pci bridge related code into pci_bridge.c from pci.c for further enhancement. pci.c is big enough now, so split it out. No code change but exporting some accesser functions. In fact, few pci bridge functions stays in pci.c. Signed-off-by: Isaku Yamahata --- Makefile.objs |2 +- hw/ap

[Qemu-devel] [PATCH v2 3/5] pci_bridge: rename PCIBridge::bus -> PCIBridge::sec_bus.

2010-07-12 Thread Isaku Yamahata
To avoid confusion of primary bus with secondary bus, rename PCIBridge::bus to PCIBridge::sec_bus. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c|7 +++ hw/pci_internals.h |2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci_bridge.c b/hw/pci_bridge.c i

[Qemu-devel] [PATCH v2 5/5] pci_bridge: introduce pci bridge library.

2010-07-12 Thread Isaku Yamahata
introduce pci bridge library. convert apb bridge and dec p2p bridge to use new pci bridge library. save/restore is supported as a side effect. This is also preparation for pci express root/upstream/downstream port. Signed-off-by: Isaku Yamahata --- hw/apb_pci.c | 42 ++- hw/d

[Qemu-devel] [PATCH v2 4/5] pci_bridge: clean up: remove pci_{register, unregister}_secondary_bus()

2010-07-12 Thread Isaku Yamahata
Remove pci_{register, unregister}_secondary_bus() by open code. They are old stype API and aren't used any more by others. So eliminate it. Signed-off-by: Isaku Yamahata --- hw/pci_bridge.c | 32 ++-- 1 files changed, 10 insertions(+), 22 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 1/5] pci: move out pci internal structures, PCIBus, PCIBridge, and pci_bus_info.

2010-07-12 Thread Isaku Yamahata
move out pci internal structures, PCIBus, PCIBridge and pci_bus_info into private header file, pci_internals.h. This is a preparation. Later pci bridge implementation will be split out form pci.c into pci_bridge.c. Signed-off-by: Isaku Yamahata --- hw/pci.c | 32 ++---

[Qemu-devel] [PATCH v2 0/5] pci: split out bridge code into pci_bridge and make it library

2010-07-12 Thread Isaku Yamahata
changes v1 -> v2: - introduce pci_internals.h to accomodate pci internal strcutures to share between pci.c and pci_bridge.c - don't make PCIBridge::bus pointer as suggested by Michael S. Tsirkin - rename PCIBridge::bus -> PCIBridge::sec_bus - eliminate pci_reguster_secondary_bus()/pci_unregist

[Qemu-devel] Re: [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more

2010-07-12 Thread Kevin Wolf
Am 06.07.2010 14:37, schrieb Markus Armbruster: > This patch series is about purging the "type hint" from the block > layer. My previous series cleaned up improper uses it. Remaining > uses are info block and qdevs ide-drive, scsidisk. > > Remove the type hint from info block. Its value is unre

Re: [Qemu-devel] [PATCH] trace: Remove monitor.h dependency from simpletrace

2010-07-12 Thread Stefan Hajnoczi
I forgot to mention this patch is against the tracing branch, not qemu.git: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing Stefan

[Qemu-devel] [PATCH] trace: Remove monitor.h dependency from simpletrace

2010-07-12 Thread Stefan Hajnoczi
User-mode targets don't have a monitor so the simple trace backend currently does not build on those targets. This patch abstracts the monitor printing interface so there is no direct coupling between simpletrace and the monitor. Signed-off-by: Stefan Hajnoczi --- I started reading the monitor c

[Qemu-devel] Re: [RFC PATCH 4/5] APIC/IOAPIC EOI callback

2010-07-12 Thread Avi Kivity
On 07/12/2010 12:05 PM, Gleb Natapov wrote: On Mon, Jul 12, 2010 at 09:33:12AM +0300, Avi Kivity wrote: On 07/11/2010 09:30 PM, Avi Kivity wrote: Registering an eventfd for the eoi seems like a reasonable alternative. I'm worried about that racing (with what?) I do

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-07-12 Thread Коренберг Марк
valgrind --malloc-fill=0x69 --free-fill=0x11 Process terminating with default action of signal 11 (SIGSEGV) ==00:00:01:03.046 29447== Access not within mapped region at address 0x1151 ==00:00:01:03.046 29447==at 0x80B4713: scsi_req_free (scsi-bus.c:153) ==00:00:01:03.047 29447==by 0x8

  1   2   >