WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).
Signed-off-by: MORITA Kazutaka
---
Betts, I think this patch fix the compile error. Can you try this
one?
block/sheepdog.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/sheepdog.c b/block/s
Public bug reported:
Modern linuxes can use ATA TRIM command on block devices. It will be
very nice if qemu translates this request to underlying block driver.
1. So, if I use RAW image (on my case - lvm partition), TRIM inside qemu should
do TRIM command on my readl HDD
2. In the future, TRIM c
When building the current master branch, I get an error when building the
Sheepdog block driver:
/Users/cwbetts/makestuff/qemu/block/sheepdog.c: In function ‘set_cork’:
/Users/cwbetts/makestuff/qemu/block/sheepdog.c:903: error: ‘SOL_TCP’ undeclared
(first use in this function)
/Users/cwbetts/make
This patch makes use of pci device initialization helper function
to convert if/switch clause to table driven.
So this makes it easier to add q35 initialization code.
Signed-off-by: Isaku Yamahata
---
changes v1 -> v2
- renamed files i440fx -> dev->i440fx.
- dropped copyright notice from dev-i44
introduce helper function to initialize a given device,
This will be used later.
Signed-off-by: Isaku Yamahata
---
src/pci.c | 20
src/pci.h | 34 ++
2 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/src/pci.c b/src/pci.c
ind
Changes from v1 -> v2
- renamed files i440fx -> dev->i440fx.
- dropped copyright notice from dev-i440fx.h
This patch series cleans up pci device initialization by introducing
a helper function.
This makes it easier to add more device initialization code cleanly
as preparation for q35 chipset.
I
On Tue, Jul 06, 2010 at 03:18:52PM +0300, Michael S. Tsirkin wrote:
> On Fri, Jul 02, 2010 at 11:30:11AM +0900, Isaku Yamahata wrote:
> > allocate PCIBus dynamically for PCIBridge and bug fix of
> > pci_unregister_secondary_bus().
>
> could you make the bugfix a separate patch please?
Will do.
On Mon, Jul 05, 2010 at 11:22:29AM +0900, Isaku Yamahata wrote:
> This patch makes use of pci device initialization helper function
> to convert if/switch clause to table driven.
> So this makes it easier to add q35 initialization code.
Looks okay to me. A couple of minor comments..
> SRC32FLAT
On Tue, Jul 06, 2010 at 02:23:27PM +0300, Michael S. Tsirkin wrote:
> bridge config write should trigger updates
> on the secondary bus. never on the primary bus.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> Compile-tested only.
> Isaku Yamahata, could you review this please?
> You wrote the
On Tue, Jul 06, 2010 at 02:37:44PM +0200, Markus Armbruster wrote:
> Disks without media make no sense. For SCSI, a Linux guest kernel
> complains during boot. I didn't try other combinations.
>
> scsi-generic doesn't need the additional check, because it already
> requires bdrv_is_sg(), which f
Looks good,
Reviewed-by: Christoph Hellwig
I'd rather have an enum about the drive type instead of the is_cdrom
flag. In addition I think patch 8 should be folded into this one.
Looks good,
Reviewed-by: Christoph Hellwig
On Tue, Jul 06, 2010 at 02:37:47PM +0200, Markus Armbruster wrote:
> Disk vs. CD needs to be in qdev, because it belongs to the drive's
> guest part.
Looks good, but the scsi-hd name feelds kinda awkward. This is one
case we're I'm really wondering if the compatiblity is worth it or
if we should
Looks good,
Reviewed-by: Christoph Hellwig
** Branch linked: lp:~ubuntu-bugs-auftrags-killer/qemu/proper-error-
characters
--
qemus pmemsave doesn't accept "/" in filename
https://bugs.launchpad.net/bugs/543478
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Inva
Ok.
Looks correct to me,
Reviewed-by: Christoph Hellwig
Ok.
I'd call it drive_type or just type, but either way the patch looks good,
Reviewed-by: Christoph Hellwig
Looks good.
Looks good,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:50PM +0200, Markus Armbruster wrote:
> Needed for decent error locations when complaining about options
> outside of qemu_opts_foreach(). That one sets the location
> already.
Ok.
On Tue, Jul 06, 2010 at 02:08:49PM +0200, Markus Armbruster wrote:
> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
> we get it via if=none and -device.
>
> Moreover, scsi-generic doesn't support werror. Since drive_init()
> doesn't catch that, option werror was silently ig
Looks good,
Reviewed-by: Christoph Hellwig
On Tue, Jul 06, 2010 at 02:08:46PM +0200, Markus Armbruster wrote:
> * Any drive backed by host_floppy now retries.
I would really prefer not to change the behaviour for this case, it'll
just confuse people looking at the history when finally removing this
hack.
Ok,
Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Christoph Hellwig
First patch is a small README update, important change is in second patch.
Thanks.
This helps ensuring two things:
1. An initial warning on client writers playing with current QMP
2. Clients using unstable QMP will break when we declare QMP stable and
drop that argument
Signed-off-by: Luiz Capitulino
---
QMP/README |2 +-
QMP/qmp-shell |2 +-
QMP/qmp.py
A number of small changes I prefer to do in one shot:
- Add a note about instability
- Add multiple monitors example
- Small clarifications
Signed-off-by: Luiz Capitulino
---
QMP/README | 36 +++-
1 files changed, 23 insertions(+), 13 deletions(-)
diff --git a
Signed-off-by: Stefan Hajnoczi
---
This applies to the tracing branch at:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev
simpletrace.c | 21 ++---
tracetool |3 ++-
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/simpletrace.c b
Signed-off-by: Stefan Hajnoczi
---
This applies to the tracing branch at:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev
simpletrace.c | 23 +++
1 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/simpletrace.c b/simpletrace.c
index ace
The simple trace backend exports a function that can be used to
programmatically enable/disable trace events at runtime.
Signed-off-by: Stefan Hajnoczi
---
This applies to the tracing branch at:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing-dev
docs/tracing.txt | 11 +++
On 07/02/2010 06:15 AM, Prerna Saxena wrote:
Set up host kernel include paths specified by --kerneldir
When host kernel headers are placed in non-standard paths, the
KVM_CFLAGS are presently invoked only for a few .c files
(kvm*.c,vhost*.c) and not for other files like machine.c, cpus.c
..etc
On 07/06/2010 10:33 AM, Kevin Wolf wrote:
The following changes since commit 734003e6153b3552b9406ef598a1e67aac4a899e:
Anthony Liguori (1):
Merge remote branch 'kwolf/for-anthony' into staging
Pulled. Thanks.
Regards,
Anthony Liguori
are available in the git repository at:
Am 06.07.2010 14:37, schrieb Markus Armbruster:
> Its value is unreliable: a block device used as floppy has type
> "floppy" if created with if=floppy, but type "hd" if created with
> if=none.
>
> That's because with if=none, the type is at best a declaration of
> intent: the drive can be connecte
On 07/06/2010 11:42 AM, Natalia Portillo wrote:
Hi,
El 06/07/2010, a las 15:41, Bryan Wilwerding escribió:
I have a 0.9.0 qemu package that was modified by a research project. I would
like to upgrade this qemu package. Where I can find a patch for 0.9.0 to qemu
0.10 and higher?
On Tue, Jul 06, 2010 at 06:39:53PM +0200, Kevin Wolf wrote:
> Am 06.07.2010 14:37, schrieb Markus Armbruster:
> > Its value is unreliable: a block device used as floppy has type
> > "floppy" if created with if=floppy, but type "hd" if created with
> > if=none.
> >
> > That's because with if=none,
Hi,
El 06/07/2010, a las 15:41, Bryan Wilwerding escribió:
> I have a 0.9.0 qemu package that was modified by a research project. I would
> like to upgrade this qemu package. Where I can find a patch for 0.9.0 to
> qemu 0.10 and higher?
You can use the git to obtain a patch between two snaps
** Tags added: patch
--
qemus pmemsave doesn't accept "/" in filename
https://bugs.launchpad.net/bugs/543478
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Invalid
Status in “qemu-kvm” package in Ubuntu: Incomplete
Bug
No need to call cpu_register_physical_memory() for a zero sized area.
Signed-off-by: Alex Williamson
---
hw/pc.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index a96187f..58dea57 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -916,8 +916,10 @@ void pc
Public bug reported:
Hello,
I have trouble with the network performance inside my virtual machines. I don't
know if this is realy a bug, but I didn't find a solution for this problem in
other forums or maillists.
My KVM-Host machine is connected to a 10Gbit Network. All interfaces are
configure
Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>>> use in this function)
>>> /home/njh/src/
On 06/18/2010 11:27 AM, Kevin Wolf wrote:
scanf calls must not use PRI constants, they have probably the wrong size and
corrupt memory. We could replace them by SCN ones, but strtol is simpler than
scanf here anyway. While at it, also fix the parsers to reject garbage after
the number ("4096xyz"
On 07/06/2010 03:49 AM, Jan Kiszka wrote:
Nigel Horne wrote:
./configure --enable-linux-aio --enable-io-thread --enable-kvm
make
...
/home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
use in this function)
/home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier
On 07/05/2010 03:36 AM, Gleb Natapov wrote:
Convert alarm time from BCD if needed before comparing with current
time.
Signed-off-by: Gleb Natapov
Applied. Thanks.
Regards,
Anthony Liguori
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index c3459bf..2b91fa8 100644
--- a/hw/mc146818r
On 06/25/2010 12:08 PM, Alex Williamson wrote:
We currently need this either to allocate the next ram_addr_t for a
new block, or for total memory to be migrated. Both of which we can
calculate without need of this to keep us in a contiguous address space.
Signed-off-by: Alex Williamson
Ap
Here's a patch against qemu from git that prints the offending
characters, helping the user to understand what's going on.
I can't deal with qemu-devel myself, it's way too noisy. But Ubuntu
might want to take that patch or push it upstream.
** Patch added: "Patch which prints the errorneous char
On 07/01/2010 02:21 PM, Luiz Capitulino wrote:
Hi Anthony,
The following QMP/Monitor patches have been sent to the list and look good
to me. I also did some basic testing on them.
Most of these changes are bug fixes, the only exception is my new argument
checker series, which is a complete rewr
There're also projects like http://compression.ca/pbzip2/ . We'll be
facing more and more cores per cpu, so we should use these techniques.
--
[Feature request] qemu-img multi-threaded compressed image conversion
https://bugs.launchpad.net/bugs/601946
You received this bug notification because
On 07/06/2010 03:58 AM, Jan Kiszka wrote:
When the controller raises the SCSI reset line, we have to perform the
requested reset on all disks attached to the controller's bus. Moreover,
reset is edge triggered, so avoid repeating it if the line was already
high.
Signed-off-by: Jan Kiszka
A
From: Markus Armbruster
It still always succeeds. The next commits will add failures.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/core.c | 13 +
hw/ide/internal.h |4 ++--
hw/ide/qdev.c |4 +++-
3 files changed, 14 insertions(+), 7 dele
From: Markus Armbruster
drive_init() doesn't permit option readonly for if=ide, but that's
worthless: we get it via if=none and -device.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/core.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw
On 07/06/2010 03:50 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
The result of parsing qemu-options.def depends on whehter or not
MAP_POPULATE is defined, so make sure to include sys/mman.h before
including qemu-options.h.
Reported by Frank Arnold.
Signed-off-by: Jes Sorensen
Ap
From: Markus Armbruster
The two aren't independent variables. Make that obvious.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/core.c | 40
hw/ide/internal.h |5 +++--
hw/ide/macio.c |2 +-
hw/ide/microdr
From: Markus Armbruster
drive_init() doesn't permit invalid CHS for if=ide, but that's
worthless: we get it via if=none and -device.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/core.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git
From: MORITA Kazutaka
Sheepdog is a distributed storage system for QEMU. It provides highly
available block level storage volumes to VMs like Amazon EBS. This
patch adds a qemu block driver for Sheepdog.
Sheepdog features are:
- No node in the cluster is special (no metadata node, no control
From: Markus Armbruster
Use error_report(), because it points to the error location.
Reword "tried to assign twice" messages to make it clear that we're
complaining about the unit property.
Report invalid unit property instead of failing silently.
Signed-off-by: Markus Armbruster
Signed-off-b
From: Markus Armbruster
Needed for decent error locations when complaining about options
outside of qemu_opts_foreach(). That one sets the location
already.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
qemu-option.c |5 +
qemu-option.h |1 +
2 files changed, 6 i
From: Markus Armbruster
drive_init() doesn't permit them for if=floppy, but that's worthless:
we get them via if=none and -global.
This can make device initialization fail. Since all callers of
fdctrl_init_isa() ignore its value, change it to die instead of
returning failure. Without this, som
From: Markus Armbruster
Some of the failures are internal errors, and hw_error() is okay then.
But the common way to fail is bad user input, e.g. -global
isa-fdc.driveA=foo where drive foo has an unsupported rerror value.
exit(1) instead.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin W
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/scsi-bus.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index b84b9b9..d69c74c 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -102,19 +102,2
From: Markus Armbruster
init_blk_migration_it() skips drives with type hint BDRV_TYPE_CDROM.
The intention is to skip read-only drives. However, BDRV_TYPE_CDROM
is only a hint. It is currently sufficent for read-only. But it's
not necessary, and it may not remain sufficient.
Use bdrv_is_read_
This distinguishes between harmless leaks and real corruption. Hopefully users
better understand what qemu-img check wants to tell them.
Signed-off-by: Kevin Wolf
---
block.c|3 +-
block/qcow2-refcount.c | 120 ++--
block/qcow2.c
From: Markus Armbruster
drive_init() doesn't permit rerror for if=scsi, but that's worthless:
we get it via if=none and -device.
Moreover, scsi-generic doesn't support werror. Since drive_init()
doesn't catch that, option werror was silently ignored even with
if=scsi.
Wart: unlike drive_init()
From: Markus Armbruster
Since commit cb4e5f8e, monitor command change makes the new media
readonly iff the type hint is BDRV_TYPE_CDROM, i.e. the drive was
created with media=cdrom. The intention is to avoid changing a block
device's read-only-ness. However, BDRV_TYPE_CDROM is only a hint. It
From: john cooper
This patch adds the final missing bits for support of
passing a serial/id string to a virtio-blk guest driver.
The guest-side component already exists in the virtio
driver, and has recently been reworked by Ryan to export
a /sys interface for retrieval of the id from guest user
People think that their images are corrupted when in fact there are just some
leaked clusters. Differentiating several error cases should make the messages
more comprehensible.
Signed-off-by: Kevin Wolf
---
block.c| 10 ++--
block.h| 10 -
qemu-img.c | 63 ++
On 07/06/2010 10:27 AM, Kevin Wolf wrote:
Any chance to get the next series (Split ide-drive and scsi-disk qdevs,
and more) as well? 1-3/8 are bug fixes, and 4/8 removes unreliable
information from info block; wanted in .13. 5-8/8 could be punted to
.14.
If it's purely bug fixes, I think
From: Markus Armbruster
raw_pread_aligned() retries up to two times if the block device backs
a virtual CD-ROM (a drive with media=cdrom and if=ide, scsi, xen or
none). This makes no sense. Whether retrying reads can correct read
errors can only depend on what we're reading, not on how the resu
The following changes since commit 734003e6153b3552b9406ef598a1e67aac4a899e:
Anthony Liguori (1):
Merge remote branch 'kwolf/for-anthony' into staging
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Kevin Wolf (2):
qemu-img check: Distinguish
On Tue, Jul 6, 2010 at 8:46 AM, Juan Quintela wrote:
>
> Today was a short call as Anthony didn't attend.
>
> - Jes reminded people that Linux Plumbers deadline is July 19th
> - Qemu 0.13 (from the agenda, we didn't discuss it without Anthony).
>
> List of patches missing commit/comment/review fro
Am 06.07.2010 17:19, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 06.07.2010 15:53, schrieb Anthony Liguori:
>>> On 07/06/2010 08:37 AM, Kevin Wolf wrote:
Am 06.07.2010 15:26, schrieb Anthony Liguori:
> On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
>
>>
Kevin Wolf writes:
> Am 06.07.2010 15:53, schrieb Anthony Liguori:
>> On 07/06/2010 08:37 AM, Kevin Wolf wrote:
>>> Am 06.07.2010 15:26, schrieb Anthony Liguori:
>>>
On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
> On Mon, 05 Jul 2010 14:45:23 +0200
> Juan Quintela w
Am 20.06.2010 22:01, schrieb MORITA Kazutaka:
> Sheepdog is a distributed storage system for QEMU. It provides highly
> available block level storage volumes to VMs like Amazon EBS. This
> patch adds a qemu block driver for Sheepdog.
>
> Sheepdog features are:
> - No node in the cluster is specia
1. during benchmark I used iotop and just top. qemu-img is eating all my cpu
(3.07 Ghz) and disk streaming was at low speeds.
2. Writing on disk in ext4 is cached very strongly, so writing in 4 streams is
not the problem.
3. For example, 7z give huge speed increase in when compressing in multiple
** Changed in: qemu
Status: Incomplete => Confirmed
--
migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)
https://bugs.launchpad.net/bugs/584121
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Status in QEMU: Confirmed
Bug
Today was a short call as Anthony didn't attend.
- Jes reminded people that Linux Plumbers deadline is July 19th
- Qemu 0.13 (from the agenda, we didn't discuss it without Anthony).
List of patches missing commit/comment/review from Anthony. We decided
to send to the list an initial list, and a
I have a 0.9.0 qemu package that was modified by a research project. I would
like to upgrade this qemu package. Where I can find a patch for 0.9.0 to qemu
0.10 and higher?
Regards,
ding329
Hi,
The problem is that it is more than just the compression that is the
problem, with modern cpus disk speed is a problem, and compression is
often stream based. For now there isn't enough valid data that this
qualifies as a bug/rfe.
If you decide to try and implement it, and provide data showin
Hi all !
I stumbled over https://computing.llnl.gov/tutorials/pthreads/samples/join.c
and tried to run it with qemu-arm (gcc-arm -lm -lc -lpthread -o join join.c;
qemu-arm ./join ).
qemu-arm from 9f5a1fae7ee1a7c66462e5b8e9d21552d4dc5027 compiled with:
./configure --prefix=/usr \
--disa
I have now moved the roadmap onto the wiki because it becomes hard to
get a sense of the status from an email thread:
http://wiki.qemu.org/Features/Tracing/Roadmap
Stefan
Am 06.07.2010 14:08, schrieb Markus Armbruster:
> I'm working on cleanly separating block device host and guest parts.
> I'd like to route all this work through Kevin's block tree. This is
> still just preliminaries.
>
> This patch series is based available at
> git://repo.or.cz/qemu/armbru.git
>
Am 06.07.2010 15:53, schrieb Anthony Liguori:
> On 07/06/2010 08:37 AM, Kevin Wolf wrote:
>> Am 06.07.2010 15:26, schrieb Anthony Liguori:
>>
>>> On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
>>>
On Mon, 05 Jul 2010 14:45:23 +0200
Juan Quintela wrote:
>
On Tue, 2010-07-06 at 08:26 -0500, Anthony Liguori wrote:
> On 07/05/2010 11:52 PM, Alex Williamson wrote:
> > On Mon, 2010-07-05 at 11:05 -0300, Luiz Capitulino wrote:
> >
> >> On Mon, 05 Jul 2010 14:45:23 +0200
> >> Juan Quintela wrote:
> >>
> >>
> >>> Please send in any agenda items y
On 07/06/2010 08:37 AM, Kevin Wolf wrote:
Am 06.07.2010 15:26, schrieb Anthony Liguori:
On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
On Mon, 05 Jul 2010 14:45:23 +0200
Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
- 0.1
Am 06.07.2010 15:26, schrieb Anthony Liguori:
> On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
>> On Mon, 05 Jul 2010 14:45:23 +0200
>> Juan Quintela wrote:
>>
>>
>>> Please send in any agenda items you are interested in covering.
>>>
>> - 0.13 release
>>
>
> I was hoping to do -rc0
On 07/05/2010 07:45 AM, Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
If we have a lack of agenda items I'll cancel the week's call.
I've got a lot to catch up on after the mini-holiday so I'd rather skip
the call unless there's a pressing agenda ite
On 07/05/2010 11:52 PM, Alex Williamson wrote:
On Mon, 2010-07-05 at 11:05 -0300, Luiz Capitulino wrote:
On Mon, 05 Jul 2010 14:45:23 +0200
Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
- 0.13 release
- migration + hotplug fixes
On 07/05/2010 09:05 AM, Luiz Capitulino wrote:
On Mon, 05 Jul 2010 14:45:23 +0200
Juan Quintela wrote:
Please send in any agenda items you are interested in covering.
- 0.13 release
I was hoping to do -rc0 before the holiday but that didn't happen so I'm
working on it now. F
Per rth's reply to qemu-devel, fix has been pushed into upstream as of
July 1st, commit 7418027ea4fec276455abd4291558bc58a0a7ba7
If problem reappears, please reopen or open a new bug.
Closing
** Changed in: qemu
Status: New => Fix Committed
--
xchg r8,rax treated as nop
https://bugs.la
Am 06.07.2010 14:38, schrieb Markus Armbruster:
> Kevin Wolf writes:
>
>> Am 30.06.2010 13:55, schrieb Markus Armbruster:
>>> The two aren't independent variables. Make that obvious.
>>>
>>> Signed-off-by: Markus Armbruster
>>
>> Can we please call the constant IDE_CDROM or something else that
On Mon, Jul 05, 2010 at 10:39:19PM +0530, Sripathi Kodi wrote:
> Hi Stefan, Prerna,
>
> I pulled down QEMU tracing code from git://repo.or.cz/qemu/stefanha.git
> and tried to use it to trace something in virtio-9p code. I don't have
> any knowledge of how traces are implemented and I just went wit
Disk vs. CD needs to be in qdev, because it belongs to the drive's
guest part.
Keep scsi-disk for backward compatibility.
Signed-off-by: Markus Armbruster
---
hw/scsi-disk.c | 117 +++
1 files changed, 91 insertions(+), 26 deletions(-)
diff
Disk vs. CD needs to be in qdev, because it belongs to the drive's
guest part.
Keep ide-drive for backward compatibility.
Signed-off-by: Markus Armbruster
---
hw/ide/core.c | 11 +---
hw/ide/internal.h |2 +-
hw/ide/qdev.c | 72 ++-
Move the check from virtio_blk_init_pci(), where it protects only
virtio-blk-pci, to virtio_blk_init(). Without that, virtio-blk-s390
initializes without a drive. I figure that can lead to null pointer
dereferences.
Signed-off-by: Markus Armbruster
---
hw/virtio-blk.c |6 ++
hw/virtio-
Kevin Wolf writes:
> Am 30.06.2010 13:55, schrieb Markus Armbruster:
>> The two aren't independent variables. Make that obvious.
>>
>> Signed-off-by: Markus Armbruster
>
> Can we please call the constant IDE_CDROM or something else that is easy
> to distinguish? With this patch, we have IDE_CD
It can't actually fail now, but the next commit will change that.
s390_virtio_blk_init() already checks for failure, but
virtio_blk_init_pci() doesn't. Fix that.
Signed-off-by: Markus Armbruster
---
hw/virtio-pci.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/v
1 - 100 of 133 matches
Mail list logo
