Thanks, applied.
On Thu, Jun 10, 2010 at 9:42 AM, wrote:
> From: Jes Sorensen
>
> v4 of the vl.c clean up patch. This one just fixes a merge conflict
> due to some recent changes to vl.c, and I added the Acked-By: lines I
> received for v3. Consider it a house-keeping update to make it easier
Hi Anthony,
Is my implementation of master/peer roles acceptable? I realize with
Alex's RAMList changes I may need to modify my patch, but is the
approach of marking memory non-migratable an acceptable
implementation?
Thanks,
Cam
On Fri, Jun 4, 2010 at 3:45 PM, Cam Macdonell wrote:
> Latest pa
On 06/11/2010 01:57 PM, Stefan Weil wrote:
> mingw32 does not include function ffs.
>
> Commit c6d29ad6e24533cc3762e1d654275607e1d03058 added a
> declaration for ffs, but an implementation was missing.
>
> For compilations with optimization, the compiler creates
> inline code, so the implementati
> +} else if (timer_fsb_route(timer)) {
> +apic_send_msi(timer->fsb >> 32, timer->fsb & 0x);
This should use a regular memory write, like the PCI MSI-X code does.
Paul
From: Jan Kiszka
Only match on true dir variable assignments, avoid generating garbage
due to the "# Configured with: ..." line which may contain "*dir=" as
well.
Signed-off-by: Jan Kiszka
---
create_config |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/create_config
mingw32 does not include function ffs.
Commit c6d29ad6e24533cc3762e1d654275607e1d03058 added a
declaration for ffs, but an implementation was missing.
For compilations with optimization, the compiler creates
inline code, so the implementation is not always needed.
Without optimization, linking f
From: Jan Kiszka
Signed-off-by: Jan Kiszka
Signed-off-by: Luiz Capitulino
---
hxtool |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hxtool b/hxtool
index d499dc0..7ca83ed 100644
--- a/hxtool
+++ b/hxtool
@@ -59,6 +59,7 @@ hxtoqmp()
{
IFS=
flag=0
+line=
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
json-lexer.c | 48
1 files changed, 16 insertions(+), 32 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 5ea64a7..c736f42 100644
--- a/json-lexer.
It's not needed, use qobject_put() instead and get a cleaner code.
Signed-off-by: Luiz Capitulino
---
json-streamer.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/json-streamer.c b/json-streamer.c
index 610ffea..f7e7a68 100644
--- a/json-streamer.c
+++ b/json-s
From: Paolo Bonzini
Not requiring one extra character when lookahead is not necessary
ensures that clients behave properly even if they, for example,
send QMP requests without a trailing newline.
Signed-off-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
json-lexer.c | 58 +
QString supports adding a single char, 'buf' is unneeded.
Signed-off-by: Luiz Capitulino
---
json-lexer.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 5cc7e6c..1d9b81f 100644
--- a/json-lexer.c
+++ b/json-lexer.c
@@ -284,8 +284,
It's valid JSON and should be handled.
Signed-off-by: Luiz Capitulino
---
json-parser.c |4
qjson.c |3 +++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index b55d763..83212bc 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -20
While there make the fail_unless() calls print error messages.
IMPORTANT: The test for "\/" is failing, don't know why.
Signed-off-by: Luiz Capitulino
---
check-qjson.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/check-qjson.c b/check-qjson.c
index 109
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
check-qjson.c | 98 -
1 files changed, 97 insertions(+), 1 deletions(-)
diff --git a/check-qjson.c b/check-qjson.c
index d365799..2e52450 100644
--- a/
The 'lexer' variable is passed by the caller, it can contain anything
(eg. garbage).
Signed-off-by: Luiz Capitulino
---
json-lexer.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 9d64920..0b145d1 100644
--- a/json-lexer.c
+++ b/json-le
The JSON escape sequence "\/" and "\\" are valid and should be
handled.
Signed-off-by: Luiz Capitulino
---
json-lexer.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/json-lexer.c b/json-lexer.c
index 0b145d1..5cc7e6c 100644
--- a/json-lexer.c
+++ b/json-lexer.c
@@ -
Hi Anthony,
The following QMP/Monitor patches have been sent to the list and look good
to me. I have also tested most of them.
The changes (since 0e2029a063405091ee34170ef71aa321715e4357) are available in
the following repository:
git://repo.or.cz/qemu/qmp-unstable.git for-anthony
Jan Ki
Hi Christian,
thanks for you patch. I tried it a little and it worked quite well but
during some live migration tests I noticed a problem.
The problem is related to live migration with high I/O using the AIO
calls (I triggered it with a simple "dd").
If you launch a live migration and the guest
> +tcg_gen_shli_i32(tmp2, tmp, 16);
> +tcg_gen_or_i32(tmp, tmp, tmp2);
Which if you're paying attention is incorrect. Actual committed patch is
correct - tcg_gen_shli_i32(tmp2, tmp2, 16);
Paul
When combining multiple values as part of a NEON array load, do explcit
shift/or rather than using gen_bfi. This voids redundant mask
operations.
Signed-off-by: Paul Brook
---
target-arm/translate.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/target-arm/transla
On Fri, 11 Jun 2010 14:08:56 +0200
Jan Kiszka wrote:
> Markus Armbruster wrote:
> > Prerna Saxena writes:
> >
> >> This is v2 of monitor commands based on Stefan's trace framework :
> >> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
> >>
> >> This adds the following mon
On Fri, 11 Jun 2010 00:45:58 +0530
Prerna Saxena wrote:
> For now, I simply export tdb_hash() from qdict.h for use by tracing
> framework.
> Luiz suggested renaming and exporting it from a location other than
> qdict.h . Would "qemu-common.h" be a better place?
qemu-common.h seems to be about
On Fri, 11 Jun 2010 09:38:42 -0500
Anthony Liguori wrote:
> > 1. QMP only returns the response when the command is finished, eg:
> >
> > C: { "execute": "migrate", "id": "foo" ... }
> > /* nothing is returned, other commands are issued, after several
> > hours... */
> > S: { "re
On Fri, 2010-06-11 at 08:15 -0600, Alex Williamson wrote:
> These are the first two patches from the RFC sent out a couple days
> ago. There seemed to be concensus that these were headed in the
> right direction, so I'll post them for commit while we decided how
> to name RAMBlocks.
>
> Changes -
On Mon, Apr 19, 2010 at 10:41 AM, Cam Macdonell wrote:
> Hi,
>
> I'm trying to use a 64-bit BAR for my shared memory device. In simply
> changing the memory type in pci_register_bar() to
> PCI_BASE_ADDRESS_MEM_TYPE_64 I get an unusual physical address for
> that BAR (and my driver crashes in pci_
This makes the RAM block list easier to manipulate. Also incorporate
relevant variables into the RAMList struct.
Signed-off-by: Alex Williamson
Acked-by: Chris Wright
---
v2: For qemu.git this time
arch_init.c | 14 +--
cpu-all.h | 28 +++--
exec.c | 78 +
> The trouble I'm running into is that the SaveStateEntry.instance_id is
> effectively private, and there's no easy way to associate a
> SaveStateEntry to a device since it passes an opaque pointer, which
> could be whatever the driver decides it wants. I'm wondering if we
> should pass the Device
On Fri, 2010-06-11 at 10:48 +0200, Gerd Hoffmann wrote:
> On 06/10/10 17:21, Alex Williamson wrote:
> > On Thu, 2010-06-10 at 15:49 +0100, Paul Brook wrote:
> >>> Ok, we can certainly doname>.instance>\.
> >>> It seems like this highlights a deficiency in the vmstate matching
> >>
> >> Why are you
Am 11.06.2010 16:02, schrieb jes.soren...@redhat.com:
> From: Jes Sorensen
>
> Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c
>
> Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values
> for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against
> the In
On 06/11/2010 09:30 AM, Luiz Capitulino wrote:
On Thu, 10 Jun 2010 12:44:55 +0200
Juan Quintela wrote:
Luiz Capitulino wrote:
On Wed, 9 Jun 2010 14:10:53 +0200
Juan Quintela wrote:
This is a resent with what we agreed on yesterday call.
Migration events would be there f
On Thu, 10 Jun 2010 12:44:55 +0200
Juan Quintela wrote:
> Luiz Capitulino wrote:
> > On Wed, 9 Jun 2010 14:10:53 +0200
> > Juan Quintela wrote:
> >
> >> This is a resent with what we agreed on yesterday call.
> >> Migration events would be there for 0.13 until we get proper
> >> async command
> Note that I *only* object to case 2 (derive bus name from parent
> device's ID). Case 3 (derive bus name from bus type) is fine with me.
>
> > Using a single counter for all busses is also wrong. The order of bus
> > creation is a device implementation detail, under no circumstances
> > should
This makes the RAM block list easier to manipulate. Also incorporate
relevant variables into the RAMList struct.
Signed-off-by: Alex Williamson
Acked-by: Chris Wright
---
arch_init.c | 14 ++-
cpu-all.h | 28 --
exec.c | 75
No reason not to call qemu_ram_map() once we have the allocation
and remove duplicate code.
Signed-off-by: Alex Williamson
Acked-by: Chris Wright
---
exec.c | 37 ++---
1 files changed, 10 insertions(+), 27 deletions(-)
diff --git a/exec.c b/exec.c
index 7b0e
These are the first two patches from the RFC sent out a couple days
ago. There seemed to be concensus that these were headed in the
right direction, so I'll post them for commit while we decided how
to name RAMBlocks.
Changes - rename 'ram' to 'ram_list' to avoid polluting the global
namespace qu
Blue Swirl wrote:
> On Tue, Jun 8, 2010 at 2:15 PM, Hannes Reinecke wrote:
>> This patch updates the megasas HBA emulation to version 1.01.
>> It fixes the following issues:
>>
>> - Remove hand-crafted inquiry command
>> - Remove bounce-buffer for direct commands
>> - Implements qdev properties to
From: Jes Sorensen
Correct definitions for FD_CMD_SAVE and FD_CMD_RESTORE in hw/fdc.c
Per https://bugs.launchpad.net/qemu/+bug/424453 the correct values
for FD_CMD_SAVE is 0x2e and FD_CMD_RESTORE is 0x4e. Verified against
the Intel 82078 manual which can be found at:
http://wiki.qemu.org/Documen
On 06/11/2010 01:06 AM, Aurelien Jarno wrote:
>> That said, all the hardware to which either I or agraf have access are the
>> latest
>> z10 machines. Frankly I expect that to be true of most if not all machines,
>> since
>> I think it's just a microcode update which everyone with an active supp
On 06/11/2010 07:55 AM, Luiz Capitulino wrote:
On Thu, 10 Jun 2010 09:27:34 -0500
Anthony Liguori wrote:
On 06/10/2010 08:08 AM, Kevin Wolf wrote:
Am 10.06.2010 14:53, schrieb Anthony Liguori:
On 06/10/2010 04:43 AM, Kevin Wolf wrote:
Huh, why this? Seems I sti
Am 07.06.2010 20:00, schrieb MORITA Kazutaka:
> Sheepdog is a distributed storage system for QEMU. It provides highly
> available block level storage volumes to VMs like Amazon EBS. This
> patch adds a qemu block driver for Sheepdog.
>
> Sheepdog features are:
> - No node in the cluster is specia
On Thu, 10 Jun 2010 12:33:42 +0200
Juan Quintela wrote:
> Luiz Capitulino wrote:
> > On Wed, 9 Jun 2010 14:10:56 +0200
> > Juan Quintela wrote:
>
> >> +MIGRATION_FAILED
> >> +
> >> +
> >> +Emitted when migration fails (both is source and target). Notice
> >> +that this event
Kevin, this patch works fine.
Kevin Wolf wrote:
> When dest is NULL, i.e. a new copy of the list is created, we don't
> get a
> properly terminated list after the realloc. Initialize it as an empty
> list.
>
> Signed-off-by: Kevin Wolf
> ---
>
> Xudong, can you please try this one? I think it
On 06/11/2010 01:06 AM, Aurelien Jarno wrote:
> What's the difference between FACILITY_ZARCH and FACILITY_ZARCH_ACTIVE,
> as both are actually flagged together. My guess is that
> FACILITY_ZARCH_ACTIVE is needed in 64-bit mode, why FACILITY_ZARCH is
> only needed for a possible future 32-bit mode.
On Thu, Jun 10, 2010 at 06:48:42PM +0100, Daniel P. Berrange wrote:
> On Mon, Jun 07, 2010 at 07:50:14PM -0500, Anthony Liguori wrote:
> > On 06/07/2010 06:52 PM, Anthony Liguori wrote:
> > >Since we have MachineCore and can represent a machine entirely via default
> > >options, we can introduce a
Paul Brook writes:
>> Paul Brook writes:
>> >> The system emulators for each arch are using inconsistent
>> >> naming for the default PCI bus "pci" vs "pci.0". Since it
>> >> is conceivable we'll have multiple PCI buses in the future
>> >> standardize on "pci.0" for all architectures. This ensur
On Thu, 10 Jun 2010 09:27:34 -0500
Anthony Liguori wrote:
> On 06/10/2010 08:08 AM, Kevin Wolf wrote:
> > Am 10.06.2010 14:53, schrieb Anthony Liguori:
> >
> >> On 06/10/2010 04:43 AM, Kevin Wolf wrote:
> >>
> >>> Huh, why this? Seems I still haven't understood all of qcow2 then... I
>
To hot-unplug guest and host part of a network device, you do:
device_del NIC-ID
netdev_del NETDEV-ID
For PCI devices, device_del merely tells ACPI to unplug the device.
The device goes away for real only after the guest processed the ACPI
unplug event.
You have to wait until then (e.g.
Markus Armbruster wrote:
> Prerna Saxena writes:
>
>> This is v2 of monitor commands based on Stefan's trace framework :
>> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
>>
>> This adds the following monitor commands for the 'simple' backend:
>> - info trace
On Fri, Jun 11, 2010 at 8:37 AM, Markus Armbruster wrote:
>> +- "id": the device's ID, must be unique (json-string)
>> +- "vlan": QEMU's internal vlan identification. Only present if the device is
>> + attached to a VLAN (json-int, optional)
>> +- "peer": ID of the frontend device when on a 1:1 r
Prerna Saxena writes:
> This is v2 of monitor commands based on Stefan's trace framework :
> ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html )
>
> This adds the following monitor commands for the 'simple' backend:
> - info trace : to view current contents of the trac
Miguel Di Ciurcio Filho writes:
> These commands show the information about active backend network devices.
>
> Signed-off-by: Miguel Di Ciurcio Filho
> ---
> qemu-monitor.hx | 53 +
> 1 files changed, 53 insertions(+), 0 deletions(-)
>
> di
Hi Luiz,
Thanks for taking time to review it.
On 06/10/2010 02:13 AM, Luiz Capitulino wrote:
On Tue, 8 Jun 2010 12:38:58 +0530
Prerna Saxena wrote:
This patch adds support for dynamically enabling/disabling of tracepoints.
Monitor commands added :
Monitor has a bool type, please tak
Hi Luiz,
Thanks for your feedback.
On 06/10/2010 02:07 AM, Luiz Capitulino wrote:
On Tue, 8 Jun 2010 12:34:37 +0530
Prerna Saxena wrote:
This introduces the monitor command 'trace' to read current contents of
trace buffer.
...
diff --git a/simpletrace.c b/simpletrace.c
index 2fec4d3..8f33a81
On 06/10/2010 02:05 AM, Luiz Capitulino wrote:
On Tue, 8 Jun 2010 12:31:38 +0530
Prerna Saxena wrote:
This exports tdb_hash() for use by tracing framework.
Suggest to rename it (eg. qemu_hash()) and move it to a better location, qdict
is not the best module to export such service.
Would
2010/6/11 kruglov.dima :
> Thanks a lot for your clarify.
>
> May be in this case it is necessary to edit a shell script in linux-
> user-test-0.3.tar.gz package?
>
> In shell script qemu-linux-user.sh
> delete sparc32plus architecture from list of all arch for testing:
>>>archs="i386 arm armeb spa
Am 11.06.2010 09:59, schrieb Jes Sorensen:
> Could you please let us know whether this is still a problem and if it
> isn't, lets close this bug.
This looks like a purely hypothetical thing - have you seen this happen
in reality, and if so, with how many snapshots?
This is reported against a very
Thanks a lot for your clarify.
May be in this case it is necessary to edit a shell script in linux-
user-test-0.3.tar.gz package?
In shell script qemu-linux-user.sh
delete sparc32plus architecture from list of all arch for testing:
>>archs="i386 arm armeb sparc sparc32plus ppc ppc64abi32 mips mip
On 06/10/10 17:21, Alex Williamson wrote:
On Thu, 2010-06-10 at 15:49 +0100, Paul Brook wrote:
Ok, we can certainly doname>.instance>\.
It seems like this highlights a deficiency in the vmstate matching
Why are you forcing this to be a string?
It seemed like a good way to send an identifier.
On 06/10/10 16:33, Alex Williamson wrote:
On Thu, 2010-06-10 at 10:23 +0200, Gerd Hoffmann wrote:
I may have been a bit misleading here. What we really want to do is use the
same matching algorithm as is used by the rest of the device state. Currently
this is a vmstate name and [arbitrary] numer
When dest is NULL, i.e. a new copy of the list is created, we don't get a
properly terminated list after the realloc. Initialize it as an empty list.
Signed-off-by: Kevin Wolf
---
Xudong, can you please try this one? I think it should fix your qemu-img
problem.
qemu-option.c |1 +
1 files
Hi all,
The bios loading part of pc_memory_init in hw/pc.c does not seem to
make sense. Specifically, the operations are:
- find the bios file and its size, put the size in bios_size
- bios_offset = qemu_ram_alloc(bios_size)
- rom_add_file_fixed(bios_name, (uint32_t)(-bios_size))
-> at this p
Hi,
Could you please let us know whether this is still a problem and if it
isn't, lets close this bug.
In addition, you haven't listed which version of qemu-kvm you are
running. I am guessing it is something Ubuntu based based on the version
number, but since not all of us are running Ubuntu it
On Thu, Jun 10, 2010 at 03:19:25PM -0700, Richard Henderson wrote:
> On 06/10/2010 03:28 AM, Aurelien Jarno wrote:
> >> +asm volatile(".word 0xb2b0,0x1000"
> >> + : "=r"(r0) : "0"(0), "r"(r1) : "memory", "cc");
> >
> > Wouldn't it be possible to use the instruction directly ins
On Thu, Jun 10, 2010 at 03:05:16PM -0700, Richard Henderson wrote:
> On 06/09/2010 03:59 PM, Aurelien Jarno wrote:
> >> +start = (void *)0x9000UL;
> >
> > Is there any reason for this address?
>
> The default link address for the main application is 0x8000,
> so this is near-by.
>
BT:
#0 0x0032f0477d20 in strcmp () from /lib64/libc.so.6
#1 0x004071bb in get_option_parameter (list=0x6447e0, name=0x432dc9
"size")
at qemu-option.c:162
#2 0x00408848 in append_option_parameters (dest=,
list=0x642460) at qemu-option.c:383
#3 0x00405143 in
65 matches
Mail list logo
