Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-06 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 1 Jun 2010 19:12:19 -0300 > Eduardo Habkost wrote: > >> I have no clue why the code had the is_inserted() check, as it doesn't matter >> if there is a disk present at the host drive, when the user wants the virtual >> device to be disconnected from the host devi

Re: [Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/05/2010 11:31 PM, Blue Swirl wrote: >> Use only an opaque CPUState pointer and move the actual CPUState >> contents handling to cpu.h and cpuid.c. >> >> Set env->halted in pc.c and add a function to get the local APIC state >> of the current CPU for the MMIO. >> >> S

[Qemu-devel] [PATCH 02/02] 9p: Implement TMKDIR

2010-06-06 Thread M. Mohan Kumar
Implement TMKDIR as part of 2000.L Work Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the

[Qemu-devel] [PATCH v2 6/6] vnc: tight: don't forget to add the last color

2010-06-06 Thread Corentin Chary
While using indexed colors, the last color was never added to the palette. Triggered with ubuntu livecd. Signed-off-by: Corentin Chary --- ui/vnc-enc-tight.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 6db5570..77fcdf7 1

[Qemu-devel] [PATCH 01/02] qemu: virtio-9p: Implement TMKDIR

2010-06-06 Thread M. Mohan Kumar
Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the mkdir reply message. Note: 72 is selecte

[Qemu-devel] [PATCH v2 0/6] vnc updates and ui move

2010-06-06 Thread Corentin Chary
Hi, This set starts by adding JPEG and gradient to tight, then move all ui code in the ui/ subdirectory. Thanks, Since v1: * Format patch with rename detection * Add "lossy" parameter instead of "lossless" * Disable lossy encodings by default * Add a small tight fix (for indexed colors) Corentin

[Qemu-devel] [PATCH v2 4/6] ui: move all ui components in ui/

2010-06-06 Thread Corentin Chary
Move sdl, vnc, curses and cocoa UI into ui/ to cleanup the root directory. Also remove some unnecessary explicit targets from Makefile. Signed-off-by: Corentin Chary --- Makefile | 38 +++- Makefile.objs

[Qemu-devel] [PATCH v2 1/6] vnc: tight: add JPEG and gradient subencoding with smooth image detection

2010-06-06 Thread Corentin Chary
Add gradient filter and JPEG compression with an heuristic to detect how lossy the comppression will be. This code has been adapted from libvncserver/tight.c. JPEG support can be enabled/disabled at compile time with --enable-vnc-jpeg and --disable-vnc-jpeg. Signed-off-by: Corentin Chary --- Ma

[Qemu-devel] [PATCH v2 5/6] vnc: rename vnc-encoding-* vnc-enc-*

2010-06-06 Thread Corentin Chary
For the same reason that we don't use vnc-authentication-sasl.c but vnc-auth-sals.c. Because it's to long. Signed-off-by: Corentin Chary --- Makefile.objs|4 ++-- ui/{vnchextile.h => vnc-enc-hextile-template.h} |0 ui/{vnc-encoding-hextile.c => vn

[Qemu-devel] [PATCH v2 3/6] vnc: add lossy option

2010-06-06 Thread Corentin Chary
The lossy option can be used to enable lossy compression methods like gradient or jpeg. This patch disable them by default. Signed-off-by: Corentin Chary --- qemu-options.hx |7 +++ vnc-encoding-tight.c |4 vnc.c|2 ++ vnc.h|2 ++ 4 f

[Qemu-devel] [PATCH v2 2/6] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-06 Thread Corentin Chary
Disable JPEG compression by default and only enable it if the VNC client has sent the requested quality. Signed-off-by: Corentin Chary --- vnc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index ed0e096..9cf38d1 100644 --- a/vnc.c +++ b/vnc.c @@ -1644,

[Qemu-devel] Few Questions about QEMU JSON

2010-06-06 Thread akshay st
Hello, Basically i want to seperate QEMU(Instruction translations, hardware emulation drivers etc...) and Simulators (UI,events etc...), Someone suggested me to use json mechanism. I want to understand more on json, can u please give me some insight,It there is any document or something it will

[Qemu-devel] [PATCH v5 RESEND 0/4] Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-06-06 Thread Yoshiaki Tamura
The dirty and non-dirty pages are checked one by one. When most of the memory is not dirty, checking the dirty and non-dirty pages by multiple page size should be much faster than checking them one by one. We introduced bit-based phys_ram_dirty for VGA, CODE, MIGRATION, MASTER, and cpu_physical_m

[Qemu-devel] [PATCH v5 RESEND 1/4] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty.

2010-06-06 Thread Yoshiaki Tamura
Replaces byte-based phys_ram_dirty bitmap with four (MASTER, VGA, CODE, MIGRATION) bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. It uses ffs() to convert DIRTY_FLAG to DIRTY_IDX. Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_r

[Qemu-devel] [PATCH v5 RESEND 3/4] Use cpu_physical_memory_set_dirty_range() to update phys_ram_dirty.

2010-06-06 Thread Yoshiaki Tamura
Modifies kvm_physical_sync_dirty_bitmap to use cpu_physical_memory_set_dirty_range() to update the row of the bit-based phys_ram_dirty bitmap at once. Signed-off-by: OHMURA Kei Signed-off-by: Yoshiaki Tamura --- kvm-all.c | 24 +--- 1 files changed, 9 insertions(+), 15 del

[Qemu-devel] [PATCH v5 RESEND 2/4] Introduce cpu_physical_memory_get_dirty_range().

2010-06-06 Thread Yoshiaki Tamura
It checks the first row and puts dirty addr in the array. If the first row is empty, it skips to the first non-dirty row or the end addr, and put the length in the first entry of the array. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- cpu-all.h |4 +++ exec.c| 67

[Qemu-devel] [PATCH v5 RESEND 4/4] Use cpu_physical_memory_get_dirty_range() to check multiple dirty pages.

2010-06-06 Thread Yoshiaki Tamura
Modifies ram_save_block() and ram_save_remaining() to use cpu_physical_memory_get_dirty_range() to check multiple dirty and non-dirty pages at once. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- arch_init.c | 57 +++-- 1 files

[Qemu-devel] [Bug 590456] Re: qemu forum (http://qemu-forum.ipi.fi/) not available

2010-06-06 Thread Anthony Liguori
The QEMU forum is in no way officially associated with QEMU. We have no access to the server and no ability to fix it. I don't even know who runs it. ** Changed in: qemu Status: New => Invalid -- qemu forum (http://qemu-forum.ipi.fi/) not available https://bugs.launchpad.net/bugs/590456

[Qemu-devel] [Bug 590552] [NEW] New default network card doesn't work with tap networking

2010-06-06 Thread Gabriele Tozzi
Public bug reported: Unfortunately, I can provide very little information. Hope this will be useful anyway. I've upgraded qemu using debian apt to lastest unstable (QEMU PC emulator version 0.12.4 (Debian 0.12.4+dfsg-2), Copyright (c) 2003-2008 Fabrice Bellard): looks like at some point the defa

Re: [Qemu-devel] qemu:virtio-9p: [RFC] [PATCH 01/02] Send iounit to client for read/write operations

2010-06-06 Thread Venkateswararao Jujjuri (JV)
Sripathi Kodi wrote: > On Tue, 1 Jun 2010 19:47:14 +0530 > "M. Mohan Kumar" wrote: > >> Compute iounit based on the host filesystem block size and pass it to >> client with open/create response. Also return iounit as statfs's f_bsize >> for optimal block size transfers. >> >> Signed-off-by: M. M

[Qemu-devel] Moving a memory mapping

2010-06-06 Thread Olivier Galibert
Hi all, I create a mmio memory mapping with cpu_register_io_memory followed by cpu_register_physical_memory. The host then twiddles a control register that changes the mapping address. How can I move the mapping to the new address? I could not find a cpu_unregister_physical_memory function or

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Paolo Bonzini
On 06/05/2010 11:31 PM, Blue Swirl wrote: Use only an opaque CPUState pointer and move the actual CPUState contents handling to cpu.h and cpuid.c. Set env->halted in pc.c and add a function to get the local APIC state of the current CPU for the MMIO. Signed-off-by: Blue Swirl --- hw/apic.c

[Qemu-devel] [Bug 590456] [NEW] qemu forum (http://qemu-forum.ipi.fi/) not available

2010-06-06 Thread raymond
Public bug reported: receive an error message since this week: --- General Error SQL ERROR [ mysql4 ] Host 'www-hostnet' is blocked because of many connection errors; unblock with 'mysqladmin flush-hosts' [1129] An sql error occurred while fetching this page. Please contact an administrator if

[Qemu-devel] Re: [RFC PATCH v4 3/3] block: add sheepdog driver for distributed storage support

2010-06-06 Thread MORITA Kazutaka
At Fri, 04 Jun 2010 13:04:00 +0200, Kevin Wolf wrote: > > Am 03.06.2010 18:23, schrieb MORITA Kazutaka: > >>> +static void sd_aio_cancel(BlockDriverAIOCB *blockacb) > >>> +{ > >>> + SheepdogAIOCB *acb = (SheepdogAIOCB *)blockacb; > >>> + > >>> + acb->canceled = 1; > >>> +} > >> > >> Does this prov

[Qemu-devel] [PATCH] virtio-net: truncating packet

2010-06-06 Thread Michael S. Tsirkin
virtio net attempts to peek into virtio queue to determine that we have enough space for the complete packet to fit. However, it fails to account for space consumed by virtio net header when it does this, Under stress this results in a failure with a message 'truncating packet'. redhat bz 591494.

[Qemu-devel] Re: sun framebuffer selection (was option-rom)

2010-06-06 Thread Artyom Tarasenko
2010/6/6 Blue Swirl : > On Sat, Jun 5, 2010 at 11:10 PM, Bob Breuer wrote: >> Blue Swirl wrote: >>>  but again: should we have a new machine with cg14 or >>> some switch to select TCX vs. cg14? >>> Why not just probe for both devices? OpenBIOS has the intention to run one day on a real hardware,

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-06 Thread Avi Kivity
On 06/04/2010 05:06 PM, Miguel Di Ciurcio Filho wrote: This introduces the protocol specification for querying information about network devices available on a VM and a new monitor command that show the same information. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 69 +++

Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-06 Thread Avi Kivity
On 06/05/2010 12:44 PM, Blue Swirl wrote: On Fri, Jun 4, 2010 at 9:45 PM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socke

Re: [Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Corentin Chary
On Sun, Jun 6, 2010 at 4:53 PM, Avi Kivity wrote: > On 06/06/2010 05:48 PM, Corentin Chary wrote: >> >> On Sun, Jun 6, 2010 at 4:11 PM, Avi Kivity  wrote: >> >>> >>> On 06/04/2010 04:20 PM, Corentin Chary wrote: >>> +    if (vnc_trylock_display(vd)) { +        vd->timer_interval = V

Re: [Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Avi Kivity
On 06/06/2010 05:48 PM, Corentin Chary wrote: On Sun, Jun 6, 2010 at 4:11 PM, Avi Kivity wrote: On 06/04/2010 04:20 PM, Corentin Chary wrote: +if (vnc_trylock_display(vd)) { +vd->timer_interval = VNC_REFRESH_INTERVAL_BASE; +qemu_mod_timer(vd->timer, qemu_get_clock

Re: [Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Corentin Chary
On Sun, Jun 6, 2010 at 4:11 PM, Avi Kivity wrote: > On 06/04/2010 04:20 PM, Corentin Chary wrote: >> >> +    if (vnc_trylock_display(vd)) { >> +        vd->timer_interval = VNC_REFRESH_INTERVAL_BASE; >> +        qemu_mod_timer(vd->timer, qemu_get_clock(rt_clock) + >> +                       vd->ti

Re: [Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Corentin Chary
On Sun, Jun 6, 2010 at 3:54 PM, Avi Kivity wrote: > On 06/05/2010 11:03 AM, Corentin Chary wrote: >>> >>> So it's disabled by default? Sounds like a pretty cool and useful feature >>> to me that should be enabled by default. >>> >> >> Because it's does not work on  windows (qemu-thread.c only uses

Re: [Qemu-devel] [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Avi Kivity
On 06/04/2010 04:20 PM, Corentin Chary wrote: +if (vnc_trylock_display(vd)) { +vd->timer_interval = VNC_REFRESH_INTERVAL_BASE; +qemu_mod_timer(vd->timer, qemu_get_clock(rt_clock) + + vd->timer_interval); +return; +} + has_dirty = vnc_re

Re: [Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server

2010-06-06 Thread Avi Kivity
On 06/05/2010 11:03 AM, Corentin Chary wrote: So it's disabled by default? Sounds like a pretty cool and useful feature to me that should be enabled by default. Because it's does not work on windows (qemu-thread.c only uses pthread) and because I don't want to break everything :)

[Qemu-devel] just one more qemu problem

2010-06-06 Thread Kristoffer Gustafsson
Hi. Well, just one more problem I need help with, then I'll not post this things to the list again. I upgraded qemu, and got sound in the console using the curses option, so windows works. but when starting in a gnome terminal with qemu windows.ovl -soundhw all -localtime The microsoft windows sc

Re: [Qemu-devel] [PATCH 01/17] vl.c: Remove double include of netinet/in.h for Solaris

2010-06-06 Thread Andreas Färber
Am 04.06.2010 um 18:08 schrieb jes.soren...@redhat.com: From: Jes Sorensen vl.c: netinet/in.h is already included once above for in the generic POSIX section. Signed-off-by: Jes Sorensen Acked-by: Andreas Faerber --- vl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff -

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Gleb Natapov
On Sun, Jun 06, 2010 at 12:10:07PM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Sun, Jun 06, 2010 at 10:07:48AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Sun, Jun 06, 2010 at 09:39:04AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Sat, Jun 05, 2010 at 02:

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Jan Kiszka
Gleb Natapov wrote: > On Sun, Jun 06, 2010 at 10:07:48AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Sun, Jun 06, 2010 at 09:39:04AM +0200, Jan Kiszka wrote: Gleb Natapov wrote: > On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: >>> I'd like to also support EOI ha

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Gleb Natapov
On Sun, Jun 06, 2010 at 10:07:48AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Sun, Jun 06, 2010 at 09:39:04AM +0200, Jan Kiszka wrote: > >> Gleb Natapov wrote: > >>> On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: > > I'd like to also support EOI handling. When the guest

[Qemu-devel] Re: [PATCHv3 1/2] virtio: support layout with avail ring before idx

2010-06-06 Thread Michael S. Tsirkin
On Sat, Jun 05, 2010 at 01:40:26PM +0930, Rusty Russell wrote: > On Fri, 4 Jun 2010 09:12:05 pm Michael S. Tsirkin wrote: > > On Fri, Jun 04, 2010 at 08:46:49PM +0930, Rusty Russell wrote: > > > I'm uncomfortable with moving a field. > > > > > > We haven't done that before and I wonder what will b

[Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements

2010-06-06 Thread Jan Kiszka
Blue Swirl wrote: > On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka wrote: >> Second round, specifically adressing: >> - IRQMsg framework to refactor existing de-coalescing code >> - RTC IRQ output as GPIO pin (routed depening on HPET or -no-hpet) >> - ISA reservation for RTC IRQ >> >> If discussion

[Qemu-devel] Re: [PATCH 11/16] hpet/rtc: Rework RTC IRQ replacement by HPET

2010-06-06 Thread Jan Kiszka
Blue Swirl wrote: > On Sun, Jun 6, 2010 at 8:11 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Allow the intercept the RTC IRQ for the HPET legacy mode. Then push >> routing to IRQ8 completely into the HPET. This allows to turn >> hpet_in_legacy_mode() into a private function. Furthermore, this

[Qemu-devel] Re: [PATCH 10/16] x86: Refactor RTC IRQ coalescing workaround

2010-06-06 Thread Jan Kiszka
Blue Swirl wrote: > On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Make use of the new IRQ message and report delivery results from the >> sink to the source. As a by-product, this also adds de-coalescing >> support to the PIC. >> >> Signed-off-by: Jan Kiszka >> ---

[Qemu-devel] Re: [PATCH 00/16] HPET cleanups, fixes, enhancements

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka wrote: > Second round, specifically adressing: >  - IRQMsg framework to refactor existing de-coalescing code >  - RTC IRQ output as GPIO pin (routed depening on HPET or -no-hpet) >  - ISA reservation for RTC IRQ > > If discussion around IRQMsg and de-coal

[Qemu-devel] Re: [PATCH 11/16] hpet/rtc: Rework RTC IRQ replacement by HPET

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 8:11 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Allow the intercept the RTC IRQ for the HPET legacy mode. Then push > routing to IRQ8 completely into the HPET. This allows to turn > hpet_in_legacy_mode() into a private function. Furthermore, this stops > the RTC from clea

[Qemu-devel] Re: [PATCH 10/16] x86: Refactor RTC IRQ coalescing workaround

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 8:10 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Make use of the new IRQ message and report delivery results from the > sink to the source. As a by-product, this also adds de-coalescing > support to the PIC. > > Signed-off-by: Jan Kiszka > --- >  hw/apic.c        |   64 +

[Qemu-devel] [PATCH 16/16] hpet: Add MSI support

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka This implements the HPET capability of routing IRQs to the front-side bus, aka MSI support. This feature can be enabled via the qdev property "msi" and is off by default. Note that switching it on can cause guests (at least Linux) to use the HPET as timer instead of the LAPIC. K

[Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-06-06 Thread Avi Kivity
On 06/04/2010 05:16 PM, Markus Armbruster wrote: - "protocol": json-array of json-object Each element object has a member "name" - Possible values: "file", "nbd", ... Additional members depend on the value of "name". For "name" = "file": - "file": file name (json-string) For

[Qemu-devel] [PATCH 15/16] hpet: Make number of timers configurable

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka One HPET block supports up to 32 timers. Allow to instantiate more than the recommended and implemented minimum of 3. The number is configured via the qdev property "timers". It is also saved/restored so that it need not match between migration peers. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 13/16] hpet: Add support for level-triggered interrupts

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka By implementing this feature we can also remove a nasty way to kill qemu (by trying to enable level-triggered hpet interrupts). Signed-off-by: Jan Kiszka --- hw/hpet.c | 32 ++-- 1 files changed, 22 insertions(+), 10 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH 11/16] hpet/rtc: Rework RTC IRQ replacement by HPET

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Allow the intercept the RTC IRQ for the HPET legacy mode. Then push routing to IRQ8 completely into the HPET. This allows to turn hpet_in_legacy_mode() into a private function. Furthermore, this stops the RTC from clearing IRQ8 even if the HPET is in control. This patch comes wi

[Qemu-devel] [PATCH 12/16] hpet: Drop static state

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Instead of keeping a static reference around, pass the state to hpet_enabled and hpet_get_ticks. All callers now have it at hand. Will once allow to instantiate the HPET more than a single time. Signed-off-by: Jan Kiszka --- hw/hpet.c | 38 +--

[Qemu-devel] [PATCH 14/16] vmstate: Add VMSTATE_STRUCT_VARRAY_UINT8

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Required for hpet. Signed-off-by: Jan Kiszka --- hw/hw.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index fc2d184..36be0be 100644 --- a/hw/hw.h +++ b/hw/hw.h @@ -474,6 +474,16 @@ extern const VMStateInfo vmstate_info_un

[Qemu-devel] [PATCH 07/16] monitor/QMP: Drop info hpet / query-hpet

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka This command was of minimal use before, now it is useless as the hpet become a qdev device and is thus easily discoverable. We should definitely not set query-hpet in QMP's stone, and there is also no good reason to keep it for the interactive monitor. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 06/16] hpet: Start/stop timer when HPET_TN_ENABLE is modified

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka We have to update the qemu timer when the per-timer enable bit is toggled, just like for HPET_CFG_ENABLE changes. Signed-off-by: Jan Kiszka --- hw/hpet.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 6974935..041dd84 1

[Qemu-devel] [PATCH 09/16] Enable message delivery via IRQs

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka This patch allows to optionally attach a message to an IRQ event. The message can contain a payload reference and a callback that the IRQ handler may invoke to report the delivery result. The former can be used to model message signaling interrupts, the latter to cleanly implemen

[Qemu-devel] [PATCH 10/16] x86: Refactor RTC IRQ coalescing workaround

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Make use of the new IRQ message and report delivery results from the sink to the source. As a by-product, this also adds de-coalescing support to the PIC. Signed-off-by: Jan Kiszka --- hw/apic.c| 64 +++-- hw/apic.h|9 +

[Qemu-devel] [PATCH 03/16] hpet: Silence warning on write to running main counter

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Setting the main counter while the HPET is enabled may not be a good idea of the guest, but it is supported and should, thus, not spam the host console with warnings. Signed-off-by: Jan Kiszka --- hw/hpet.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --

[Qemu-devel] [PATCH 05/16] hpet: Convert to qdev

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Register the HPET as a sysbus device and create it that way. As it can route its IRQs to any ISA IRQ, we need to connect it to all 24 of them. Once converted to qdev, we can move reset handler and vmstate registration into its hands as well. Signed-off-by: Jan Kiszka --- hw/hp

[Qemu-devel] [PATCH 02/16] hpet: Coding style cleanups and some refactorings

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka This moves the private HPET structures into the C module, simplifies some helper functions and fixes most coding style issues (biggest chunk was improper switch-case indention). No functional changes. Signed-off-by: Jan Kiszka Reviewed-by: Juan Quintela --- hw/hpet.c |

[Qemu-devel] [PATCH 00/16] HPET cleanups, fixes, enhancements

2010-06-06 Thread Jan Kiszka
Second round, specifically adressing: - IRQMsg framework to refactor existing de-coalescing code - RTC IRQ output as GPIO pin (routed depening on HPET or -no-hpet) - ISA reservation for RTC IRQ If discussion around IRQMsg and de-coalescing happens to continue, I would suggest to merge patches 1

[Qemu-devel] [PATCH 04/16] hpet: Move static timer field initialization

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Properly initialize HPETTimer::tn and HPETTimer::state once during hpet_init instead of (re-)writing them on every reset. Signed-off-by: Jan Kiszka --- hw/hpet.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index bcb160b..fd

[Qemu-devel] [PATCH 01/16] hpet: Catch out-of-bounds timer access

2010-06-06 Thread Jan Kiszka
From: Jan Kiszka Also prevent out-of-bounds write access to the timers but don't spam the host console if it triggers. Signed-off-by: Jan Kiszka --- hw/hpet.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/hpet.c b/hw/hpet.c index 8729fb2..1980906 100644 --- a

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Jan Kiszka
Gleb Natapov wrote: > On Sun, Jun 06, 2010 at 09:39:04AM +0200, Jan Kiszka wrote: >> Gleb Natapov wrote: >>> On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: > I'd like to also support EOI handling. When the guest clears the > interrupt condtion, the EOI callback would be called.

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Gleb Natapov
On Sun, Jun 06, 2010 at 07:39:49AM +, Blue Swirl wrote: > On Sun, Jun 6, 2010 at 7:15 AM, Gleb Natapov wrote: > > On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: > >> > I'd like to also support EOI handling. When the guest clears the > >> > interrupt condtion, the EOI callback woul

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Gleb Natapov
On Sun, Jun 06, 2010 at 09:39:04AM +0200, Jan Kiszka wrote: > Gleb Natapov wrote: > > On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: > >>> I'd like to also support EOI handling. When the guest clears the > >>> interrupt condtion, the EOI callback would be called. This could occur > >>>

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 7:36 AM, Jan Kiszka wrote: > Blue Swirl wrote: >> Use only an opaque CPUState pointer and move the actual CPUState >> contents handling to cpu.h and cpuid.c. >> >> Set env->halted in pc.c and add a function to get the local APIC state >> of the current CPU for the MMIO. >> >

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Blue Swirl
On Sun, Jun 6, 2010 at 7:15 AM, Gleb Natapov wrote: > On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: >> > I'd like to also support EOI handling. When the guest clears the >> > interrupt condtion, the EOI callback would be called. This could occur >> > much later than the IRQ delivery

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Jan Kiszka
Gleb Natapov wrote: > On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: >>> I'd like to also support EOI handling. When the guest clears the >>> interrupt condtion, the EOI callback would be called. This could occur >>> much later than the IRQ delivery time. I'm not sure if we need the >>

[Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals

2010-06-06 Thread Jan Kiszka
Blue Swirl wrote: > Use only an opaque CPUState pointer and move the actual CPUState > contents handling to cpu.h and cpuid.c. > > Set env->halted in pc.c and add a function to get the local APIC state > of the current CPU for the MMIO. > > Signed-off-by: Blue Swirl > --- > hw/apic.c

[Qemu-devel] Re: sun framebuffer selection (was option-rom)

2010-06-06 Thread Blue Swirl
On Sat, Jun 5, 2010 at 11:10 PM, Bob Breuer wrote: > Blue Swirl wrote: >>  but again: should we have a new machine with cg14 or >> some switch to select TCX vs. cg14? >> >> Maybe the recently proposed machine subtype patches could help here. >> > Well, let's try to figure out a method of selecting

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-06-06 Thread Gleb Natapov
On Sat, Jun 05, 2010 at 02:04:01AM +0200, Jan Kiszka wrote: > > I'd like to also support EOI handling. When the guest clears the > > interrupt condtion, the EOI callback would be called. This could occur > > much later than the IRQ delivery time. I'm not sure if we need the > > result code in that

Re: [Qemu-devel] [PATCH-V5 0/10] virtio-9p:Introducing security model for VirtFS

2010-06-06 Thread Blue Swirl
On Sat, Jun 5, 2010 at 10:50 PM, Venkateswararao Jujjuri (JV) wrote: > Blue Swirl wrote: >> On Sat, Jun 5, 2010 at 1:08 AM, Venkateswararao Jujjuri (JV) >> wrote: >>> This patch series introduces the security model for VirtFS. >>> >>> Brief description of this patch series: >>> >>> It introduces