[Qemu-devel] [PATCH 06/12] hw/omap2.c : separate sdrc (sdram controller)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c | 144 hw/omap_sdrc.c | 165 +++ 4 files changed, 168 insertions(+), 145 deletions(-) create mod

[Qemu-devel] [PATCH 07/12] hw/omap1.c : separate interrupt controller module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap1.c | 576 + hw/omap_intc.c | 598 +++ 4 files changed, 603 insertions(+), 575 deletions(-) creat

[Qemu-devel] [PATCH 05/12] hw/omap2.c : separate gpmc(general purpose memory controller)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c | 396 hw/omap_gpmc.c | 419 +++ 4 files changed, 422 insertions(+), 397 deletions(-) create

[Qemu-devel] [PATCH 10/12] hw/omwp2.c : separate l4 interconnect module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |3 +- hw/omap.h | 37 ++-- hw/omap2.c | 269 ++- hw/omap_l4.c| 271 +++ 4 files changed, 307 insertions(+), 273 deletions(

[Qemu-devel] [PATCH 12/12] hw/omap : make local function static and remove declaration from header

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- hw/omap.h | 36 hw/omap1.c | 10 +- hw/omap2.c |6 +++--- 3 files changed, 8 insertions(+), 44 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index 34443b4..18eb72b 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -108,15

[Qemu-devel] [PATCH 04/12] hw/omap2.c : separate synctimer module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h | 11 +++--- hw/omap2.c | 72 +- hw/omap_synctimer.c | 96 +++ 4 files changed, 104 insertions(+), 77 deletions(-) crea

[Qemu-devel] [PATCH 03/12] hw/omap2.c : separate gptimer module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c| 462 -- hw/omap_gptimer.c | 484 + 4 files changed, 487 insertions(+), 463 deletions(-) cr

[Qemu-devel] [PATCH 09/12] hw/omap2.c : separate tap module(Test-Chip-level)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap2.c | 90 hw/omap_tap.c | 112 +++ 3 files changed, 113 insertions(+), 91 deletions(-) create mode 100644 hw/omap_tap.c diff --

[Qemu-devel] [PATCH 02/12] hw/omap2.c : separate gpio module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- hw/omap.h |3 + hw/omap2.c | 523 hw/omap_gpio.c | 523 3 files changed, 526 insertions(+), 523 deletions(-) diff --git a/hw/omap.h b/hw/oma

[Qemu-devel] [PATCH 01/12] hw/omap1.c : separate gpio module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |1 + hw/omap1.c | 181 - hw/omap_gpio.c | 202 +++ 4 files changed, 204 insertions(+), 182 deletions(-) create mo

[Qemu-devel] [PATCH 00/12] refactor OMAP implementation

2010-05-28 Thread cmchao
The following changes since commit 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb: Jes Sorensen (1): vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The patches almostly base on http://meego.gitorious.org/qemu-maemo/qemu work and act as preparatory

Re: [Qemu-devel] cg14

2010-05-28 Thread Artyom Tarasenko
2010/5/28 Blue Swirl : > On Fri, May 28, 2010 at 7:54 AM, Bob Breuer wrote: >> Artyom Tarasenko wrote: >>> 2010/5/27 Bob Breuer : >>> Artyom Tarasenko wrote: > Was going to put some more empty slots into SS-10/20 (VSIMMs, SX) > after we are done with SS-5 (due to technical limita

Re: [Qemu-devel] [PATCH] alpha-linux-user: Fill in SI_CODE for SIGSEGV.

2010-05-28 Thread Aurelien Jarno
On Fri, May 21, 2010 at 10:03:33AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/main.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Thanks, applied. > diff --git a/linux-user/main.c b/linux-user/main.c > index b240f29..de1076b 100644 >

Re: [Qemu-devel] [PATCH 0/2] Tidy qemu_malloc

2010-05-28 Thread Aurelien Jarno
On Fri, May 21, 2010 at 10:37:50AM -0700, Richard Henderson wrote: > I was reminded of this by the discussion on the list recently of > using calloc for qemu_mallocz. I'd vaguely remembered that I > already had a patch that did this. > > The second patch is a cleanup enabled by Paul's patch: >

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-28 Thread Artyom Tarasenko
> 32m: 0x12fff394 > 64m: 0x14fff394 > 192m:0x1cfff394 > 256m:0x20fff394 > > Memory probing? It would be strange that OS would do it itself. The OS > could just > ask OBP how much does it have. Here is the listing where it happens: > > _swift_vac_rgnflush:            rd      %psr, %g2 > _swift_vac_r

Re: [Qemu-devel] [PATCH 1/2] tcg: Add TYPE parameter to tcg_out_mov.

2010-05-28 Thread Richard Henderson
On 05/28/2010 11:21 AM, Aurelien Jarno wrote: >> +tcg_out_mov(s, TCG_TYPE_PTR, data_reg, arg0); > > Is it something correct? This refers to a data register according to the > name of the variable. > >> break; >> } >> >> @@ -1007,10 +1007,10 @@ static void tcg_out_qemu_st(T

Re: [Qemu-devel] Re: [PATCH, RFC 1/4] pci: add I/O registration functions

2010-05-28 Thread Paul Brook
> On Thu, May 27, 2010 at 2:39 PM, Michael S. Tsirkin wrote: > > On Sun, May 23, 2010 at 08:34:30PM +, Blue Swirl wrote: > >> Convert also APB to use the registration so that > >> we can remove mem_base. > >> > >> Signed-off-by: Blue Swirl > >> --- > >> hw/apb_pci.c | 23 +

Re: [Qemu-devel] [PATCH v2 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-05-28 Thread Aurelien Jarno
I would appreciate if someone knowing the PCI code could review this patch. On Wed, May 19, 2010 at 10:27:23PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |2 +- > hw/pc.h |7 + > hw/pci_ids.h|8 + > hw/vt82c686.c | 786 > +++

Re: [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context

2010-05-28 Thread Igor Kovalenko
On Sat, May 29, 2010 at 12:30 AM, Blue Swirl wrote: > On Fri, May 28, 2010 at 9:48 AM, Igor V. Kovalenko > wrote: >> From: Igor V. Kovalenko >> >> Signed-off-by: Igor V. Kovalenko >> --- >>  sparc-dis.c              |    2 ++ >>  target-sparc/op_helper.c |   10 +- >>  2 files changed, 7

Re: [Qemu-devel] [PATCH v2 3/6] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 10:27:50PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.objs|1 + > default-configs/mips64el-softmmu.mak |1 + > hw/ide.h |1 + > hw/ide/via.c | 185 > +

Re: [Qemu-devel] [PATCH] linux-user: Fix compilation with DEBUG defined

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 09:49:21PM +0200, Riccardo Magliocchetti wrote: > Signed-off-by: Riccardo Magliocchetti Thanks, applied. > --- > linux-user/flatload.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/linux-user/flatload.c b/linux-user/flatload.c > index 6a

[Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context v1

2010-05-28 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - change 128-bit atomic loads to reference nucleus context v0->v1: dropped disassembler change Signed-off-by: Igor V. Kovalenko --- target-sparc/op_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-sparc/op_helper.c b/targe

Re: [Qemu-devel] cg14

2010-05-28 Thread Blue Swirl
On Fri, May 28, 2010 at 7:54 AM, Bob Breuer wrote: > Artyom Tarasenko wrote: >> 2010/5/27 Bob Breuer : >> >>> Artyom Tarasenko wrote: >>> Was going to put some more empty slots into SS-10/20 (VSIMMs, SX) after we are done with SS-5 (due to technical limitations I can switch access f

Re: [Qemu-devel] [PATCH v2 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 10:28:11PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > hw/usb-uhci.c | 30 ++ > hw/usb-uhci.h |1 + > 2 files changed, 31 insertions(+), 0 deletions(-) > > diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c > index 624d55b..5fd

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-05-28 Thread Paul Brook
[Hit send too early on previous mail...] > The basic device interface looks like > ... > + > +/* Register a memory region at START_ADDR/SIZE. The REGION structure will > + be initialized appropriately for DEV using CB as the operation set. */ > +extern void cpu_register_memory_region(MemoryRegi

Re: [Qemu-devel] [PATCH 3/3] Fix hw/gt64xxx.c compilation with DEBUG defined

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 06:49:30PM +0200, Riccardo Magliocchetti wrote: > Use TARGET_FMT_plx as format placeholder for target_phys_addr_t > > Signed-off-by: Riccardo Magliocchetti Thanks, applied. > --- > hw/gt64xxx.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH 1/3] Fix typo in balloon help

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 06:49:28PM +0200, Riccardo Magliocchetti wrote: > Fix launchpad #563883 > > Signed-off-by: Riccardo Magliocchetti Thanks, applied. > --- > qemu-monitor.hx |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-monitor.hx b/qemu-monitor.hx >

[Qemu-devel] Re: [PATCH v2 6/6] MIPS: add PMON (binary file) used by fulong mini pc

2010-05-28 Thread Aurelien Jarno
On Wed, May 19, 2010 at 10:29:13PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > pc-bios/pmon_fulong2e.bin | Bin 0 -> 335436 bytes > 1 files changed, 0 insertions(+), 0 deletions(-) > create mode 100755 pc-bios/pmon_fulong2e.bin > Where does this file come from? Usually an U

Re: [Qemu-devel] [PATCH 1/1] ceph/rbd block driver for qemu-kvm (v2)

2010-05-28 Thread Christian Brunner
Hi Kevin, thanks for your review notes. Yehuda and I have already worked this into the git tree on the ceph site. I'll do some testing on Monday. After that I'll send an updated patch. Regards, Christian 2010/5/28 Kevin Wolf : > Am 27.05.2010 21:11, schrieb Christian Brunner: >> This is a block

Re: [Qemu-devel] [PATCH v2 5/6] MIPS: Initial support of fulong mini pc (CPU definition, machine construction, etc.)

2010-05-28 Thread Aurelien Jarno
Please find my comments below. On Wed, May 19, 2010 at 10:28:36PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |2 +- > hw/mips_fulong2e.c | 421 > ++ > target-mips/translate_init.c | 35

Re: [Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-28 Thread Michael Tokarev
12.05.2010 22:11, Stefano Stabellini wrote: On Wed, 12 May 2010, Jamie Lokier wrote: Stefano Stabellini wrote: On Wed, 12 May 2010, Avi Kivity wrote: It's useful if you have a one-line horizontal pattern you want to propagate all over. It might be useful all right, but it is not entirely cle

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-05-28 Thread Paul Brook
> The basic device interface looks like > ... > + > +/* Register a memory region at START_ADDR/SIZE. The REGION structure will > + be initialized appropriately for DEV using CB as the operation set. */ > +extern void cpu_register_memory_region(MemoryRegion *region, > +

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-28 Thread Gleb Natapov
On Fri, May 28, 2010 at 08:06:45PM +, Blue Swirl wrote: > 2010/5/28 Gleb Natapov : > > On Thu, May 27, 2010 at 06:37:10PM +, Blue Swirl wrote: > >> 2010/5/27 Gleb Natapov : > >> > On Wed, May 26, 2010 at 08:35:00PM +, Blue Swirl wrote: > >> >> On Wed, May 26, 2010 at 8:09 PM, Jan Kiszka

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2010-05-28 Thread Michael Tokarev
..And without -enable-kvm, it works (it corrupts cirrus vga but that's another issue, fixed in 0.13-tobe). -- migration always fails on 32bit qemu-kvm-0.12+ (sigsegv) https://bugs.launchpad.net/bugs/584121 You received this bug notification because you are a member of qemu- devel-ml, which is sub

[Qemu-devel] [Bug 584121] Re: migration always fails on 32bit qemu-kvm-0.12+ (sigsegv)

2010-05-28 Thread Michael Tokarev
Running it on unmodified qemu-0.12.4 gives the same effect: the sending side crashes immediately with heap corruption (detected in realloc). On the receiving side, there are 2 messages: qemu: warning: error while loading state for instance 0x0 of device 'ram' load of migration failed ie, the sa

Re: [Qemu-devel] [PATCH v2 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-05-28 Thread Aurelien Jarno
Please find my comments below. Note that I don't feel very comfortable with PCI code, so a review from someone know this part of QEMU would be nice. On Wed, May 19, 2010 at 10:26:32PM +0800, Huacai Chen wrote: > Signed-off-by: Huacai Chen > --- > Makefile.target |1 + >

Re: [Qemu-devel] [PATCH] sparc64: fix 128-bit atomic load from nucleus context

2010-05-28 Thread Blue Swirl
On Fri, May 28, 2010 at 9:48 AM, Igor V. Kovalenko wrote: > From: Igor V. Kovalenko > > Signed-off-by: Igor V. Kovalenko > --- >  sparc-dis.c              |    2 ++ >  target-sparc/op_helper.c |   10 +- >  2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/sparc-dis.c b/sp

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-28 Thread Blue Swirl
2010/5/28 Gleb Natapov : > On Thu, May 27, 2010 at 06:37:10PM +, Blue Swirl wrote: >> 2010/5/27 Gleb Natapov : >> > On Wed, May 26, 2010 at 08:35:00PM +, Blue Swirl wrote: >> >> On Wed, May 26, 2010 at 8:09 PM, Jan Kiszka wrote: >> >> > Blue Swirl wrote: >> >> >> On Tue, May 25, 2010 at 9:

Re: [Qemu-devel] [PATCH] MIPS DINSU

2010-05-28 Thread Aurelien Jarno
On Mon, May 17, 2010 at 04:20:21PM +0400, Dmitry Antipov wrote: > Hello, > > shouldn't it be in that way? > > Dmitry > Good catch, it is correct. Would you mind resending the patch with a Signed-off-by: line? > --- qemu-0.12.4/target-mips/translate.c 2010-05-17 16:12:58.048661610 > +040

Re: [Qemu-devel] [PATCH] musicpal: Drop redundant reset call

2010-05-28 Thread Aurelien Jarno
On Thu, May 13, 2010 at 03:09:58PM +0200, Jan Kiszka wrote: > Reset is now triggered after init, no need for explicit calls anymore. Thanks, applied. > Signed-off-by: Jan Kiszka > --- > hw/musicpal.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/hw/musicpal.c b

Re: [Qemu-devel] [PATCH v2] doc: Update monitor info subcommands

2010-05-28 Thread Aurelien Jarno
On Wed, May 12, 2010 at 03:10:56PM +0100, Stefan Hajnoczi wrote: > The "info blockstats" documentation was copy-pasted as "info block" > instead of "info blockstats". The documentation for "commands", "jit", > "numa", "qdm", and "roms" is missing. This patch resolves these issues > in qemu-monito

Re: [Qemu-devel] [PATCH] Name the default PCI bus "pci.0" on all architectures

2010-05-28 Thread Paul Brook
> The system emulators for each arch are using inconsistent > naming for the default PCI bus "pci" vs "pci.0". Since it > is conceivable we'll have multiple PCI buses in the future > standardize on "pci.0" for all architectures. This ensures > mgmt apps can rely on a name when assigning PCI devices

Re: [Qemu-devel] [PATCH] Fix overflow in i440fx_init()

2010-05-28 Thread Aurelien Jarno
On Sun, May 09, 2010 at 02:51:13PM +0300, Avi Kivity wrote: > The ram_size parameter can be larger than an int, so it may be truncated. > > Fix by using the correct type. Thanks, applied. > Signed-off-by: Avi Kivity > --- > hw/pc.h |2 +- > hw/piix_pci.c |2 +- > 2 files changed,

Re: [Qemu-devel] [PATCH] Compile dma only once

2010-05-28 Thread Paul Brook
> Use a qemu_irq to request CPU exit. Needing to request a CPU exit at all is just wrong. See previous discussions about how any use of qemu_bh_schedule_idle is fundamentally broken. Paul

Re: [Qemu-devel] [PATCH] arm: prevent coprocessor IO reset

2010-05-28 Thread Aurelien Jarno
On Sat, May 08, 2010 at 10:42:43PM +0200, Lars Munch wrote: > This prevent coprocessor IO structure from being reset on cpu reset. This was > a problem for PXA which uses coprocessor 6 and 14. > > Signed-off-by: Lars Munch Thanks, applied. > --- > target-arm/cpu.h | 14 +++--- > 1 fi

Re: [Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-05-28 Thread Luiz Capitulino
On Fri, 28 May 2010 14:17:07 -0500 Anthony Liguori wrote: > On 05/28/2010 02:13 PM, Kevin Wolf wrote: > > Am 28.05.2010 20:21, schrieb Markus Armbruster: > > > >> I'd like to give posting documentation of new QMP commands for review > >> before posting code a try. But first let me explain br

Re: [Qemu-devel] [PATCH] arm: fix arm kernel boot for non zero start addr

2010-05-28 Thread Aurelien Jarno
On Sat, May 08, 2010 at 10:43:35PM +0200, Lars Munch wrote: > Booting an arm kernel has been broken a while when booting from non zero start > address. This is due to the order of events: board init loads the kernel and > sets register 15 to the start address and then qemu_system_reset reset the cp

[Qemu-devel] [Reminder] KVM Forum 2010: Early Bird Registration

2010-05-28 Thread KVM Forum 2010 Program Committee
Just a reminder...The early bird registration period ends on May 30th. It's shaping up to be an excellent KVM Forum, look forward to seeing you there. Registration link is here: http://events.linuxfoundation.org/component/registrationpro/?func=details&did=34 thanks, -KVM Forum 2010 Program Comm

Re: [Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-05-28 Thread Anthony Liguori
On 05/28/2010 02:13 PM, Kevin Wolf wrote: Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me explain briefly why we need new commands. We want a clean separation between host part

[Qemu-devel] Re: RFC: blockdev_add & friends, brief rationale, QMP docs

2010-05-28 Thread Kevin Wolf
Am 28.05.2010 20:21, schrieb Markus Armbruster: > I'd like to give posting documentation of new QMP commands for review > before posting code a try. But first let me explain briefly why we need > new commands. > > We want a clean separation between host part (blockdev_add) and guest > part (devic

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-28 Thread Blue Swirl
On Thu, May 27, 2010 at 10:21 PM, Paul Brook wrote: > >> >> Then the amount >> >> of CPU cycles between timer interrupts would increase and hopefully >> >> the guest can keep up. If the guest sleeps, time base could be >> >> accelerated to catch up with wall clock and then set back to 1:1 rate. >>

[Qemu-devel] [PATCH] target-ppc: fix RFI by clearing some bits of MSR

2010-05-28 Thread Thomas Monjalon
From: Thomas Monjalon Since commit 2ada0ed, "Return From Interrupt" is broken for PPC processors because some interrupt specifics bits of SRR1 are copied to MSR. SRR1 is a save of MSR during interrupt. During RFI, MSR must be restored from SRR1. But some bits of SRR1 are interrupt-specific and a

[Qemu-devel] [PATCH] target-ppc: remove useless line

2010-05-28 Thread Thomas Monjalon
From: Thomas Monjalon This line was a bit clear. The next lines set or reset this bit (LE) depending of another bit (ILE). So the first line is useless. Signed-off-by: Thomas Monjalon --- target-ppc/helper.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-ppc/he

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-28 Thread Blue Swirl
On Thu, May 27, 2010 at 10:19 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> On Thu, May 27, 2010 at 7:08 PM, Jan Kiszka wrote: >>> Blue Swirl wrote: On Thu, May 27, 2010 at 6:31 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> On Wed, May 26, 2010 at 11:26 PM, Paul Brook >> wrote:

[Qemu-devel] Re: [PATCH] savevm: Really verify if a drive supports snapshots

2010-05-28 Thread Kevin Wolf
Am 28.05.2010 20:18, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b

[Qemu-devel] RFC: blockdev_add & friends, brief rationale, QMP docs

2010-05-28 Thread Markus Armbruster
I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me explain briefly why we need new commands. We want a clean separation between host part (blockdev_add) and guest part (device_add). Existing -drive and drive_add don't provide that; t

[Qemu-devel] [PATCH] qemu-io: Fix error messages

2010-05-28 Thread Kevin Wolf
The truncate and getlength commands passed a negative error number to strerror. They also happen to be the two functions that are lacking a newline at the end of their error message. Signed-off-by: Kevin Wolf --- qemu-io.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [STABLE PULL 0/6] Block patches for 0.12.x

2010-05-28 Thread Kevin Wolf
The following changes since commit 0c459361a1117a6c434c7b2b008a4c6c035eb4bf: Rabin Vincent (1): arm_timer: fix oneshot mode are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-stable-0.12 Kevin Wolf (6): ide: Fix ide_dma_cancel qcow2: Clear L2 tabl

[Qemu-devel] [STABLE PATCH 3/6] qcow2: Fix error handling in l2_allocate

2010-05-28 Thread Kevin Wolf
l2_allocate has some intermediate states in which the image is inconsistent. Change the order to write to the L1 table only after the new L2 table has successfully been initialized. Also reset the L2 cache in failure case, it's very likely wrong. Signed-off-by: Kevin Wolf (cherry picked from com

[Qemu-devel] [STABLE PATCH 5/6] qcow2: Fix corruption after refblock allocation

2010-05-28 Thread Kevin Wolf
Refblock allocation code needs to take into consideration that update_refcount will load a different refcount block into the cache, so it must initialize the cache for a new refcount block only afterwards. Not doing this means that not only the refcount in the wrong block is updated, but also that

Re: [Qemu-devel] [PATCH 2/2] tcg: Use INDEX_op_qemu_ld32 for 32-bit results.

2010-05-28 Thread Aurelien Jarno
On Mon, May 03, 2010 at 04:30:48PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson Thanks, applied. > --- > tcg/tcg-op.h |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index bafac2b..aa436de 100644 > --- a/t

Re: [Qemu-devel] [PATCH 1/2] tcg: Add TYPE parameter to tcg_out_mov.

2010-05-28 Thread Aurelien Jarno
On Mon, May 03, 2010 at 04:30:47PM -0700, Richard Henderson wrote: > Mirror tcg_out_movi in having a TYPE parameter. This allows x86_64 > to perform the move at the proper width, which may elide a REX prefix. > Update all targets to match. This patch basically looks ok except a few comments below

[Qemu-devel] [PATCH 11/12] hw/omap1.c : separate uart module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |3 +- hw/omap1.c | 170 hw/omap_uart.c | 194 +++ 3 files changed, 196 insertions(+), 171 deletions(-) create mode 100644 hw/omap_uart.c d

[Qemu-devel] [PATCH] savevm: Really verify if a drive supports snapshots

2010-05-28 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually checkin

[Qemu-devel] [PATCH 08/12] hw/omap2.c : separate spi module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c | 323 --- hw/omap_spi.c | 346 +++ 4 files changed, 349 insertions(+), 324 deletions(-) create

[Qemu-devel] [STABLE PATCH 1/6] ide: Fix ide_dma_cancel

2010-05-28 Thread Kevin Wolf
When cancelling a request, bdrv_aio_cancel may decide that it waits for completion of a request rather than for cancellation. IDE therefore can't abandon its DMA status before calling bdrv_aio_cancel; otherwise the callback of a completed request would use invalid data. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 06/12] hw/omap2.c : separate sdrc (sdram controller)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c | 144 hw/omap_sdrc.c | 165 +++ 4 files changed, 168 insertions(+), 145 deletions(-) create mod

[Qemu-devel] [STABLE PATCH 2/6] qcow2: Clear L2 table cache after write error

2010-05-28 Thread Kevin Wolf
If the L2 table was already updated in cache, but writing it to disk has failed, we must not continue using the changed version in the cache to stay consistent with what's on the disk. Signed-off-by: Kevin Wolf (cherry picked from commit 1b7c801b40ce90795397bb566d019c9b76ef9c13) Conflicts:

[Qemu-devel] [STABLE PATCH 4/6] block: Fix multiwrite with overlapping requests

2010-05-28 Thread Kevin Wolf
With overlapping requests, the total number of sectors is smaller than the sum of the nb_sectors of both requests. Signed-off-by: Kevin Wolf (cherry picked from commit cbf1dff2f1033cadcb15c0ffc9c0a3d039d8ed42) --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

[Qemu-devel] [PATCH 05/12] hw/omap2.c : separate gpmc(general purpose memory controller)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c | 396 hw/omap_gpmc.c | 419 +++ 4 files changed, 422 insertions(+), 397 deletions(-) create

[Qemu-devel] [PATCH 04/12] hw/omap2.c : separate synctimer module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h | 11 +++--- hw/omap2.c | 72 +- hw/omap_synctimer.c | 96 +++ 4 files changed, 104 insertions(+), 77 deletions(-) crea

[Qemu-devel] [STABLE PATCH 6/6] qcow2: Fix corruption after error in update_refcount

2010-05-28 Thread Kevin Wolf
After it is done with updating refcounts in the cache, update_refcount writes all changed entries to disk. If a refcount block allocation fails, however, there was no change yet and therefore first_index = last_index = -1. Don't treat -1 as a normal sector index (resulting in a 512 byte write!) but

[Qemu-devel] [PATCH 09/12] hw/omap2.c : separate tap module(Test-Chip-level)

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap2.c | 90 hw/omap_tap.c | 112 +++ 3 files changed, 113 insertions(+), 91 deletions(-) create mode 100644 hw/omap_tap.c diff --

[Qemu-devel] [PATCH 03/12] hw/omap2.c : separate gptimer module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap2.c| 462 -- hw/omap_gptimer.c | 484 + 4 files changed, 487 insertions(+), 463 deletions(-) cr

[Qemu-devel] [PATCH 12/12] hw/omap : make local function static and remove declaration from header

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- hw/omap.h | 36 hw/omap1.c | 10 +- hw/omap2.c |6 +++--- 3 files changed, 8 insertions(+), 44 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index 34443b4..18eb72b 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -108,15

[Qemu-devel] [PATCH 10/12] hw/omwp2.c : separate l4 interconnect module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |3 +- hw/omap.h | 37 ++-- hw/omap2.c | 269 ++- hw/omap_l4.c| 271 +++ 4 files changed, 307 insertions(+), 273 deletions(

[Qemu-devel] [PATCH 01/12] hw/omap1.c : separate gpio module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |1 + hw/omap1.c | 181 - hw/omap_gpio.c | 202 +++ 4 files changed, 204 insertions(+), 182 deletions(-) create mo

[Qemu-devel] [PATCH 07/12] hw/omap1.c : separate interrupt controller module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- Makefile.target |2 +- hw/omap.h |2 + hw/omap1.c | 576 + hw/omap_intc.c | 598 +++ 4 files changed, 603 insertions(+), 575 deletions(-) creat

[Qemu-devel] [PATCH 02/12] hw/omap2.c : separate gpio module

2010-05-28 Thread cmchao
Signed-off-by: cmchao --- hw/omap.h |3 + hw/omap2.c | 523 hw/omap_gpio.c | 523 3 files changed, 526 insertions(+), 523 deletions(-) diff --git a/hw/omap.h b/hw/oma

[Qemu-devel] [PATCH 00/12] refactor OMAP implementation

2010-05-28 Thread cmchao
The following changes since commit 29f91781bd300b228d9c38b9f6c1e0b6a38f25fb: Jes Sorensen (1): vhost_net.c: v2 Fix build failure introduced by 0bfcd599e3f5c5679cc7d0165a0a1822e2f60de2 The patches almostly base on http://meego.gitorious.org/qemu-maemo/qemu work and act as pr

[Qemu-devel] Re: [PULL 00/14] Block patches

2010-05-28 Thread Kevin Wolf
Am 28.05.2010 18:48, schrieb Anthony Liguori: > On 05/28/2010 11:45 AM, Kevin Wolf wrote: >> Hi Anthony, >> >> this includes again some patches that should be applied to stable-0.12, too: >> >> 86fa8da qcow2: Fix corruption after error in update_refcount >> 25408c0 qcow2: Fix corruption a

[Qemu-devel] Re: [PULL 00/14] Block patches

2010-05-28 Thread Anthony Liguori
On 05/28/2010 11:45 AM, Kevin Wolf wrote: Hi Anthony, this includes again some patches that should be applied to stable-0.12, too: 86fa8da qcow2: Fix corruption after error in update_refcount 25408c0 qcow2: Fix corruption after refblock allocation cbf1dff block: Fix multiwrite wi

Re: [Qemu-devel] [PATCH 02/62] add lost chunks from the original patch

2010-05-28 Thread Richard Henderson
On 05/28/2010 09:49 AM, Andreas Färber wrote: > Am 27.05.2010 um 22:45 schrieb Richard Henderson: > >> From: Alexander Graf >> >> --- >> tcg/s390/tcg-target.c |3 ++ >> tcg/s390/tcg-target.h | 86 >> +++-- >> 2 files changed, 86 insertions(+), 3 del

[Qemu-devel] [PATCH 11/14] qcow2: Return right error code in write_refcount_block_entries

2010-05-28 Thread Kevin Wolf
write_refcount_block_entries used to return -EIO for any errors. Change this to return the real error code. Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qco

[Qemu-devel] Re: [PULL 00/14] Block patches

2010-05-28 Thread Anthony Liguori
On 05/28/2010 11:51 AM, Kevin Wolf wrote: Am 28.05.2010 18:48, schrieb Anthony Liguori: On 05/28/2010 11:45 AM, Kevin Wolf wrote: Hi Anthony, this includes again some patches that should be applied to stable-0.12, too: 86fa8da qcow2: Fix corruption after error in update_refcou

[Qemu-devel] [PATCH 07/14] posix-aio-compat: Expand tabs that have crept in

2010-05-28 Thread Kevin Wolf
From: Stefan Hajnoczi This patch expands tabs on a few lines so the code formats nicely and follows the QEMU coding style. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- posix-aio-compat.c | 58 ++-- 1 files changed, 29 insertion

Re: [Qemu-devel] [PATCH 02/62] add lost chunks from the original patch

2010-05-28 Thread Andreas Färber
Am 27.05.2010 um 22:45 schrieb Richard Henderson: From: Alexander Graf --- tcg/s390/tcg-target.c |3 ++ tcg/s390/tcg-target.h | 86 +++-- 2 files changed, 86 insertions(+), 3 deletions(-) This one's missing an SoB, and fwiw I think it should

[Qemu-devel] [PATCH 13/14] qcow2: Fix corruption after error in update_refcount

2010-05-28 Thread Kevin Wolf
After it is done with updating refcounts in the cache, update_refcount writes all changed entries to disk. If a refcount block allocation fails, however, there was no change yet and therefore first_index = last_index = -1. Don't treat -1 as a normal sector index (resulting in a 512 byte write!) but

[Qemu-devel] [PATCH 04/14] qemu-io: Add multiwrite command

2010-05-28 Thread Kevin Wolf
The new multiwrite commands allows to use qemu-io for testing bdrv_aio_multiwrite. Signed-off-by: Kevin Wolf --- qemu-io.c | 192 + 1 files changed, 192 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index f39109e..7

[Qemu-devel] [PATCH 12/14] qcow2: Fix corruption after refblock allocation

2010-05-28 Thread Kevin Wolf
Refblock allocation code needs to take into consideration that update_refcount will load a different refcount block into the cache, so it must initialize the cache for a new refcount block only afterwards. Not doing this means that not only the refcount in the wrong block is updated, but also that

[Qemu-devel] [PATCH 08/14] block.h: Make BDRV_SECTOR_SIZE 64 bit safe

2010-05-28 Thread Kevin Wolf
From: Jes Sorensen C defaults to int, so make definition of BDRV_SECTOR_SIZE 64 bit safe as it and BDRV_SECTOR_MASK may be used against 64 bit addresses. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- block.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[Qemu-devel] [PATCH 03/14] block: Fix multiwrite with overlapping requests

2010-05-28 Thread Kevin Wolf
With overlapping requests, the total number of sectors is smaller than the sum of the nb_sectors of both requests. Signed-off-by: Kevin Wolf --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index cd70730..47be5ba 100644 --- a/block.c +++ b/b

[Qemu-devel] [PATCH 14/14] block: Add missing bdrv_delete() for SG_IO BlockDriver in find_image_format()

2010-05-28 Thread Kevin Wolf
From: Nicholas A. Bellinger This patch adds a missing bdrv_delete() call in find_image_format() so that a SG_IO BlockDriver properly releases the temporary BlockDriverState *bs created from bdrv_file_open() Signed-off-by: Nicholas A. Bellinger Reported-by: Chris Krumme Signed-off-by: Kevin Wol

[Qemu-devel] [PATCH 10/14] qcow2: Change l2_load to return 0/-errno

2010-05-28 Thread Kevin Wolf
Provide the error code to the caller instead of just indicating success/error. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 38 ++ 1 files changed, 22 insertions(+), 16 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index e

[Qemu-devel] [PATCH 05/14] add support for protocol driver create_options

2010-05-28 Thread Kevin Wolf
From: MORITA Kazutaka This patch enables protocol drivers to use their create options which are not supported by the format. For example, protcol drivers can use a backing_file option with raw format. Signed-off-by: MORITA Kazutaka Signed-off-by: Kevin Wolf --- block.c |7 +++

[Qemu-devel] [PATCH 02/14] qcow2: Fix error handling in l2_allocate

2010-05-28 Thread Kevin Wolf
l2_allocate has some intermediate states in which the image is inconsistent. Change the order to write to the L1 table only after the new L2 table has successfully been initialized. Also reset the L2 cache in failure case, it's very likely wrong. Signed-off-by: Kevin Wolf --- block/qcow2-cluste

[Qemu-devel] [PATCH 09/14] qcow2: Allow qcow2_get_cluster_offset to return errors

2010-05-28 Thread Kevin Wolf
qcow2_get_cluster_offset() looks up a given virtual disk offset and returns the offset of the corresponding cluster in the image file. Errors (e.g. L2 table can't be read) are currenctly indicated by a return value of 0, which is unfortuately the same as for any unallocated cluster. So in effect we

[Qemu-devel] [PATCH 06/14] drive: allow rerror, werror and readonly for if=none

2010-05-28 Thread Kevin Wolf
From: Gerd Hoffmann When creating guest disks the qdev way using ... -drive if=none,id=$name,args -device $driver,drive=$name it is not possible to specify rerror, werror and readonly arguments for drive as drive_init allows/blocks them based on the interface (if=) specified and none isn't

[Qemu-devel] [PULL 00/14] Block patches

2010-05-28 Thread Kevin Wolf
Hi Anthony, this includes again some patches that should be applied to stable-0.12, too: 86fa8da qcow2: Fix corruption after error in update_refcount 25408c0 qcow2: Fix corruption after refblock allocation cbf1dff block: Fix multiwrite with overlapping requests 175e115 qcow2: Fix

[Qemu-devel] [PATCH 01/14] qcow2: Clear L2 table cache after write error

2010-05-28 Thread Kevin Wolf
If the L2 table was already updated in cache, but writing it to disk has failed, we must not continue using the changed version in the cache to stay consistent with what's on the disk. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

  1   2   >