[Qemu-devel] [PATCH 2/3] vnc: tight: don't forget the third color

2010-05-26 Thread Corentin Chary
While couting color, if the third color was only present one time it wasn't added to the palette. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vnc-encoding-tight.c b/vnc-encoding-tight.c index c8effe6..efb57e7 100

[Qemu-devel] [PATCH 3/3] vnc: add missing target for vnc-encodings-*.o

2010-05-26 Thread Corentin Chary
vnc-encodings-*.c dependencies where missing. Signed-off-by: Corentin Chary --- Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 8e1f9d6..b264e38 100644 --- a/Makefile +++ b/Makefile @@ -120,11 +120,11 @@ vnc-auth-vencrypt.o: vnc-au

[Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-05-26 Thread Corentin Chary
A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i < count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |9 - 1 files changed, 4 insertions(+), 5 delet

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Gleb Natapov
On Wed, May 26, 2010 at 08:14:38PM +, Blue Swirl wrote: > On Wed, May 26, 2010 at 8:08 AM, Gleb Natapov wrote: > > On Tue, May 25, 2010 at 11:44:50PM +0200, Jan Kiszka wrote: > >> > > >> >> I think the real solution to coalescing is put the logic inside one > >> >> device, in this case APIC be

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Gleb Natapov
On Wed, May 26, 2010 at 08:35:00PM +, Blue Swirl wrote: > On Wed, May 26, 2010 at 8:09 PM, Jan Kiszka wrote: > > Blue Swirl wrote: > >> On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote: > >>> Anthony Liguori wrote: > On 05/25/2010 02:09 PM, Blue Swirl wrote: > > On Mon, May 24, 2010

[Qemu-devel] [PATCH] pci.h: remove unused constants.

2010-05-26 Thread Isaku Yamahata
So remove unused constants, PCI_STATUS_RESERVED_MASK_LO, PCI_STATUS_RESERVED_MASK_HI, PCI_COMMAND_RESERVED, PCI_COMMAND_RESERVED_MASK_HI. They were used once, but they aren't used anymore. Signed-off-by: Isaku Yamahata --- hw/pci.h | 11 --- 1 files changed, 0 insertions(+), 11 deletio

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Gleb Natapov
On Wed, May 26, 2010 at 10:09:52PM +0200, Jan Kiszka wrote: > Blue Swirl wrote: > > On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote: > >> Anthony Liguori wrote: > >>> On 05/25/2010 02:09 PM, Blue Swirl wrote: > On Mon, May 24, 2010 at 8:13 PM, Jan Kiszka wrote: > > > From: Jan Kis

[Qemu-devel] [PATCH] multiboot: compilation fix with DEBUG_MULTIBOOT enabled.

2010-05-26 Thread Isaku Yamahata
This patch fixes the following compilation errors in multiboot.c when DEBUG_MULTIBOOT is defined. Use TARGET_FMT_plx instead of %x for target_phys_addr_t. CCi386-softmmu/multiboot.o cc1: warnings being treated as errors qemu/hw/multiboot.c: In function 'mb_add_mod': qemu/hw/multiboot.c:121:

Re: [Qemu-devel] [PATCH] move net_handle_fd_param() into a common utility function

2010-05-26 Thread Markus Armbruster
Alex Williamson writes: > Move to monitor.c:monitor_handle_fd_param() as a common helper. > > Signed-off-by: Alex Williamson > --- > > I'd like to use this for the proposed device assignment configfd > parameter since there's nothing net specific about it. Looks good. Error checking after strt

[Qemu-devel] [PATCH] vga-isa-mm: remove one #ifdef CONFIG_BOCHS_VBE.

2010-05-26 Thread Isaku Yamahata
remove one #ifdef CONFIG_BOCHS_VBE. Call vga_init_vbe() instead. Signed-off-by: Isaku Yamahata --- hw/vga-isa-mm.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/vga-isa-mm.c b/hw/vga-isa-mm.c index 2faefa5..8e31e36 100644 --- a/hw/vga-isa-mm.c +++ b/hw/vga-isa-

[Qemu-devel] [PATCH] qbus: fix memory leak in qbus_free()

2010-05-26 Thread Isaku Yamahata
BusState::name is allocated in qbus_create_inplace(). So it should be freed by qbus_free(). Signed-off-by: Isaku Yamahata --- hw/qdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index af17486..2845af5 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@

[Qemu-devel] [PATCH] main: allocate gui_timer only once.

2010-05-26 Thread Isaku Yamahata
fix memory leak. there is no need to allocate more than one gui_timer. Signed-off-by: Isaku Yamahata --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 417554f..22cdf43 100644 --- a/vl.c +++ b/vl.c @@ -3794,6 +3794,7 @@ int main(int argc, char **a

[Qemu-devel] [PATCH] pci: add const to pci_is_express(), pci_config_size().

2010-05-26 Thread Isaku Yamahata
add const to pci_is_express(), pci_config_size(). Signed-off-by: Isaku Yamahata --- hw/pci.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 6eee93a..b803593 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -339,12 +339,12 @@ void pci_qdev_register_ma

Re: [Qemu-devel] Re: [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Markus Armbruster
Anthony Liguori writes: > On 05/26/2010 10:51 AM, Alexander Graf wrote: >> Usually the guest can tell the host to flush data to disk. In some cases we >> don't want to flush though, but try to keep everything in cache. >> >> So let's add a new cache value to -drive that allows us to set the cache

[Qemu-devel] [PATCH] msix: remove duplicated defines.

2010-05-26 Thread Isaku Yamahata
remove defines which are already defined in pci_regs.h Signed-off-by: Isaku Yamahata --- hw/msix.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 2ca0900..1613bb4 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -15,14 +15,6 @@ #include "msi

[Qemu-devel] [PATCH] pci: fix pci_default_read_config().

2010-05-26 Thread Isaku Yamahata
address and config_size are both unsigned. So check which is bigger before minus operation. Otherwise the result of minus can be unexpected big value. Signed-off-by: Isaku Yamahata --- hw/pci.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c i

[Qemu-devel] [PATCH] pci-hotplug: make them aware of pci domain.

2010-05-26 Thread Isaku Yamahata
add helper function which converts root bus to pci domain. make functions which ignored domain aware of pci domain. Signed-off-by: Isaku Yamahata --- hw/pci-hotplug.c |7 --- hw/pci.c | 24 +++- hw/pci.h |2 ++ 3 files changed, 29 insertions(+),

[Qemu-devel] [PATCH] pci: clean up of pci_set_default_subsystem_id().

2010-05-26 Thread Isaku Yamahata
Use pci accessor function. don't return value because it always return 0 and the caller doesn't check the return value. Signed-off-by: Isaku Yamahata --- hw/pci.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 8d84651..3362842 100644

[Qemu-devel] Re: [PATCH-V4 0/7] virtio-9p:Introducing security model for VirtFS

2010-05-26 Thread Andy Lutomirski
Venkateswararao Jujjuri (JV) wrote: This patch series introduces the security model for VirtFS. Brief description of this patch series: It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS deter

[Qemu-devel] [Bug 586175] [NEW] Windows XP/2003 doesn't boot

2010-05-26 Thread tekditt
Public bug reported: Hello everyone, my qemu doesn't boot any Windows XP/2003 installations if I try to boot the image. If I boot the install cd first, it's boot manager counts down and triggers the boot on it's own. That's kinda stupid. I'm using libvirt, but even by a simple > qemu-kvm -driv

[Qemu-devel] [PATCH -V4 2/7] virtio-9p: Rearrange fileop structures

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p.c | 185 ++-- hw/virtio-9p.h | 92 2 files changed, 138 insertions(+), 139 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index a57562a..6feaa53

[Qemu-devel] [PATCH -V4 1/7] virtio-9p: Introduces an option to specify the security model.

2010-05-26 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev fstype,id=myid,path=/share_path/,security_model=[mapped|passthrough] -virtfs fstype,path=/share_path/,security_model=[mapped|passthrough],mnt_tag=tag In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Paul Brook
> At the other extreme, would it be possible to make the educated guests > aware of the virtualization also in clock aspect: virtio-clock? The guest doesn't even need to be aware of virtualization. It just needs to be able to accommodate the lack of guaranteed realtime behavior. The fundamental

[Qemu-devel] [PATCH -V4 6/7] virtio-9p: Implemented Security model for lstat and fstat

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/virtio-9p-local.c | 62 ++--- 1 files changed, 58 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 395a33f..11f3650 100644 --- a/hw/virtio-9p-local.c +++ b/hw/v

[Qemu-devel] [PATCH -V4 5/7] virtio-9p: Implemented security model for symlink and link.

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 +- hw/virtio-9p-local.c | 98 - hw/virtio-9p.c | 24 + 3 files changed, 99 insertions(+), 27 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h i

[Qemu-devel] [PATCH -V4 4/7] virtio-9p: Implement Security model for mknod related files

2010-05-26 Thread Venkateswararao Jujjuri (JV)
In the mapped security model all the special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. These extended attributes are used to present this file as special file to the client. Signed-off-by: Venkateswararao Jujjuri --- hw/f

[Qemu-devel] [PATCH -V4 7/7] virtio-9p: Implemented security model for chown and chgrp.

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h |4 ++-- hw/virtio-9p-local.c | 18 ++ hw/virtio-9p.c | 15 --- 3 files changed, 28 insertions(+), 9 deletions(-) diff --git a/hw/file-op-9p.h b/hw/file-op-9p.h index c1c08b4..877faf2 100644

[Qemu-devel] [PATCH-V4 0/7] virtio-9p:Introducing security model for VirtFS

2010-05-26 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series: It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control. L

[Qemu-devel] [PATCH -V4 3/7] virtio-9p: modify create/open2 and mkdir for new security model.

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri --- hw/file-op-9p.h | 23 +++- hw/virtio-9p-local.c | 149 -- hw/virtio-9p.c | 42 ++ 3

[Qemu-devel] Re: [PATCH] Make cache=unsafe the default for -snapshot

2010-05-26 Thread Aurelien Jarno
On Wed, May 26, 2010 at 09:04:32PM +0200, Alexander Graf wrote: > When using -snapshot we don't care about data integrity of the cow file > at all, so let's disable flushing there and squeeze out the last drop > of performance we could possibly get. > > Signed-off-by: Alexander Graf Thanks, appl

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Jan Kiszka
Blue Swirl wrote: >> I think the real solution to coalescing is put the logic inside one >> device, in this case APIC because it has the information about irq >> delivery. APIC could monitor incoming RTC irqs for frequency >> information and whether they get delivered or not. If not

[Qemu-devel] [PATCH] move net_handle_fd_param() into a common utility function

2010-05-26 Thread Alex Williamson
Move to monitor.c:monitor_handle_fd_param() as a common helper. Signed-off-by: Alex Williamson --- I'd like to use this for the proposed device assignment configfd parameter since there's nothing net specific about it. monitor.c| 17 + monitor.h|1 + net.c

[Qemu-devel] [PATCHv2-RFC 2/2] virtio: publish used idx

2010-05-26 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c |2 ++ drivers/virtio/virtio_ring.c | 17 +++-- include/linux/virtio_ring.h |4 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread Johannes Stezenbach
On Wed, May 26, 2010 at 08:00:33AM -0600, David S. Ahern wrote: > On 05/26/2010 07:23 AM, Kevin Wolf wrote: > > Am 26.05.2010 15:06, schrieb David S. Ahern: > >> > >> My understanding is that the port routing happens internally to the host > >> controller based on device speed - section 4.2 (pag 64

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: make virtio-9p available to all POSIX systems

2010-05-26 Thread Blue Swirl
On Wed, May 26, 2010 at 6:02 PM, Venkateswararao Jujjuri (JV) wrote: > Blue Swirl wrote: >> On Mon, May 24, 2010 at 8:46 PM, Venkateswararao Jujjuri (JV) >> wrote: >>> Blue Swirl wrote: Field d_off in struct dirent is Linux specific. Signed-off-by: Blue Swirl ---  Makefi

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Blue Swirl
On Wed, May 26, 2010 at 8:09 PM, Jan Kiszka wrote: > Blue Swirl wrote: >> On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote: >>> Anthony Liguori wrote: On 05/25/2010 02:09 PM, Blue Swirl wrote: > On Mon, May 24, 2010 at 8:13 PM, Jan Kiszka  wrote: > >> From: Jan Kiszka >> >>>

Re: [Qemu-devel] [PATCH -V3 2/7] virtio-9p: Rearrange fileop structures

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Sripathi Kodi wrote: > On Fri, 21 May 2010 14:26:05 -0700 > "Venkateswararao Jujjuri (JV)" wrote: > > Hi JV, > > While I agree that this patch is nice to have, why is this part of the > security model patchset? Is it required to implement the models? Initially I had a grand plan of making this

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Blue Swirl
On Wed, May 26, 2010 at 8:08 AM, Gleb Natapov wrote: > On Tue, May 25, 2010 at 11:44:50PM +0200, Jan Kiszka wrote: >> > >> >> I think the real solution to coalescing is put the logic inside one >> >> device, in this case APIC because it has the information about irq >> >> delivery. APIC could moni

[Qemu-devel] [PATCHv2-RFC 1/2] virtio: support layout with avail ring before idx

2010-05-26 Thread Michael S. Tsirkin
This adds an (unused) option to put available ring before control (avail index, flags). This avoids cache line sharing between control and ring, and also makes it possible to extend avail control without incurring extra cache misses. Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_ri

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Jan Kiszka
Blue Swirl wrote: > On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote: >> Anthony Liguori wrote: >>> On 05/25/2010 02:09 PM, Blue Swirl wrote: On Mon, May 24, 2010 at 8:13 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This allows to communicate potential IRQ coalescing during

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Blue Swirl
On Tue, May 25, 2010 at 8:16 PM, Anthony Liguori wrote: > On 05/25/2010 02:09 PM, Blue Swirl wrote: >> >> On Mon, May 24, 2010 at 8:13 PM, Jan Kiszka  wrote: >> >>> >>> From: Jan Kiszka >>> >>> This allows to communicate potential IRQ coalescing during delivery from >>> the sink back to the source

[Qemu-devel] [PATCHv2-RFC 0/2] virtio: put last seen used index into ring itself

2010-05-26 Thread Michael S. Tsirkin
Here's a rewrite of the original patch with a new layout. I haven't tested it yet so no idea how this performs, but I think this addresses the cache bounce issue raised by Avi. Posting for early flames/comments. Generally, the Host end of the virtio ring doesn't need to see where Guest is up to in

Re: [Qemu-devel] Re: hw/serial.c: Xmit fifo never used

2010-05-26 Thread Frank Mehnert
On Wednesday 26 May 2010, Stefano Stabellini wrote: > I think the patch is correct. serial: fixed bug which prevented the use of the xmit fifo Signed-off-by: Frank Mehnert --- hw/serial.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/serial.c b/hw/serial.c index 9

[Qemu-devel] Re: [PATCH 6/8] enable event_notifier to use pipes

2010-05-26 Thread Paolo Bonzini
On 05/26/2010 08:19 PM, Richard Henderson wrote: On 05/26/2010 07:09 AM, Paolo Bonzini wrote: -#ifdef CONFIG_EVENTFD -#include -#endif Is there a reason not to use eventfd if it is available? qemu_eventfd chooses between eventfd or pipes. The reads and writes are done so that both cases ar

Re: [Qemu-devel] Re: [RFT][PATCH 07/15] qemu_irq: Add IRQ handlers with delivery feedback

2010-05-26 Thread Blue Swirl
On Tue, May 25, 2010 at 9:44 PM, Jan Kiszka wrote: > Anthony Liguori wrote: >> On 05/25/2010 02:09 PM, Blue Swirl wrote: >>> On Mon, May 24, 2010 at 8:13 PM, Jan Kiszka  wrote: >>> From: Jan Kiszka This allows to communicate potential IRQ coalescing during delivery from the sin

Re: [Qemu-devel] [PATCH] Default to cache=writeback

2010-05-26 Thread Stefan Hajnoczi
On Wed, May 26, 2010 at 7:13 PM, Alexander Graf wrote: > In the previous discussion Anthony brought up the fact that cache=writeback is > safe enough considering data integrity. If so, I don't see a reason not to use > it as default, as it speeds up things a lot. cache=writeback is not a good def

Re: [Qemu-devel] [PATCH, RFC 3/4] Implement byte swapped MMIO type

2010-05-26 Thread Blue Swirl
On Tue, May 25, 2010 at 7:45 PM, Igor Kovalenko wrote: > On Mon, May 24, 2010 at 12:34 AM, Blue Swirl wrote: >> BROKEN >> >> Signed-off-by: Blue Swirl >> --- >>  cpu-common.h       |    3 +- >>  softmmu_template.h |   69 >> ++-- >>  2 files change

Re: [Qemu-devel] [PATCH 0/2] sparc64: cleanups

2010-05-26 Thread Blue Swirl
Thanks, applied both. On Tue, May 25, 2010 at 12:08 PM, Igor V. Kovalenko wrote: > - rename sun4u cpu to Ultrasparc IIi > - cleanup pci bridge map (requires openbios change) > > v0->v1: split out rename of sun4u cpu to separate patch > > --- > > Igor V. Kovalenko (2): >      sparc64: rename sun4u

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-26 Thread Artyom Tarasenko
2010/5/25 Blue Swirl : > On Tue, May 25, 2010 at 5:00 PM, Artyom Tarasenko > wrote: >> 2010/5/21 Blue Swirl : >>> On Fri, May 21, 2010 at 5:23 PM, Artyom Tarasenko >>> wrote: 2010/5/10 Blue Swirl : > On 5/10/10, Artyom Tarasenko wrote: >> 2010/5/10 Blue Swirl : >> >> > On 5/

[Qemu-devel] [PATCH] Make cache=unsafe the default for -snapshot

2010-05-26 Thread Alexander Graf
When using -snapshot we don't care about data integrity of the cow file at all, so let's disable flushing there and squeeze out the last drop of performance we could possibly get. Signed-off-by: Alexander Graf --- qemu-options.hx |6 +++--- vl.c|4 ++-- 2 files changed, 5 ins

Re: [Qemu-devel] [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Aurelien Jarno
On Wed, May 26, 2010 at 05:51:49PM +0200, Alexander Graf wrote: > Usually the guest can tell the host to flush data to disk. In some cases we > don't want to flush though, but try to keep everything in cache. > > So let's add a new cache value to -drive that allows us to set the cache > policy to

Re: [Qemu-devel] [PATCH 6/8] enable event_notifier to use pipes

2010-05-26 Thread Richard Henderson
On 05/26/2010 07:09 AM, Paolo Bonzini wrote: > -#ifdef CONFIG_EVENTFD > -#include > -#endif Is there a reason not to use eventfd if it is available? r~

[Qemu-devel] [PATCH] Default to cache=writeback

2010-05-26 Thread Alexander Graf
In the previous discussion Anthony brought up the fact that cache=writeback is safe enough considering data integrity. If so, I don't see a reason not to use it as default, as it speeds up things a lot. Keep in mind that most people will want to use cache=none anyways if they want to bypass the ho

Re: [Qemu-devel] [PATCH 00/14] configure --xyzdir options cleanup

2010-05-26 Thread Richard Henderson
On 05/26/2010 07:08 AM, Paolo Bonzini wrote: > This series cleans up the handling of --xyzdir options and > improves the customizability of the directory layout. > > Patches 1/2/3/14 are somewhat unrelated to the main purpose > of the patch, but they conflict with other patches in the > series so

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: make virtio-9p available to all POSIX systems

2010-05-26 Thread Venkateswararao Jujjuri (JV)
Blue Swirl wrote: > On Mon, May 24, 2010 at 8:46 PM, Venkateswararao Jujjuri (JV) > wrote: >> Blue Swirl wrote: >>> Field d_off in struct dirent is Linux specific. >>> >>> Signed-off-by: Blue Swirl >>> --- >>> Makefile.objs |8 >>> Makefile.target |2 +- >>> hw/virtio-9p.c |

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Anthony Liguori
On 05/26/2010 10:15 AM, Daniel P. Berrange wrote: On Wed, May 26, 2010 at 09:54:22AM -0500, Anthony Liguori wrote: On 05/26/2010 05:33 AM, Daniel P. Berrange wrote: I'm not sure why you would need a notification of when migration starts (since you know when you've started migration).

[Qemu-devel] Re: [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Alexander Graf
On 26.05.2010, at 18:17, Anthony Liguori wrote: > On 05/26/2010 10:51 AM, Alexander Graf wrote: >> Usually the guest can tell the host to flush data to disk. In some cases we >> don't want to flush though, but try to keep everything in cache. >> >> So let's add a new cache value to -drive that a

[Qemu-devel] Re: [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 10:51 AM, Alexander Graf wrote: Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 10:40 AM, Aurelien Jarno wrote: I highly doubt that this is even visible on benchmarks without using KVM. The improvement on a microbenchmark was relatively small and the cost from TCG would almost certainly dwarf it. It is something clearly visible. Before fsync() was not u

[Qemu-devel] [PATCH] Add cache=unsafe parameter to -drive

2010-05-26 Thread Alexander Graf
Usually the guest can tell the host to flush data to disk. In some cases we don't want to flush though, but try to keep everything in cache. So let's add a new cache value to -drive that allows us to set the cache policy to most aggressive, disabling flushes. We call this mode "unsafe", as guest d

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 05/26/2010 09:12 AM, Aurelien Jarno wrote: >>> It's hard for me to consider this a performance regression because >>> ultimately, you're getting greater than bare metal performance (because >>> of extremely aggressive caching). It might be a regression from the >>> p

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Daniel P. Berrange
On Wed, May 26, 2010 at 09:54:22AM -0500, Anthony Liguori wrote: > On 05/26/2010 05:33 AM, Daniel P. Berrange wrote: > >>>I'm not sure why you would need a notification of when migration > >>>starts (since you know when you've started migration). > >>> > >>But you don't know if the other end

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Kevin Wolf a écrit : > Am 26.05.2010 15:42, schrieb Anthony Liguori: >> On 05/26/2010 03:43 AM, Kevin Wolf wrote: >>> Am 26.05.2010 03:31, schrieb Anthony Liguori: >>> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: > I really think this patch can be useful, in my own case whe

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Aurelien Jarno
Anthony Liguori a écrit : > On 05/26/2010 03:52 AM, Aurelien Jarno wrote: >> On Tue, May 25, 2010 at 08:31:20PM -0500, Anthony Liguori wrote: >> >>> On 05/25/2010 04:01 PM, Aurelien Jarno wrote: >>> I really think this patch can be useful, in my own case when testing debian-inst

[Qemu-devel] [PATCH 14/14] move computation of tools and roms outside of config-host.mak generation

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 40 +--- 1 files changed, 21 insertions(+), 19 deletions(-) diff --git a/configure b/configure index 488ef07..d9983b0 100755 --- a/configure +++ b/configure @@ -1991,6 +1991,27 @@ fi confdir=$sysconfdir$confsuf

[Qemu-devel] [PATCH 04/14] delete duplicate create_config case stanza

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- create_config |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/create_config b/create_config index 2f052ae..edcad25 100755 --- a/create_config +++ b/create_config @@ -13,11 +13,6 @@ case $line in pkgversion=${line#*=} echo "#d

[Qemu-devel] [PATCH 03/14] dyngen is long time gone

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5a7cb6e..f96 100755 --- a/configure +++ b/configure @@ -748,7 +748,8 @@ echo "Advanced options (experts only):" echo " --source-path=PATH p

[Qemu-devel] [PATCH 2/8] add event_notifier_set

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event_notifier.h |1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 2c73555..3f50568 100644 --- a/event_notifier.c +++ b/event_notifier.c @@ -38,6 +38,13 @@ int event_

[Qemu-devel] [PATCH 01/14] bail out early on invalid -cpu option

2010-05-26 Thread Paolo Bonzini
It would fail later anyway. Signed-off-by: Paolo Bonzini --- configure |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 3cd2c5f..e8dd2ef 100755 --- a/configure +++ b/configure @@ -232,7 +232,8 @@ case "$cpu" in cpu="sparc" ;; *

[Qemu-devel] [PATCH 8/8] change ioevent to use event notifiers

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpus.c | 95 +--- 1 files changed, 9 insertions(+), 86 deletions(-) diff --git a/cpus.c b/cpus.c index 8341f6c..7a1dd06 100644 --- a/cpus.c +++ b/cpus.c @@ -26,6 +26,7 @@ #include "config-host.h" #

[Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Paolo Bonzini
On 05/26/2010 03:48 PM, Anthony Liguori wrote: We might get 100 bug reports about this "regression" but they concern much less than 1 bug report of image corruption because of power failure/host crash. A reputation of being unsafe is very difficult to get rid of and is something that I hear conce

[Qemu-devel] [PATCH 0/8] Make event_notifier more useful and more used

2010-05-26 Thread Paolo Bonzini
Hi, this patch adds all the eventfd bells and whistles from vl.c/cpus.c to event_notifier, including pipe emulation and Win32 support. It then modifies the iothread code to use it instead. Paolo Bonzini (8): move event_notifier into the main directory add event_notifier_set remove event_not

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Avi Kivity
On 05/26/2010 04:50 PM, Anthony Liguori wrote: In fact, btrfs is currently unusable for virt because O_SYNC writes inflate a guest write to a host write. by a huge factor (50x-100x). cache=writethrough is 100% unusable, cache=writeback is barely tolerable. As of 2.6.32, cache=volatile is prob

[Qemu-devel] [PATCH 09/14] move all directory entries in config-host.mak close

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/configure b/configure index fee9665..9736942 100755 --- a/configure +++ b/configure @@ -2067,6 +2067,12 @@ printf "# Configured with:" >> $config_host_mak printf " '%s'

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Anthony Liguori
If someone reproduces the bug against upstream qemu, feel free to refile the bug with the appropriate information. -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [PATCH 4/8] add and use virtqueue_from_guest_notifier

2010-05-26 Thread Paolo Bonzini
This changes the opaque pointer passed to the handler, from being the virtqueue to being the eventnotifier. It is useful as soon as the eventnotifier will be able to set its own (type-safe) handler. Signed-off-by: Paolo Bonzini --- I don't have a vhost-enabled machine yet. So only compi

[Qemu-devel] Re: [PATCH 3/5] QMP: Introduce MIGRATION events

2010-05-26 Thread Anthony Liguori
On 05/26/2010 05:33 AM, Daniel P. Berrange wrote: I'm not sure why you would need a notification of when migration starts (since you know when you've started migration). But you don't know if the other end "knows" that it has also started. started is needed only in incoming part, becaus

[Qemu-devel] [PATCH 5/8] add and use event_notifier_set_handler

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event_notifier.h |3 +++ hw/virtio-pci.c |9 +++-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 0f7b8da..066adb9 100644 --- a/event_notifier.c +++ b/event_no

[Qemu-devel] [PATCH 08/14] unify handling of xyzdir variables

2010-05-26 Thread Paolo Bonzini
Making an xyzdir variable for each directory prepares for the next patches introducing config-host.h defines and configure options for them. It also fixes the problem where overriding prefix at "make install" time did not override it for sysconfdir. Removes some of the differences between sysconfd

[Qemu-devel] [PATCH 12/14] ignore unknown --xyzdir options

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 2e59f9b..b036c40 100755 --- a/configure +++ b/configure @@ -673,6 +673,8 @@ for opt do ;; --enable-vhost-net) vhost_net="yes" ;; + --*dir) +

[Qemu-devel] [PATCH 3/8] remove event_notifier_test

2010-05-26 Thread Paolo Bonzini
This is broken; since the eventfd is used in nonblocking mode there is a race between reading and writing. Signed-off-by: Paolo Bonzini --- event_notifier.c | 15 --- event_notifier.h |1 - 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/event_notifier.c b/event

[Qemu-devel] [PATCH 10/14] expand ${prefix} in create_config

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure |3 +-- create_config |9 + vl.c |2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 9736942..4dc75c2 100755 --- a/configure +++ b/configure @@ -2073,8 +2073,7 @@ echo "mandi

[Qemu-devel] [PATCH 02/14] avoid using expr in configure

2010-05-26 Thread Paolo Bonzini
Just a personal preference against duplicating hieroglyphics. Signed-off-by: Paolo Bonzini --- configure | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8dd2ef..5a7cb6e 100755 --- a/configure +++ b/configure @@ -928,6 +928,13 @@ if

[Qemu-devel] [PATCH 1/8] move event_notifier into the main directory

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-) rename hw/event_notifier.c => event_notifier.c (98%) rename hw/event_notifier.h => event_notifier.h (100%) diff --

[Qemu-devel] [PATCH 06/14] introduce confdir and confsuffix

2010-05-26 Thread Paolo Bonzini
confsuffix was write-only, flesh it out. Signed-off-by: Paolo Bonzini --- configure | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index cf19ebf..435e765 100755 --- a/configure +++ b/configure @@ -1969,10 +1969,10 @@ if test "$mingw32" = "

[Qemu-devel] [PATCH 05/14] introduce sysconfsuffix

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/configure b/configure index f96..cf19ebf 100755 --- a/configure +++ b/configure @@ -1972,9 +1972,7 @@ if test "$mingw32" = "yes" ; then confsuffix="" docsuffix=""

[Qemu-devel] [PATCH 7/8] add Win32 implementation of event notifiers

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Compile-tested only. iothread is broken anyway on Win32 due to missing implementation of qemu-threads. event_notifier.c | 33 + event_notifier.h |8 2 files changed, 41 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 6/8] enable event_notifier to use pipes

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c | 69 +++--- event_notifier.h |3 +- 2 files changed, 52 insertions(+), 20 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index 066adb9..a33f3c5 100644 --- a/event_notifier.c ++

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Kevin Wolf
Am 26.05.2010 16:08, schrieb Anthony Liguori: > On 05/26/2010 09:03 AM, Kevin Wolf wrote: >> Am 26.05.2010 15:42, schrieb Anthony Liguori: >> >>> On 05/26/2010 03:43 AM, Kevin Wolf wrote: >>> Am 26.05.2010 03:31, schrieb Anthony Liguori: > On 05/25/2010 04:01 PM

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
and just for reference so there isnt coming up any confusion again, the used qemu call that breaks is for a versatilbepb machine using the versatile kernel from http://ports.ubuntu.com/ubuntu- ports/dists/lucid/main/installer- armel/current/images/versatile/netboot/vmlinuz -- apt/dpkg in qemu-sys

[Qemu-devel] [PATCH 00/14] configure --xyzdir options cleanup

2010-05-26 Thread Paolo Bonzini
This series cleans up the handling of --xyzdir options and improves the customizability of the directory layout. Patches 1/2/3/14 are somewhat unrelated to the main purpose of the patch, but they conflict with other patches in the series so I sent them together. Paolo Bonzini (14): bail out ear

[Qemu-devel] [PATCH 13/14] move directory defaults earlier

2010-05-26 Thread Paolo Bonzini
Unify with existing special-purpose configure code for win32. Signed-off-by: Paolo Bonzini --- configure | 47 ++- 1 files changed, 14 insertions(+), 33 deletions(-) diff --git a/configure b/configure index b036c40..488ef07 100755 --- a/configure ++

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 09:03 AM, Kevin Wolf wrote: Am 26.05.2010 15:42, schrieb Anthony Liguori: On 05/26/2010 03:43 AM, Kevin Wolf wrote: Am 26.05.2010 03:31, schrieb Anthony Liguori: On 05/25/2010 04:01 PM, Aurelien Jarno wrote: I really think this patch can be useful,

[Qemu-devel] [PATCH 07/14] rename CONFIG_QEMU_PREFIX

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- bsd-user/main.c |2 +- configure |2 +- linux-user/main.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bsd-user/main.c b/bsd-user/main.c index 05cc3d9..aff9f13 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -43

[Qemu-devel] Re: migrating guest with msi-x interrupts

2010-05-26 Thread Michael S. Tsirkin
On Tue, May 25, 2010 at 04:09:13PM -0600, Cam Macdonell wrote: > Hi, > > I'm trying to migrate a guest device with MSI-X interrupts. However, > the interrupts are not injected into the guest. I've added some > tracing to msix.c and it seems that the MSI-X vectors are masked when > the guest is r

[Qemu-devel] [PATCH 11/14] introduce more --xyzdir options

2010-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 4dc75c2..2e59f9b 100755 --- a/configure +++ b/configure @@ -68,6 +68,10 @@ cpu="" prefix="" interp_prefix="/usr/gnemul/qemu-%

Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive

2010-05-26 Thread Anthony Liguori
On 05/26/2010 09:12 AM, Aurelien Jarno wrote: It's hard for me to consider this a performance regression because ultimately, you're getting greater than bare metal performance (because of extremely aggressive caching). It might be a regression from the previous performance, but that was at the c

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
@Anthony please see all the above comments before judging and please reopen it upstream again -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [Bug 532733] Re: apt/dpkg in qemu-system-arm hangs if a big task is installed

2010-05-26 Thread Oliver Grawert
@Anthony, this bug has nothing to do with beagleboards it happens if qemu is run on x86 systems -- apt/dpkg in qemu-system-arm hangs if a big task is installed https://bugs.launchpad.net/bugs/532733 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] RFC: ehci -> uhci handoff suggestions

2010-05-26 Thread David S. Ahern
On 05/26/2010 07:23 AM, Kevin Wolf wrote: > Am 26.05.2010 15:06, schrieb David S. Ahern: >> >> >> On 05/26/2010 06:48 AM, Gerd Hoffmann wrote: >>> >>> Hi, >>> > USB devices can support both 1.1 and 2.0, right? Who decides which > protocol is used then? I think the OS can speak 1.1 to

  1   2   >