Re: [Qemu-devel] Problem with QEMU on KVM

2010-04-23 Thread Gerhard Wiesinger
On Fri, 23 Apr 2010, Gerhard Wiesinger wrote: On Thu, 22 Apr 2010, Gerd Hoffmann wrote: Hi, Had also a look at ps2.c/ps2.h, pckbd.c: There were no changes which could explain such a behaviour. Also keyboard is very strange which switches to CAPS LOCK (shift state) very unmotivated. Hmm.

Re: [Qemu-devel] Atomicity of i386 guest atomic instructions

2010-04-23 Thread Jamie Lokier
Alexander Graf wrote: > They should be atomic. TCG SMP swaps between different vCPUs only > after translation blocks are done. In fact, the only way I'm aware > of to stop the execution of a TB mid-way is a page fault. A page fault would interrupt it if the atomic is implemented as a read followed

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Jamie Lokier
Ian Molton wrote: > Jamie Lokier wrote: > > First of all: Why are your egd daemons with open connections dying > > anyway? Buggy egd? > > No, they aren't buggy. but occasionally, the sysadmin of said server > farms may want to, you know, update the daemon? Many daemons don't kill active connecti

[Qemu-devel] VNC crash (double-free, maybe)

2010-04-23 Thread Andrew Lutomirski
Hi all- Running Windows 7 in KVM with -vga std, I often get VNC-related crashes. This is easiest to trigger by changing the screen resolution, but I sometimes get it disconnecting VNC as well. (This is qemu-kvm. I can't get plain old qemu to work.) This occurs in all the Fedora builds I've tri

[Qemu-devel] Re: [PATCH v3 11/12] monitor/net: Convert do_info_network() to QObject/QMP

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:07:06 -0300 Miguel Di Ciurcio Filho wrote: > Each device is represented by a QDict. The returned QObject is a QList > of all devices. > > This commit slightly changes the monitor output when 'info network' is used. Actually, it's much more than that. For example, the s

[Qemu-devel] Re: [PATCH v3 09/12] net: socket: use info_dict instead of info_str

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:07:04 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/socket.c | 47 --- > 1 files changed, 32 insertions(+), 15 deletions(-) > > diff --git a/net/socket.c b/net/socket.c > index 1c4e

[Qemu-devel] Re: [PATCH v3 06/12] net: tap/tap-win32: use info_dict instead of info_str

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:07:01 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/tap-win32.c |9 ++--- > net/tap.c | 18 +- > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/net/tap-win32.c b/net/tap-win32

[Qemu-devel] Re: [PATCH v3 05/12] net: slirp: use info_dict instead of info_str

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:07:00 -0300 Miguel Di Ciurcio Filho wrote: > Signed-off-by: Miguel Di Ciurcio Filho > --- > net/slirp.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/net/slirp.c b/net/slirp.c > index b41c60a..eb9d261 100644 > --- a/net/slirp.c > ++

[Qemu-devel] Re: [PATCH v3 02/12] net: add qemu_nic_format_info_dict and VLANClientState->info_dict

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:06:57 -0300 Miguel Di Ciurcio Filho wrote: > There is no standard format when formatting VLANClientState.info_str, > so it is difficult to extract information and transmit it over QMP. > > This patch adds info_dict, a QDict to better handle the information > of a NIC. > >

[Qemu-devel] Re: [PATCH v3 01/12] QObject API: add qdict_to_qstring() function

2010-04-23 Thread Luiz Capitulino
On Thu, 15 Apr 2010 11:06:56 -0300 Miguel Di Ciurcio Filho wrote: > This is a helper function that converts a QDict to a QString, using the > format: > > key1=value1 SPACE key2=value2 SPACE key3=value3 > > Handy for debugging and other things. Something I don't remember if we talked about is

Re: [Qemu-devel] Atomicity of i386 guest atomic instructions

2010-04-23 Thread Alexander Graf
On 23.04.2010, at 19:27, Jakub Jermar wrote: > Hello, > > is it at least theoretically possible that the guest atomic instructions > (e.g. XCHG, > LOCK CMPXCHG) on target-i386 are somehow not atomic when simulated/translated > by Qemu? > > I am observing a problem with one of my HelenOS/ia32

Re: [Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-23 Thread Ryan Harper
* Kevin Wolf [2010-04-23 11:29]: > From: Stefan Hajnoczi > > A new iovec array is allocated when creating a merged write request. > This patch ensures that the iovec array is deleted in addition to its > qiov owner. > Submit for [STABLE] ? > Reported-by: Leszek Urbanski > Signed-off-by: Stef

Re: [Qemu-devel] Problem with QEMU on KVM

2010-04-23 Thread Gerhard Wiesinger
On Thu, 22 Apr 2010, Gerd Hoffmann wrote: Hi, Had also a look at ps2.c/ps2.h, pckbd.c: There were no changes which could explain such a behaviour. Also keyboard is very strange which switches to CAPS LOCK (shift state) very unmotivated. Hmm. Recent qemu tries hard to make sure vncviewer an

[Qemu-devel] Re: [PULL 00/26] Block patches

2010-04-23 Thread Anthony Liguori
On 04/23/2010 10:30 AM, Kevin Wolf wrote: Hi Anthony, this is the first part of the block patches that accumulated in my block branch during your absence. I consider these patches ready to be merged into master. I've not included another 13 patches that might still need discussion/review or depe

[Qemu-devel] Re: [PATCH] target-sparc: Fix address masking in ldqf and stqf.

2010-04-23 Thread Blue Swirl
Thanks, applied. On 4/23/10, Richard Henderson wrote: > Use address_mask on both addr and addr+8 in both these routines, > rather than explicit masking with 0x. > > Reformulate address_mask to return a result, rather than masking > a pass-by-reference argument. > > Signed-off-by: Rich

[Qemu-devel] Re: [PATCH] linux-user: Remove ELFLOAD32.

2010-04-23 Thread Blue Swirl
On 4/23/10, Richard Henderson wrote: > The ABI-specific types used by linux_binprm and image_info > are different after forcing TARGET_ABI32 on. Which means > that the parameters that load_elf_binary_multi sees are not > those that loader_exec passed. This is inherently broken > and is more

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Anthony Liguori
On 04/23/2010 09:21 AM, Daniel P. Berrange wrote: Say libvirt is running a 'offline core dump' operation. This consists of us invoking stop migrate exec:cat> foo.dump cont I don't want other debug commands accidentally being issued in between these steps. These 3 commands are in e

Re: [Qemu-devel] [PATCH 0/2] [RFC] 64-bit io paths

2010-04-23 Thread Blue Swirl
On 4/23/10, Richard Henderson wrote: > On 04/22/2010 01:01 PM, Blue Swirl wrote: > >> This is also fine. Although by using NULL all you'd get is a qemu > >> null pointer dereference; I suppose this might get caught and > >> translated to an cpu exception, but I think it would be preferable >

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Anthony Liguori
On 04/23/2010 09:24 AM, Avi Kivity wrote: On 04/23/2010 04:48 PM, Anthony Liguori wrote: On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still runnin

[Qemu-devel] Re: [PATCH v4] Shared memory uio_pci driver

2010-04-23 Thread Cam Macdonell
On Mon, Apr 12, 2010 at 2:57 PM, Avi Kivity wrote: > > There is work now to bring msi to the generic pci 2.3 driver, perhaps we can > use that instead.  From a quick look it looks fine. > I'd be interested to follow this development. I can't find anything on LKML, is it being discussed anywhere?

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Jamie Lokier
Ian Molton wrote: > >You can configure any chardev to be a tcp client. I never do that though > >as I find it much more convenient to configure it as server. > > Perhaps thats because chardev clients are nearly useless right now > because they just die if the connection drops... Which is why dro

[Qemu-devel] Atomicity of i386 guest atomic instructions

2010-04-23 Thread Jakub Jermar
Hello, is it at least theoretically possible that the guest atomic instructions (e.g. XCHG, LOCK CMPXCHG) on target-i386 are somehow not atomic when simulated/translated by Qemu? I am observing a problem with one of my HelenOS/ia32 builds which suggests me that for some reason HelenOS spinlock

[Qemu-devel] [uq/master patch 5/5] introduce qemu_ram_map

2010-04-23 Thread Marcelo Tosatti
Which allows drivers to register an mmaped region into ram block mappings. To be used by device assignment driver. CC: Cam Macdonell Signed-off-by: Marcelo Tosatti Index: qemu-kvm/cpu-common.h === --- qemu-kvm.orig/cpu-common.h +++

[Qemu-devel] [uq/master patch 3/5] introduce leul_to_cpu

2010-04-23 Thread Marcelo Tosatti
To be used by next patch. Signed-off-by: Marcelo Tosatti Index: qemu-memslot/bswap.h === --- qemu-memslot.orig/bswap.h +++ qemu-memslot/bswap.h @@ -205,8 +205,10 @@ static inline void cpu_to_be32wu(uint32_ #ifdef HOST_WORDS_BIGEN

[Qemu-devel] [uq/master patch 1/5] vga: fix typo in length passed to kvm_log_stop

2010-04-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Index: qemu-kvm/hw/vga.c === --- qemu-kvm.orig/hw/vga.c +++ qemu-kvm/hw/vga.c @@ -1613,8 +1613,8 @@ void vga_dirty_log_stop(VGACommonState * kvm_log_stop(s->map_addr, s->map_end - s->map_addr);

[Qemu-devel] [uq/master patch 4/5] kvm: port qemu-kvm's bitmap scanning

2010-04-23 Thread Marcelo Tosatti
Which is significantly faster. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/kvm-all.c === --- qemu-kvm.orig/kvm-all.c +++ qemu-kvm/kvm-all.c @@ -26,6 +26,7 @@ #include "hw/hw.h" #include "gdbstub.h" #include "kvm.h" +#include "

[Qemu-devel] [uq/master patch 2/5] kvm: add logging count to slots

2010-04-23 Thread Marcelo Tosatti
Otherwise there is no way to differentiate between global and slot specific logging, so for example vga dirty log start migration start migration fail Disables dirty logging for the vga slot. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/kvm-all.c ===

[Qemu-devel] [uq/master patch 0/5] prepare for qemu-kvm's usage of upstream memslot code

2010-04-23 Thread Marcelo Tosatti

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-23 Thread Christoph Hellwig
On Fri, Apr 23, 2010 at 06:09:09PM +0200, Kevin Wolf wrote: > Christoph, what about this one? It's still in the block branch, but I > have excluded it from first pull request round because these questions > are still open. > > What should I do with it? Drop it, wait for a new version or keep it as

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-23 Thread Kevin Wolf
Am 07.04.2010 14:32, schrieb Kevin Wolf: > Am 07.04.2010 13:57, schrieb Christoph Hellwig: >> Various obscure image format drivers do not allow write access. >> Instead of silently falling back to read-only access reject attempts >> to open these images for write access. >> >> Signed-off-by: Christ

[Qemu-devel] [PATCH] [RFC] target-ppc: fix RFI by clearing TGPR and ILE

2010-04-23 Thread Thomas Monjalon
From: Thomas Monjalon Since commit 2ada0ed, the PPC processors which have TGPR support should be broken because the bit TGPR was not cleared. After testing with e300, it seems that ILE should be cleared also. Feedbacks welcomed, thanks. Signed-off-by: Thomas Monjalon --- target-ppc/op_helper

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Ian Molton
On 23/04/10 15:07, Gerd Hoffmann wrote: In my usage of qemu I didn't came across a use case which needs qemu reconnecting yet. You're comparing apples with oranges :-) IMHO I don't. Well, comparing a connection where qemu is the server to one where it is the client doesn't seem terribly v

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Markus Armbruster
Anthony Liguori writes: > On 04/23/2010 07:48 AM, Avi Kivity wrote: >> On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like that. >>> Another problem is

[Qemu-devel] [PATCH 26/26] block: Free iovec arrays allocated by multiwrite_merge()

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi A new iovec array is allocated when creating a merged write request. This patch ensures that the iovec array is deleted in addition to its qiov owner. Reported-by: Leszek Urbanski Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c |3 +++ 1 files c

[Qemu-devel] [PATCH 25/26] qcow2: Use QLIST_FOREACH_SAFE macro

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 30ded6a..f3e3cba 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -539,14 +539

[Qemu-devel] [PATCH 24/26] linux-aio: Fix typo in read() EINTR check

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- linux-aio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-aio.c b/linux-aio.c index 5e892b0..68f4b3d 100644 --- a/linux-aio.c +++ b/linux-aio.c @@ -123,7 +123,7 @@ static void q

[Qemu-devel] [PATCH 23/26] qemu-img: Fix BRDV_O_FLAGS typo

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi It should be BDRV_O_FLAGS instead of BRDV_O_FLAGS. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b30effa..7203b8b 100644

[Qemu-devel] [PATCH 22/26] qemu-img: Eliminate bdrv_new_open() code duplication

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi Several commands have code to create a BlockDriverState and open a file. The bdrv_new_open() function can be used to perform these steps. This patch converts the qemu-img commands to actually use bdrv_new_open(). Replaced the bdrv_new_open() 'readonly' argument with bdrv_o

[Qemu-devel] [PATCH 20/26] block.h: bdrv_create2 doesn't exist any more

2010-04-23 Thread Kevin Wolf
The bdrv_create2 implementation has disappeared long ago. Remove its prototype from the header file, too. Signed-off-by: Kevin Wolf --- block.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/block.h b/block.h index 4a57dd5..05ad572 100644 --- a/block.h +++ b/block.h

[Qemu-devel] [PATCH 21/26] block: Convert first_drv to QLIST

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 22 -- block_int.h |2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index 5d087de..12cf434 100644 --- a/block.c +++ b/block.c @@ -

[Qemu-devel] [PATCH 19/26] Remove un-needed code

2010-04-23 Thread Kevin Wolf
From: Bruce Rogers The bdrv_set_geometry_hint call below is not needed - it's just setting what was just read. Signed-off-by: Bruce Rogers Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c i

[Qemu-devel] [PATCH 18/26] block: Convert bdrv_first to QTAILQ

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.c | 41 +++-- block_int.h |3 ++- 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/block.c b/block.c index 61da183..5d087de 100644 --- a/block.

[Qemu-devel] [PATCH 16/26] cleanup block driver option handling in vl.c

2010-04-23 Thread Kevin Wolf
From: Christoph Hellwig Assign directly to the bdrv_flags variable instead of using magic numbers before translating to the BDRV_O_* options. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- vl.c | 45 - 1 files changed, 16 insertion

[Qemu-devel] [PATCH 17/26] block: Do not export bdrv_first

2010-04-23 Thread Kevin Wolf
From: Stefan Hajnoczi The bdrv_first linked list of BlockDriverStates is currently extern so that block migration can iterate the list. However, since there is already a bdrv_iterate() function there is no need to expose bdrv_first. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 14/26] qcow2: Return 0/-errno in write_l1_entry

2010-04-23 Thread Kevin Wolf
Change write_l1_entry to return the real error code instead of -1. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index d2774d1..d5c52a9 100644 --- a/block/qcow2-c

[Qemu-devel] [PATCH 15/26] qcow2: Return 0/-errno in l2_allocate

2010-04-23 Thread Kevin Wolf
Returning NULL on error doesn't allow distinguishing between different errors. Change the interface to return an integer for -errno. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 40 +++- 1 files changed, 23 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] [PATCH 07/26] qcow2: Trigger blkdebug events

2010-04-23 Thread Kevin Wolf
This adds blkdebug events to qcow2 to allow injecting I/O errors in specific places. Signed-off-by: Kevin Wolf --- block.h| 44 block/blkdebug.c | 42 ++ block/qcow2-cluster.c | 15 +

[Qemu-devel] [PATCH 11/26] block: split raw_getlength

2010-04-23 Thread Kevin Wolf
From: Christoph Hellwig Split up the raw_getlength into separate generic, solaris and BSD versions to reduce the ifdef maze a bit. The BSD variant still is a complete maze, but to clean it up properly we'd need some people using the BSD variants to figure out what code is used for what variant.

[Qemu-devel] [PATCH 12/26] qcow2: Return 0/-errno in write_l2_entries

2010-04-23 Thread Kevin Wolf
Change write_l2_entries to return the real error code instead of -1. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 8cb4b38..2f37acd 100644 --- a/block/qcow2-

[Qemu-devel] [PATCH 10/26] block: get rid of the BDRV_O_FILE flag

2010-04-23 Thread Kevin Wolf
From: Christoph Hellwig BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open. It affects two things: first bdrv_open only searches for protocols using find_protocol instead of all image formats and host drivers. We can easily move that to the caller and pass the found dr

[Qemu-devel] [PATCH 13/26] qcow2: Fix error return code in qcow2_alloc_cluster_link_l2

2010-04-23 Thread Kevin Wolf
Fix qcow2_alloc_cluster_link_l2 to return the real error code like it does in all other error cases. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 2f37acd..d2774d

[Qemu-devel] [PATCH 09/26] Replace calls of old bdrv_open

2010-04-23 Thread Kevin Wolf
What is known today as bdrv_open2 becomes the new bdrv_open. All remaining callers of the old function are converted to the new one. In some places they even know the right format, so they should have used bdrv_open2 from the beginning. Signed-off-by: Kevin Wolf --- block.c | 24

[Qemu-devel] [PATCH 08/26] qcow2: Fix creation of large images

2010-04-23 Thread Kevin Wolf
qcow_create2 assumes that the new image will only need one cluster for its refcount table initially. Obviously that's not true any more when the image is big enough (exact value depends on the cluster size). This patch calculates the refcount table size dynamically. Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 06/26] blkdebug: Add events and rules

2010-04-23 Thread Kevin Wolf
Block drivers can trigger a blkdebug event whenever they reach a place where it could be useful to inject an error for testing/debugging purposes. Rules are read from a blkdebug config file and describe which action is taken when an event is triggered. For now this is only injecting an error (with

[Qemu-devel] [PATCH 05/26] Make qemu-config available for tools

2010-04-23 Thread Kevin Wolf
To be able to use config files for blkdebug, we need to make these functions available in the tools. This involves moving two functions that can only be built in the context of the emulator. Signed-off-by: Kevin Wolf --- Makefile.objs|4 ++-- hw/qdev-properties.c | 19 +

[Qemu-devel] [PATCH 03/26] blkdebug: Basic request passthrough

2010-04-23 Thread Kevin Wolf
This isn't doing anything interesting. It creates the blkdebug block driver as a protocol which just passes everything through to raw. Signed-off-by: Kevin Wolf --- Makefile.objs|2 +- block/blkdebug.c | 104 ++ 2 files changed, 105 in

[Qemu-devel] [PULL 00/26] Block patches

2010-04-23 Thread Kevin Wolf
Hi Anthony, this is the first part of the block patches that accumulated in my block branch during your absence. I consider these patches ready to be merged into master. I've not included another 13 patches that might still need discussion/review or depend on such patches. I'm going to send anothe

[Qemu-devel] [PATCH 04/26] blkdebug: Inject errors

2010-04-23 Thread Kevin Wolf
Add a mechanism to inject errors instead of passing requests on. With no further patches applied, you can use it by setting inject_errno in gdb. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 81 ++ 1 files changed, 81 insertions(+), 0 dele

[Qemu-devel] [PATCH 02/26] qemu-config: Make qemu_config_parse more generic

2010-04-23 Thread Kevin Wolf
qemu_config_parse gets the option groups as a parameter now instead of hardcoding the VM configuration groups. This way it can be used for other configurations, too. Signed-off-by: Kevin Wolf --- qemu-config.c | 18 -- qemu-config.h |2 +- 2 files changed, 13 insertions(+),

[Qemu-devel] [PATCH 01/26] qemu-config: qemu_read_config_file() reads the normal config file

2010-04-23 Thread Kevin Wolf
Introduce a new function qemu_read_config_file which reads the VM configuration from a config file. Unlike qemu_config_parse it doesn't take a open file but a filename and reduces code duplication as a side effect. Signed-off-by: Kevin Wolf --- qemu-config.c | 15 +++ qemu-config.h

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-23 Thread Jamie Lokier
Yoshiaki Tamura wrote: > Jamie Lokier wrote: > >Yoshiaki Tamura wrote: > >>Dor Laor wrote: > >>>On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: > Event tapping is the core component of Kemari, and it decides on which > event the > primary should synchronize with the secondary. The basic

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 05:24:34PM +0300, Avi Kivity wrote: > On 04/23/2010 04:48 PM, Anthony Liguori wrote: > >On 04/23/2010 07:48 AM, Avi Kivity wrote: > >>On 04/22/2010 09:49 PM, Anthony Liguori wrote: > real API. Say, adding a device libvirt doesn't know about or > stopping the VM > >>

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 08:48:51AM -0500, Anthony Liguori wrote: > On 04/23/2010 07:48 AM, Avi Kivity wrote: > >On 04/22/2010 09:49 PM, Anthony Liguori wrote: > >>>real API. Say, adding a device libvirt doesn't know about or > >>>stopping the VM > >>>while libvirt thinks it's still running or anyt

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Avi Kivity
On 04/23/2010 04:48 PM, Anthony Liguori wrote: On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like that. Another problem

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Fri, Apr 23, 2010 at 08:40:49AM -0500, Anthony Liguori wrote: > On 04/23/2010 05:28 AM, Daniel P. Berrange wrote: > >On Thu, Apr 22, 2010 at 01:45:27PM -0500, Anthony Liguori wrote: > > > >>On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: > >> > >>>On Fri, Apr 09, 2010 at 09:41:39AM -04

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Gerd Hoffmann
On 04/23/10 11:28, Ian Molton wrote: Gerd Hoffmann wrote: Hi, Im not sure I agree there... surely there are other things which would benefit from generic socket reconnection support (virtio-rng cant be the only driver that might want to rely on a reliable source of data via a socket in a se

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Anthony Liguori
On 04/23/2010 07:48 AM, Avi Kivity wrote: On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like that. Another problem is issuing Monitor commands that could confuse

[Qemu-devel] Re: [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops().

2010-04-23 Thread Avi Kivity
On 04/23/2010 04:22 PM, Anthony Liguori wrote: I currently don't have data, but I'll prepare it. There were two things I wanted to avoid. 1. Pages to be copied to QEMUFile buf through qemu_put_buffer. 2. Calling write() everytime even when we want to send multiple pages at once. I think 2 may

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Markus Armbruster
Michael Tokarev writes: > Markus Armbruster wrote: >> Michael Tokarev writes: >> >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >>> (with fprintf) something like this: >>> >>> warning: could not open /dev/net/tun: no virtual network emulation >>> >>> this has 2 iss

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Anthony Liguori
On 04/23/2010 05:28 AM, Daniel P. Berrange wrote: On Thu, Apr 22, 2010 at 01:45:27PM -0500, Anthony Liguori wrote: On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: myguest ... q

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Kevin Wolf
Am 23.04.2010 14:52, schrieb Michael Tokarev: > Kevin Wolf wrote: >> Am 22.04.2010 11:52, schrieb Markus Armbruster: >>> Michael Tokarev writes: >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: > [] TFR(fd = ope

[Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-04-23 Thread Anthony Liguori
On 04/23/2010 04:53 AM, Avi Kivity wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Why is this needed? The real buffering is in the kernel anyways; this is only used to reduce the number of write() sysca

[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-23 Thread Avi Kivity
On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Kemari starts synchronizing VMs when QEMU handles I/O requests. Without this patch VCPU state is already proceeded before synchronization, and after failover to the VM on the receiver, it hangs because of this. We discussed moving the barrier t

[Qemu-devel] Re: [RFC PATCH 07/20] Introduce qemu_put_vector() and qemu_put_vector_prepare() to use put_vector() in QEMUFile.

2010-04-23 Thread Anthony Liguori
On 04/22/2010 11:02 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: For fool proof purpose, qemu_put_vector_parepare should be called before qemu_put_vector. Then, if qemu_put_* functions except this is called after qemu_put_vector_prepare, progr

[Qemu-devel] Re: [RFC PATCH 05/20] Introduce put_vector() and get_vector to QEMUFile and qemu_fopen_ops().

2010-04-23 Thread Anthony Liguori
On 04/22/2010 10:37 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/21/2010 12:57 AM, Yoshiaki Tamura wrote: QEMUFile currently doesn't support writev(). For sending multiple data, such as pages, using writev() should be more efficient. Signed-off-by: Yoshiaki Tamura Is there perform

Re: [Qemu-devel] [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-23 Thread Anthony Liguori
On 04/22/2010 08:53 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: On 04/22/2010 08:16 AM, Yoshiaki Tamura wrote: 2010/4/22 Dor Laor: On 04/22/2010 01:35 PM, Yoshiaki Tamura wrote: Dor Laor wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Hi all, We have been implementing the proto

[Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-04-23 Thread Avi Kivity
On 04/23/2010 12:59 PM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Why is this needed? The real buffering is in the kernel anyways; this is only used to reduce the nu

[Qemu-devel] Re: [RFC PATCH 00/20] Kemari for KVM v0.1

2010-04-23 Thread Anthony Liguori
On 04/22/2010 07:45 PM, Yoshiaki Tamura wrote: Anthony Liguori wrote: I think it would make sense to separate out the things that are actually optimizations (like the dirty bitmap changes and the writev/readv changes) and to attempt to justify them with actual performance data. I agree with t

Re: [Qemu-devel] One more thing about block device locking

2010-04-23 Thread Kevin Wolf
Am 23.04.2010 10:00, schrieb Richard W.M. Jones: > On Fri, Apr 23, 2010 at 09:07:28AM +0400, Michael Tokarev wrote: >> So we'll have to either >> trial and error, or open "normally", check >> if it's a block device and re-open with that >> flag set. > > Perhaps I'm missing something, but why can't

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Michael Tokarev
Kevin Wolf wrote: > Am 22.04.2010 11:52, schrieb Markus Armbruster: >> Michael Tokarev writes: >> >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >>> (with fprintf) something like this: >>> [] >>> TFR(fd = open("/dev/net/tun", O_RDWR)); >>> if (fd < 0) { >>> -

RE: [Qemu-devel] Can not find the function body of omap3_lcd_panel_draw_fn_32

2010-04-23 Thread steven_chiu
You are right, thanks to the glue and xglue~~ I should not grep the name Thank you Juha~ From: juha.riihim...@nokia.com [mailto:juha.riihim...@nokia.com] Sent: Friday, April 23, 2010 8:44 PM To: Steven Chiu(TPE) Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel]

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Avi Kivity
On 04/22/2010 09:49 PM, Anthony Liguori wrote: real API. Say, adding a device libvirt doesn't know about or stopping the VM while libvirt thinks it's still running or anything like that. Another problem is issuing Monitor commands that could confuse libvirt's We need to make libvirt and qem

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Kevin Wolf
Am 22.04.2010 11:52, schrieb Markus Armbruster: > Michael Tokarev writes: > >> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> (with fprintf) something like this: >> >> warning: could not open /dev/net/tun: no virtual network emulation >> >> this has 2 issues: >> 1) i

Re: [Qemu-devel] Can not find the function body of omap3_lcd_panel_draw_fn_32

2010-04-23 Thread Juha.Riihimaki
On Apr 23, 2010, at 15:17, ext steven_c...@htc.com wrote: I am tracing the code and I can not find the body of omap3_lcd_panel_draw_fn_32. I did print out the address and search the map file, that address did not match any function. Can some one give me a hint?? Tha

[Qemu-devel] Can not find the function body of omap3_lcd_panel_draw_fn_32

2010-04-23 Thread steven_chiu
Hi I am tracing the code and I can not find the body of omap3_lcd_panel_draw_fn_32. I did print out the address and search the map file, that address did not match any function. Can some one give me a hint?? Thank you guys Steven

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Michael Tokarev
Markus Armbruster wrote: > Michael Tokarev writes: > >> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> (with fprintf) something like this: >> >> warning: could not open /dev/net/tun: no virtual network emulation >> >> this has 2 issues: >> 1) it is not a warning real

Re: [Qemu-devel] One more thing about block device locking

2010-04-23 Thread Michael Tokarev
Richard W.M. Jones wrote: > On Fri, Apr 23, 2010 at 09:07:28AM +0400, Michael Tokarev wrote: >> So we'll have to either >> trial and error, or open "normally", check >> if it's a block device and re-open with that >> flag set. > > Perhaps I'm missing something, but why can't you stat(2) the name >

Re: [libvirt] [Qemu-devel] Re: Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Thu, Apr 22, 2010 at 01:47:55PM -0500, Anthony Liguori wrote: > On 04/12/2010 07:23 AM, Jamie Lokier wrote: > >Daniel Veillard wrote: > > > >>On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote: > >> > >>>It's not that hard to write this for trivial extra options: > >>> > >>>

Re: [Qemu-devel] Re: [libvirt] Libvirt debug API

2010-04-23 Thread Daniel P. Berrange
On Thu, Apr 22, 2010 at 01:45:27PM -0500, Anthony Liguori wrote: > On 04/09/2010 09:27 AM, Daniel P. Berrange wrote: > >On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote: > > > > > >> > >> myguest > >> ... > >> > >> > >> > >> qemu arguments > >> > >>

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Ian Molton
Jamie Lokier wrote: > Ian Molton wrote: >>> It might make sense to have the reconnect logic in the egd chardev >>> backend then, thereby obsoleting the socket reconnect patch. >> Im not sure I agree there... surely there are other things which would >> benefit from generic socket reconnection suppo

[Qemu-devel] Linux Plumbers Conference 2010 - call for tracks

2010-04-23 Thread Jes Sorensen
Hi, I am organizing a Virtualization track at LPC 2010 (Linux Plumbers Conference 2010). Please see the official call for tracks below. LPC is particular well suited for work in progress and subjects that needs discussion and collaboration between communities, for example between KVM/QEMU and the

[Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-04-23 Thread Avi Kivity
On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Why is this needed? The real buffering is in the kernel anyways; this is only used to reduce the number of write() syscalls. -- Do not meddle in the internal

[Qemu-devel] Re: [RFC PATCH 04/20] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2010-04-23 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/21/2010 08:57 AM, Yoshiaki Tamura wrote: Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Why is this needed? The real buffering is in the kernel anyways; this is only used to reduce the number of write() syscalls. This was introduced

[Qemu-devel] [PATCH] target-ppc: exception model of 603e inherits from 603

2010-04-23 Thread Thomas Monjalon
From: Thomas Monjalon It appears that the exception handling of 603e is the same as 603. So it could be removed safely. Signed-off-by: Thomas Monjalon --- target-ppc/cpu.h|2 -- target-ppc/helper.c |3 --- target-ppc/translate_init.c |5 + 3 files changed, 1

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Ian Molton
Gerd Hoffmann wrote: > Hi, > >> Im not sure I agree there... surely there are other things which would >> benefit from generic socket reconnection support (virtio-rng cant be the >> only driver that might want to rely on a reliable source of data via a >> socket in a server-farm type situation?)

[Qemu-devel] xen domU screen corruption

2010-04-23 Thread Arvind R
Hi, I have a pvops-domU running on xen, using qemu-dm as the device-model. All is fine as long as I do not switch to the qemu-console (ctrl-alt-1). After a switch to the qemu-console, on returning to the domU console, the screen is unreadable. This is because in hw/xenfb.c, in the function xenfb_gu

Re: [Qemu-devel] One more thing about block device locking

2010-04-23 Thread Richard W.M. Jones
On Fri, Apr 23, 2010 at 09:07:28AM +0400, Michael Tokarev wrote: > So we'll have to either > trial and error, or open "normally", check > if it's a block device and re-open with that > flag set. Perhaps I'm missing something, but why can't you stat(2) the name first to see if it's a block device (

[Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash

2010-04-23 Thread Jan Kiszka
Michael Walle wrote: > Hi Jan, > > your commit "Optimize consecutive CFI02 writes by remapping memory lazily" > breaks the code execution from flash. > > If you write to the flash, the flash will switch into I/O mode. Now if code > is > executed from this flash, a cpu_abort will be raised ("Tr

[Qemu-devel] [PATCH] usb-wacom: fix usb_wacom_initfn regression

2010-04-23 Thread Spencer Oliver
>From 2c0a39852848d146e27843ab3b45ff8cdf49ba86 Mon Sep 17 00:00:00 2001 From: Spencer Oliver Date: Fri, 23 Apr 2010 09:07:23 +0100 Subject: [PATCH] usb-wacom: fix usb_wacom_initfn regression eh_entry was not intialized and so produced a seg fault when WACOM_SET_REPORT was called. --- hw/usb-wac

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-23 Thread Gerd Hoffmann
Hi, Im not sure I agree there... surely there are other things which would benefit from generic socket reconnection support (virtio-rng cant be the only driver that might want to rely on a reliable source of data via a socket in a server-farm type situation?) Usually qemu takes the server pa

  1   2   >