[Qemu-devel] [patch 02/02] sparc32 use empty_slot for missing RAM v1

2010-04-17 Thread Artyom Tarasenko
use empty_slot device for the RAM which is not installed Models without ECC don't trap when missing ram is accessed. v0->v1 compile only once and fix indentation Signed-off-by: Artyom Tarasenko --- diff --git a/Makefile.objs b/Makefile.objs index ab1af88..f4d2faf 100644 --- a/Makefile.objs +++

Re: [Qemu-devel] Guest latency issues due to bdrv_check_byte_request

2010-04-17 Thread Stefan Hajnoczi
Thanks Christoph. Cached getlength with pread/pwrite: % time seconds usecs/call callserrors syscall -- --- --- - - 96.971.760111 11893 148 4 futex 1.610.029209 1 46891 2217 select

Re: [Qemu-devel] Guest latency issues due to bdrv_check_byte_request

2010-04-17 Thread Christoph Hellwig
On Sat, Apr 17, 2010 at 08:05:45PM +0100, Stefan Hajnoczi wrote: > I think there are still a lot of lseeks left because > raw-posix.c:raw_pread_aligned() is implemented using lseek+read > instead of pread. Does anyone know the reasoning there or could > pread() be used? There's no good reason for

Re: [Qemu-devel] QEMU OS support site

2010-04-17 Thread Natalia Portillo
That's because I was debugging some code, but it should be silent now. Sorry for the inconveniences it may have caused you. El 17/04/2010, a las 09:05, Andrea Canciani escribió: > On the website http://www.claunia.com/qemu/ the pages contain log > information from php complaining that > > "Depr

Re: [Qemu-devel] Guest latency issues due to bdrv_check_byte_request

2010-04-17 Thread Stefan Hajnoczi
$ strace -cf x86_64-softmmu/qemu-system-x86_64 test.raw Uncached getlength: % time seconds usecs/call callserrors syscall -- --- --- - - 96.401.944174 13136 148 4 futex 1.650.033259 1 564

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/17/10, Richard Henderson wrote: > On 04/17/2010 12:49 PM, Richard Henderson wrote: > > On 04/17/2010 11:41 AM, Blue Swirl wrote: > >> About this patch: it's good that we now free the constants, but > >> constant handling is still not optimal and I think this series > >> actually may add e

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/17/10, Richard Henderson wrote: > On 04/17/2010 11:41 AM, Blue Swirl wrote: > > About this patch: it's good that we now free the constants, but > > constant handling is still not optimal and I think this series > > actually may add extra 'movi' ops in the worst case. It would be nice > >

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Richard Henderson
On 04/17/2010 12:49 PM, Richard Henderson wrote: > On 04/17/2010 11:41 AM, Blue Swirl wrote: >> About this patch: it's good that we now free the constants, but >> constant handling is still not optimal and I think this series >> actually may add extra 'movi' ops in the worst case. It would be nice

Re: [Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Richard Henderson
On 04/17/2010 11:41 AM, Blue Swirl wrote: > About this patch: it's good that we now free the constants, but > constant handling is still not optimal and I think this series > actually may add extra 'movi' ops in the worst case. It would be nice > if we detected if constants are in play and call imm

Re: [Qemu-devel] [PATCH 2/3] vmdk: Clean up backing file handling

2010-04-17 Thread Stefan Hajnoczi
Looks good. Stefan

[Qemu-devel] Re: [PATCH 2/3] target-sparc: Free instruction temporaries.

2010-04-17 Thread Blue Swirl
On 4/16/10, Richard Henderson wrote: > Rather than creating new temporaries for constants, use the > ones created in disas_sparc_insn. Remember the temps created > there so that they can be freed at the end of the function. > > Profile data collected by TCG while booting sparc-test kernel: > >

[Qemu-devel] QEMU OS support site

2010-04-17 Thread Andrea Canciani
On the website http://www.claunia.com/qemu/ the pages contain log information from php complaining that "Deprecated: Function split() is deprecated in /Users/claunia/Sites/www.claunia.com/qemu/include/query.php on line 88" Even if the content is actually available, this makes the page much less r

Re: [Qemu-devel] [PATCH 1/2] block: Set backing_hd to NULL after deleting it

2010-04-17 Thread Stefan Hajnoczi
On Sat, Apr 17, 2010 at 10:49 AM, Stefan Hajnoczi wrote: > This patch should be applied after Kevin Wolf's "vmdk: Convert to > bdrv_open" so that vmdk does not segfault on close. This is a mistake, vmdk will check backing_hd != NULL so it is safe. Stefan

Re: [Qemu-devel] wrong behaviour of caps lock

2010-04-17 Thread Stefan Weil
Benjamin Drung schrieb: > Hi, > > We applied the attached patch in Ubuntu to fix the wrong behavior of > caps lock. > > Initial bug report: https://launchpad.net/bugs/427612 > > Testcase: Select German NEO 2 as keyboard layout and press "caps lock" + > "l". Then a "-" should appear instead of a "t"

[Qemu-devel] [PATCH 1/2] block: Set backing_hd to NULL after deleting it

2010-04-17 Thread Stefan Hajnoczi
It is safer to set backing_hd to NULL after deleting it so that any use after deletion is obvious during development. Happy segfaulting! This patch should be applied after Kevin Wolf's "vmdk: Convert to bdrv_open" so that vmdk does not segfault on close. Signed-off-by: Stefan Hajnoczi --- bloc

[Qemu-devel] [PATCH 2/2] qcow2: Avoid shadowing variable in alloc_clusters_noref()

2010-04-17 Thread Stefan Hajnoczi
The i loop iterator is shadowed by the next free cluster index. Both using the variable name 'i' makes the code harder to read. Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qc

Re: [Qemu-devel] [PATCH 3/3] vmdk: Convert to bdrv_open

2010-04-17 Thread Stefan Hajnoczi
On Fri, Apr 16, 2010 at 8:59 PM, Kevin Wolf wrote: > diff --git a/block/vmdk.c b/block/vmdk.c > index 781518a..27b6360 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -835,14 +828,12 @@ static void vmdk_close(BlockDriverState *bs) >     qemu_free(s->l1_table); >     qemu_free(s->l2_cache); >

Re: [Qemu-devel] [PATCH 1/3] vmdk: Fix COW

2010-04-17 Thread Stefan Hajnoczi
Looks good. Stefan