Hi,
just for the record: a build of QEMU from HEAD with
'--enable-io-thread' fails. In "vl.c" "qemu_system_ready" is used but
not declared any longer.
Dirk
Hi. I have a question.
On KVM website (http://www.linux-kvm.org/page/Main_Page ) it says that:
'KVM also requires a modified QEMU although work is underway to get the
required changes upstream'
But in Qemu documentation there are options like '-enable-kvm'. Furthermore,
kqemu support is dropp
Here is the command I issued
"*qemu -initrd initramfs.img -kernel vmlinux-2.6.24 /dev/zero -append
"noapic rw root=/dev/ram*"
Thanks for help.
On Wed, Mar 31, 2010 at 7:26 PM, Mulyadi Santosa
wrote:
> On Thu, Apr 1, 2010 at 05:20, Arpit Patel wrote:
> > Hi,
> >
> > I am trying to use Qemu, to
On 03/31/2010 09:45 PM, Anthony Liguori wrote:
On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
While it probably make sense to achieve this goal, it doesn't mean it
should be done the dirty way.
For example it is known for a lot of time that the solution for the
bswap in the device code is to add
On 03/31/2010 05:45 PM, Aurelien Jarno wrote:
While it probably make sense to achieve this goal, it doesn't mean it
should be done the dirty way.
For example it is known for a lot of time that the solution for the
bswap in the device code is to add a bus model doing the byteswapping.
Removing th
On Thu, Apr 1, 2010 at 05:20, Arpit Patel wrote:
> Hi,
>
> I am trying to use Qemu, to boot kernel image I got, using the initramfs
> image that was build, when I build kernel
>
> But it only loads initramfs image, and gives me prompt with "(initramfs)_",
> and thus doesn't load kernel.
Care to s
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
>> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
>>
>>> On Wed, 31 Mar 2010 13:26:23 -0500
>>> Anthony Liguori wrote:
>>>
>>>
On 03/31/2010 01:20 P
Hi,
I am trying to use Qemu, to boot kernel image I got, using the initramfs
image that was build, when I build kernel
But it only loads initramfs image, and gives me prompt with "(initramfs)_",
and thus doesn't load kernel.
Do you guys have any idea, what I am doing wrong.
Thanks for your help
On 03/31/2010 02:00 PM, Juergen Lock wrote:
> V2 that uses endaddr = end-of-guest-address-space if !h2g_valid(endaddr)
> after I found out that indeed works; and also disables the FreeBSD 6.x
> /compat/linux/proc/self/maps fallback because it can return partial lines
> if (at least I think that's t
V2 that uses endaddr = end-of-guest-address-space if !h2g_valid(endaddr)
after I found out that indeed works; and also disables the FreeBSD 6.x
/compat/linux/proc/self/maps fallback because it can return partial lines
if (at least I think that's the reason) the mappings change between
subsequent re
> >>+
> >>+if (QTAILQ_EMPTY(&kbd_handlers)) {
> >>+qerror_report(QERR_DEVICE_NOT_FOUND, "keyboard");
> >>+return -1;
> >>+}
> >>+
> >>+QTAILQ_FOREACH(cursor,&kbd_handlers, node) {
> >>+if (cursor->index == index) {
> >>+QTAILQ_REMOVE(&kbd_handlers, cu
Anthony Liguori wrote:
> On 03/31/2010 02:37 PM, Shahar Havivi wrote:
>> On Wed, Mar 31, 2010 at 06:58:14PM +0200, Juan Quintela wrote:
>>
>>> Date: Wed, 31 Mar 2010 18:58:14 +0200
>>> From: Juan Quintela
>>> To: Markus Armbruster
>>> Cc: Shahar Havivi, qemu-devel@nongnu.org
>>> Subject: [Qemu
Trivial, as it never fails, doesn't have output nor return
any data.
Note that it's also available under QMP, as kvm-autotest
needs this.
Signed-off-by: Luiz Capitulino
---
monitor.c |3 ++-
qemu-monitor.hx |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/mo
Some people might think that this event is emitted whenever the
time changes, be more specific.
Signed-off-by: Luiz Capitulino
---
QMP/qmp-events.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index a94e9b4..c084a47 100644
-
On Wed, Mar 31, 2010 at 10:25:53PM +0300, Michael S. Tsirkin wrote:
> On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> > Long term, I think most of us want to see a single qemu executable
> > that works for all architectures and compiling once is an important
> > step in that di
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:38 PM, Blue Swirl wrote:
>
> > On 3/31/10, Michael S. Tsirkin wrote:
> >
> >
> > > On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> > > > On Wed, 31 Mar 2010 13:26:23 -0500
> > > > Anthony Liguori wrote:
> > > >
> > >
On 03/31/2010 02:54 PM, Blue Swirl wrote:
This refactoring effort isn't really paying attention to improving
interfaces which I think is a bit problematic.
I agree, but with improved memory API, the questionable byte swapping
could be eliminated from devices. Do you plan to finish your
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:25 PM, Michael S. Tsirkin wrote:
>
> > On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> >
> >
> > > Long term, I think most of us want to see a single qemu executable
> > > that works for all architectures and compiling once
On 03/31/2010 02:37 PM, Shahar Havivi wrote:
On Wed, Mar 31, 2010 at 06:58:14PM +0200, Juan Quintela wrote:
Date: Wed, 31 Mar 2010 18:58:14 +0200
From: Juan Quintela
To: Markus Armbruster
Cc: Shahar Havivi, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: '
On 3/31/10, Anthony Liguori wrote:
> On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
>
> > On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> >
> >
> > > On Wed, 31 Mar 2010 13:26:23 -0500
> > > Anthony Liguori wrote:
> > >
> > >
> > >
> > > > On 03/31/2010 01:20 PM, Michael S.
Stefan Weil schrieb:
> Commit c05c7a7306a23a4b01d1606172b142c45caffc92
> breaks cross compilation for mips (and other
> compilations without CONFIG_INOTIFY1):
>
> make[1]: Entering directory `/qemu/bin/mips'
> CC i386-linux-user/syscall.o
> cc1: warnings being treated as errors
> /qemu/linux-user/s
On 03/31/2010 02:38 PM, Blue Swirl wrote:
On 3/31/10, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> On Wed, 31 Mar 2010 13:26:23 -0500
> Anthony Liguori wrote:
>
> > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > From
On 3/31/10, Michael S. Tsirkin wrote:
> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> > On Wed, 31 Mar 2010 13:26:23 -0500
> > Anthony Liguori wrote:
> >
> > > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > > From: David L Stevens
> > > >
> > > > vhost driver
On Wed, Mar 31, 2010 at 06:58:14PM +0200, Juan Quintela wrote:
> Date: Wed, 31 Mar 2010 18:58:14 +0200
> From: Juan Quintela
> To: Markus Armbruster
> Cc: Shahar Havivi , qemu-devel@nongnu.org
> Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set'
> and 'info keybaor
On 03/31/2010 02:25 PM, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
Long term, I think most of us want to see a single qemu executable
that works for all architectures and compiling once is an important
step in that direction.
I'm not s
On Wed, Mar 31, 2010 at 02:24:51PM -0500, Anthony Liguori wrote:
> Long term, I think most of us want to see a single qemu executable
> that works for all architectures and compiling once is an important
> step in that direction.
I'm not so sure. It's pretty low on my list of priorities. Most us
On 03/31/2010 02:19 PM, Blue Swirl wrote:
On 3/31/10, Anthony Liguori wrote:
On 03/27/2010 05:11 PM, Blue Swirl wrote:
Move target specific functions and RAM handling to arch_init.c.
Add a flag to QEMUOptions structure to indicate for which
architectures the option is allowed, chec
On 03/31/2010 02:07 PM, Michael S. Tsirkin wrote:
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
On Wed, 31 Mar 2010 13:26:23 -0500
Anthony Liguori wrote:
On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
From: David L Stevens
vhost driver in qemu didn't
On 03/31/2010 02:19 PM, Blue Swirl wrote:
On 3/31/10, Anthony Liguori wrote:
On 03/27/2010 05:11 PM, Blue Swirl wrote:
Move target specific functions and RAM handling to arch_init.c.
Add a flag to QEMUOptions structure to indicate for which
architectures the option is allowed, chec
On 3/31/10, Anthony Liguori wrote:
> On 03/27/2010 05:11 PM, Blue Swirl wrote:
>
> > Move target specific functions and RAM handling to arch_init.c.
> >
> > Add a flag to QEMUOptions structure to indicate for which
> > architectures the option is allowed, check the flag
> > in run time and remove
On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote:
> On Wed, 31 Mar 2010 13:26:23 -0500
> Anthony Liguori wrote:
>
> > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > > From: David L Stevens
> > >
> > > vhost driver in qemu didn't ack features, and this happens
> > > to work b
On Wed, Mar 31, 2010 at 08:08:52PM +0300, Blue Swirl wrote:
> On 3/31/10, Paolo Bonzini wrote:
> > On 03/26/2010 08:02 PM, Blue Swirl wrote:
> > > Comments, anyone?
> >
> > Sorry I'm late.
> >
> > I don't really like the changes introduced here, because they make
> > devices very very tied to
On Wed, 31 Mar 2010 13:26:23 -0500
Anthony Liguori wrote:
> On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
> > From: David L Stevens
> >
> > vhost driver in qemu didn't ack features, and this happens
> > to work because we don't really require any features. However,
> > it's better not to rely
On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote:
From: David L Stevens
vhost driver in qemu didn't ack features, and this happens
to work because we don't really require any features. However,
it's better not to rely on this. This patch passes features to
vhost as guest acks them.
Signed-off-b
From: David L Stevens
vhost driver in qemu didn't ack features, and this happens
to work because we don't really require any features. However,
it's better not to rely on this. This patch passes features to
vhost as guest acks them.
Signed-off-by: David L Stevens
Signed-off-by: Michael S. Tsirk
On Wed, 31 Mar 2010 17:46:59 +0200
Kevin Wolf wrote:
> virtio_blk_req_complete frees the request, so we can't access it any more when
> calling bdrv_mon_event. Use the pointer that was copied earlier.
Urgh, of course that I assume that by freeing 'req' we don't free 'req->dev'.
To make this a
The code processing incoming & sending outgoing messages from/to
clients used embedded magic numbers for all message IDs. This
made the code a little hard to follow. Add constants in the vnc.h
header file for all message IDs and use them in the code
Signed-off-by: Daniel P. Berrange
---
vnc.c |
On 03/31/2010 05:20 AM, Juan Quintela wrote:
Shahar Havivi wrote:
Two new monitor commands: adding ability to handle which keyboard qemu will
use and to see which keyboard are currently available.
+int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
+{
+
On Wed, Mar 31, 2010 at 12:07:51PM -0500, Anthony Liguori wrote:
> On 03/31/2010 11:45 AM, Daniel P. Berrange wrote:
> >diff --git a/vnc.h b/vnc.h
> >index 0a7487b..8752de0 100644
> >--- a/vnc.h
> >+++ b/vnc.h
> >@@ -276,6 +276,57 @@ enum {
> > #define VNC_FEATURE_COPYRECT_MASK(1<< VN
On 3/31/10, Paolo Bonzini wrote:
> On 03/26/2010 08:02 PM, Blue Swirl wrote:
> > Comments, anyone?
>
> Sorry I'm late.
>
> I don't really like the changes introduced here, because they make
> devices very very tied to the boards. Hopefully this could be changed
> one day with qdev, and patch
On 03/31/2010 11:45 AM, Daniel P. Berrange wrote:
diff --git a/vnc.h b/vnc.h
index 0a7487b..8752de0 100644
--- a/vnc.h
+++ b/vnc.h
@@ -276,6 +276,57 @@ enum {
#define VNC_FEATURE_COPYRECT_MASK(1<< VNC_FEATURE_COPYRECT)
+/* Client -> Server message IDs */
+#define VNC_MSG_CLIENT_
Markus Armbruster wrote:
> Juan Quintela writes:
>> I still think that adding an "id" property as in markus proposal would
>> be neat. Otherwise I don't know how you are going to distinguish
>> between two keyboards with the same name.
>
> If I understand the patch correctly (only time for a qui
The code processing incoming & sending outgoing messages from/to
clients used embedded magic numbers for all message IDs. This
made the code a little hard to follow. Add constants in the vnc.h
header file for all message IDs and use them in the code
Signed-off-by: Daniel P. Berrange
---
vnc.c |
On 03/16/2010 01:18 PM, Alexander Graf wrote:
Older Linux guests don't activate the bus master enable bit. So for those we
can just try to be clever and track if they set the DEVICE_OK bit even though
bus mastering is still disabled.
Under that condition we can disable the windows safety check.
On 03/14/2010 03:41 PM, Shahar Havivi wrote:
Patch 2d753894c7553d6a05e8fdbed5f4704398919a35 was missing this check,
when running monitor as /dev/tty and other serial device, i.e:
qemu -monitor /dev/tty -serial /dev/pts/1
Without this patch any serial device will override the monitor stored
at
On 03/14/2010 06:19 AM, Max Reitz wrote:
Mass Storage Reset and Get Max LUN are class specific requests, but
they were not marked as such in hw/usb-msd.c, moved therefore
ClassInterfaceRequest and ClassInterfaceOutRequest from hw/usb-net.c
to hw/usb.h.
Furthermore there was a problem in hw/usb-oh
On 03/26/2010 08:02 PM, Blue Swirl wrote:
> Comments, anyone?
Sorry I'm late.
I don't really like the changes introduced here, because they make
devices very very tied to the boards. Hopefully this could be changed
one day with qdev, and patches like this make this task more complicated.
One exa
virtio_blk_req_complete frees the request, so we can't access it any more when
calling bdrv_mon_event. Use the pointer that was copied earlier.
Signed-off-by: Kevin Wolf
---
hw/virtio-blk.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-
On Wed, Mar 31, 2010 at 05:31:49PM +0200, Markus Armbruster wrote:
> Date: Wed, 31 Mar 2010 17:31:49 +0200
> From: Markus Armbruster
> To: Juan Quintela
> Cc: Shahar Havivi , qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands:
> 'keyboard_set' and 'info keyb
On Wed, Mar 31, 2010 at 05:23:46PM +0200, Markus Armbruster wrote:
> Date: Wed, 31 Mar 2010 17:23:46 +0200
> From: Markus Armbruster
> To: Shahar Havivi
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH 1/2] Support for multiple keyboard devices
>
> Shahar Havivi writes:
>
> > Cur
Juan Quintela writes:
> Shahar Havivi wrote:
>> Two new monitor commands: adding ability to handle which keyboard qemu will
>> use and to see which keyboard are currently available.
>
>> +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
>> +{
>> +QEMUPutKbdEntry *cur
balloon.c contained some code from monitor.c, so it was compiled
once per target. Fix this.
Signed-off-by: Paolo Bonzini
---
Makefile.objs |2 +-
Makefile.target |2 +-
kvm.h |9 +
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Makefile.objs b/Mak
With more files from outside the hw/ directory being placed into
libhw, avoid the need to include hw/hw.h for the sake of targ_phys_addr_t.
Signed-off-by: Paolo Bonzini
---
cpu-common.h|8
hw/hw.h |2 --
hw/poison.h => poison.h |0
3 files changed
Shahar Havivi writes:
> Currently you get segfault when trying to remove keyboard (device_del
> monitor command) because no keyboard handling is done.
>
> This patch add QEMUPutKbdEntry structure, handling each keyboard entry.
> Adding a keyboard add to the list, removing keyboard select the prev
Markus Armbruster wrote:
> Shahar Havivi writes:
>
>> On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
> [...]
>>> Since the index is not a stable identifier of keyboards, and we support
>>> multiple monitors, you're prone to remove the wrong keyboard.
>>>
>>> Monitor#1
On Wed, Mar 31, 2010 at 05:10:22PM +0200, Markus Armbruster wrote:
> Date: Wed, 31 Mar 2010 17:10:22 +0200
> From: Markus Armbruster
> To: Shahar Havivi
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands:
> 'keyboard_set' and 'info keybaord'
>
> Shahar Ha
On Wed, Mar 31, 2010 at 12:12:15PM +0200, Juan Quintela wrote:
> Date: Wed, 31 Mar 2010 12:12:15 +0200
> From: Juan Quintela
> To: Shahar Havivi
> Cc: qemu-devel@nongnu.org
> Subject: Re: [PATCH 1/2] Support for multiple keyboard devices
>
> Shahar Havivi wrote:
> > Currently you get segfault w
Shahar Havivi writes:
> On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote:
[...]
>> Since the index is not a stable identifier of keyboards, and we support
>> multiple monitors, you're prone to remove the wrong keyboard.
>>
>> Monitor#1 Monitor#2
>>
Signed-off-by: Paolo Bonzini
---
Makefile.target |2 +-
balloon.c | 145 +++
balloon.h |7 +++
monitor.c | 85
vl.c| 34 -
5 files changed, 153 insertions(+)
Signed-off-by: Paolo Bonzini
---
hw/i8259.c |1 +
hw/isa-bus.c |1 +
vl.c |4
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/i8259.c b/hw/i8259.c
index 3de22e3..37ef04e 100644
--- a/hw/i8259.c
+++ b/hw/i8259.c
@@ -68,6 +68,7 @@ static int irq_level[16
Rebased after Blue Swirl's changes.
Paolo Bonzini (3):
move socket_init to qemu-sockets.c
move two variable declarations out of vl.c
move balloon handling to balloon.c
Makefile.target |2 +-
balloon.c | 145 +++
balloon.h
Signed-off-by: Paolo Bonzini
---
qemu-sockets.c | 24
qemu_socket.h |1 +
vl.c | 24
3 files changed, 25 insertions(+), 24 deletions(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index 23c3def..a7399aa 100644
--- a/qemu-socke
Signed-off-by: Paolo Bonzini
---
exec-all.h |4
target-i386/translate.c |2 ++
target-mips/translate.c |2 ++
target-sh4/translate.c |2 ++
target-sparc/translate.c |3 +++
translate-all.c |8
6 files changed, 9 insertions(+), 12 de
On Tue, 30 Mar 2010 22:09:29 +0800
sploving wrote:
> Hello,
>My name is Baozeng and I am a graduate student from Beijing, China. I
> would like to join this year's gsoc. I am interested in the project
> "Shared memory transport between guest(s) and host" in the idea list.
> Its mentor is Avi
On (Wed) Mar 31 2010 [15:53:59], Gerd Hoffmann wrote:
>> /* Callback function that's called when the guest sends us data */
>> -static size_t flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t
>> len)
>> +static void flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t
>> len)
/* Callback function that's called when the guest sends us data */
-static size_t flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t len)
+static void flush_buf(VirtIOSerialPort *port, const uint8_t *buf, size_t len)
{
VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
-
Kevin Wolf wrote:
> What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
> callers of the old function are converted to the new one. In some places they
> even know the right format, so they should have used bdrv_open2 from the
> beginning.
>
> Signed-off-by: Kevin Wolf
I w
Am 31.03.2010 15:08, schrieb Juan Quintela:
> Kevin Wolf wrote:
>> What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
>> callers of the old function are converted to the new one. In some places they
>> even know the right format, so they should have used bdrv_open2 from the
Kevin Wolf wrote:
> What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
> callers of the old function are converted to the new one. In some places they
> even know the right format, so they should have used bdrv_open2 from the
> beginning.
>
> Signed-off-by: Kevin Wolf
I w
What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
callers of the old function are converted to the new one. In some places they
even know the right format, so they should have used bdrv_open2 from the
beginning.
Signed-off-by: Kevin Wolf
---
block.c | 24
Amit Shah wrote:
> Hello,
>
> These patches rework the way ports are announced to the guests. A
> control message is used to let the guest know a new port is
> added. Initial port discovery and port hot-plug work via this way now.
>
> This was done to have the host and guest port numbering in sync
Wenhao Xu wrote:
> Hi, Juan,
>I am fresh to both QEMU and KVM. But so far, I notice that QEMU
> uses "KVM_SET_USER_MEMORY_REGION" to set memory region that KVM can
> use and uses cpu_register_physical_memory_offset to register the same
> memory to QEMU emulator, which means QEMU and KVM use th
Amit Shah wrote:
Hi
> +buf_size = iov_size(elem.out_sg, elem.out_num);
> +buf = qemu_malloc(buf_size);
> +ret = iov_to_buf(elem.out_sg, elem.out_num, buf, 0, buf_size);
This is independent of the this series, but I think this idiom is going
to be very common,
On 03/31/10 06:37, Gerhard Wiesinger wrote:
On Mon, 29 Mar 2010, Gerd Hoffmann wrote:
On 03/29/10 15:51, Kevin Wolf wrote:
It actually searches the queue in case tag != s->current->tag, and it
should most likely do the same for s->current == NULL ...
Attached patch makes the rom boot for me.
If adding of ports or devices in the guest fails we can send out a QMP
event so that management software can deal with it.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-ser
Shahar Havivi wrote:
> Two new monitor commands: adding ability to handle which keyboard qemu will
> use and to see which keyboard are currently available.
> +int do_keyboard_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
> +{
> +QEMUPutKbdEntry *cursor;
> +int index = qdict_ge
Shahar Havivi wrote:
> Currently you get segfault when trying to remove keyboard (device_del
> monitor command) because no keyboard handling is done.
>
> This patch add QEMUPutKbdEntry structure, handling each keyboard entry.
> Adding a keyboard add to the list, removing keyboard select the previo
The check for a 0-sized write request to a guest port is not necessary;
the while loop below won't be executed in this case and all will be
fine.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-serial-bus.c
[ Moving internal discussion to upstream list - with right address now ]
Am 30.03.2010 17:44, schrieb Juan Quintela:
> Kevin Wolf wrote:
>> Am 30.03.2010 16:21, schrieb Juan Quintela:
>
>>
>> So you would have a function that "almost closes" the image and another
>> one that basically re-opens,
Current control messages are small enough to not be split into multiple
buffers but we could run into such a situation in the future or a
malicious guest could cause such a situation.
So handle the entire iov request for control messages.
Also ensure the size of the control request is >= what we
Data should be written only when ports are open.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 33083af..236e300 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/vi
From: Thomas Monjalon
There was a pointer cast warning on Ubuntu since _FORTIFY_SOURCE has been
reenabled.
_FORTIFY_SOURCE had been disabled by 4a24470497360d8b77568b83008d0e9d6eb0787d
and reenabled by 849583050d5f6f782718be8cb50688978973fbea.
Signed-off-by: Thomas Monjalon
---
hw/e1000.c |
Signed-off-by: Amit Shah
---
hw/virtio-console.c|2 +-
hw/virtio-serial-bus.c |2 +-
hw/virtio-serial.h |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 17b221d..6b8 100644
--- a/hw/virtio-console.c
+++ b
On Mon, Mar 29, 2010 at 11:59:24PM +0300, Avi Kivity wrote:
> On 03/28/2010 10:48 PM, Cam Macdonell wrote:
>> On Sat, Mar 27, 2010 at 11:48 AM, Avi Kivity wrote:
>>
>>> On 03/26/2010 07:14 PM, Cam Macdonell wrote:
>>>
> I'm not familiar with the uio internals, but for th
Current guests don't send more than one iov but it can change later.
Ensure we handle that case.
Signed-off-by: Amit Shah
CC: Avi Kivity
---
hw/virtio-serial-bus.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
The virtio-net code uses iov_fill() which fills an iov from a linear
buffer. The virtio-serial-bus code does something similar in an
open-coded function.
Create a new iov.c file that has iov_from_buf().
Convert virtio-net and virtio-serial-bus over to use this functionality.
virtio-net used ints
iov_to_buf() puts the buffer contents in the iov in a linearized buffer.
iov_size() gets the length of the contents in the iov.
The iov_to_buf() function is the memcpy_to_iovec() function that was
used in virtio-ballon.c.
Signed-off-by: Amit Shah
---
hw/iov.c| 37
Two new monitor commands: adding ability to handle which keyboard qemu will
use and to see which keyboard are currently available.
$ info keyboard
$ keyboard_set
Signed-off-by: Shahar Havivi
---
console.h |4 ++
input.c | 101 +
Currently you get segfault when trying to remove keyboard (device_del
monitor command) because no keyboard handling is done.
This patch add QEMUPutKbdEntry structure, handling each keyboard entry.
Adding a keyboard add to the list, removing keyboard select the previous
keyboard in list.
Signed-of
v3:
Changes by Markus comments,
Patch #1 Change keyboard list pointer to qemu tail queue
Patch #2 Add static index to keyboard entry
Remove unused error messages
Qemu support for multiple keyboard devices:
Patch #1 adding keyboard is done to list instead of "last added keyboard
Before the earlier patch, we relied on incorrect virtio api usage to
signal to the guest that a particular buffer wasn't consumed by the
host.
After fixing that, we now just discard the data the guest sends us while
a host port is disconnected or doesn't have a handler registered for
consuming dat
Individual ports can now signal to the virtio-serial core to stop
sending data if the ports cannot immediately handle new data. When a
port later unthrottles, any data queued up in the virtqueue are sent to
the port.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 24 +++
We cannot indicate to the guest how much data was consumed by an app for
out_bufs. So we just have to assume the apps will consume all the data
that are handed over to them.
Fix the virtio api abuse in control_out() and handle_output().
Signed-off-by: Amit Shah
---
hw/virtio-console.c|
Allow the port 'id's to be set by a user on the command line. This is
needed by management apps that will want a stable port numbering scheme
for hot-plug/unplug and migration.
Since the port numbers are shared with the guest (to identify ports in
control messages), we just send a control message
The virtio-serial code doesn't mix declarations and definitions, so
separate them out on different lines.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 00e8616
If the host connection to a port is closed on the destination machine
after migration, whereas the connection was open on the source, the
guest has to be informed of that.
Similar for a host connection open on the destination.
Signed-off-by: Amit Shah
---
hw/virtio-serial-bus.c | 11 +
If some ports that were hot-plugged on the source are not available on
the destination, fail migration instead of trying to deref a NULL
pointer.
Signed-off-by: Amit Shah
Reported-by: Juan Quintela
---
hw/virtio-serial-bus.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff
The number of ports on the source as well as the destination machines
should match. If they don't, it means some ports that got hotplugged on
the source aren't instantiated on the destination. Or that ports that
were hot-unplugged on the source are created on the destination.
Signed-off-by: Amit S
The target could be started with max_nr_ports for a virtio-serial device
lesser than what was available on the source machine. Fail the migration
in such a case.
Signed-off-by: Amit Shah
Reported-by: Juan Quintela
---
hw/virtio-serial-bus.c | 13 +++--
1 files changed, 11 insertions(+
Hello,
These patches rework the way ports are announced to the guests. A
control message is used to let the guest know a new port is
added. Initial port discovery and port hot-plug work via this way now.
This was done to have the host and guest port numbering in sync to
avoid surprises after seve
1 - 100 of 101 matches
Mail list logo
