[Qemu-devel] KVM call agenda for Mar 23

2010-03-22 Thread Chris Wright
Please send in any agenda items you are interested in covering. Yes, usability is a valid topic esp. if you promise to come w/ GUI patches. thanks, -chris

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

2010-03-22 Thread Aurelien Jarno
On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote: > Hi! > > I just wanted to make another FreeBSD qemu git head snaphot port update, > and found both i386-softmmu and x86_64-softmmu no longer boot, they seem > to hang early in the bios before it prints anything, last tb seems to be >

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 07:49 PM, Paul Brook wrote: Solutions: - VirtIOPCIBus and hang devices from there (anthony). Why? because this is a simulated pci bus, we can implement the features that we need (not full pci) in the three showed architectures. We will have VirtIOPCIBLock everywhere, and i

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 04:00 PM, Paul Brook wrote: On 03/22/2010 11:16 AM, Paul Brook wrote: But look at the lguest virtio implement. We would definitely model a VirtIOBus if we implemented something like that in qemu. VirtIO really is designed to be a bus. When you say "bus" you actua

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Paul Brook
>Solutions: >- VirtIOPCIBus and hang devices from there (anthony). Why? because > this is a simulated pci bus, we can implement the features that we > need (not full pci) in the three showed architectures. We will have > VirtIOPCIBLock everywhere, and its VirtIOPCIBus implmentation will > h

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Cole Robinson
On 03/22/2010 05:33 PM, Gerd Hoffmann wrote: > Hi, > >> Stepping back a bit first, there are the two core areas in which >> people can >> be limited by libvirt currently. > >> 2. Command line flags > > For me: This one, and monitor access. > > libvirt is very unfriendly to qemu hackers. T

[Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Mon, Mar 22, 2010 at 03:51:43PM +, Paul Brook wrote: >> > > It's a classic OOP problem. >> > > >> > > VirtIOBlock is-a VirtIODevice, VirtIODevice is-a DeviceState >> > > >> > > VirtIOPCI is-a PCIDevice, PCIDevice is-a Device State. >> > > >> > > But VirtIODevic

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Anthony Liguori
On 03/22/2010 04:33 PM, Gerd Hoffmann wrote: Hi, Stepping back a bit first, there are the two core areas in which people can be limited by libvirt currently. 2. Command line flags For me: This one, and monitor access. libvirt is very unfriendly to qemu hackers. There is no easy way

[Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Anthony Liguori
On 03/22/2010 03:10 PM, Daniel P. Berrange wrote: This isn't necessarily libvirt's problem if it's mission is to provide a common hypervisor API that covers the most commonly used features. That is more or less our current mission. If this mission leads to QEMU creating a non-libvirt based

[Qemu-devel] Re: git head broken? (x86 softmmu w/o kvm)

2010-03-22 Thread Juergen Lock
On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote: > Hi! > > I just wanted to make another FreeBSD qemu git head snaphot port update, > and found both i386-softmmu and x86_64-softmmu no longer boot, they seem > to hang early in the bios before it prints anything, last tb seems to be >

Re: [Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Gerd Hoffmann
Hi, Stepping back a bit first, there are the two core areas in which people can be limited by libvirt currently. 2. Command line flags For me: This one, and monitor access. libvirt is very unfriendly to qemu hackers. There is no easy way to add command line switches. There is no ea

[Qemu-devel] git head broken? (x86 softmmu w/o kvm)

2010-03-22 Thread Juergen Lock
Hi! I just wanted to make another FreeBSD qemu git head snaphot port update, and found both i386-softmmu and x86_64-softmmu no longer boot, they seem to hang early in the bios before it prints anything, last tb seems to be this loop: IN: 0x000f1b8e: mov0xf81a0,%ecx

Re: [Qemu-devel] [patch 1/2] Pass QEMUIOWorker to qemu_notify_event

2010-03-22 Thread Anthony Liguori
On 03/11/2010 08:45 PM, Marcelo Tosatti wrote: This can be used later to introduce generic iothread workers. Signed-off-by: Marcelo Tosatti Could you rebase this? It failed to apply in a strange way that made me nervous... Regards, Anthony Liguori Index: qemu-ioworker/async.c ==

Re: [Qemu-devel] [PATCHv6 08/11] vhost: vhost net support

2010-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2010 at 03:58:58PM -0500, Anthony Liguori wrote: > On 03/17/2010 06:08 AM, Michael S. Tsirkin wrote: >> This adds vhost net device support in qemu. Will be tied to tap device >> and virtio by following patches. Raw backend is currently missing, >> will be worked on/submitted separa

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Paul Brook
> On 03/22/2010 11:16 AM, Paul Brook wrote: > >> But look at the lguest virtio implement. We would definitely model a > >> VirtIOBus if we implemented something like that in qemu. VirtIO really > >> is designed to be a bus. > > > > When you say "bus" you actually mean point-point connection, righ

Re: [Qemu-devel] [PATCHv6 08/11] vhost: vhost net support

2010-03-22 Thread Anthony Liguori
On 03/17/2010 06:08 AM, Michael S. Tsirkin wrote: This adds vhost net device support in qemu. Will be tied to tap device and virtio by following patches. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin --- Makefile.target |2 +

Re: [Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: > Hi, > > I've mentioned this to a few folks already but I wanted to start a > proper thread. > > We're struggling in qemu with usability and one area that concerns me is > the disparity in features that are supported by qemu vs w

[Qemu-devel] Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: > Hi, > > I've mentioned this to a few folks already but I wanted to start a > proper thread. > > We're struggling in qemu with usability and one area that concerns me is > the disparity in features that are supported by qemu vs w

Re: [Qemu-devel] [PATCH 03/16] Convert io handlers to QLIST

2010-03-22 Thread Anthony Liguori
On 03/11/2010 10:55 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela Applied 3-7, thanks. Regards, Anthony Liguori --- vl.c | 35 ++- 1 files changed, 14 insertions(+), 21 deletions(-) diff --git a/vl.c b/vl.c index 10d8e34..051eb1c 100644 ---

Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers

2010-03-22 Thread Anthony Liguori
On 03/11/2010 08:48 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity --- CODING_STYLE |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index a579cb1..92036f3 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -49,6 +49,9 @@ and is therefore lik

[Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-22 Thread Anthony Liguori
Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's implemented in libvirt. This isn't necessarily libvirt's problem if

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 11:16 AM, Paul Brook wrote: But look at the lguest virtio implement. We would definitely model a VirtIOBus if we implemented something like that in qemu. VirtIO really is designed to be a bus. When you say "bus" you actually mean point-point connection, right[1]? I don't se

[Qemu-devel] [PATCH] Fix bsd-user broken by commit b5ec5ce0e39d6e7ea707d5604a5f6d567dfd2f48

2010-03-22 Thread Juergen Lock
Signed-off-by: Juergen Lock --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -759,6 +759,10 @@ int main(int argc, char **argv) } cpu_model = NULL; +#if defined(cpudef_setup) +cpudef_setup(); /* parse cpu definitions in target config file (TBD) */ +#endif + optind = 1; for(

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2010 at 03:51:43PM +, Paul Brook wrote: > > > It's a classic OOP problem. > > > > > > VirtIOBlock is-a VirtIODevice, VirtIODevice is-a DeviceState > > > > > > VirtIOPCI is-a PCIDevice, PCIDevice is-a Device State. > > > > > > But VirtIODevice is-a VirtIOPCI device isn't always t

[Qemu-devel] Re: How to create multiplexed chardevs?

2010-03-22 Thread Jan Kiszka
Gerd Hoffmann wrote: > On 03/22/10 17:39, Jan Kiszka wrote: >> Hi Gerd, >> >> I think you mostly worked on this: >> >> How to specify -serial mon:stdio using the new syntax? I just ran into >> the problem having to define a serial port via -device isa-serial but >> wanting its terminal multiplexed

[Qemu-devel] Re: How to create multiplexed chardevs?

2010-03-22 Thread Gerd Hoffmann
On 03/22/10 17:39, Jan Kiszka wrote: Hi Gerd, I think you mostly worked on this: How to specify -serial mon:stdio using the new syntax? I just ran into the problem having to define a serial port via -device isa-serial but wanting its terminal multiplexed with a monitor. -chardev mon:stdio is no

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread john cooper
Jamie Lokier wrote: > john cooper wrote: >> All that said, I like the alternate choice of adding a >> special virtio request far better. It is actually simpler >> (and more maintainable IMO) than going through the >> gyrations of stuffing the S/N data through PCI config >> space. > > And it needn

[Qemu-devel] How to create multiplexed chardevs?

2010-03-22 Thread Jan Kiszka
Hi Gerd, I think you mostly worked on this: How to specify -serial mon:stdio using the new syntax? I just ran into the problem having to define a serial port via -device isa-serial but wanting its terminal multiplexed with a monitor. -chardev mon:stdio is not understood. BTW, there is are thousa

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread Jamie Lokier
john cooper wrote: > All that said, I like the alternate choice of adding a > special virtio request far better. It is actually simpler > (and more maintainable IMO) than going through the > gyrations of stuffing the S/N data through PCI config > space. And it needn't have a 20 character limit.

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Paul Brook
> But look at the lguest virtio implement. We would definitely model a > VirtIOBus if we implemented something like that in qemu. VirtIO really > is designed to be a bus. When you say "bus" you actually mean point-point connection, right[1]? I don't see anything in virtio that allows arbitration

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Paul Brook
> > It's a classic OOP problem. > > > > VirtIOBlock is-a VirtIODevice, VirtIODevice is-a DeviceState > > > > VirtIOPCI is-a PCIDevice, PCIDevice is-a Device State. > > > > But VirtIODevice is-a VirtIOPCI device isn't always true so it can't be > > an is-a relationship. Initially, this was true and

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 10:17 AM, Michael S. Tsirkin wrote: On Mon, Mar 22, 2010 at 10:03:29AM -0500, Anthony Liguori wrote: On 03/22/2010 09:50 AM, Michael S. Tsirkin wrote: On Mon, Mar 22, 2010 at 09:49:03AM -0500, Anthony Liguori wrote: On 03/22/2010 08:30 AM, Paul Brook wrote:

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2010 at 10:03:29AM -0500, Anthony Liguori wrote: > On 03/22/2010 09:50 AM, Michael S. Tsirkin wrote: >> On Mon, Mar 22, 2010 at 09:49:03AM -0500, Anthony Liguori wrote: >> >>> On 03/22/2010 08:30 AM, Paul Brook wrote: >>> > A VirtIOBlock device cannot be a VirtIODevice

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread Paul Brook
> > John attempted this and it was reverted because the implementation > > exhausted the PCI config space. > > I don't understand that. Existig hardware devices dump much more of > their data such as vendor and model type information into the config > space, how can using a field that real hardwar

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread john cooper
Marc Haber wrote: Hi, On Mon, Mar 22, 2010 at 02:26:11AM -0400, john cooper wrote: This is a tad ironic as that is how this saga begun. Namely stuffing 20 bytes of serial number string into the virtio-blk PCI config space on qemu's side and pushing it over to the guest driver. I exposed this

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 09:50 AM, Michael S. Tsirkin wrote: On Mon, Mar 22, 2010 at 09:49:03AM -0500, Anthony Liguori wrote: On 03/22/2010 08:30 AM, Paul Brook wrote: A VirtIOBlock device cannot be a VirtIODevice while being a VirtIOPCIProxy (proxy is a poor name, btw). It really ought to be:

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2010 at 09:49:03AM -0500, Anthony Liguori wrote: > On 03/22/2010 08:30 AM, Paul Brook wrote: >>> A VirtIOBlock device cannot be a VirtIODevice while being a >>> VirtIOPCIProxy (proxy is a poor name, btw). >>> >>> It really ought to be: >>> >>> DeviceState -> VirtIODevice -> VirtIO

[Qemu-devel] Re: virtio block device and sysfs

2010-03-22 Thread Anthony Liguori
On 03/22/2010 09:46 AM, Michael S. Tsirkin wrote: On Tue, Mar 09, 2010 at 03:34:07PM -0600, Anthony Liguori wrote: John attempted this and it was reverted because the implementation exhausted the PCI config space. Not config space really, John's implementation put ATA_IDENTITY (512 by

[Qemu-devel] Re: virtio block device and sysfs

2010-03-22 Thread Michael S. Tsirkin
On Tue, Mar 09, 2010 at 03:34:07PM -0600, Anthony Liguori wrote: > John attempted this and it was reverted because the implementation > exhausted the PCI config space. Not config space really, John's implementation put ATA_IDENTITY (512 bytes) in PCI IO memory, PCI spec limits each such BAR to 2

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Anthony Liguori
On 03/22/2010 08:30 AM, Paul Brook wrote: A VirtIOBlock device cannot be a VirtIODevice while being a VirtIOPCIProxy (proxy is a poor name, btw). It really ought to be: DeviceState -> VirtIODevice -> VirtIOBlock and: PCIDevice -> VirtIOPCI : implements VirtIOBus The interface between the

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread john cooper
Marc Haber wrote: > Hi, > > On Tue, Mar 09, 2010 at 03:34:07PM -0600, Anthony Liguori wrote: >> On 03/06/2010 04:42 PM, Marc Haber wrote: >>> My goal is to have a possibility to give a "speaking" name to any >>> block device handed into a guest instance by the host. That name >>> should be visible

[Qemu-devel] Re: Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Juan Quintela
Jan Kiszka wrote: > Juan Quintela wrote: >> Jan Kiszka wrote: >>> Juan Quintela wrote: Bruce Majia wrote: > Hi, > > When I built qemu on my x86_32 host with following configure line: > try to do first a: make distclean > $ ./configure --prefix=/usr/local/q

[Qemu-devel] Re: Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Jan Kiszka
Juan Quintela wrote: > Jan Kiszka wrote: >> Juan Quintela wrote: >>> Bruce Majia wrote: Hi, When I built qemu on my x86_32 host with following configure line: >>> try to do first a: >>> make distclean >>> $ ./configure --prefix=/usr/local/qemus/master \ --target-l

[Qemu-devel] Re: Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Juan Quintela
Jan Kiszka wrote: > Juan Quintela wrote: >> Bruce Majia wrote: >>> Hi, >>> >>> When I built qemu on my x86_32 host with following configure line: >>> >> >> try to do first a: >> make distclean >> >>> $ ./configure --prefix=/usr/local/qemus/master \ >>> --target-list=i386-softmmu >>> $ make

[Qemu-devel] Re: Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Jan Kiszka
Juan Quintela wrote: > Bruce Majia wrote: >> Hi, >> >> When I built qemu on my x86_32 host with following configure line: >> > > try to do first a: > make distclean > >> $ ./configure --prefix=/usr/local/qemus/master \ >> --target-list=i386-softmmu >> $ make > > there are several config.h

Re: [Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Paul Brook
> A VirtIOBlock device cannot be a VirtIODevice while being a > VirtIOPCIProxy (proxy is a poor name, btw). > > It really ought to be: > > DeviceState -> VirtIODevice -> VirtIOBlock > > and: > > PCIDevice -> VirtIOPCI : implements VirtIOBus > > The interface between the VirtIODevice and VirtIO

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread Marc Haber
Hi, On Mon, Mar 22, 2010 at 02:26:11AM -0400, john cooper wrote: > This is a tad ironic as that is how this saga begun. Namely stuffing > 20 bytes of serial number string into the virtio-blk PCI config space > on qemu's side and pushing it over to the guest driver. I exposed this > to the guest

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread Marc Haber
Hi, On Tue, Mar 09, 2010 at 03:34:07PM -0600, Anthony Liguori wrote: > On 03/06/2010 04:42 PM, Marc Haber wrote: >> My goal is to have a possibility to give a "speaking" name to any >> block device handed into a guest instance by the host. That name >> should be visible inside the guest, just as a

[Qemu-devel] [PATCH v2 1/2] qdev: Convert qdev_unplug() to QError

2010-03-22 Thread Markus Armbruster
Note: our device unplug methods don't need conversion work, because they can't currently fail. Signed-off-by: Markus Armbruster --- hw/qdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index f45ed0f..c521115 100644 --- a/hw/qdev.c +++ b/hw/qd

[Qemu-devel] [PATCH v2 2/2] monitor: convert do_device_del() to QObject, QError

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/qdev.c |8 hw/qdev.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index c521115..d3bf0fa 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -799,15 +799,15 @@ in

[Qemu-devel] [PATCH v2 0/2] monitor: convert do_device_del() to QObject, QError

2010-03-22 Thread Markus Armbruster
v2: Supply a missing error conversion pointed out by Luiz Markus Armbruster (2): qdev: Convert qdev_unplug() to QError monitor: convert do_device_del() to QObject, QError hw/qdev.c | 11 +-- hw/qdev.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 8 insertions(

[Qemu-devel] Re: [PATCH v2 00/11] monitor: New commands netdev_add, netdev_del

2010-03-22 Thread Markus Armbruster
Note: This series depends on "[PATCH v2 0/6] error: Clean up after recent changes".

[Qemu-devel] [PATCH 6/7] blkdebug: Add events and rules

2010-03-22 Thread Kevin Wolf
Block drivers can trigger a blkdebug event whenever they reach a place where it could be useful to inject an error for testing/debugging purposes. Rules are read from a blkdebug config file and describe which action is taken when an event is triggered. For now this is only injecting an error (with

[Qemu-devel] [PATCH 7/7] qcow2: Trigger blkdebug events

2010-03-22 Thread Kevin Wolf
This adds blkdebug events to qcow2 to allow injecting I/O errors in specific places. Signed-off-by: Kevin Wolf --- block.h| 44 block/blkdebug.c | 42 ++ block/qcow2-cluster.c | 15 +

[Qemu-devel] [PATCH 5/7] Make qemu-config available for tools

2010-03-22 Thread Kevin Wolf
To be able to use config files for blkdebug, we need to make these functions available in the tools. This involves moving two functions that can only be built in the context of the emulator. Signed-off-by: Kevin Wolf --- Makefile.objs|4 ++-- hw/qdev-properties.c | 19 +

[Qemu-devel] [PATCH 4/7] blkdebug: Inject errors

2010-03-22 Thread Kevin Wolf
Add a mechanism to inject errors instead of passing requests on. With no further patches applied, you can use it by setting inject_errno in gdb. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 81 ++ 1 files changed, 81 insertions(+), 0 dele

[Qemu-devel] [PATCH 1/7] qemu-config: qemu_read_config_file() reads the normal config file

2010-03-22 Thread Kevin Wolf
Introduce a new function qemu_read_config_file which reads the VM configuration from a config file. Unlike qemu_config_parse it doesn't take a open file but a filename and reduces code duplication as a side effect. Signed-off-by: Kevin Wolf --- qemu-config.c | 15 +++ qemu-config.h

[Qemu-devel] [PATCH 3/7] blkdebug: Basic request passthrough

2010-03-22 Thread Kevin Wolf
This isn't doing anything interesting. It creates the blkdebug block driver as a protocol which just passes everything through to raw. Signed-off-by: Kevin Wolf --- Makefile.objs|2 +- block/blkdebug.c | 104 ++ 2 files changed, 105 in

[Qemu-devel] [PATCH 2/7] qemu-config: Make qemu_config_parse more generic

2010-03-22 Thread Kevin Wolf
qemu_config_parse gets the option groups as a parameter now instead of hardcoding the VM configuration groups. This way it can be used for other configurations, too. Signed-off-by: Kevin Wolf --- qemu-config.c | 18 -- qemu-config.h |2 +- 2 files changed, 13 insertions(+),

[Qemu-devel] [PATCH 0/7] blkdebug

2010-03-22 Thread Kevin Wolf
This patch series introduces a new block driver which acts as a protocol and whose purpose it is to fail requests. To be more precise, I want it to fail in configurable places, so that qemu-iotests can be extended with tests for the error paths (for example for the case when something with metadata

[Qemu-devel] [PATCH v2 09/11] error: Convert net_client_init() to QError

2010-03-22 Thread Markus Armbruster
The conversion is shallow: client type init() methods aren't converted. Converting them is a big job for relatively little practical benefit, so leave it for later. Signed-off-by: Markus Armbruster --- net.c | 38 ++ 1 files changed, 18 insertions(+), 20 de

[Qemu-devel] [PATCH v2 02/11] error: New QERR_DUPLICATE_ID

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 4520b0d..9fb817e 100644 --- a/qerror.c +++ b/qerror.c @@ -97,6 +97,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v2 00/11] monitor: New commands netdev_add, netdev_del

2010-03-22 Thread Markus Armbruster
v2: Avoid loss of help in parse_option_size(). Rebased. Markus Armbruster (11): error: Put error definitions back in alphabetical order error: New QERR_DUPLICATE_ID error: Convert qemu_opts_create() to QError error: New QERR_INVALID_PARAMETER_VALUE error: Convert qemu_opts_set() to QErr

[Qemu-devel] [PATCH v2 03/11] error: Convert qemu_opts_create() to QError

2010-03-22 Thread Markus Armbruster
Fixes device_add to report duplicate ID properly in QMP, as DuplicateId instead of UndefinedError. Signed-off-by: Markus Armbruster --- qemu-option.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index f83d07c..12ce322 100644 --- a/qemu

[Qemu-devel] [PATCH v2 08/11] error: Convert qemu_opts_validate() to QError

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-option.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 394c763..1ffc497 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -877,8 +877,7 @@ int qemu_opts_validate(QemuOpts *opts, const QemuO

[Qemu-devel] [PATCH v2 05/11] error: Convert qemu_opts_set() to QError

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-option.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 12ce322..394c763 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -176,7 +176,7 @@ static int parse_option_bool(const

[Qemu-devel] [PATCH v2 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/qdev.c |2 +- monitor.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 17a46a7..f45ed0f 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -207,7 +207,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)

[Qemu-devel] [PATCH v2 11/11] monitor: New commands netdev_add, netdev_del

2010-03-22 Thread Markus Armbruster
Monitor commands to go with -netdev. Signed-off-by: Markus Armbruster --- net.c | 57 ++- net.h |2 + qemu-monitor.hx | 30 3 files changed, 88 insertions(+), 1 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 10/11] error: New QERR_DEVICE_IN_USE

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 97e8d4a..8d885cd 100644 --- a/qerror.c +++ b/qerror.c @@ -69,6 +69,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v2 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse()

2010-03-22 Thread Markus Armbruster
Both functions report errors nicely enough now, no need for additional messages. Signed-off-by: Markus Armbruster --- hw/pci-hotplug.c |2 -- net.c|2 -- qemu-config.c|1 - vl.c |5 - 4 files changed, 0 insertions(+), 10 deletions(-) diff --git a/

[Qemu-devel] [PATCH v2 04/11] error: New QERR_INVALID_PARAMETER_VALUE

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 9fb817e..97e8d4a 100644 --- a/qerror.c +++ b/qerror.c @@ -121,6 +121,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v2 01/11] error: Put error definitions back in alphabetical order

2010-03-22 Thread Markus Armbruster
Add suitable comments to help keerp them in order. Signed-off-by: Markus Armbruster --- qerror.c | 12 qerror.h |8 +--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/qerror.c b/qerror.c index eaa1deb..4520b0d 100644 --- a/qerror.c +++ b/qerror.c @@ -38,6

Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o

2010-03-22 Thread Markus Armbruster
Blue Swirl writes: > On 3/18/10, Markus Armbruster wrote: >> Blue Swirl writes: >> >> > On 3/18/10, Markus Armbruster wrote: >> >> Blue Swirl writes: >> >> >> >> > On 3/17/10, Markus Armbruster wrote: >> >> >> Blue Swirl writes: >> >> >> >> >> >> > On 3/17/10, Markus Armbruster

[Qemu-devel] [PATCH v2 6/6] error: Move qerror_report() from qemu-error.[ch] to qerror.[ch]

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-error.c | 18 -- qemu-error.h |6 -- qerror.c | 20 qerror.h |5 + 4 files changed, 25 insertions(+), 24 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 9b9c0a1..57d7555 100644

[Qemu-devel] [PATCH v2 2/6] error: Trim includes in qerror.c

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qerror.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qerror.c b/qerror.c index d0aba61..ff2fbd5 100644 --- a/qerror.c +++ b/qerror.c @@ -11,9 +11,7 @@ */ #include "qjson.h" #include "qerror.h" -#include "qstring.h" #include

[Qemu-devel] [PATCH v2 1/6] error: Trim includes after "Move qemu_error & friends..."

2010-03-22 Thread Markus Armbruster
Missed in commit 2f792016. Signed-off-by: Markus Armbruster --- hw/qdev-properties.c |1 + monitor.c|2 -- sysemu.h |2 -- 3 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 92d6793..157a111 100644

[Qemu-devel] [PATCH v2 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o

2010-03-22 Thread Markus Armbruster
The location tracking interface is used by code shared with qemi-img, qemu-nbd and qemu-io, so it needs to be available there. Commit 827b0813 provides it in a rather hamfisted way: it adds a dummy implementation to qemu-tool.c. It's cleaner to provide the real thing, and put a few more dummy mon

[Qemu-devel] [PATCH v2 4/6] error: Make use of error_set_progname() optional

2010-03-22 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-error.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-error.c b/qemu-error.c index 5d5fe37..9b9c0a1 100644 --- a/qemu-error.c +++ b/qemu-error.c @@ -167,7 +167,7 @@ void error_print_loc(void) int i; const char *

[Qemu-devel] [PATCH v2 0/6] error: Clean up after recent changes

2010-03-22 Thread Markus Armbruster
Cleaner integration of location tracking with qemu-tool.c. Move qerror_report() where it belongs. v2: Remove an assertion that unreachable code can't be reached, at Blue Swirl's request. Rebased. Markus Armbruster (6): error: Trim includes after "Move qemu_error & friends..." error: Trim in

[Qemu-devel] [PATCH v2 3/6] error: Trim includes after "Infrastructure to track locations..."

2010-03-22 Thread Markus Armbruster
Missed in commit 827b0813. Signed-off-by: Markus Armbruster --- monitor.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/monitor.h b/monitor.h index bd4ae34..5bdeed1 100644 --- a/monitor.h +++ b/monitor.h @@ -3,7 +3,6 @@ #include "qemu-common.h" #include "qemu-char.

Re: [Qemu-devel] Re: >2 serial ports?

2010-03-22 Thread Avi Kivity
On 03/22/2010 10:35 AM, Michael Tokarev wrote: Paul Brook wrote at Wed, 17 Mar 2010 11:18:09 +: Oh, well, yes, I remember. qemu is more strict on ISA irq sharing now. A bit too strict. /me goes dig out a old patch which never made it upstream for some reason I forgot. Attached.

[Qemu-devel] Re: Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Juan Quintela
Bruce Majia wrote: > Hi, > > When I built qemu on my x86_32 host with following configure line: > try to do first a: make distclean > $ ./configure --prefix=/usr/local/qemus/master \ > --target-list=i386-softmmu > $ make there are several config.h & config.mak around (from old builds) you

[Qemu-devel] Re: [PATCH 0/9] Virtio cleanups

2010-03-22 Thread Michael S. Tsirkin
On Mon, Mar 22, 2010 at 02:13:48AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Sun, Mar 21, 2010 at 06:11:43PM +, Jamie Lokier wrote: > >> Michael S. Tsirkin wrote: > >> > That's version 1 of my patch. Version 2 removed even need for macro > >> > completely by moving alloc

[Qemu-devel] Re: [PATCH 1/6] error: Trim includes after "Move qemu_error & friends..."

2010-03-22 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 19 Mar 2010 22:31:05 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Wed, 17 Mar 2010 18:56:49 +0100 >> > Markus Armbruster wrote: >> > >> >> Missed in commit 2f792016. >> >> >> >> Signed-off-by: Markus Armbruster >> >> --- >> >> h

Re: [Qemu-devel] Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Bruce Majia
On Mon, Mar 22, 2010 at 09:31:09AM +0100, Stefan Weil wrote: > Bruce Majia schrieb: > > Hi, > > > > When I built qemu on my x86_32 host with following configure line: > > > > $ ./configure --prefix=/usr/local/qemus/master \ > > --target-list=i386-softmmu > > $ make > > > > The build will always fai

Re: [Qemu-devel] Re: >2 serial ports?

2010-03-22 Thread Michael Tokarev
Paul Brook wrote at Wed, 17 Mar 2010 11:18:09 +: >> Oh, well, yes, I remember. qemu is more strict on ISA irq sharing now. >> A bit too strict. >> >> /me goes dig out a old patch which never made it upstream for some >> reason I forgot. Attached. > > This is wrong. Two devices should never

Re: [Qemu-devel] Build always fail on x86_32 host for i386_softmmu target

2010-03-22 Thread Stefan Weil
Bruce Majia schrieb: > Hi, > > When I built qemu on my x86_32 host with following configure line: > > $ ./configure --prefix=/usr/local/qemus/master \ > --target-list=i386-softmmu > $ make > > The build will always fail with message: > > ... > CC i386-softmm

Re: [Qemu-devel] virtio block device and sysfs

2010-03-22 Thread john cooper
Jamie Lokier wrote: Anthony Liguori wrote: On 03/06/2010 04:42 PM, Marc Haber wrote: Hi, I am looking to get in touch with somebody who knows more about the connection between host configuration, qemu, kvm, and the virtio block device driver guest side than I know. My goal is to have a possib