[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp

2010-03-06 Thread Gleb Natapov
On Thu, Mar 04, 2010 at 02:03:54PM +0200, Gleb Natapov wrote: > > BTW, do real systems allow to hot plug BSP as well? Or how is the case > > handled when you unplug the BSP and then reboot the box? > > > Did you mean hot unplug BSP? OS determines what CPU is BSP by checking > BSP bit in APIC base

[Qemu-devel] virtio block device and sysfs

2010-03-06 Thread Marc Haber
Hi, I am looking to get in touch with somebody who knows more about the connection between host configuration, qemu, kvm, and the virtio block device driver guest side than I know. My goal is to have a possibility to give a "speaking" name to any block device handed into a guest instance by the h

Re: [Qemu-devel] [PATCH] Fix curses interaction with keymaps

2010-03-06 Thread Aurelien Jarno
On Sun, Feb 28, 2010 at 09:03:00PM +0100, Samuel Thibault wrote: > Hello, > > The combination of keymap support (-k option) and curses is currently > very broken. The patch below fixes it by first extending keymap support > to interpret the shift, ctrl, altgr and addupper keywords in keymaps, > a

Re: [Qemu-devel] [PATCH] use absolute URLs for .gitmodules

2010-03-06 Thread Aurelien Jarno
On Fri, Mar 05, 2010 at 09:08:04AM +0100, Paolo Bonzini wrote: > The relative URLs do not work when cloning a fork of qemu or when > cloning from the Savannah URL. > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > --- > .gitmodules |4 ++-- > 1 files changed, 2 insertions

Re: [Qemu-devel] [PATCH] scsi: update comment on the standards revision

2010-03-06 Thread Aurelien Jarno
On Thu, Mar 04, 2010 at 02:45:44PM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Thanks, applied. > Index: qemu/hw/scsi-disk.c > === > --- qemu.orig/hw/scsi-disk.c 2010-03-04 14:39:43.699022260 +0100 > +++ qemu

Re: [Qemu-devel] [PATCH] qemu-nbd: Fix wrong description in qemu-nbd.texi

2010-03-06 Thread Aurelien Jarno
On Thu, Mar 04, 2010 at 12:18:43AM +0900, Ryota Ozaki wrote: > -c option needs argument but it's missing now. > This patch fixes it. > > Signed-off-by: Ryota Ozaki Thanks, applied. > --- > qemu-nbd.texi |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-nbd

Re: [Qemu-devel] [PATCH] Build usb-ohci for PCs

2010-03-06 Thread Aurelien Jarno
On Wed, Mar 03, 2010 at 04:02:25PM +0100, Kevin Wolf wrote: > The OHCI emulation isn't obviously broken and there are people who want to use > it. Let's build it by default so that it can be enabled via -device. > > Signed-off-by: Kevin Wolf Thanks, applied. > --- > default-configs/i386-softmm

Re: [Qemu-devel] [PATCH 2/2] ppc440_bamboo: Disable new virtio-serial features for 0.12 machine type

2010-03-06 Thread Aurelien Jarno
On Thu, Feb 25, 2010 at 07:26:12PM +0530, Amit Shah wrote: > Disable the MULTIPORT feature and MSI vectors for the 0.12 machine > types; those features are added only for 0.13 onwards. > > Signed-off-by: Amit Shah Thanks, applied. > --- > hw/ppc440_bamboo.c | 12 > 1 files chang

Re: [Qemu-devel] [PATCH 1/2] ppc440_bamboo: Add 0.12 and 0.13 machine types for backward compat

2010-03-06 Thread Aurelien Jarno
On Thu, Feb 25, 2010 at 07:26:11PM +0530, Amit Shah wrote: > Add a 0.12 machine type for compatibility with older versions. Mark the > default one as 0.13. > > Signed-off-by: Amit Shah Thanks, applied. > --- > hw/ppc440_bamboo.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deleti

Re: [Qemu-devel] [PATCH 1/3] s390-virtio: Fix compile error for virtio-block init

2010-03-06 Thread Aurelien Jarno
On Thu, Feb 25, 2010 at 07:15:18PM +0530, Amit Shah wrote: > Commit 428c149b0be790b440e1cbee185b152cdb22feec modified the argument > that virtio_blk_init takes. Update the s390 bus code that calls this > function. > > Signed-off-by: Amit Shah > CC: Christoph Hellwig Thanks, applied. > --- > h

Re: [Qemu-devel] [PATCH] json-parser: Fix segfault on malformed input

2010-03-06 Thread Aurelien Jarno
On Wed, Feb 24, 2010 at 04:17:58PM +0100, Kevin Wolf wrote: > If the parser fails to parse the key in parse_pair, it will access a NULL > pointer. A simple way to trigger this is sending {foo} via QMP. This patch > turns the segfault into a syntax error reply. > > Signed-off-by: Kevin Wolf Thank

Re: [Qemu-devel] [PATCH] Fix segfault with ram_size > 4095M without kvm

2010-03-06 Thread Aurelien Jarno
On Thu, Mar 04, 2010 at 03:34:34PM -0600, Ryan Harper wrote: > * Aurelien Jarno [2010-03-04 15:27]: > > On Tue, Feb 23, 2010 at 06:02:15PM +0100, Aurelien Jarno wrote: > > > Ryan Harper a écrit : > > > > Currently, x86_64-softmmu qemu segfaults when trying to use > 4095M > > > > memsize. > > > >

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-06 Thread Michael S. Tsirkin
On Fri, Mar 05, 2010 at 05:40:18PM +0530, Amit Shah wrote: > On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: > > vhost needs physical addresses for ring and other queue fields, > > so add APIs for these. > > Already discussed on IRC, but mentioning here so that it doesn't get > lost: >

[Qemu-devel] Re: [PATCHv4 05/12] virtio: add APIs for queue fields

2010-03-06 Thread Michael S. Tsirkin
On Fri, Mar 05, 2010 at 06:38:35PM +0530, Amit Shah wrote: > On (Wed) Mar 03 2010 [19:16:09], Michael S. Tsirkin wrote: > > + > > +EventNotifier *virtio_queue_guest_notifier(VirtQueue *vq) > > +{ > > +return &vq->guest_notifier; > > +} > > +EventNotifier *virtio_queue_host_notifier(VirtQueue *v

[Qemu-devel] Re: [PATCHv4 09/12] vhost: vhost net support

2010-03-06 Thread Michael S. Tsirkin
On Fri, Mar 05, 2010 at 11:49:11PM +0530, Amit Shah wrote: > On (Wed) Mar 03 2010 [19:16:35], Michael S. Tsirkin wrote: > > > +static int vhost_virtqueue_init(struct vhost_dev *dev, > > +struct VirtIODevice *vdev, > > +struct vhost_vi

Re: [Qemu-devel] [PATCH] sh4 linux-user: Save/restore fpu registers to signal context.

2010-03-06 Thread Aurelien Jarno
On Thu, Feb 18, 2010 at 12:46:45AM +0900, takas...@ops.dti.ne.jp wrote: > As "todo" comment in source code. > And modify restore_sigcontext() to have three args as kernel's does. > > Signed-off-by: Takashi YOSHII Thanks, applied. > --- > linux-user/signal.c | 27 +++ >

Re: [Qemu-devel] [PATCH 05/13] cpuid: add missing CPUID feature flag names

2010-03-06 Thread Aurelien Jarno
On Tue, Feb 02, 2010 at 11:08:13AM +0100, Andre Przywara wrote: > Some CPUID feature flags had no string value, so they could not be > switched on or off from the command line. > Add names for the missing ones mentioned in the current public CPUID > specification from both Intel and AMD. Those only

Re: [Qemu-devel] [PATCH 03/13] cpuid: moved host_cpuid function and remove prototype

2010-03-06 Thread Aurelien Jarno
On Tue, Feb 02, 2010 at 11:08:11AM +0100, Andre Przywara wrote: > the host_cpuid function was located at the end of the file and had > a prototype before it's first use. Move it up and remove the > prototype. > > Signed-off-by: Andre Przywara Acked-by: Aurelien Jarno > --- > target-i386/cpuid

Re: [Qemu-devel] [PATCH 02/13] cpuid: replace magic number with named constant

2010-03-06 Thread Aurelien Jarno
On Tue, Feb 02, 2010 at 11:08:10AM +0100, Andre Przywara wrote: > CPUID leaf Fn8000_0001.EDX contains a copy of many Fn_0001.EDX bits. > Define a name for the mask to improve readability and avoid typos. > > Signed-off-by: Andre Przywara Acked-by: Aurelien Jarno > --- > target-i386/cpuid.

Re: [Qemu-devel] [RFC][PATCH] x86_64: Fix long jumps/calls in long mode with REX.W set

2010-03-06 Thread Aurelien Jarno
On Thu, Mar 04, 2010 at 04:03:33PM +0300, malc wrote: > On Thu, 4 Mar 2010, malc wrote: > > That's not enough, later on there's a bunch of operations assuming > 32bit width... > After discussing with malc, it happens that this patch is actually correct and enough. I have just committed it. --

Re: [Qemu-devel] qustion about x86 sse insn "lddqu"

2010-03-06 Thread Aurelien Jarno
On Thu, Dec 03, 2009 at 01:29:23PM +0800, Hui Zhu wrote: > Hi, > > In qemu 0.11.0, it handle lddqu as: > case 0x3f0: /* lddqu */ > if (mod == 3) > goto illegal_op; > gen_lea_modrm(s, modrm, ®_addr, &offset_addr); > gen_sto_env_A0(s->mem_i

[Qemu-devel] [PATCH] target-i386: fix lddqu SSE instruction

2010-03-06 Thread Aurelien Jarno
This instruction load data from memory to register and not the reverse. Signed-off-by: Aurelien Jarno --- target-i386/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a597e80..525a83b 100644 --- a/target

Re: [Qemu-devel] [PATCH] EHCI support - device recognized, but no data

2010-03-06 Thread Kevin Wolf
Am Freitag, 5. März 2010 04:17 schrieb David S. Ahern: > Jan: > > I spent some more time on the EHCI support today. With the attached > patch (delta to the patch from yesterday) a USB key is recognized within > the guest (FC-12): Looks very nice. Actually I could access the file system on my USB

Re: [Qemu-devel] i386 emulation bug: mov reg, [addr]

2010-03-06 Thread Aurelien Jarno
On Tue, Dec 15, 2009 at 07:48:53PM +0100, Clemens Kolbitsch wrote: > Hi list, > > I'm experiencing a strange emulation bug with the op-code below. The > instruction raises a segfault in the application (running on the guest), > however, if I enable KVM to run the exact same application, no segfa

[Qemu-devel] [PATCH] target-i386: fix SIB decoding with index = 4

2010-03-06 Thread Aurelien Jarno
A SIB byte with an index of 4 means "no scaled index", even if the scale value is not 0. In 64-bit mode, if REX.X is used, an index of 4 selects %r12. This is correctly handled by the computation of the index variable, which includes the index bits, and also the REX.X prefix: index = ((code >>

[Qemu-devel] Re: [PATCH] EHCI support - device recognized, but no data

2010-03-06 Thread Jan Kiszka
David S. Ahern wrote: > Jan: > > I spent some more time on the EHCI support today. With the attached > patch (delta to the patch from yesterday) a USB key is recognized within > the guest (FC-12): > > scsi 2:0:0:0: Direct-Access Kingston DT HyperXPMAP PQ: 0 > ANSI: 0 CCS > sd 2:0:0:0:

[Qemu-devel] QEMU license problem (was [PATCH v3] Drop --whole-archive and static libraries)

2010-03-06 Thread Stefan Weil
Blue Swirl schrieb: > Thanks, applied. > > > On Wed, Jan 6, 2010 at 7:24 PM, Andreas Färber > wrote: >> From: Andreas Färber >> >> Juan has contributed a cool Makefile infrastructure that enables us >> to drop >> static libraries completely: >> >> Move shared obj-y definitions to Makefile.objs, p

Re: [Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-06 Thread Blue Swirl
On 3/6/10, Aurelien Jarno wrote: > On Sat, Mar 06, 2010 at 09:15:38AM +0200, Blue Swirl wrote: > > On 3/4/10, Aurelien Jarno wrote: > > > Some targets like ARM would benefit to use 32-bit helpers for > > > div/rem/divu/remu. > > > > > > Create a #define for div2 so that targets can select

Re: [Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-06 Thread malc
On Sat, 6 Mar 2010, Aurelien Jarno wrote: > On Sat, Mar 06, 2010 at 09:15:38AM +0200, Blue Swirl wrote: > > On 3/4/10, Aurelien Jarno wrote: > > > Some targets like ARM would benefit to use 32-bit helpers for > > > div/rem/divu/remu. > > > > > > Create a #define for div2 so that targets can sel

Re: [Qemu-devel] [PATCH] tcg: add div/rem 32-bit helpers

2010-03-06 Thread Aurelien Jarno
On Sat, Mar 06, 2010 at 09:15:38AM +0200, Blue Swirl wrote: > On 3/4/10, Aurelien Jarno wrote: > > Some targets like ARM would benefit to use 32-bit helpers for > > div/rem/divu/remu. > > > > Create a #define for div2 so that targets can select between > > div, div2 and helper implementation. U

Re: [Qemu-devel] Re: Another VNC crash, qemu-kvm-0.12.3

2010-03-06 Thread Chris Webb
Alexander Graf writes: > On 05.03.2010, at 17:52, Chris Webb wrote: > > > Of course, if the screen width or height is 1, it doesn't really matter what > > the value of the mouse position for the click is, so something as simple as > > > > diff --git a/vnc.c b/vnc.c > > --- a/vnc.c > > +++ b/vnc.