Re: [Qemu-devel] Seabios dislikes -M isapc

2010-02-11 Thread Anthony Liguori
On 02/11/2010 05:51 PM, Jamie Lokier wrote: If it emulated a PCI chipset _but_ ignored any access to the chipset registers after the BIOS has initialised whatever it will (by unmapping the registers but keeping the chipset device running), that would look an awful lot like a real ISA PC at that

[Qemu-devel] [PATCH] seabios: acpi: fix memory leak in build_srat().

2010-02-11 Thread Isaku Yamahata
numadata() is allocated for temporal use, but not freed. free it. Signed-off-by: Isaku Yamahata --- src/acpi.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index dbdca79..e2a1153 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -490,6 +490,7 @@ bui

[Qemu-devel] [PATCH] pci: introduce get_info_quirk callback.

2010-02-11 Thread Isaku Yamahata
This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 by introducing device specific get_info_quirk callback. It wrongly assumes that pci host bridge class device has header type of pci-pci bridge. But this isn't always true. In fact i440fx pci host bridge has header type of normal device, henc

[Qemu-devel] Re: [PATCH 1/3] qemu-kvm: Wrap phys_ram_dirty with additional inline functions.

2010-02-11 Thread OHMURA Kei
> Why do you need a counter? It may be sufficient to set a single bit. > This reduces the memory overhead and perhaps cache thrashing. Thanks for looking into this. I agree with your opinion. Our motivation here is to skip traveling when the dirty bitmap is really sparse or dense, so either sett

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-11 Thread OHMURA Kei
On 02/11/2010 Anthony Liguori wrote: > Oh, I see what's happening here. Yes, I think a leul_to_cpu() makes more > sense. Maybe I'm missing something here. I couldn't find leul_to_cpu(), so have defined it in bswap.h. Correct? --- a/bswap.h +++ b/bswap.h @@ -205,8 +205,10 @@ static inline void cp

[Qemu-devel] [PATCH 5/6] linux-user: Use h2g_valid in qemu_vmalloc.

2010-02-11 Thread Richard Henderson
--- linux-user/mmap.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 25fc0b2..65fdc33 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -80,16 +80,15 @@ void mmap_unlock(void) void *qemu_vmalloc(size_t size) {

[Qemu-devel] [PATCH 6/6] linux-user: Fix mmap_find_vma returning invalid addresses.

2010-02-11 Thread Richard Henderson
Don't return addresses that aren't properly aligned for the guest, e.g. when the guest has a larger page size than the host. Don't return addresses that are outside the virtual address space for the target, by paying proper attention to the h2g/g2h macros. At the same time, place the default mapp

[Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-11 Thread Richard Henderson
Removes a set of ifdefs from exec.c. Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other than Alpha. This will be used for page_find_alloc, which is supposed to be using virtual addresses in the first place. --- exec.c | 17 - target-alpha/cpu.h |

[Qemu-devel] [PATCH 2/6] Use TARGET_VIRT_ADDR_SPACE_BITS in h2g_valid.

2010-02-11 Thread Richard Henderson
Previously, only 32-bit guests had a proper check for the validity of the virtual address. Extend that check to 64-bit guests with a restricted virtual address space. --- cpu-all.h | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index

[Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes.

2010-02-11 Thread Richard Henderson
I have previously posted a variant of part 6, to address the problem of the host returning mmap results that are not page aligned for the guest. That, however, led me to the fact that we could also return addresses that are outside the guest's virtual address space. Which raises the question of w

[Qemu-devel] [PATCH 4/6] Implement multi-level page tables.

2010-02-11 Thread Richard Henderson
Use TARGET_VIRT_ADDR_SPACE_BITS for the virtual memory map based off of l1_map. This rewrites page_find_alloc, page_flush_tb, and walk_memory_regions. Use TARGET_PHYS_ADDR_SPACE_BITS for the physical memory map based off of l1_phys_map. This rewrites page_phys_find_alloc and phys_page_for_each.

[Qemu-devel] [PATCH 3/6] Fix last page errors in page_set_flags and page_check_range.

2010-02-11 Thread Richard Henderson
The addr < end comparison prevents the last page from being iterated; an iteration based on length avoids this problem. --- exec.c | 54 +++--- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/exec.c b/exec.c index 766568b..ebbe6d0

Re: [Qemu-devel] Seabios dislikes -M isapc

2010-02-11 Thread Jamie Lokier
Anthony Liguori wrote: > On 02/09/2010 06:27 PM, malc wrote: > >APIC is almost as good as useless without ACPI and we have a switch to > >disable that. > > > > Which is another thing that I'm not sure it all that useful to have. > > >>Firmware is really hard to implement if you have to deal wi

Re: [Qemu-devel] Audio latency

2010-02-11 Thread malc
On Thu, 11 Feb 2010, Alberich de megres wrote: > On Thu, Feb 11, 2010 at 10:45 PM, malc wrote: > > On Thu, 11 Feb 2010, Alberich de megres wrote: > > > >> Another interesting thing: > >> > >> on guest side, > >> when i leave the screen quiet, for example just showing desktop with > >> no animatio

Re: [Qemu-devel] Audio latency

2010-02-11 Thread Alberich de megres
On Thu, Feb 11, 2010 at 10:45 PM, malc wrote: > On Thu, 11 Feb 2010, Alberich de megres wrote: > >> Another interesting thing: >> >> on guest side, >> when i leave the screen quiet, for example just showing desktop with >> no animations at all (so there's no change in what should be drawed) >> thi

Re: [Qemu-devel] Audio latency

2010-02-11 Thread malc
On Thu, 11 Feb 2010, Alberich de megres wrote: > Another interesting thing: > > on guest side, > when i leave the screen quiet, for example just showing desktop with > no animations at all (so there's no change in what should be drawed) > things improve a lot of, and then i coudl hear a song perf

[Qemu-devel] Qemu does not pass pressed caps lock to client

2010-02-11 Thread Shahar Havivi
Qemu have a hack for capslock that is not working with Ubuntu. attached patch that fix it, as describe in this bug: https://bugs.launchpad.net/qemu/+bug/427612 Signed-off-by: Shahar Havivi --- sdl.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/sdl.c b/sdl.c ind

[Qemu-devel] [PATCH] ide save/restore pio/atapi cmd transfer fields and io buffer

2010-02-11 Thread Marcelo Tosatti
Save/restore information necessary to continue in progress PIO/ATAPI CMD transfers. This includes the IO buffer. Signed-off-by: Marcelo Tosatti diff --git a/hw/ide/core.c b/hw/ide/core.c index b6643e8..64aebc2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2640,6 +2640,7 @@ void ide_init2(

Re: [Qemu-devel] Audio latency

2010-02-11 Thread Alberich de megres
Another interesting thing: on guest side, when i leave the screen quiet, for example just showing desktop with no animations at all (so there's no change in what should be drawed) things improve a lot of, and then i coudl hear a song perfectly. The screen is 1680x1050. the same thing happens when

Re: [Qemu-devel] Audio latency

2010-02-11 Thread Alberich de megres
On Thu, Feb 11, 2010 at 8:42 AM, malc wrote: > On Thu, 11 Feb 2010, Alberich de megres wrote: > >> On Thu, Feb 11, 2010 at 7:53 AM, malc wrote: >> > On Thu, 11 Feb 2010, Alberich de megres wrote: >> > >> >> I'm using the alsa driver. >> >> Even I tried to change some values using the export and s

[Qemu-devel] Heads up: glibc preadv emulation breaks qemu on older kernels

2010-02-11 Thread Richard W.M. Jones
This isn't a problem with qemu as such, but it may affect you if you use qemu with a newer glibc on a Linux kernel which does not support the preadv(2) syscall natively. glibc will attempt to emulate preadv(2) using pread(2) syscalls, but it doesn't align the user buffer when it does this, and th

[Qemu-devel] [PATCH] virtio-spec: document MSI-X

2010-02-11 Thread Michael S. Tsirkin
This documents MSI-X support in virtio. Signed-off-by: Michael S. Tsirkin --- virtio-spec.lyx | 358 +++ 1 files changed, 332 insertions(+), 26 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 49ed612..d16104a 100644 --- a/v

Re: [Qemu-devel] [PATCH v2] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-11 Thread Anthony Liguori
On 02/11/2010 11:21 AM, Naphtali Sprei wrote: Anthony Liguori wrote: On 01/28/2010 08:15 PM, Sheng Yang wrote: Commit 03cbdac7 "Disable fall-back to read-only when cannot open drive's file for read-write" result in read-only image can't be used as backed image in qemu-img. Cc: Naphta

Re: [Qemu-devel] [PATCH v2] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-11 Thread Naphtali Sprei
Anthony Liguori wrote: > On 01/28/2010 08:15 PM, Sheng Yang wrote: >> Commit 03cbdac7 "Disable fall-back to read-only when cannot open drive's >> file for read-write" result in read-only image can't be used as backed >> image in qemu-img. >> >> Cc: Naphtali Sprei >> Signed-off-by: Sheng Yang >>

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Anthony Liguori
On 02/11/2010 10:57 AM, Markus Armbruster wrote: Yes, that's a sensible argument. It's also quite impractical at this time. In fact, I had the same idea, and dropped it like a hot potato when I realized how much code we'd have to touch for it. Can you give me an example of where it gets p

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Markus Armbruster
Anthony Liguori writes: > On 02/11/2010 09:27 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> On 02/10/2010 07:49 PM, Luiz Capitulino wrote: >>> Hi there, When I started converting handlers to the QObject style, I thought that returning an er

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Anthony Liguori
On 02/11/2010 09:27 AM, Markus Armbruster wrote: Anthony Liguori writes: On 02/10/2010 07:49 PM, Luiz Capitulino wrote: Hi there, When I started converting handlers to the QObject style, I thought that returning an error code wouldn't be needed. That is, we have an error obje

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Luiz Capitulino
On Thu, 11 Feb 2010 16:27:00 +0100 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 02/10/2010 07:49 PM, Luiz Capitulino wrote: > >> Hi there, > >> > >> When I started converting handlers to the QObject style, I thought that > >> returning an error code wouldn't be needed. That i

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Markus Armbruster
Anthony Liguori writes: > On 02/10/2010 07:49 PM, Luiz Capitulino wrote: >> Hi there, >> >> When I started converting handlers to the QObject style, I thought that >> returning an error code wouldn't be needed. That is, we have an error object >> already, so if the handler returns the error o

Re: [Qemu-devel] [PATCH 1/5] virtio-blk: revert serial number support

2010-02-11 Thread Anthony Liguori
On 02/10/2010 04:36 PM, Christoph Hellwig wrote: The addition of the whole ATA IDENTIY page caused the config space to go above the allowed size in the PCI spec, and thus the feature was already reverted in the Linux guest driver and disabled by default in qemu. Signed-off-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH 07/15] ac97: convert to new PCI API

2010-02-11 Thread Anthony Liguori
On 02/09/2010 06:24 PM, malc wrote: On Tue, 9 Feb 2010, Anthony Liguori wrote: On 02/09/2010 05:36 PM, malc wrote: Let's see: Currently we have this readb(...): dostuff return stuff readw(...): dostuff return stuff And this is completely wrong. It

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Anthony Liguori
On 02/10/2010 07:49 PM, Luiz Capitulino wrote: Hi there, When I started converting handlers to the QObject style, I thought that returning an error code wouldn't be needed. That is, we have an error object already, so if the handler returns the error object it has failed, otherwise it has su

[Qemu-devel] Re: [PATCH 0/6] Assorted netdev fixes

2010-02-11 Thread Mark McLoughlin
On Thu, 2010-02-11 at 14:44 +0100, Markus Armbruster wrote: > The fixes fall into three groups: > > * Dead code removal. > > * Fix bogus "Warning: vlan 0 with no nics" with -device > > * When we added network clients not associated with a VLAN (-netdev & > friends), we missed a few places. Fi

[Qemu-devel] [PATCH 4/6] net: net_check_clients() checks only VLAN clients, fix

2010-02-11 Thread Markus Armbruster
Clients not associated with a VLAN exist since commit d80b9fc6. Signed-off-by: Markus Armbruster --- net.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 509f074..fb425e3 100644 --- a/net.c +++ b/net.c @@ -1300,6 +1300,13 @@ void net_check_clie

[Qemu-devel] [PATCH 2/6] net: net_check_clients() runs too early to see -device, fix

2010-02-11 Thread Markus Armbruster
Call it right after -device devices get created. Signed-off-by: Markus Armbruster --- net.c |4 +--- net.h |1 + vl.c |2 ++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/net.c b/net.c index f51d376..38b65f4 100644 --- a/net.c +++ b/net.c @@ -1275,7 +1275,7 @@ void

[Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit()

2010-02-11 Thread Markus Armbruster
Unused since commit 9ad4531e. Signed-off-by: Markus Armbruster --- net.c | 14 -- net.h |1 - 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/net.c b/net.c index 8e951ca..f51d376 100644 --- a/net.c +++ b/net.c @@ -1128,20 +1128,6 @@ int net_client_init(Monitor *

[Qemu-devel] [PATCH 0/6] Assorted netdev fixes

2010-02-11 Thread Markus Armbruster
The fixes fall into three groups: * Dead code removal. * Fix bogus "Warning: vlan 0 with no nics" with -device * When we added network clients not associated with a VLAN (-netdev & friends), we missed a few places. Fix them up. Markus Armbruster (6): net: Remove unused net_client_uninit()

[Qemu-devel] [PATCH 3/6] net: Fix bogus "Warning: vlan 0 with no nics" with -device

2010-02-11 Thread Markus Armbruster
net_check_clients() prints this when an VLAN has host devices, but no guest devices. It uses VLANState members nb_guest_devs and nb_host_devs to keep track of these devices. However, -device does not update nb_guest_devs, only net_init_nic() does that, for -net nic. Check the VLAN clients direct

[Qemu-devel] [PATCH 6/6] net: Monitor command set_link finds only VLAN clients, fix

2010-02-11 Thread Markus Armbruster
Clients not associated with a VLAN exist since commit d80b9fc6. Signed-off-by: Markus Armbruster --- net.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index fb89f94..029b0d7 100644 --- a/net.c +++ b/net.c @@ -1243,6 +1243,7 @@ void do_set_link(Monitor *

[Qemu-devel] [PATCH 5/6] net: info network shows only VLAN clients, fix

2010-02-11 Thread Markus Armbruster
Clients not associated with a VLAN exist since commit d80b9fc6. Signed-off-by: Markus Armbruster --- net.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index fb425e3..fb89f94 100644 --- a/net.c +++ b/net.c @@ -1210,16 +1210,23 @@ void net_set_b

[Qemu-devel] Re: [PATCH 1/3] qemu-kvm: Wrap phys_ram_dirty with additional inline functions.

2010-02-11 Thread Avi Kivity
On 02/08/2010 12:22 PM, OHMURA Kei wrote: > We think access phys_ram_dirty through inline functions is better > than directly for encoupseling reason. > > We devided the ram in a 64 pages block. Each block has a counter, which is > stored in phys_ram_dirty_by_word. It shows the number of dirty page

Re: [Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-11 Thread Alexander Graf
Rob Landley wrote: > Static binaries that run under the Linux kernel don't run under qemu-ppc. > For > example, the prebuilt busybox binaries here: > > http://busybox.net/downloads/binaries/1.16.0/busybox-powerpc > > Don't run under qemu-ppc, but runs just fine under qemu-system-ppc with the

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 11 Feb 2010 09:58:43 +0100 > Markus Armbruster wrote: > >> Excellent job! I'll base my next patch submissions on this series, >> because that way I can resolve the conflicts now rather than after >> Anthony bounced my patches right back to me. Anthony, merging

[Qemu-devel] qemu-ppc can't run static uClibc binaries.

2010-02-11 Thread Rob Landley
Static binaries that run under the Linux kernel don't run under qemu-ppc. For example, the prebuilt busybox binaries here: http://busybox.net/downloads/binaries/1.16.0/busybox-powerpc Don't run under qemu-ppc, but runs just fine under qemu-system-ppc with the image at: http://impactlinux.

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Luiz Capitulino
On Thu, 11 Feb 2010 09:58:43 +0100 Markus Armbruster wrote: > Excellent job! I'll base my next patch submissions on this series, > because that way I can resolve the conflicts now rather than after > Anthony bounced my patches right back to me. Anthony, merging this > sooner rather than later w

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-02-11 Thread Laurent Desnogues
On Wed, Feb 10, 2010 at 10:38 PM, Damion Yates wrote: [...] > Should clone()/fork() work?  Has anyone been able to run wine ./blah.exe > under user-linux mode of qemu on arm or indeed any other non x86 based > CPU ? I forgot to mention NPTL is not supported for x86 which will be an issue. Laure

Re: [Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-11 Thread Markus Armbruster
Excellent job! I'll base my next patch submissions on this series, because that way I can resolve the conflicts now rather than after Anthony bounced my patches right back to me. Anthony, merging this sooner rather than later would help me. No need for undue haste, of course. There are a few op

Re: [Qemu-devel] Audio latency

2010-02-11 Thread malc
On Thu, 11 Feb 2010, Alberich de megres wrote: > On Thu, Feb 11, 2010 at 7:53 AM, malc wrote: > > On Thu, 11 Feb 2010, Alberich de megres wrote: > > > >> I'm using the alsa driver. > >> Even I tried to change some values using the export and some flags > >> that -audio-help shows, but nothing sig