[Qemu-devel] [PATCH] Fix qemu-img can't create qcow image based on read-only image

2010-01-27 Thread Sheng Yang
Commit 03cbdac7 "Disable fall-back to read-only when cannot open drive's file for read-write" result in read-only image can't be used as backed image in qemu-img. CC: Naphtali Sprei Signed-off-by: Sheng Yang --- This issue blocked our QA's KVM nightly test. But in fact, I don't like this patch,

[Qemu-devel] Re: [PATCH] Seabios - read e820 table from qemu_cfg

2010-01-27 Thread Kevin O'Connor
On Tue, Jan 26, 2010 at 10:52:12PM +0100, Jes Sorensen wrote: > Read optional table of e820 entries from qemu_cfg [...] > --- seabios.orig/src/paravirt.c > +++ seabios/src/paravirt.c > @@ -132,6 +132,23 @@ u16 qemu_cfg_smbios_entries(void) > return cnt; > } > > +u32 qemu_cfg_e820_entries(vo

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-01-27 Thread Max Asbock
On Wed, 2010-01-27 at 15:39 -0600, Anthony Liguori wrote: > On 01/26/2010 09:25 PM, Zheng, Jiajia wrote: > > Add command p2v to translate Guest physical address to Host virtual address. > > > > For what purpose? > > > Signed-off-by: Max Asbock > > Jiajia Zheng > > --- > > diff --g

Re: [Qemu-devel] qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-27 Thread acrux
On Thu, 28 Jan 2010 00:30:23 +0100 Alexander Graf wrote: _omissis__ > > I've encuntered two issues under my quick test with CRUX PPC 2.6 > > (32bit) as host. This was my start command: > > > > $ qemu-system-ppc -m 256 -localtime -hda 25a_qcow.img -cdrom > > crux-ppc-2.5a.iso -boot d > > > > The a

[Qemu-devel] KVM Forum 2010 - save the date

2010-01-27 Thread Chris Wright
We are pleased to announce that planning is underway for the 2010 KVM Forum. The plan is to co-locate the KVM Forum in Boston with the Linux Foundation's LinuxCon 2010 in August. The KVM Forum is planned for Aug 9-10, 2010. Pencil in those dates and begin thinking about what work you would like t

Re: [Qemu-devel] qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-27 Thread Alexander Graf
Am 27.01.2010 um 20:17 schrieb acrux : On Mon, 25 Jan 2010 10:25:30 +0100 Alexander Graf wrote: _omissis__ Ugh. Please use --disable-kvm on such old kernel versions. KVM doesn't work on G4s (yet) anyway. I guess I'll need to add a minimum version check for KVM on ppc. _cut__ thanks, it n

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v4

2010-01-27 Thread Blue Swirl
On Wed, Jan 27, 2010 at 9:00 PM, Igor V. Kovalenko wrote: > From: Igor V. Kovalenko > > sparc64 timer has tick counter which can be set and read, > and tick compare value used as deadline to fire timer interrupt. > The timer is not used as periodic timer, instead deadline > is set each time new t

[Qemu-devel] Re: [PATCHv2] configure: verify stdio.h

2010-01-27 Thread Måns Rullgård
"Michael S. Tsirkin" writes: > Heh, configure script runs the program it's built > in a couple of places. This probably does not > work for cross-builds: > > if compile_prog "" "" ; then > $TMPE && bigendian="yes" > else > echo big/little test failed > fi > > likely

Re: [Qemu-devel] Re: [PATCH 6/6] fix audio_bug related failures

2010-01-27 Thread Anthony Liguori
On 01/27/2010 05:56 AM, Paolo Bonzini wrote: On 01/27/2010 03:10 AM, Anthony Liguori wrote: What did clang complain about? It's not obvious to me. It doesn't see that audio_bug returns cond, and gives quite a few false positive in its callers. Ah, this is a clang issue. I'll have to defer

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v4

2010-01-27 Thread Blue Swirl
Thanks, applied. On Wed, Jan 27, 2010 at 9:00 PM, Igor V. Kovalenko wrote: > From: Igor V. Kovalenko > > sparc64 timer has tick counter which can be set and read, > and tick compare value used as deadline to fire timer interrupt. > The timer is not used as periodic timer, instead deadline > is

Re: [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address.

2010-01-27 Thread Anthony Liguori
On 01/26/2010 09:25 PM, Zheng, Jiajia wrote: Add command p2v to translate Guest physical address to Host virtual address. For what purpose? Signed-off-by: Max Asbock Jiajia Zheng --- diff --git a/monitor.c b/monitor.c index b33b01f..83d9ac7 100644 --- a/monitor.c +++ b/mon

[Qemu-devel] [PATCH] sparc64: reimplement tick timers v4

2010-01-27 Thread Igor V. Kovalenko
From: Igor V. Kovalenko sparc64 timer has tick counter which can be set and read, and tick compare value used as deadline to fire timer interrupt. The timer is not used as periodic timer, instead deadline is set each time new timer interrupt is needed. v3 -> v4: - coding style v2 -> v3: - added

[Qemu-devel] Re: [RFC][PATCH] KVM: Introduce modification context for cpu_synchronize_state

2010-01-27 Thread Marcelo Tosatti
On Wed, Jan 27, 2010 at 03:54:08PM +0100, Jan Kiszka wrote: > This patch originates in the mp_state writeback issue: During runtime > and even on reset, we must not write the previously saved VCPU state > back into the kernel in an uncontrolled fashion. E.g mp_state should > only written on reset o

Re: [Qemu-devel] qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-27 Thread acrux
On Mon, 25 Jan 2010 10:25:30 +0100 Alexander Graf wrote: _omissis__ > > Ugh. Please use --disable-kvm on such old kernel versions. KVM > doesn't work on G4s (yet) anyway. I guess I'll need to add a minimum > version check for KVM on ppc. > _cut__ thanks, it now compiles fine on both ppc32 and

[Qemu-devel] [PATCHv3 3/3] kvm: move kvm to use memory notifiers

2010-01-27 Thread Michael S. Tsirkin
remove direct kvm calls from exec.c, make kvm use memory notifiers framework instead. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- exec.c| 17 + kvm-all.c | 40 ++-- kvm.h |8 3 files changed, 35 insertio

[Qemu-devel] [PATCHv3 2/3] kvm: move kvm_set_phys_mem around

2010-01-27 Thread Michael S. Tsirkin
move kvm_set_phys_mem so that it will be later available earlier in the file. needed for next patch using memory notifiers. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- kvm-all.c | 276 ++-- 1 files changed, 138 insertions(+

[Qemu-devel] [PATCHv3 1/3] qemu: memory notifiers

2010-01-27 Thread Michael S. Tsirkin
This adds notifiers for phys memory changes: a set of callbacks that vhost can register and update kernel accordingly. Down the road, kvm code can be switched to use these as well, instead of calling kvm code directly from exec.c as is done now. Signed-off-by: Michael S. Tsirkin --- cpu-common.

[Qemu-devel] [PATCHv3 0/3] qemu: memory notifiers

2010-01-27 Thread Michael S. Tsirkin
This patch against qemu upstream adds notifiers hook which lets backends get notified on memory changes, and converts kvm to use it. It survived light testing. Michael S. Tsirkin (3): qemu: memory notifiers kvm: move kvm_set_phys_mem around kvm: move kvm to use memory notifiers cpu-commo

[Qemu-devel] [PATCH] Monitor: Fix command execution regression

2010-01-27 Thread Luiz Capitulino
Function is_async_return() added by commit 940cc30d0d4 assumes that 'data', which is returned by handlers, is always a QDict. This is not true, as QLists can also be returned, in this case we'll get a segfault. Fix that by checking if 'data' is a QDict. Signed-off-by: Luiz Capitulino --- moni

Re: [Qemu-devel] [PATCHv2-repost 1/3] qemu: memory notifiers

2010-01-27 Thread Anthony Liguori
On 01/27/2010 01:47 PM, Michael S. Tsirkin wrote: Ugh, this will fix it. Want me to repost the series? Please do. Regards, Anthony Liguori diff --git a/exec.c b/exec.c index 63caca0..2e7434e 100644 --- a/exec.c +++ b/exec.c @@ -1623,6 +1623,7 @@ const CPULogItem cpu_log_items[] = { {

Re: [Qemu-devel] [PATCHv2-repost 1/3] qemu: memory notifiers

2010-01-27 Thread Michael S. Tsirkin
On Tue, Jan 26, 2010 at 05:07:43PM -0600, Anthony Liguori wrote: > On 01/25/2010 08:29 AM, Michael S. Tsirkin wrote: >> This adds notifiers for phys memory changes: a set of callbacks that >> vhost can register and update kernel accordingly. Down the road, kvm >> code can be switched to use these

[Qemu-devel] Re: [PATCHv2] configure: verify stdio.h

2010-01-27 Thread Michael S. Tsirkin
On Wed, Jan 27, 2010 at 08:02:26PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Tue, Jan 26, 2010 at 10:44:44PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> Verify that stdio.h supports %lld %zd. > >>> Some migw variants don't unless requested explicitly (see >

[Qemu-devel] Re: [PATCHv2] configure: verify stdio.h

2010-01-27 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Tue, Jan 26, 2010 at 10:44:44PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> Verify that stdio.h supports %lld %zd. >>> Some migw variants don't unless requested explicitly (see >> migw -> mingw >> >> I don't know any ming32 variant which supports %l

[Qemu-devel] Re: [PATCH 3/3] virtio-blk: Fix error cases which ignored rerror/werror

2010-01-27 Thread Christoph Hellwig
On Wed, Jan 27, 2010 at 01:12:36PM +0100, Kevin Wolf wrote: > If an I/O request fails right away instead of getting an error only in the > callback, we still need to consider rerror/werror. Looks good, Reviewed-by: Christoph Hellwig

[Qemu-devel] Re: [PATCH 2/3] virtio-blk: Fix restart after read error

2010-01-27 Thread Christoph Hellwig
On Wed, Jan 27, 2010 at 01:12:35PM +0100, Kevin Wolf wrote: > Current code assumes that only write requests are ever going to be restarted. > This is wrong since rerror=stop exists. Instead of directly starting writes, > use the same request processing as used for new requests. Looks good, Revie

[Qemu-devel] Re: [PATCH 1/3] virtio_blk: Factor virtio_blk_handle_request out

2010-01-27 Thread Christoph Hellwig
On Wed, Jan 27, 2010 at 01:12:34PM +0100, Kevin Wolf wrote: > We need a function that handles a single request. Create one by splitting out > code from virtio_blk_handle_output. Looks good, Reviewed-by: Christoph Hellwig

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v3

2010-01-27 Thread Blue Swirl
On Tue, Jan 26, 2010 at 11:09 PM, Igor Kovalenko wrote: > On Fri, Jan 22, 2010 at 11:32 PM, Blue Swirl wrote: >> On Tue, Jan 19, 2010 at 10:25 PM, Igor V. Kovalenko >> wrote: >>> From: Igor V. Kovalenko >>> >>> sparc64 timer has tick counter which can be set and read, >>> and tick compare value

[Qemu-devel] Re: sparc solaris guest, hsfs_putpage: dirty HSFS page

2010-01-27 Thread Blue Swirl
On Tue, Jan 26, 2010 at 10:42 PM, Artyom Tarasenko wrote: > 2010/1/26 Blue Swirl : >> On Tue, Jan 26, 2010 at 7:03 PM, Artyom Tarasenko >> wrote: >>> 2010/1/24 Blue Swirl : On Sun, Jan 24, 2010 at 2:02 AM, Artyom Tarasenko wrote: > All solaris versions which currently boot (from cd

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-27 Thread Blue Swirl
On Wed, Jan 27, 2010 at 12:41 PM, Loïc Minier wrote: > On Tue, Jan 26, 2010, Blue Swirl wrote: >> The patches didn't apply. Also please send only one patch per message, >> git am can't handle multiple patches. > >  They applied fine here, perhaps you didn't apply the sdl-config patch >  first?  I

Re: [Qemu-devel] [PATCH] sparc64: correct write extra bits to cwp

2010-01-27 Thread Blue Swirl
Thanks, applied. On Tue, Jan 26, 2010 at 11:11 PM, Igor V. Kovalenko wrote: > From: Igor V. Kovalenko > > - correctly fit to cwp if provided window number is out of range > > Signed-off-by: Igor V. Kovalenko > --- >  target-sparc/cpu.h |    2 +- >  1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH] Fix regression in option parsing

2010-01-27 Thread Anthony Liguori
Commit ec229bbe7 broke invocation without a specific -hda. IOW, qemu foo.img. The lack of an optind update caused an infinite loop. Reported-by: Amit Shah Signed-off-by: Anthony Liguori --- vl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 1cd355c.

[Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification

2010-01-27 Thread Amit Shah
This commit enables one to use multiple virtio-serial devices and to assign ports to arbitrary devices like this: -device virtio-serial,id=foo -device virtio-serial,id=bar \ -device virtserialport,bus=foo.0,name=foo \ -device virtserialport,bus=bar.0,name=bar Signed-off-by: Amit Shah ---

[Qemu-devel] [PATCH v4 2/8] QDict: New qdict_get_double()

2010-01-27 Thread Markus Armbruster
Helper function just like qdict_get_int(), just for QFloat/double. Signed-off-by: Markus Armbruster --- Makefile |2 +- qdict.c | 24 qdict.h |1 + 3 files changed, 26 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 60d5c66..3f02c66 1006

[Qemu-devel] [RFC][PATCH] KVM: Introduce modification context for cpu_synchronize_state

2010-01-27 Thread Jan Kiszka
This patch originates in the mp_state writeback issue: During runtime and even on reset, we must not write the previously saved VCPU state back into the kernel in an uncontrolled fashion. E.g mp_state should only written on reset or on VCPU setup. Certain clocks (e.g. the TSC) may only be written o

Re: [Qemu-devel] Re: [PATCH qemu-kvm] Add raw(af_packet) network backend to qemu

2010-01-27 Thread Anthony Liguori
On 01/27/2010 12:52 AM, Arnd Bergmann wrote: On Wednesday 27 January 2010, Anthony Liguori wrote: The raw backend can be attached to a physical device This is equivalent to bridging with tun/tap except that it has the unexpected behaviour of unreliable host/guest networking (which i

Re: [Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might free vs

2010-01-27 Thread Anthony Liguori
On 01/27/2010 06:29 AM, Stefano Stabellini wrote: On Wed, 27 Jan 2010, Gerd Hoffmann wrote: On 01/27/10 01:07, Anthony Liguori wrote: On 01/25/2010 06:54 AM, Stefano Stabellini wrote: Hi all, this patch fixes another bug in vnc_refresh: calling vnc_update_client might cause v

Re: [Qemu-devel] [PATCH 4/4] target-arm: refactor cp15.c13 register access

2010-01-27 Thread Laurent Desnogues
On Wed, Jan 27, 2010 at 1:49 PM, Riku Voipio wrote: > From: Riku Voipio > > Access the cp15.c13 TLS registers directly with TCG ops instead of with > a slow helper. If the the cp15 read/write was not TLS register access, > fall back to the cp15 helper. > > This makes accessing __thread variables

[Qemu-devel] [PATCH 6/6] fix audio_bug related clang false positives

2010-01-27 Thread Paolo Bonzini
By making the abort condition visible in the caller, this fixes several false positives in the audio code. Signed-off-by: Paolo Bonzini --- audio/audio.c | 44 audio/audio_int.h |3 ++- 2 files changed, 22 insertions(+), 25 deletions(-) dif

[Qemu-devel] [PATCH 5/6] usb-linux.c: remove write-only variable

2010-01-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- usb-linux.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 1aaa595..ba8facf 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -1007,11 +1007,9 @@ USBDevice *usb_host_device_open(const char *devname) { st

[Qemu-devel] [PATCH 4/6] vnc.c: remove dead code

2010-01-27 Thread Paolo Bonzini
to= has always been handled by qemu-sockets.c's inet_listen, not by vnc.c. Signed-off-by: Paolo Bonzini --- vnc.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/vnc.c b/vnc.c index cc2a26e..69d6624 100644 --- a/vnc.c +++ b/vnc.c @@ -2535,7 +2535,6 @@ int vnc_display_o

[Qemu-devel] [PATCH 3/6] exec.c: dead assignments

2010-01-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- exec.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index 1190591..64109a7 100644 --- a/exec.c +++ b/exec.c @@ -2489,17 +2489,13 @@ void *qemu_get_ram_ptr(ram_addr_t addr) ram_addr_t qemu_ram_addr_from_host(void *ptr

[Qemu-devel] [PATCH 2/6] fix undefined shifts by >32

2010-01-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 5e8c775..d9f1ccb 100644 --- a/vl.c +++ b/vl.c @@ -2373,9 +2373,9 @@ static void numa_add(const char *optarg) fprintf(stderr,

[Qemu-devel] [PATCH 0/6] fix a few clang warnings.

2010-01-27 Thread Paolo Bonzini
All of these should be quite uncontroversial. I'll propose the second patch for 0.12 after a short while. v1 -> v2: redid vnc patch (4/6) Paolo Bonzini (6): remove two dead assignments in target-i386/translate.c fix undefined shifts by >32 exec.c: dead assignments vnc.c: remove dead co

[Qemu-devel] [PATCH 1/6] remove two dead assignments in target-i386/translate.c

2010-01-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-i386/translate.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index 8078112..a597e80 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -4692,8 +4692,6 @@ stat

[Qemu-devel] Re: [PATCH 1/3] Check for sdl-config before calling it

2010-01-27 Thread Paolo Bonzini
Glad to see someone working on Solaris. Wondering why you're using the which command, when you just created a "has" function in the other patch segments, and just replaced all the other instances of which. This is patch 1/3, patch 2/3 creates "has" and uses it here too. Paolo

[Qemu-devel] [PATCH 2/4] fix locking error with current_tb

2010-01-27 Thread Riku Voipio
From: Riku Voipio Signed-off-by: Riku Voipio --- exec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index 76831a1..431e104 100644 --- a/exec.c +++ b/exec.c @@ -1537,15 +1537,15 @@ static void cpu_unlink_tb(CPUState *env) TranslationBlock *tb;

[Qemu-devel] [PATCH 3/4] linux-user: remove signal handler before calling abort()

2010-01-27 Thread Riku Voipio
From: Riku Voipio Qemu may hang in host_signal_handler after qemu has done a seppuku with cpu_abort(). But at this stage we are not really interested in target process coredump anymore, so unregister host_signal_handler to die grafefully. Signed-off-by: Riku Voipio --- exec.c |9 +

[Qemu-devel] [PATCH 1/4] linux-user: adapt uname machine to emulated CPU

2010-01-27 Thread Riku Voipio
From: Loïc Minier This patch for linux-user adapts the output of the emulated uname() syscall to match the configured CPU. Tested with x86, x86-64 and arm emulation. Signed-off-by: Riku Voipio Signed-off-by: Loïc Minier --- Makefile.target|2 +- linux-user/cpu-uname.c | 72

[Qemu-devel] [PATCH 0/4] linux-user-for-upstream patches

2010-01-27 Thread Riku Voipio
From: Riku Voipio Some fixes to avoid hanging, make arm uname match selected cpu, and fix cp15.c13 register for linux-user tls register access. Loïc Minier (1): linux-user: adapt uname machine to emulated CPU Riku Voipio (3): fix locking error with current_tb linux-user: remove signal han

[Qemu-devel] [PATCH 4/4] target-arm: refactor cp15.c13 register access

2010-01-27 Thread Riku Voipio
From: Riku Voipio Access the cp15.c13 TLS registers directly with TCG ops instead of with a slow helper. If the the cp15 read/write was not TLS register access, fall back to the cp15 helper. This makes accessing __thread variables in linux-user when apps are compiled with -mtp=cp15 possible. leg

Re: [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it

2010-01-27 Thread Ben Taylor
On Wed, Jan 27, 2010 at 7:10 AM, Loïc Minier wrote: > Check whether sdl-config is available before calling it, otherwise > ./configure triggers a warning: >    ./configure: 957: sdl-config: not found > > If neither the .pc file not sdl-config are present, disable SDL support. > > Signed-off-by: Lo

Re: [Qemu-devel] Re: Stop using "which" in ./configure

2010-01-27 Thread Loïc Minier
On Tue, Jan 26, 2010, Blue Swirl wrote: > The patches didn't apply. Also please send only one patch per message, > git am can't handle multiple patches. They applied fine here, perhaps you didn't apply the sdl-config patch first? I rebased them and resent them. -- Loïc Minier

Re: [Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might free vs

2010-01-27 Thread Stefano Stabellini
On Wed, 27 Jan 2010, Gerd Hoffmann wrote: > On 01/27/10 01:07, Anthony Liguori wrote: > > On 01/25/2010 06:54 AM, Stefano Stabellini wrote: > >> Hi all, > >> this patch fixes another bug in vnc_refresh: calling vnc_update_client > >> might cause vs to be free()ed, in this case we cannot access vs->

[Qemu-devel] [PATCH 1/3] virtio_blk: Factor virtio_blk_handle_request out

2010-01-27 Thread Kevin Wolf
We need a function that handles a single request. Create one by splitting out code from virtio_blk_handle_output. Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 78 -- 1 files changed, 46 insertions(+), 32 deletions(-) diff --git a/hw/virti

[Qemu-devel] [PATCH 0/3] virtio-blk: rerror/werror fixes (including corruption fix)

2010-01-27 Thread Kevin Wolf
This fixes two bugs in the handling of rerror/werror in virtio-blk. First is a fix for read requests morphing into write requests after the VM was stopped by a read error. Second is to consider rerror/werror in places where virtio-blk used to directly report errors back. This series should be appl

[Qemu-devel] [PATCH 2/3] virtio-blk: Fix restart after read error

2010-01-27 Thread Kevin Wolf
Current code assumes that only write requests are ever going to be restarted. This is wrong since rerror=stop exists. Instead of directly starting writes, use the same request processing as used for new requests. Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 11 +-- 1 files changed,

[Qemu-devel] [PATCH 3/3] virtio-blk: Fix error cases which ignored rerror/werror

2010-01-27 Thread Kevin Wolf
If an I/O request fails right away instead of getting an error only in the callback, we still need to consider rerror/werror. Signed-off-by: Kevin Wolf --- hw/virtio-blk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 5a413b9.

[Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has()

2010-01-27 Thread Loïc Minier
--- configure |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 6bdd2b7..1d0915a 100755 --- a/configure +++ b/configure @@ -803,21 +803,19 @@ fi # Solaris specific configure tool chain decisions # if test "$solaris" = "yes" ; then - sol

[Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs

2010-01-27 Thread Loïc Minier
Add has() and path_of() funcs and use them across configure; has() will test whether a command or builtin is available; path_of() will search the PATH for executables and return the full pathname if found. --- configure | 52 +++- 1 files changed,

[Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it

2010-01-27 Thread Loïc Minier
Check whether sdl-config is available before calling it, otherwise ./configure triggers a warning: ./configure: 957: sdl-config: not found If neither the .pc file not sdl-config are present, disable SDL support. Signed-off-by: Loïc Minier --- configure |7 ++- 1 files changed, 6 ins

[Qemu-devel] Re: [PATCH 6/6] fix audio_bug related failures

2010-01-27 Thread Paolo Bonzini
On 01/27/2010 03:10 AM, Anthony Liguori wrote: What did clang complain about? It's not obvious to me. It doesn't see that audio_bug returns cond, and gives quite a few false positive in its callers. Paolo

[Qemu-devel] Re: [FOR 0.12 RESEND PATCH] fdc: fix drive property handling.

2010-01-27 Thread Gerd Hoffmann
On 01/06/10 15:23, Gerd Hoffmann wrote: Fix the floppy controller init wrappers to set the drive properties only in case the DriveInfo pointers passed in are non NULL. This allows to set the properties using -global. Signed-off-by: Gerd Hoffmann Ping. This patch seems to keep missing the boa

Re: [Qemu-devel] [RFC] gPXE fw_cfg file interface support

2010-01-27 Thread Gerd Hoffmann
gPXE> imgfetch fw_cfg:genroms/static.gpxe Neat idea. On the qemu side we better shouldn't abuse the -option-rom switch though as seabios will try to load these files as option roms. Note that this patch only adds the fw_cfg file interface mechanism, it does not automatically probe for a sp

Re: [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option

2010-01-27 Thread Gerd Hoffmann
On 01/27/10 03:10, Anthony Liguori wrote: On 01/26/2010 05:14 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- vnc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index cc2a26e..9ebee09 100644 --- a/vnc.c +++ b/vnc.c @@ -2563,6 +2563,7 @@ int vnc_dis

Re: [Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might free vs

2010-01-27 Thread Gerd Hoffmann
On 01/27/10 01:07, Anthony Liguori wrote: On 01/25/2010 06:54 AM, Stefano Stabellini wrote: Hi all, this patch fixes another bug in vnc_refresh: calling vnc_update_client might cause vs to be free()ed, in this case we cannot access vs->next right after to examine the next item on the list. Sign

[Qemu-devel] [RFC] gPXE fw_cfg file interface support

2010-01-27 Thread Stefan Hajnoczi
This patch makes it possible for gPXE under QEMU/KVM to fetch files from the host using the fw_cfg file interface. This means gPXE in the guest can fetch an exposed file from the host without using networking. I believe this feature will be useful to management software so that network boot confi

[Qemu-devel] Re: [PATCHv2] configure: verify stdio.h

2010-01-27 Thread Michael S. Tsirkin
On Tue, Jan 26, 2010 at 10:44:44PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > Verify that stdio.h supports %lld %zd. > > Some migw variants don't unless requested explicitly (see > > migw -> mingw > > I don't know any ming32 variant which supports %lld, %zd. > There is a new ming

Re: [Qemu-devel] [PATCH v2 01/10] qcow2: Fix error handling in qcow2_grow_l1_table

2010-01-27 Thread Kevin Wolf
Am 26.01.2010 22:37, schrieb Anthony Liguori: > On 01/20/2010 08:02 AM, Kevin Wolf wrote: >> Return the appropriate error value instead of always using EIO. Don't free >> the >> L1 table on errors, we still need it. >> >> Signed-off-by: Kevin Wolf >> > > Applied all. Thanks. > > Do you thin

Re: [Qemu-devel] [PATCH v2 6/6] monitor: convert do_cpu_set() to QObject, QError

2010-01-27 Thread Markus Armbruster
Anthony Liguori writes: > On 01/20/2010 06:07 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> monitor.c |4 ++-- >> qemu-monitor.hx |3 ++- >> 2 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/monitor.c b/monitor.c >> index 816f6fd..b