Re: [Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote: > From: Kirill A. Shutemov > > CCblock/vvfat.o > cc1: warnings being treated as errors > block/vvfat.c: In function 'commit_one_file': > block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared > with attribute w

[Qemu-devel] possible qemu miscompilation by latest gcc

Hi folks- Just wanted to let you know that perhaps the function helper_neon_rshl_s8() is being miscompiled by the latest gcc. I'm using qemu 0.12.2 and gcc rev 156103, which is a pre-version of gcc 4.5. This is on an x86 machine running Ubuntu 9.10. At -O2 or higher this is the resulting o

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

Thank Mr. Weil for your reply.   > > Maybe you can also try the TCG interpreter (TCI) from > http://repo.or.cz/w/qemu/ar7.git. > In theory, it supports any host architecture with or > without native TCG > support. > > It was tested successful with some basic tests on x86, > mips, ppc and arm, > s

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Chris Wright wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> To be honest all possible naming schemes for '-cpu ' are just as >> unfriendly as each other. The only user friendly option is '-cpu host'. >> >> IMHO, we should just pick a concise naming scheme & document it. Given >> the

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

* Daniel P. Berrange (berra...@redhat.com) wrote: > To be honest all possible naming schemes for '-cpu ' are just as > unfriendly as each other. The only user friendly option is '-cpu host'. > > IMHO, we should just pick a concise naming scheme & document it. Given > they are all equally unfriend

[Qemu-devel] Re: [PATCH] Add definitions for current cpu models..

On Monday 18 January 2010, john cooper wrote: > +.name = "Conroe", > +.level = 2, > +.vendor1 = CPUID_VENDOR_INTEL_1, > +.vendor2 = CPUID_VENDOR_INTEL_2, > +.vendor3 = CPUID_VENDOR_INTEL_3, > +.family = 6, /* P6 */ > +.model = 2,

Re: [Qemu-devel] [PATCH] Tell users about out-of-memory errors

On Wed, 20 Jan 2010, Stefan Weil wrote: > Aborting without an error message when memory is short > is not helpful, so print the reason for the abort. > > Try > qemu -m 100 > to force an out-of-memory error. The patch is wrong for, at least, Windows. > > Signed-off-by: Stefan Weil >

[Qemu-devel] Re: [PATCH 01/14] arm host: Fix compiler warning

Stefan Weil schrieb: > Compilation for arm (native or cross) results in this > warning: > > fpu/softfloat-native.c: In function ‘float64_round_to_int’: > fpu/softfloat-native.c:387: error: control reaches end of non-void function > > float64_round_to_int uses special assembler code for arm > and ha

Re: [Qemu-devel] [PATCH] Documentation: Add missing documentation for qdev related command line options

Markus Armbruster schrieb: > Stefan Weil writes: > >> Markus Armbruster schrieb: >>> Stefan Weil writes: >>> The command line options -device, -nodefaults, -readconfig, -writeconfig had entries for command line help, but documentation for texi and derived formats (man, html, info)

[Qemu-devel] [PATCH 3/3] Documentation: Improve command line help for -device option

* Fix column for help text. * Give some more help, especially for the new '?' parameters. Signed-off-by: Stefan Weil --- qemu-options.hx | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ee60d8a..ef82cac 100644 --- a/

[Qemu-devel] [PATCH 2/3] qdev: Add help for property value

When called with property value "?", a help text will be printed (instead of an error message). This is useful for command lines like qemu -device e1000,mac=? and is already standard for other command line options. A better help text could be provided by extending the Property structure w

[Qemu-devel] [PATCH 1/3] qdev: Add help for device properties

When called with property "?", a list of supported properties will be printed (instead of an error message). This is useful for command lines like qemu -device e1000,? and was already standard for other options like model=? Signed-off-by: Stefan Weil --- hw/qdev-properties.c | 15

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

On 01/20/2010 09:19 AM, identifier scorpio wrote: Below i'll append my newly generated patch against stable-0.10, in case it is mangled, i also put it in the attachment. For the record, the inline portion was again mangled; the attachment is fine. in qemu_ld/st, we must use $16,$17,$18 as t

[Qemu-devel] [PATCH] Documentation: Add missing texi description for command line options

Some more command line options had entries for command line help, but documentation for texi and derived formats (man, html, info) was missing. For conditional options, the texi documentation was added unconditionally. This seems reasonable because typically man pages are shared, and html users e

[Qemu-devel] [PATCH] Tell users about out-of-memory errors

Aborting without an error message when memory is short is not helpful, so print the reason for the abort. Try qemu -m 100 to force an out-of-memory error. Signed-off-by: Stefan Weil --- osdep.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/osdep.c b/o

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

On 01/20/2010 02:26 PM, Daniel P. Berrange wrote: To be honest all possible naming schemes for '-cpu' are just as unfriendly as each other. The only user friendly option is '-cpu host'. IMHO, we should just pick a concise naming scheme& document it. Given they are all equally unfriendly, the on

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

On Wed, Jan 20, 2010 at 03:09:53PM -0500, john cooper wrote: > Anthony Liguori wrote: > > On 01/19/2010 02:03 PM, Chris Wright wrote: > >> * Anthony Liguori (anth...@codemonkey.ws) wrote: > >> > >>> I'm very much against having -cpu Nehalem. The whole point of this is > >>> to make things easie

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Jamie Lokier wrote: > john cooper wrote: >> As before a cpu feature 'check' option is added which warns when >> feature flags (either implicit in a cpu model or explicit on the >> command line) would have otherwise been quietly unavailable to a >> guest: >> >> # qemu-system-x86_64 ... -cpu Neha

[Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error

Signed-off-by: Juan Quintela --- linux-user/mmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index c1c7e48..25fc0b2 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -243,7 +243,7 @@ static int mmap_frag(abi_ulong real_

[Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all

Signed-off-by: Juan Quintela --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5556b9d..d8af978 100755 --- a/configure +++ b/configure @@ -101,7 +101,7 @@ QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS" QEMU_CFLAGS="-I. -I\$(SRC_PA

[Qemu-devel] [PATCH 14/17] check pipe() return value

Signed-off-by: Juan Quintela --- hw/xen_domainbuild.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c index 20d731d..2f59856 100644 --- a/hw/xen_domainbuild.c +++ b/hw/xen_domainbuild.c @@ -156,15 +156,18 @@ quit:

[Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2

From: Kirill A. Shutemov _FORTIFY_SOURCE is a Glibc feature which adds memory and string function protection. Signed-off-by: Kirill A. Shutemov Signed-off-by: Juan Quintela --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5631

[Qemu-devel] [PATCH 13/17] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-linux-user/mmap.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag': /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared with attribute warn_unu

[Qemu-devel] [PATCH 12/17] monitor.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with attribute warn_unused_resul

[Qemu-devel] [PATCH 10/17] usb-linux.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCusb-linux.o cc1: warnings being treated as errors usb-linux.c: In function 'usb_host_read_file': usb-linux.c:1204: error: ignoring return value of 'fgets', declared with attribute warn_unused_result make: *** [usb-linux.o] Error 1 Signed-off-by: Kirill A. Shutemov

[Qemu-devel] [PATCH 11/17] vl.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src

[Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCnet/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1 Signed-off-by: Kirill A. Shutemov

[Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/qcow2.o cc1: warnings being treated as errors block/qcow2.c: In function 'qcow_create2': block/qcow2.c:829: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow2.c:838: error: ignoring return value of 'write', declare

[Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CCblock/vvfat.o In

[Qemu-devel] [PATCH 06/17] block/vmdk.o: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/vmdk.o cc1: warnings being treated as errors block/vmdk.c: In function 'vmdk_snapshot_create': block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result block/vmdk.c: In function 'vmdk_create': block/vmdk.c:775:

[Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/cow.o cc1: warnings being treated as errors block/cow.c: In function 'cow_create': block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result block/cow.c:253: error: ignoring return value of 'ftruncate', declared with

[Qemu-devel] [PATCH 05/17] block/qcow.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/qcow.o cc1: warnings being treated as errors block/qcow.c: In function 'qcow_create': block/qcow.c:804: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow.c:806: error: ignoring return value of 'write', declared wit

[Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCposix-aio-compat.o cc1: warnings being treated as errors posix-aio-compat.c: In function 'aio_signal_handler': posix-aio-compat.c:505: error: ignoring return value of 'write', declared with attribute warn_unused_result make: *** [posix-aio-compat.o] Error 1 Signed

[Qemu-devel] [PATCH 01/17] Introduce qemu_write_full()

From: Kirill A. Shutemov A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov Signed-off-by: Juan Quintela --- osdep.c | 27 +++ qemu-common.h |1 + 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/osdep.c b/os

[Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full()

Signed-off-by: Juan Quintela --- qemu-common.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index a2731e1..ae4f23b 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -161,7 +161,8 @@ void qemu_mutex_lock_iothread(void); void qemu_mutex_

[Qemu-devel] [PATCH v2 00/17] Fix compilation with _FORTIFY_SOURCE

changes in v2: - we retry the write in the signal handler when error is -EINTR (just use the qemu_write_full() function) (spoted by Jamie Lokier) - we don't do arith on void * anymore (spoted by malc) and there were no more pending commets. you can get it as a branch at: git://repo.or.cz/qe

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Anthony Liguori wrote: > On 01/19/2010 02:03 PM, Chris Wright wrote: >> * Anthony Liguori (anth...@codemonkey.ws) wrote: >> >>> I'm very much against having -cpu Nehalem. The whole point of this is >>> to make things easier for a user and for most of the users I've >>> encountered, -cpu Nehalem

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Jamie Lokier wrote: > Anthony Liguori wrote: >> On 01/18/2010 10:45 AM, john cooper wrote: >>> x86 Conroe Intel Celeron_4x0 (Conroe/Merom Class Core 2) >>> x86 Penryn Intel Core 2 Duo P9xxx (Penryn Class Core 2) >>> x86 Nehalem Intel Core i7 9xx (Nehalem

[Qemu-devel] [PATCH] Fix generation of config-host.h

This patch improves Anthony patch a6a853c86275efd89996ce59612a000c5873db5d Once there, it improves handling of object files for qemu tools cc: Andreas Färber Signed-off-by: Juan Quintela --- Makefile | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/Mak

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

On Wed, Jan 20, 2010 at 6:11 PM, Luiz Capitulino wrote: > On Wed, 20 Jan 2010 18:57:56 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> >  Hi, >> > >> >  This new version addresses Markus's comments. >> > >> > changelog >> > - >> > >> > V1 -> V2 >> > >> > - Make class_

[Qemu-devel] Re: [PATCH 1/5] substitute all uses of which by type

Stefan Weil wrote: > Juan Quintela schrieb: >> Except in one case, we are only interested in knowing if a command >> exist, not is path. Just create prog_exists() function that does this >> check. >> >> Signed-off-by: Juan Quintela > > See comments below. The changes proposed are a suggestion, no

[Qemu-devel] [PATCH 01/14] arm host: Fix compiler warning

Compilation for arm (native or cross) results in this warning: fpu/softfloat-native.c: In function ‘float64_round_to_int’: fpu/softfloat-native.c:387: error: control reaches end of non-void function float64_round_to_int uses special assembler code for arm and has no explicit return value. As the

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v2

On Tue, Jan 19, 2010 at 10:24 PM, Igor Kovalenko wrote: > On Tue, Jan 19, 2010 at 9:44 PM, Blue Swirl wrote: >> On Mon, Jan 18, 2010 at 10:28 PM, Igor V. Kovalenko >> wrote: >>> From: Igor V. Kovalenko >>> >>> sparc64 timer has tick counter which can be set and read, >>> and tick compare value

Re: [Qemu-devel] [PATCH 1/5] substitute all uses of which by type

Juan Quintela schrieb: > Except in one case, we are only interested in knowing if a command > exist, not is path. Just create prog_exists() function that does this > check. > > Signed-off-by: Juan Quintela See comments below. The changes proposed are a suggestion, no real need. Regards, Stefan

[Qemu-devel] Re: sparc32 do_unassigned_access overhaul

On Tue, Jan 19, 2010 at 9:44 PM, Artyom Tarasenko wrote: > 2010/1/19 Blue Swirl : >> On Tue, Jan 19, 2010 at 5:30 PM, Artyom Tarasenko >> wrote: >>> 2010/1/15 Artyom Tarasenko : 2010/1/15 Blue Swirl : > On Fri, Jan 15, 2010 at 9:11 PM, Artyom Tarasenko > wrote: >> 2010/1/15 Blue

[Qemu-devel] Re: Stop using "which" in ./configure

Loïc Minier writes: > On Wed, Jan 20, 2010, Paolo Bonzini wrote: >> > Are you saying that I can't backup/restore IFS without setting it >> > first? >> Yes, it affects the behavior of read for example: >> $ echo a b c | (read a b c; echo $a; echo $b; echo $c) >> a >> b >> c >> $ IFS= >> $ echo a

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

On Wed, 20 Jan 2010 18:57:56 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Hi, > > > > This new version addresses Markus's comments. > > > > changelog > > - > > > > V1 -> V2 > > > > - Make class_info's key 'desc' optional > > - Better indentation > > - Doc fixes > > >

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

Luiz Capitulino writes: > Hi, > > This new version addresses Markus's comments. > > changelog > - > > V1 -> V2 > > - Make class_info's key 'desc' optional > - Better indentation > - Doc fixes > > V0 -> V1 > > - Coding style fixes > - Make 'BAR' and 'IRQ' keys lowercase > - Add 'irq' key

[Qemu-devel] [PATCH 7/7] Add documentation for --enable/disable-docs

Signed-off-by: Juan Quintela --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 046b0fb..9d315f4 100755 --- a/configure +++ b/configure @@ -758,6 +758,8 @@ echo " --disable-debug disable common debug build options" echo

[Qemu-devel] [PATCH 6/7] Sort boolean options

No code changes Signed-off-by: Juan Quintela --- configure | 285 +++-- 1 files changed, 144 insertions(+), 141 deletions(-) diff --git a/configure b/configure index f86fef3..046b0fb 100755 --- a/configure +++ b/configure @@ -477,164 +477

[Qemu-devel] [PATCH 5/7] Change --static to --enable-static

This way it is consistent with everything else. Leave --static as compatible option, but don't document it Signed-off-by: Juan Quintela --- configure |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index c9061e1..f86fef3 100755 --- a/configu

[Qemu-devel] [PATCH 4/7] Add help to --cpu and --with-pkgversion

Signed-off-by: Juan Quintela --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 1e6088c..c9061e1 100755 --- a/configure +++ b/configure @@ -715,6 +715,7 @@ echo " Available cards: $audio_possible_cards"

[Qemu-devel] [PATCH 3/7] Sort together all options that take arguments

Signed-off-by: Juan Quintela --- configure | 103 +++- 1 files changed, 53 insertions(+), 50 deletions(-) diff --git a/configure b/configure index 6175b75..1e6088c 100755 --- a/configure +++ b/configure @@ -60,12 +60,12 @@ audio_win_int="

[Qemu-devel] [PATCH 2/7] Add PATH argument to options that need it

Signed-off-by: Juan Quintela --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 08ff6a2..6175b75 100755 --- a/configure +++ b/configure @@ -779,9 +779,9 @@ echo " emulation targets" echo " --disable-

[Qemu-devel] [PATCH 1/7] Rename --enable-uname-release

It really sets uname string. It don't make sense a --disable option Signed-off-by: Juan Quintela --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 192338f..08ff6a2 100755 --- a/configure +++ b/configure @@ -578,7 +578,7 @@ for

[Qemu-devel] [PATCH 0/7] *** SUBJECT HERE ***

*** BLURB HERE *** Juan Quintela (7): Rename --enable-uname-release Add PATH argument to options that need it Sort together all options that take arguments Add help to --cpu and --with-pkgversion Change --static to --enable-static Sort boolean options Add documentation for --enable/d

Re: [Qemu-devel] [PATCH] make: qemu-img depends on config-host.h

Am 20.01.2010 um 17:12 schrieb Anthony Liguori: Fixes mingw32 build out of tree. Signed-off-by: Anthony Liguori --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b1bbe6d..60d5c66 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,

[Qemu-devel] [PATCH 5/5] Fix missing symbols in .rel/.rela.plt sections

From: Loïc Minier Fix .rel.plt sections in the output to not only include .rel.plt sections from the input but also the .rel.iplt sections and to define the hidden symbols __rel_iplt_start and __rel_iplt_end around .rel.iplt as otherwise we get undefined references to these when linking staticall

[Qemu-devel] [PATCH 2/5] Check for sdl-config before calling it

Adapted Loïc Minier version to not use which. cc: Loïc Minier Signed-off-by: Juan Quintela --- configure |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 71edaf5..c671918 100755 --- a/configure +++ b/configure @@ -996,9 +996,15 @@ fi

[Qemu-devel] [PATCH 3/5] Add -static earlier to LDFLAGS for compile_prog()

From: Loïc Minier Add -static to LDFLAGS earlier as to run the compile_prog() tests with this flags, this will avoid turning on features for which a shared library is available but not a static one. Signed-off-by: Loïc Minier Signed-off-by: Juan Quintela --- configure |5 +++-- 1 files ch

[Qemu-devel] [PATCH 4/5] Remove check for grep

The rest of configure assumes that grep is available already Signed-off-by: Juan Quintela --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 83f8b26..f31be87 100755 --- a/configure +++ b/configure @@ -1430,8 +1430,7 @@ EOF fi

[Qemu-devel] [PATCH 0/5] Remove which use

This series substitute "which" use by "type" one. It is similar to Loïc patch, just that I didn't use path_of() because it was used just once. This addresses commets about using && instead of -a. It also remove the search for "grep" in kvm code. grep is assumed in lots of other places in configur

[Qemu-devel] [PATCH 1/5] substitute all uses of which by type

Except in one case, we are only interested in knowing if a command exist, not is path. Just create prog_exists() function that does this check. Signed-off-by: Juan Quintela --- configure | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH 5/6] tcg-i386: Implement setcond.

Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 73 +++-- 1 files changed, 70 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index e1691b3..3914570 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i3

[Qemu-devel] [PATCH 3/6] tcg: Add tcg_invert_cond.

It is very handy to have a reliable mapping of a condition to its inverse. Signed-off-by: Richard Henderson --- tcg/tcg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 121b17c..b218abe 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -205,6 +20

[Qemu-devel] [PATCH 4/6] tcg-i386: Implement small forward branches.

There are places, like brcond2, where we know that the destination of a forward branch will be within 127 bytes. Add the R_386_PC8 relocation type to support this. Add a flag to tcg_out_jxx and tcg_out_brcond* to enable it. Set the flag in the brcond2 label_next branches; pass along the input fl

[Qemu-devel] [PATCH 6/6] tcg-x86_64: Implement setcond.

Signed-off-by: Richard Henderson --- tcg/x86_64/tcg-target.c | 38 +- 1 files changed, 33 insertions(+), 5 deletions(-) diff --git a/tcg/x86_64/tcg-target.c b/tcg/x86_64/tcg-target.c index cbaabef..6e7a6a4 100644 --- a/tcg/x86_64/tcg-target.c +++ b/tcg/x86_6

[Qemu-devel] [PATCH 2/6] tcg: Generic support for conditional set

Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. Signed-off-by: Richard Henderson --- tcg/README| 13 + tcg/tcg-op.h | 47 +++ tcg/tcg-opc.h |3 +++ tcg/tcg.c | 21 +++-- 4 files changed, 78 in

[Qemu-devel] [PATCH 0/6] tcg conditional set, round 6

Changes v5-v6: * Update x86-64 post P_REXB changes. Changes v4-v5: * Document double-word support opcodes in a new section of the README, as requested by Aurelien. * Shorten the branch-to-next in the EQ case of i386 brcond2, as pointed out by Laurent. r~ Richard Henderson (6):

[Qemu-devel] [PATCH 1/6] tcg: Document double-word support opcodes.

The internal opcodes brcond2, add2, sub2, mulu2 were undocumented. Place these in a new section that clearly indicates that they are not to be emitted by translators. Signed-off-by: Richard Henderson --- tcg/README | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'

"Krumme, Chris" writes: > Hello Markus, > > Not sure of the best answer, but thought there should be some > discussion. > > You mention Mebibyte, which according to the all knowing Wikipedia, is > abbreviated Mi. > > I understand that if you will only support one, then maybe you don't > need to d

[Qemu-devel] [PATCH v2 2/2] block: kill BDRV_O_CREAT

The BDRV_O_CREAT option is unused inside qemu and partially duplicates the bdrv_create method. Remove it, and the -C option to qemu-io which isn't used in qemu-iotests anyway. Signed-off-by: Christoph Hellwig Index: qemu/block.h ==

[Qemu-devel] [PATCH v2 1/2] block: clean up bdrv_open2 structure a bit

Check the whitelist as early as possible instead of continuing the setup, and move all the error handling code to the end of the function. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2010-01-20 1

Re: [Qemu-devel] [PATCH v2 0/4] Modifications to the drives' readonly attribute

Looking at the version of this that landed in git I don't think the read-only handling is entirely clean after this. - we now normally set the read_only flag from bdrv_open2 when we do not have the O_RDWR flag set - but the block drivers also mess with it: o raw-posix superflously set

[Qemu-devel] [PATCH] ide save/restore current transfer fields

From: Marcelo Tosatti If migration takes place between write of the bmdma address register and write of the command register (to initiate DMA), the destination will not properly start the DMA op, hanging the guest: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen ata1.00: cmd c8/

[Qemu-devel] Re: [PATCH] ide save/restore current transfer fields

Marcelo Tosatti wrote: > If migration takes place between write of the bmdma address register and > write of the command register (to initiate DMA), the destination will > not properly start the DMA op, hanging the guest: > > ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen > ata1.

Re: [Qemu-devel] Re: Stop using "which" in ./configure

On Wed, Jan 20, 2010, Paolo Bonzini wrote: > > Are you saying that I can't backup/restore IFS without setting it > > first? > Yes, it affects the behavior of read for example: > $ echo a b c | (read a b c; echo $a; echo $b; echo $c) > a > b > c > $ IFS= > $ echo a b c | (read a b c; echo $a; echo

Re: [Qemu-devel] [PATCH] fix savevm command without id or tag

Am 20.01.2010 17:26, schrieb Marcelo Tosatti: > > savevm without id or tag segfaults in: > > (gdb) bt > #0 0x7f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6 > #1 0x004745b6 in bdrv_snapshot_find (bs=, > sn_info=0x7fff996be280, name=0x0) at savevm.c:1631 > #2 0x0

RE: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'

> -Original Message- > From: > qemu-devel-bounces+chris.krumme=windriver@nongnu.org > [mailto:qemu-devel-bounces+chris.krumme=windriver@nongnu.o > rg] On Behalf Of Markus Armbruster > Sent: Wednesday, January 20, 2010 10:08 AM > To: qemu-devel@nongnu.org > Subject: [Qemu-devel] [P

[Qemu-devel] [PATCH 5/5] PCI: do_pci_info(): PCI bridge devices support

This commit completes the do_pci_info() conversion to QObject by adding support to PCI bridge devices. This is done by recursively adding devices in the "pci_bridge" key. IMPORTANT: This code is being added separately because I could NOT test it properly. According to Michael Tsirkin, it depends

[Qemu-devel] [PATCH 4/5] PCI: do_pci_info(): PCI bridge support

This commit adds the "pci_bridge" key to the PCI device QDict, it also adds support for printing it in the user protocol. IMPORTANT: This code is being added separately because I could NOT test it properly. According to Michael Tsirkin, it depends on ultrasparc and it would take time to do the pro

[Qemu-devel] [PATCH 3/5] PCI: Convert pci_info() to QObject

The returned QObject is a QList of all buses. Each bus is represented by a QDict, which has a key with a QList of all PCI devices attached to it. Each device is represented by a QDict. IMPORTANT: support for printing PCI bridge information and its devices is NOT part of this commit, it's going to

[Qemu-devel] [PATCH 2/5] QDict: Introduce qdict_get_qdict()

A helper to retrieve a QDict from a QDict. Signed-off-by: Luiz Capitulino --- qdict.c | 13 + qdict.h |1 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/qdict.c b/qdict.c index ba8eef0..c6a5a42 100644 --- a/qdict.c +++ b/qdict.c @@ -216,6 +216,19 @@ QList *qd

[Qemu-devel] [PATCH 1/5] QList: Introduce QLIST_FOREACH_ENTRY()

Iterate over QList entries, it's needed to call qlist_entry_obj() to retrieve the stored QObject. I'm not sure if it's ok to have this, because it's not as easy as qlist_iter() and the QListEntry data type is now exposed to the users, which means we have one more struct to be maintained when we ha

[Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

Hi, This new version addresses Markus's comments. changelog - V1 -> V2 - Make class_info's key 'desc' optional - Better indentation - Doc fixes V0 -> V1 - Coding style fixes - Make 'BAR' and 'IRQ' keys lowercase - Add 'irq' key to the documentation Thanks.

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

Am 20.01.2010 17:24, schrieb Christoph Hellwig: > On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: >> Am 19.01.2010 22:15, schrieb Christoph Hellwig: >>> If we go over the maximum number of iovecs support by syscall we get >>> back EINVAL from the kernel which translate to I/O errors for

[Qemu-devel] [PATCH] fix savevm command without id or tag

savevm without id or tag segfaults in: (gdb) bt #0 0x7f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6 #1 0x004745b6 in bdrv_snapshot_find (bs=, sn_info=0x7fff996be280, name=0x0) at savevm.c:1631 #2 0x00475c80 in del_existing_snapshots (name=, mon=) at savevm.

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: > Am 19.01.2010 22:15, schrieb Christoph Hellwig: > > If we go over the maximum number of iovecs support by syscall we get > > back EINVAL from the kernel which translate to I/O errors for the guest. > > > > Signed-off-by: Christoph Hellw

[Qemu-devel] [PATCH] ide save/restore current transfer fields

If migration takes place between write of the bmdma address register and write of the command register (to initiate DMA), the destination will not properly start the DMA op, hanging the guest: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen ata1.00: cmd c8/00:16:41:00:00/00:00:00

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

Kirill A. Shutemov wrote: > On Wed, Jan 20, 2010 at 3:03 PM, Markus Armbruster wrote: > > "Kirill A. Shutemov" writes: > >> No, compiler can't add anything between. 'char' is always byte-aligned. > > > > You got some reading to do then. > > Do you want to say that it's not true? Could you provid

[Qemu-devel] [PATCH] make: qemu-img depends on config-host.h

Fixes mingw32 build out of tree. Signed-off-by: Anthony Liguori --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b1bbe6d..60d5c66 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,7 @@ bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS)

[Qemu-devel] Re: [PATCH v2 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject

Please ignore the v2 in the subject, it's an accident.

[Qemu-devel] [PATCH v2 6/8] monitor: New argument type 'T'

This is a double value with optional suffixes ms, us, ns. We'll need this to get migrate_set_downtime() QMP-ready. Signed-off-by: Markus Armbruster --- monitor.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index ce97e7b..6dafe0b

[Qemu-devel] [PATCH v2 7/8] monitor: Use argument type 'T' for migrate_set_downtime()

Before, it used type 's', which strips quotes and interprets escapes, and is quite inappropriate for QMP. Signed-off-by: Markus Armbruster --- migration.c | 15 ++- qemu-monitor.hx |2 +- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/migration.c b/migratio

[Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'

Was forgotten in commit b6e098d7. Signed-off-by: Markus Armbruster --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index b9166c3..775fe3f 100644 --- a/monitor.c +++ b/monitor.c @@ -68,6 +68,8 @@ * 's' string (accept optiona

[Qemu-devel] [PATCH v2 8/8] monitor: convert do_migrate_set_downtime() to QObject

Signed-off-by: Markus Armbruster --- migration.c |3 ++- migration.h |3 ++- qemu-monitor.hx |2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index c7763f6..2dfb4cd 100644 --- a/migration.c +++ b/migration.c @@ -132,7 +132,8 @@ u

[Qemu-devel] [PATCH v2 5/8] monitor: convert do_migrate_set_speed() to QObject

Signed-off-by: Markus Armbruster --- migration.c |2 +- migration.h |2 +- qemu-monitor.hx |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index 4e7a1ea..e8802ba 100644 --- a/migration.c +++ b/migration.c @@ -106,7 +106,7 @@ voi

[Qemu-devel] [PATCH v2 2/8] QDict: New qdict_get_double()

Helper function just like qdict_get_int(), just for QFloat/double. Signed-off-by: Markus Armbruster --- qdict.c | 15 +++ qdict.h |1 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/qdict.c b/qdict.c index ba8eef0..de278b1 100644 --- a/qdict.c +++ b/qdict.c @@

[Qemu-devel] [PATCH v2 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject

These conversions take a few extra steps, because do_migrate_set_speed() and do_migrate_set_downtime() interpret their string argument as floating-point number + optional unit suffix. This is quite inappropriate for QMP. Markus Armbruster (8): monitor: Document argument type 'M' QDict: New qd

[Qemu-devel] [PATCH v2 3/8] monitor: New argument type 'b'

This is a double value with optional suffixes G, g, M, m, K, k. We'll need this to get migrate_set_speed() QMP-ready. Signed-off-by: Markus Armbruster --- monitor.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a

  1   2   >