[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2009 at 08:55:38PM -0600, Anthony Liguori wrote: >> Anthony - it looks like you've made some changes to your seabios repo, >> but I don't think you've pushed them yet. > > I've pushed now. Don't worry about merging them from me though, it's > easy enough to let git do it's magic

Re: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Kevin O'Connor wrote: On Fri, Dec 18, 2009 at 11:12:06AM -0600, Anthony Liguori wrote: BTW, the following works: sudo x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot -m 512 -net nic,model=rtl8139,macaddr=56:54:32:12:34:56 -net nic,model=e1000,macaddr=56:54:32:12:34:57

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Anthony Liguori
Kevin O'Connor wrote: On Fri, Dec 18, 2009 at 12:16:00PM +0100, Gerd Hoffmann wrote: Hi, qemu is about to change the way how option roms are loaded. pci roms will be loaded into a option rom bar (like real hardware does). non-pci roms can be loaded using the qemu firmware interface. With

Re: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2009 at 11:12:06AM -0600, Anthony Liguori wrote: > BTW, the following works: > > sudo x86_64-softmmu/qemu-system-x86_64 -hda ~/images/linux.img -snapshot > -m 512 -net nic,model=rtl8139,macaddr=56:54:32:12:34:56 -net > nic,model=e1000,macaddr=56:54:32:12:34:57 -net > nic,model

[Qemu-devel] [PATCH] PPC: Fix ppc32 kvm build

2009-12-18 Thread Alexander Graf
My segment sync patch broke compilation on PPC32, because it was trying to sync the SLB even though ppc32 CPUs don't have an SLB. So let's only sync it when we're on a PP64 one! Signed-off-by: Alexander Graf --- target-ppc/kvm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-18 Thread Juan Quintela
"Kirill A. Shutemov" wrote: > ping? Blue or Anthony, please apply. Patch is needed to get libuser + pie working well. Later, Juan. > On Wed, Dec 16, 2009 at 4:20 PM, Kirill A. Shutemov > wrote: >> We really need compile _all_ sources for user target with -fpie when >> use --enable-user-pie. >>

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2009 at 12:16:00PM +0100, Gerd Hoffmann wrote: > Hi, > > qemu is about to change the way how option roms are loaded. pci roms > will be loaded into a option rom bar (like real hardware does). > non-pci roms can be loaded using the qemu firmware interface. > > With this change s

[Qemu-devel] Re: [PATCH] user_only: compile everything with -fpie

2009-12-18 Thread Kirill A. Shutemov
ping? On Wed, Dec 16, 2009 at 4:20 PM, Kirill A. Shutemov wrote: > We really need compile _all_ sources for user target with -fpie when > use --enable-user-pie. > > It's regression introduced by commit add16157d72454. > > Signed-off-by: Kirill A. Shutemov > Cc: Blue Swirl > Signed-off-by: Juan

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Kevin O'Connor
On Fri, Dec 18, 2009 at 04:52:08PM +0100, Gerd Hoffmann wrote: > On 12/18/09 16:41, Anthony Liguori wrote: >> I needed the following patch for this series to build: >> >> --- a/src/optionroms.c >> +++ b/src/optionroms.c >> @@ -13,6 +13,7 @@ >> +#include "paravirt.h" // qemu_cfg_* > >> --- a/src/par

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Anthony Liguori
Sebastian Herbszt wrote: Actually you have to else networking doesn't work at all. Without specifying "vlan" with the "-device" syntax you end up with vlan= and not vlan=0 with "info qtree". -netdev type=tap,id=mynic -device ne2k_isa,irq=5,iobase=0x280,id=mynic One of the changes in 0.12 all

[Qemu-devel] [PATCH] PPC: Use interrupts for escc

2009-12-18 Thread Alexander Graf
When using the escc with Linux, we need interrupts. So instead of creating a dummy device, let's just map them to the openpic we have anyways. This makes Linux on PPC64 with console=ttyPZ0 work. Obviously, this change needs to be reflected in openbios. Patch for that follows this one. Please upda

[Qemu-devel] [PATCH] PPC: Initialize OpenPIC properly

2009-12-18 Thread Alexander Graf
When lowering an IRQ line, we search for the line we're supposed to lower. Usually we run into an optimization there that queues up interrupts. This queue ends with -1. Unfortunately we didn't set the first item to -1. This patch fixes this, making interrupts work on PPC64. Signed-off-by: Alexan

[Qemu-devel] [PATCH] target-alpha: Emit tcg debug_insn_start.

2009-12-18 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-alpha/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 45cb697..ceff9bf 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c @@ -2627,6 +262

Re: [Qemu-devel] [PATCH] target-arm: ARMv4 emulation

2009-12-18 Thread Aurelien Jarno
On Fri, Dec 18, 2009 at 10:32:37PM +0100, Marc Andre Tanner wrote: > On Tue, Dec 01, 2009 at 09:41:43PM +0100, Filip Navara wrote: > > While most of the ARMv5 instructions are backward compatible with ARMv4, > > there > > are few important differences. Most notably the stack pop and load > > inst

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Sebastian Herbszt
Anthony Liguori wrote: Sebastian Herbszt wrote: Gerd Hoffmann wrote: On 12/18/09 07:12, Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=

Re: [Qemu-devel] [PATCH] target-arm: ARMv4 emulation

2009-12-18 Thread Marc Andre Tanner
On Tue, Dec 01, 2009 at 09:41:43PM +0100, Filip Navara wrote: > While most of the ARMv5 instructions are backward compatible with ARMv4, there > are few important differences. Most notably the stack pop and load > instructions > ignore the lowest bit, which is used by ARMv5 to switch to Thumb mode

[Qemu-devel] tcg conditional set/move, round 3

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:37 AM, Laurent Desnogues wrote: tcg: Generic support for conditional set and conditional move. Needs cosmetics changes. Fixed, attachment 1. tcg-x86_64: Implement setcond and movcond. Some cosmetics and comments, but overall good. Fixed, attachment 2. tcg-i386:

Re: [Qemu-devel] [PATCH] S390: Bail out whithout KVM

2009-12-18 Thread Andreas Färber
Am 18.12.2009 um 22:07 schrieb Alexander Graf: Andreas Färber wrote: Hi, Am 18.12.2009 um 16:29 schrieb Alexander Graf: Currently only the S390 KVM target works. To keep users from accidently not using KVM, let's not even initialize the machine when KVM is not used. How does this fit to

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Sebastian Herbszt
Anthony Liguori wrote: Sebastian Herbszt wrote: Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device n

Re: [Qemu-devel] [FOR 0.12] monitor: Revert do_migrate_set_speed() conversion

2009-12-18 Thread Markus Armbruster
Luiz Capitulino writes: > This reverts commit 3a4921. do_migrate_set_speed() accepts > a suffix for the 'value' argument and this is not good for > QMP. > > We will have to add a new argument type to handle that and > this will have to wait for 0.13. > > Signed-off-by: Luiz Capitulino Yes, this

Re: [Qemu-devel] [PATCH] S390: Bail out whithout KVM

2009-12-18 Thread Alexander Graf
Andreas Färber wrote: > Hi, > > Am 18.12.2009 um 16:29 schrieb Alexander Graf: > >> Currently only the S390 KVM target works. To keep users from >> accidently not >> using KVM, let's not even initialize the machine when KVM is not used. > > How does this fit together with your "S390 TCG target" pat

Re: [Qemu-devel] [PATCH] S390: Bail out whithout KVM

2009-12-18 Thread Andreas Färber
Hi, Am 18.12.2009 um 16:29 schrieb Alexander Graf: Currently only the S390 KVM target works. To keep users from accidently not using KVM, let's not even initialize the machine when KVM is not used. How does this fit together with your "S390 TCG target" patch? Aren't they mutually exclusiv

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Anthony Liguori
Sebastian Herbszt wrote: Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device ne2k_isa,irq=5,iobase=0x2

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Anthony Liguori
Sebastian Herbszt wrote: Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device ne2k_isa,irq=5,iobase=0x2

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Anthony Liguori
Sebastian Herbszt wrote: Gerd Hoffmann wrote: On 12/18/09 07:12, Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x

[Qemu-devel] Re: [PATCH v2 STABLE] monitor: allow device to be ejected if no disk is inserted

2009-12-18 Thread Luiz Capitulino
On Fri, 18 Dec 2009 18:22:41 -0200 Eduardo Habkost wrote: > On Fri, Dec 18, 2009 at 06:15:27PM -0200, Luiz Capitulino wrote: > > On Fri, 18 Dec 2009 17:07:43 -0200 > > Eduardo Habkost wrote: > > > > > When using a file, eject works as expected. But when using a host cdrom > > > device: > > >

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Sebastian Herbszt
Gerd Hoffmann wrote: On 12/18/09 17:42, Anthony Liguori wrote: Do we need to do something for -M pc-0.11? Like loading the pci roms via fw_cfg too so the guest doesn't see the new pci rom bar? Yes, we do. We can fix that problem as a stable-0.12 update though. Right now, migration with pc-0.11

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Sebastian Herbszt
Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device ne2k_isa,irq=5,iobase=0x280 If i specify "-net ni

[Qemu-devel] Re: [PATCH v2 STABLE] monitor: allow device to be ejected if no disk is inserted

2009-12-18 Thread Eduardo Habkost
On Fri, Dec 18, 2009 at 06:15:27PM -0200, Luiz Capitulino wrote: > On Fri, 18 Dec 2009 17:07:43 -0200 > Eduardo Habkost wrote: > > > When using a file, eject works as expected. But when using a host cdrom > > device: > > > > (qemu) change ide1-cd0 /dev/cdrom > > (qemu) info block > > ide1

[Qemu-devel] Re: [PATCH v2 STABLE] monitor: allow device to be ejected if no disk is inserted

2009-12-18 Thread Luiz Capitulino
On Fri, 18 Dec 2009 17:07:43 -0200 Eduardo Habkost wrote: > When using a file, eject works as expected. But when using a host cdrom > device: > > (qemu) change ide1-cd0 /dev/cdrom > (qemu) info block > ide1-cd0: type=cdrom removable=1 locked=0 file=/dev/cdrom ro=0 > drv=host_cdrom encryp

Re: [Qemu-devel] Re: SVM support in 0.12?

2009-12-18 Thread Alexander Graf
Jamie Lokier wrote: > Alexander Graf wrote: > >> Am 18.12.2009 um 03:39 schrieb Jun Koi >> >> >>> On Fri, Dec 18, 2009 at 11:37 AM, Jun Koi >>> wrote: >>> Hi, I am running latest Qemu 0.12-rc. My guest VM runs Linux kernel 2.6.31. Because Qemu now

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Sebastian Herbszt
Anthony Liguori wrote: Sebastian Herbszt wrote: Gerd Hoffmann wrote: On 12/18/09 17:42, Anthony Liguori wrote: Do we need to do something for -M pc-0.11? Like loading the pci roms via fw_cfg too so the guest doesn't see the new pci rom bar? Yes, we do. We can fix that problem as a stable-0.1

Re: [Qemu-devel] Re: SVM support in 0.12?

2009-12-18 Thread Jamie Lokier
Alexander Graf wrote: > > Am 18.12.2009 um 03:39 schrieb Jun Koi > > >On Fri, Dec 18, 2009 at 11:37 AM, Jun Koi > >wrote: > >>Hi, > >> > >>I am running latest Qemu 0.12-rc. My guest VM runs Linux kernel > >>2.6.31. > >> > >>Because Qemu now supports SVM, I expect to see the SVM flag in > >>

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Sebastian Herbszt
Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device ne2k_isa,irq=5,iobase=0x280 Shouldn't this also b

Re: [Qemu-devel] ne2k_isa: how to specify a custom iobase and irq?

2009-12-18 Thread Sebastian Herbszt
Gerd Hoffmann wrote: On 12/18/09 07:12, Markus Armbruster wrote: "Sebastian Herbszt" writes: The default iobase and irq for the ne2k_isa card are 0x300 and 9. It should be possible to override both using the "-net" syntax like "-net nic,model=ne2k_isa,irq=5,iobase=0x280". -device ne2k_isa,i

[Qemu-devel] [FOR 0.12] monitor: Revert do_migrate_set_speed() conversion

2009-12-18 Thread Luiz Capitulino
This reverts commit 3a4921. do_migrate_set_speed() accepts a suffix for the 'value' argument and this is not good for QMP. We will have to add a new argument type to handle that and this will have to wait for 0.13. Signed-off-by: Luiz Capitulino --- migration.c |2 +- migration.h |

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Sebastian Herbszt wrote: Gerd Hoffmann wrote: On 12/18/09 17:42, Anthony Liguori wrote: Do we need to do something for -M pc-0.11? Like loading the pci roms via fw_cfg too so the guest doesn't see the new pci rom bar? Yes, we do. We can fix that problem as a stable-0.12 update though. Right n

[Qemu-devel] [PATCH v2 STABLE] monitor: allow device to be ejected if no disk is inserted

2009-12-18 Thread Eduardo Habkost
Rebasing previous patch to latest staging tree. For the master branch and stable-0.12. This changes the monitor eject_device() function to not check for bdrv_is_inserted(). Example run where the bug manifests itself: (output of 'info block' is stripped to include only the CD-ROM device) QEMU

Re: [Qemu-devel] Re: [PATCH] fix tool/libuser makefile race

2009-12-18 Thread Andreas Färber
Hey, Am 18.12.2009 um 17:16 schrieb Juan Quintela: Paolo Bonzini wrote: I just had this race happen on me while building qemu. The problematic file in my case was cutils.o. I'm using GNU make's order-only dependencies to avoid that "make recurse-all" builds the tools as well. Signed-o

[Qemu-devel] [PATCH 2/2] multiboot: Separate multiboot loading into separate file

2009-12-18 Thread Adam Lackorzynski
multiboot: Separate multiboot loading into separate file Move multiboot loading code into a separate file as suggested by Alex Graf. Signed-off-by: Adam Lackorzynski --- Makefile.target |2 +- hw/multiboot.c | 326 +++ hw/multiboot.h |

[Qemu-devel] [PATCH 1/2] multiboot: Support arbitrary number of modules.

2009-12-18 Thread Adam Lackorzynski
multiboot: Support arbitrary number of modules. Signed-off-by: Adam Lackorzynski --- hw/pc.c | 268 +++ 1 files changed, 167 insertions(+), 101 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index db7d58e..2f5b3a1 100644 --- a/hw/pc.c ++

Re: [Qemu-devel] [PATCH 2/2] Fix for cdrom un-eject

2009-12-18 Thread Eduardo Habkost
Excerpts from Eduardo Habkost's message of Thu Dec 03 14:33:21 -0200 2009: > From: Naphtali Sprei > > When guest un-eject a cdrom, re-insert the cdrom image (re-open the drive's > file). > > Also, related changes for the un-eject: > o enter UNIT ATTENTION state only on change/insert media, not

[Qemu-devel] Re: QEMU hangs on sdl/monitor switch

2009-12-18 Thread Luiz Capitulino
On Tue, 8 Dec 2009 11:45:48 -0200 Luiz Capitulino wrote: > I'm getting a strange QEMU hang if a switch fast between the SDL main > screen and the monitor's prompt. This looks like a kernel bug, but I as > can't reproduce with qemu-kvm and as we're in testing phase, I figured I > would report it

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 18 Dec 2009 18:20:52 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> [...] >> > -4. Notes to Client implementors >> > >> > +4. Compatibility Considerations >> > + >> > >> >

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster wrote: >> While I think these promises are appropriate for a mature version of the >> protocol, I do not think we should make them for 0.12. >> >> We've just dreamed up version 0.1 of the protocol. It hasn't been used >> in anger. Yes, we put some ser

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Luiz Capitulino
On Fri, 18 Dec 2009 19:06:18 +0100 Markus Armbruster wrote: > Anthony Liguori writes: > > > Markus Armbruster wrote: > >> While I think these promises are appropriate for a mature version of the > >> protocol, I do not think we should make them for 0.12. > >> > >> We've just dreamed up version

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 18:14, Anthony Liguori wrote: If you've got additional changes, please send them out, otherwise, let me know if you're happy with what's in staging. Looks good. cheers, Gerd

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Luiz Capitulino
On Fri, 18 Dec 2009 18:20:52 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > [...] > > -4. Notes to Client implementors > > > > +4. Compatibility Considerations > > + > > > > -4.1 It is recommended to always start t

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Luiz Capitulino
On Fri, 18 Dec 2009 11:44:27 -0600 Anthony Liguori wrote: > Markus Armbruster wrote: > > While I think these promises are appropriate for a mature version of the > > protocol, I do not think we should make them for 0.12. > > > > We've just dreamed up version 0.1 of the protocol. It hasn't been u

Re: [Qemu-devel] Re: [PATCH 5/6] tcg-i386: Simplify brcond2.

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:40 AM, Laurent Desnogues wrote: I'm not sure I really like that rewrite, I find it hard to read. Convince me it's better :-) Would it be more obvious if I used a table instead of a switch? The code size reduction is Num:Value Size TypeBind Vis Ndx Name befo

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Anthony Liguori
Markus Armbruster wrote: While I think these promises are appropriate for a mature version of the protocol, I do not think we should make them for 0.12. We've just dreamed up version 0.1 of the protocol. It hasn't been used in anger. Yes, we put some serious thought in it, and we even have pro

Re: [Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Laurent Desnogues
On Fri, Dec 18, 2009 at 6:11 PM, Richard Henderson wrote: >> Also note that tcg_out_modrm will generate an unneeded prefix >> for some registers. cf. the patch I sent to the list months ago. > > Huh.  Didn't notice since the disassembler printed what I expected to see. >  Is fixing this at the sam

Re: [Qemu-devel] Re: SVM support in 0.12?

2009-12-18 Thread Alexander Graf
Am 18.12.2009 um 17:52 schrieb Jun Koi : On Fri, Dec 18, 2009 at 8:35 PM, Alexander Graf wrote: Am 18.12.2009 um 03:39 schrieb Jun Koi On Fri, Dec 18, 2009 at 11:37 AM, Jun Koi wrote: Hi, I am running latest Qemu 0.12-rc. My guest VM runs Linux kernel 2.6.31. Because Qemu now sup

Re: [Qemu-devel] [FOR 0.12 0/7]: More QMP related fixes

2009-12-18 Thread Markus Armbruster
Apart from the compatibility promise I challenged [PATCH 5/7], the series is fine, and I badly want it in 0.12.

Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Markus Armbruster
Luiz Capitulino writes: [...] > -4. Notes to Client implementors > > +4. Compatibility Considerations > + > > -4.1 It is recommended to always start the Server in pause mode, thus the > -Client is able to perform any setup pro

Re: [Qemu-devel] Re: [PATCH 4/6] tcg-i386: Implement small forward branches.

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:39 AM, Laurent Desnogues wrote: To be consistent with the rest I'd use: if (small) tcg_abort(); Ok. +tcg_out8(s, 0x0f); I don't think this prefix should be output. Oops. Paste-o. r~

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: Is 0.11 -> 0.12 migration supposed to work? That could become quite nasty too. But maybe that is impossible anyway due to the switch to seabios? In theory, it should work. SeaBIOS should not be a guest visible change because the guest should not depend on what BIOS we're us

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/18/09 17:42, Anthony Liguori wrote: Do we need to do something for -M pc-0.11? Like loading the pci roms via fw_cfg too so the guest doesn't see the new pci rom bar? Yes, we do. We can fix that problem as a stable-0.12 update though. Right now, migration with pc-0.11

Re: [Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:39 AM, Laurent Desnogues wrote: +static void tcg_out_setcond(TCGContext *s, int cond, TCGArg arg0, +TCGArg arg1, TCGArg arg2, int const_arg2, int rexw) Perhaps renaming arg0 to dest would make things slightly more readable. Ok. Also note that tcg

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 17:42, Anthony Liguori wrote: Do we need to do something for -M pc-0.11? Like loading the pci roms via fw_cfg too so the guest doesn't see the new pci rom bar? Yes, we do. We can fix that problem as a stable-0.12 update though. Right now, migration with pc-0.11 is broken in other ar

Re: [Qemu-devel] Re: SVM support in 0.12?

2009-12-18 Thread Jun Koi
On Fri, Dec 18, 2009 at 8:35 PM, Alexander Graf wrote: > > Am 18.12.2009 um 03:39 schrieb Jun Koi > >> On Fri, Dec 18, 2009 at 11:37 AM, Jun Koi wrote: >>> >>> Hi, >>> >>> I am running latest Qemu 0.12-rc. My guest VM runs Linux kernel 2.6.31. >>> >>> Because Qemu now supports SVM, I expect to s

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/18/09 15:35, Anthony Liguori wrote: I know this series carries a good bit of risk but I'd like to bring it in 0.12.0. Because this has a guest visible change to the PCI devices, we cannot carry it in stable-0.12 post release and I think the functionality it brings it'

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 17:22, Anthony Liguori wrote: I think your fw_cfg.h changes also broke the optionroms/multiboot build. Haven't debugged yet though. That one is easy to fix, see attachment cheers, Gerd diff --git a/hw/fw_cfg.h b/hw/fw_cfg.h index a63f54f..c1019d0 100644 --- a/hw/fw_cfg.h +++ b/hw

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 15:35, Anthony Liguori wrote: I know this series carries a good bit of risk but I'd like to bring it in 0.12.0. Because this has a guest visible change to the PCI devices, we cannot carry it in stable-0.12 post release and I think the functionality it brings it's very important. Th

[Qemu-devel] Re: [PATCH] fix tool/libuser makefile race

2009-12-18 Thread Paolo Bonzini
> Notice that cutils.o (from Makefile) is built in the root dir, and > cutils.o (from Makefile.user) is built into libuser/ directory. Ah, since that was the file that was built, that would be a problem with my reasoning. Definitely I saw the following in the log AR libuser.a CC

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/18/09 16:41, Anthony Liguori wrote: I needed the following patch for this series to build: --- a/src/optionroms.c +++ b/src/optionroms.c @@ -13,6 +13,7 @@ +#include "paravirt.h" // qemu_cfg_* --- a/src/paravirt.h +++ b/src/paravirt.h +u32 qemu_cfg_read_file(QemuCfg

[Qemu-devel] Re: [PATCH] fix tool/libuser makefile race

2009-12-18 Thread Juan Quintela
Paolo Bonzini wrote: > I just had this race happen on me while building qemu. The problematic > file in my case was cutils.o. I'm using GNU make's order-only > dependencies to avoid that "make recurse-all" builds the tools as well. > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH 2/2] VMDK4: Parse and check the createType (VMDK file type) field.

2009-12-18 Thread Richard W.M. Jones
Add Signed-off-by line. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~

[Qemu-devel] [PATCH 1/2] VMDK4: Parse the VMDK descriptor explicitly, improve handling of CIDs

2009-12-18 Thread Richard W.M. Jones
Let's fix a buffer overflow, and add the Signed-off-by line ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.red

Re: [Qemu-devel] [PATCH 0/7] tcg: conditional set and move opcodes

2009-12-18 Thread Richard Henderson
On 12/18/2009 07:40 AM, malc wrote: After fixing a bug (crop was done after reading the cr) i run some openssl speed benchmarks, and, at least here on an MPC7447A, got a speed degradation, tiny but consistent. Well, you could try rendering the setcond with branches instead of logical operation

[Qemu-devel] [PATCH 2/2] VMDK4: Parse and check the createType (VMDK file type) field.

2009-12-18 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v >From bc09a7473b0382fbac7c3702b668acc1b

[Qemu-devel] [PATCH 1/2] VMDK4: Parse the VMDK descriptor explicitly, improve handling of CIDs

2009-12-18 Thread Richard W.M. Jones
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v >From 69701355561c328fac5e7986d6122c841

[Qemu-devel] [PATCH 0/2] Small improvements to VMDK4 file handling

2009-12-18 Thread Richard W.M. Jones
We're tracing a bug in "qemu-img convert" where it will silently fail to convert certain types of VMDK file. The VMDK files produced by VMWare vSphere / ESX 4.0, which have the VMDK subformat "streamOptimized" are one notable case: https://bugzilla.redhat.com/show_bug.cgi?id=548723 These two

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 16:41, Anthony Liguori wrote: I needed the following patch for this series to build: --- a/src/optionroms.c +++ b/src/optionroms.c @@ -13,6 +13,7 @@ +#include "paravirt.h" // qemu_cfg_* --- a/src/paravirt.h +++ b/src/paravirt.h +u32 qemu_cfg_read_file(QemuCfgFile *entry, void *dst

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading

2009-12-18 Thread Anthony Liguori
I needed the following patch for this series to build: diff --git a/src/optionroms.c b/src/optionroms.c index c5de1ad..0be6852 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -13,6 +13,7 @@ #include "pci_regs.h" // PCI_ROM_ADDRESS #include "pci_ids.h" // PCI_CLASS_DISPLAY_VGA #include "bo

Re: [Qemu-devel] [PATCH 0/7] tcg: conditional set and move opcodes

2009-12-18 Thread malc
On Thu, 17 Dec 2009, Richard Henderson wrote: > On 12/17/2009 07:32 AM, malc wrote: > > > These new opcodes are considered "required" by the backend, > > > because expanding them at the tcg level breaks the basic block. > > > There might be some way to emulate within tcg internals, but > > > that

[Qemu-devel] [PATCH] S390: Bail out whithout KVM

2009-12-18 Thread Alexander Graf
Currently only the S390 KVM target works. To keep users from accidently not using KVM, let's not even initialize the machine when KVM is not used. Signed-off-by: Alexander Graf --- hw/s390-virtio.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/s390-virtio.c b/

[Qemu-devel] [PATCH 7/7] monitor: do_balloon(): Use 'M' argument type

2009-12-18 Thread Luiz Capitulino
This makes do_balloon() accept megabyte values from the user Monitor while accepting byte values for QMP. Signed-off-by: Luiz Capitulino --- monitor.c |3 +-- qemu-monitor.hx |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index f779680..

[Qemu-devel] [PATCH 6/7] monitor: Introduce 'M' argument type

2009-12-18 Thread Luiz Capitulino
This is a target long value in megabytes which should be converted to bytes. It will be used by handlers which accept a megabyte value when in "user mode". Signed-off-by: Luiz Capitulino --- monitor.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monito

[Qemu-devel] [PATCH 5/7] QMP: Update spec file

2009-12-18 Thread Luiz Capitulino
- Remove "draft" status - Change default success response to be json-object - Change error and event data member to be a json-object - Update examples - Add new section "Compatibility Considerations" - Other fixes and clarifications Signed-off-by: Luiz Capitulino --- QMP/qmp-spec.txt | 69

[Qemu-devel] [PATCH 4/7] QMP: Update README file

2009-12-18 Thread Luiz Capitulino
- Fix output description - Fix command-line usage notes - Minor improvements Signed-off-by: Luiz Capitulino --- QMP/README | 34 +++--- 1 files changed, 23 insertions(+), 11 deletions(-) diff --git a/QMP/README b/QMP/README index 50c31f2..09e7053 100644 --- a/QMP/R

[Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict

2009-12-18 Thread Luiz Capitulino
This is for debug purposes only. Signed-off-by: Luiz Capitulino --- monitor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index d238660..8ef1582 100644 --- a/monitor.c +++ b/monitor.c @@ -283,6 +283,7 @@ static void monitor_protocol_emitter(Moni

[Qemu-devel] [PATCH 2/7] QMP: Return an empty dict by default

2009-12-18 Thread Luiz Capitulino
Currently, when a regular command doesn't have any data to output, QMP will emit: { "return": "OK" } Returning an empty dict is better though, because dicts can support some protocol changes in a compatible way. So, with this commit we will return: { "return": {} } Signed-off-by: Luiz Capituli

[Qemu-devel] [PATCH 1/7] QMP: Only handle converted commands

2009-12-18 Thread Luiz Capitulino
Looks like I dropped this check when addressing the 'query-' commands request. QMP should only handle converted commands, obviously. Reported-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c

[Qemu-devel] [FOR 0.12 0/7]: More QMP related fixes

2009-12-18 Thread Luiz Capitulino
Apart form that there are two important changes: 1. New output for success response 2. A new argument type Thanks.

[Qemu-devel] [PATCH] S390 TCG target

2009-12-18 Thread Alexander Graf
We already have stubs for a TCG target on S390, but were missing code that would actually generate instructions. So I took Uli's patch, cleaned it up and present it to you again :-). I hope I found all odd coding style and unprettiness issues, but if you still spot one feel free to nag about it.

[Qemu-devel] Re: [SeaBIOS] [PATCH 0/8] option rom loading overhaul.

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: From: Anthony Liguori Hi, Option rom saga continued. This is the first series I consider ready for merging. Changes: * pci roms: will be loaded via option pci rom bar. * non-pci roms: will be loaded via fw_cfg. Note that using the old bochs-bios based pc-bios wil

Re: [Qemu-devel] Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: Hi, If you have a pending patch that you think should be considered for 0.12.0, please check this tree and let me know if it's not there. http://patchwork.ozlabs.org/patch/40546/ is missing. Picked this up, thanks. cheers, Gerd -- Regards, Anthony Liguori

[Qemu-devel] Re: Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Anthony Liguori
Jan Kiszka wrote: Anthony Liguori wrote: I haven't built/tested at all, but this is the set of patches I've collected for the 0.12.0 release. Will be testing tonight and tomorrow and tagging probably around 5pm CST. Will then upload the release and announce once things are propagated. If y

Re: [Qemu-devel] Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Anthony Liguori
Markus Armbruster wrote: Commit 731b9ff6 is correct, but commit 24598d23 is more general, and it comes first. Drop it the former? "Nice to have" commit log corrections: * 92375e10 qdev: Improve uni-north device names (was: [Qemu-devel] [FOR 0.12 PATCH] qdev: Replace device names containing wh

[Qemu-devel] Re: Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Anthony Liguori
Juan Quintela wrote: Anthony Liguori wrote: I haven't built/tested at all, but this is the set of patches I've collected for the 0.12.0 release. Will be testing tonight and tomorrow and tagging probably around 5pm CST. Will then upload the release and announce once things are propagated.

Re: [Qemu-devel] Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Anthony Liguori
Gerd Hoffmann wrote: Hi, If you have a pending patch that you think should be considered for 0.12.0, please check this tree and let me know if it's not there. Also missing: http://patchwork.ozlabs.org/patch/41172/ Had that one. Did you copy/paste the wrong url or just miss it in staging

[Qemu-devel] Re: [PATCH v2] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Kevin Wolf
Am 18.12.2009 13:37, schrieb Andre Przywara: > If QEMU finds newer kernel header files on compilation time, it will use > advertised features like pipe2 or SOCK_CLOEXEC by just doing a compile test. > If later the executables are executed on an older kernel (<2.6.27, > like Xen Dom0 2.6.18), then Q

[Qemu-devel] [PATCH v2] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Andre Przywara
If QEMU finds newer kernel header files on compilation time, it will use advertised features like pipe2 or SOCK_CLOEXEC by just doing a compile test. If later the executables are executed on an older kernel (<2.6.27, like Xen Dom0 2.6.18), then QEMU will fail on opening sockets and creating pipes a

Re: [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Andre Przywara
Kevin Wolf wrote: >> @@ -302,12 +306,14 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen) #ifdef CONFIG_ACCEPT4 ret = accept4(s, addr, addrlen, SOCK_CLOEXEC); -#else +if (ret != -1 || errno != EINVAL) { Shouldn't this be an ENOSYS? Oh, right you are. This wa

Re: [Qemu-devel] Staging tree updated with patches I'm considering for 0.12.0

2009-12-18 Thread Gerd Hoffmann
On 12/18/09 10:06, Gerd Hoffmann wrote: Hi, If you have a pending patch that you think should be considered for 0.12.0, please check this tree and let me know if it's not there. Also missing: http://patchwork.ozlabs.org/patch/41172/ Oops, false alarm. That one is in. /me was looking at

[Qemu-devel] Re: SVM support in 0.12?

2009-12-18 Thread Paolo Bonzini
On 12/18/2009 03:39 AM, Jun Koi wrote: On Fri, Dec 18, 2009 at 11:37 AM, Jun Koi wrote: Hi, I am running latest Qemu 0.12-rc. My guest VM runs Linux kernel 2.6.31. Because Qemu now supports SVM, I expect to see the SVM flag in /proc/cpuinfo, but that is not the case. So it seems SVM support

[Qemu-devel] Re: [PATCH 4/6] tcg-i386: Implement small forward branches.

2009-12-18 Thread Laurent Desnogues
On Thu, Dec 17, 2009 at 6:55 PM, Richard Henderson wrote: > There are places, like brcond2, where we know that the destination > of a forward branch will be within 127 bytes.  Add the R_386_PC8 > relocation type to support this, and add a flag to tcg_out_jxx to > generate it.  Set the flag in the

[Qemu-devel] Re: [PATCH 5/6] tcg-i386: Simplify brcond2.

2009-12-18 Thread Laurent Desnogues
On Thu, Dec 17, 2009 at 7:38 PM, Richard Henderson wrote: > Split out tcg_out_cond from tcg_out_brcond.  Add "small" arguments > to all branch functions for completeness.  Unify all the calls to > generate branches within brcond2 and pass on the small flag. > > Signed-off-by: Richard Henderson >

[Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Laurent Desnogues
On Thu, Dec 17, 2009 at 6:32 PM, Richard Henderson wrote: > Implement conditional moves in the x86_64 backend. > > Signed-off-by: Richard Henderson > --- >  tcg/x86_64/tcg-target.c |   65 -- >  1 files changed, 62 insertions(+), 3 deletions(-) > > diff

  1   2   >