Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Bernhard Fischer
On Wed, Jan 03, 2007 at 04:16:53PM +, Thiemo Seufer wrote: >Fabrice Bellard wrote: >> IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it >> is almost sure to break the dyngen stuff. If ever it is allowed, it >> should be done so that the CFLAGS for the files used by dyng

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Thiemo Seufer
Fabrice Bellard wrote: > IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it > is almost sure to break the dyngen stuff. If ever it is allowed, it > should be done so that the CFLAGS for the files used by dyngen are not > modified. That's why I made OP_CFLAGS a separate set

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Fabrice Bellard
IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it is almost sure to break the dyngen stuff. If ever it is allowed, it should be done so that the CFLAGS for the files used by dyngen are not modified. Fabrice. Thiemo Seufer wrote: Thiemo Seufer wrote: CVSROOT:/

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Thiemo Seufer
Daniel Jacobowitz wrote: > On Wed, Jan 03, 2007 at 02:42:20PM +, Thiemo Seufer wrote: > > +CFLAGS += $(OS_CFLAGS) > > Did you try this on any target that triggers one of the += cases? > > It's not the most intuitive thing in the world, but I believe make > ignores Makefile += operators if the

[Qemu-devel] qemu monitor.c

2007-01-03 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/01/03 15:20:39 Modified files: . : monitor.c Log message: memsave monitor command CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/monitor.c?cvsroot=qemu&r1=1.58&r2=1.5

[Qemu-devel] qemu/target-mips exec.h helper.c op_helper.c

2007-01-03 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/01/03 15:18:08 Modified files: target-mips: exec.h helper.c op_helper.c Log message: moved invalidate_tlb() to helper.c as a work around for gcc 3.2.2 bug - suppressed invalid tb_inv

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Thiemo Seufer
Bernhard Fischer wrote: > On Wed, Jan 03, 2007 at 01:59:50PM +, Thiemo Seufer wrote: > > >All of this works fine for me, but patches of this sort are likely to > >break things, so please test and comment. > > > > > >Thiemo > > > > >Index: Makefile.target > >===

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Daniel Jacobowitz
On Wed, Jan 03, 2007 at 02:42:20PM +, Thiemo Seufer wrote: > +CFLAGS += $(OS_CFLAGS) Did you try this on any target that triggers one of the += cases? It's not the most intuitive thing in the world, but I believe make ignores Makefile += operators if the variable was overridden on the command

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Thiemo Seufer
Thiemo Seufer wrote: > Thiemo Seufer wrote: > > CVSROOT:/sources/qemu > > Module name:qemu > > Changes by: Thiemo Seufer 07/01/01 21:31:01 > > > > Modified files: > > . : Makefile configure > > > > Log message: > > Fix Makefile weirdness. > > > > CVSWeb URL

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Bernhard Fischer
On Wed, Jan 03, 2007 at 01:59:50PM +, Thiemo Seufer wrote: >All of this works fine for me, but patches of this sort are likely to >break things, so please test and comment. > > >Thiemo > >Index: Makefile.target >=== >RCS file: /s

Re: [Qemu-devel] qemu Makefile configure

2007-01-03 Thread Thiemo Seufer
Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer 07/01/01 21:31:01 > > Modified files: > . : Makefile configure > > Log message: > Fix Makefile weirdness. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/qe