VmdkAdapterType',
> 'ChardevBackendKind',
> -'CpuS390Entitlement',
> -'CpuS390Polarization',
> -'CpuS390State',
> +'S390CpuEntitlement',
> +'S390CpuPolarization',
> +'S390CpuState',
> 'CxlCorErrorType',
> 'DisplayProtocol',
> 'DriveBackupWrapper',
It seems to be in alphabetical order. The new names don't follow the
original order.
Just the above nits,
Reviewed-by: Zhao Liu
> ---
> qapi/machine.json| 1 -
> hw/core/numa.c | 4 ++--
> hw/pci-bridge/cxl_upstream.c | 4 ++--
> 3 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Zhao Liu
On Thu, Dec 14, 2023 at 11:53:18PM +0100, Samuel Tardieu wrote:
> Date: Thu, 14 Dec 2023 23:53:18 +0100
> From: Samuel Tardieu
> Subject: [PATCH] docs: fix typo
> X-Mailer: git-send-email 2.42.0
>
> Signed-off-by: Samuel Tardieu
> ---
Reviewed-by: Zhao Liu
> doc
Hi Philippe,
On Fri, Feb 16, 2024 at 12:02:52PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Fri, 16 Feb 2024 12:02:52 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style
> X-Mailer: git-send-email 2.41.0
>
> QEMU's coding style gener
fer QDev API for QDev objects, avoid the underlying QOM layer.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/pc_sysfw.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sys
Hi Philippe,
On Fri, Feb 16, 2024 at 12:03:08PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Fri, 16 Feb 2024 12:03:08 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH 17/21] hw/i386/iommu: Prefer object_initialize_child over
> object_initialize
> X-Mailer: git-send-email 2.41.0
>
> When
Hi Philippe,
On Fri, Feb 16, 2024 at 12:03:02PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Fri, 16 Feb 2024 12:03:02 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH 11/21] hw/usb: Add QOM parentship relation with hub devices
> X-Mailer: git-send-email 2.41.0
>
> QDev objects created wit
ev objects, avoid the underlying QOM layer.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/musicpal.c | 2 +-
> hw/core/qdev.c| 2 +-
> hw/sparc/sun4m.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/usb/bus.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git a/hw/usb/bus.c b/hw/usb/bus.c
> index 59c39945dd..148224f06a 100644
> --- a/hw/usb/bus.c
> +++ b/hw/usb
r QDev objects, avoid the underlying QOM layer.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/mips/cpu.c | 2 +-
> target/xtensa/cpu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git a/target/mips/cpu.c b/tar
Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/usb.h| 1 -
> hw/usb/bus.c| 9 ++---
> hw/usb/dev-serial.c | 2 +-
> 3 files changed, 3 insertions(+), 9 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git a/include/hw/usb.h b/include/hw/usb.h
> index
fer QDev API for QDev objects, avoid the underlying QOM layer.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/ppc/spapr_cpu_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Zhao Liu
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr
s3adsp1800_mmu.c | 1 +
> hw/mips/cps.c| 1 +
> hw/nios2/10m50_devboard.c| 1 +
> hw/ppc/e500.c| 1 +
> hw/ppc/spapr.c | 1 +
> 7 files changed, 7 insertions(+)
Reviewed-by: Zhao Liu
&
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
ends/iommufd.c | 1 -
> chardev/char-fe.c | 1 -
> system/rtc.c | 1 -
> 3 files changed, 3 deletions(-)
>
Reviewed-by: Zhao Liu
t;
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> hw/ppc/spapr_pci.c| 5 ++---
> system/qdev-monitor.c | 8 +---
> 3 files changed, 7 insertions(+), 9 deletions(-)
>
Reviewed-by: Zhao Liu
up.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> block/snapshot.c | 7 ---
> blockdev.c | 2 +-
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
Reviewed-by: Zhao Liu
up.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> hw/core/qdev.c| 4 ++--
> system/qdev-monitor.c | 2 +-
> 3 files changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Zhao Liu
dé
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> qapi/opts-visitor.c | 2 +-
> util/qemu-option.c| 10 +-
> 3 files changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Zhao Liu
y: Markus Armbruster
> ---
> qapi/qobject-input-visitor.c | 32 ++++----
> qapi/string-input-visitor.c | 8
> qom/object.c | 12
> 3 files changed, 28 insertions(+), 24 deletions(-)
Reviewed-by: Zhao Liu
y).
>
> Signed-off-by: Philippe Mathieu-Daudé
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> qom/object.c | 4 ++--
> scripts/qapi/visit.py | 5 ++---
> 3 files changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by: Zhao Liu
++--
> migration/savevm.c| 2 +-
> 4 files changed, 4 insertions(+), 7 deletions(-)
Reviewed-by: Zhao Liu
lude/qapi/qmp/qerror.h.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> hw/core/qdev-properties.c | 3 +--
> 2 files changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Zhao Liu
ALID_PARAMETER_VALUE,
> - "vcpu_dirty_limit",
> - "is invalid, it must greater then 1 MB/s");
> +error_setg(errp, "Parameter 'vcpu_dirty_limit' is invalid,"
> + " it must greater than 1 MB/s");
> return false;
> }
>
Otherwise,
Reviewed-by: Zhao Liu
> diff --git a/rust/block/Cargo.toml b/rust/block/Cargo.toml
> new file mode 100644
> index 00..fbc2f2d6ef
> --- /dev/null
> +++ b/rust/block/Cargo.toml
> @@ -0,0 +1,16 @@
> +[package]
> +name = "block"
> +version = "0.1.0"
> +edition = "2021"
> +authors = ["Kevin Wolf "]
> +license = "GPL-
to update subprojects/.gitignore. With this nit fixed,
Reviewed-by: Zhao Liu
> +/// Use QEMU's event loops to run a Rust [`Future`] to completion and return
> its result.
> +///
> +/// This function must be called in coroutine context. If the future isn't
> ready yet, it yields.
> +pub fn qemu_co_run_future(future: F) -> F::Output {
> +let waker = Waker::from(Arc::new
> +use crate::driver::{block_driver, BdrvChild, BlockDriver, Mapping,
> MappingTarget, Request};
> +use crate::SizedIoBuffer;
> +use qemu_api::bindings;
it's better to list all items from bindings here, which helps in understanding
which parts will need a wrapper added later.
> +use qemu_api::er
> diff --git a/rust/qemu-api/Cargo.toml b/rust/qemu-api/Cargo.toml
> index 57747bc934..bc0393add4 100644
> --- a/rust/qemu-api/Cargo.toml
> +++ b/rust/qemu-api/Cargo.toml
> @@ -25,6 +25,7 @@ version_check = "~0.9"
> default = ["debug_cell"]
> allocator = []
> debug_cell = []
> +system= []
With
> +impl BdrvChild {
> +/// Creates a new child reference from a `BlockdevRef`.
> +pub unsafe fn new(
> +parent: *mut bindings::BlockDriverState,
> +bref: *mut bindings::BlockdevRef,
> +errp: *mut *mut bindings::Error,
> +) -> Option {
> +unsafe {
> +
lippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/block/fdc-isa.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Zhao Liu
> Reviewed-by: Daniel P. Berrangé
> Reviewed-by: Thomas Huth
> ---
> include/hw/virtio/virtio-pci.h | 4
> hw/virtio/virtio-pci.c | 6 +-
> 2 files changed, 1 insertion(+), 9 deletions(-)
Reviewed-by: Zhao Liu
ld
> compatibility code").
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/net/e1000.c | 72 ++
> 1 file changed, 14 insertions(+), 58 deletions(-)
Reviewed-by: Zhao Liu
ow unused empty pc_compat_2_5[] array.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> include/hw/i386/pc.h | 3 ---
> hw/i386/pc.c | 3 ---
> hw/i386/pc_piix.c| 13 -
> hw/i386/pc_q35.c | 13 -
> 4 files changed, 32 deletions(-)
Reviewed-by: Zhao Liu
CI_FLAG_* enum removal).
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> Reviewed-by: Thomas Huth
> ---
> include/hw/virtio/virtio-pci.h | 4
> hw/virtio/virtio-pci.c | 5 +
> 2 files changed, 1 insertion(+), 8 deletions(-)
Reviewed-by: Zhao Liu
nclude/hw/i386/x86.h | 5 -
> hw/i386/x86.c | 1 -
> target/i386/machine.c | 5 ++---
> 3 files changed, 2 insertions(+), 9 deletions(-)
Reviewed-by: Zhao Liu
t; include/hw/nvram/fw_cfg.h | 10
> hw/core/loader.c | 14 -
> hw/i386/pc.c | 7 +--
> hw/nvram/fw_cfg.c | 109 +++---
> system/vl.c | 5 --
> 7 files changed, 9 insertions(+), 141 deletions(-)
Reviewed-by: Zhao Liu
rray was only used by the pc-q35-2.5 and
> pc-i440fx-2.5 machines, which got removed. Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> include/hw/boards.h | 3 ---
> hw/core/machine.c | 9 -
> 2 files changed, 12 deletions(-)
Reviewed-by: Zhao Liu
; ---
> include/hw/i386/pc.h | 1 -
> hw/i386/pc.c | 13 +
> 2 files changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Zhao Liu
s only used by the pc-q35-2.4
> and pc-i440fx-2.4 machines, which got removed. Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> include/hw/i386/pc.h | 3 ---
> hw/i386/pc.c | 19 ---
> 2 files changed, 22 deletions(-)
Reviewed-by: Zhao Liu
el P. Berrangé
> ---
> target/i386/cpu.h | 1 -
> target/i386/cpu.c | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Zhao Liu
rray was only used by the pc-q35-2.4 and
> pc-i440fx-2.4 machines, which got removed. Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> include/hw/boards.h | 3 ---
> hw/core/machine.c | 9 -
> 2 files changed, 12 deletions(-)
Reviewed-by: Zhao Liu
s/qtest/test-x86-cpuid-compat.c | 14 --
> 3 files changed, 40 deletions(-)
Reviewed-by: Zhao Liu
Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> Reviewed-by: Thomas Huth
> ---
> hw/scsi/vmw_pvscsi.c | 26 +++---
> 1 file changed, 7 insertions(+), 19 deletions(-)
Reviewed-by: Zhao Liu
t_flags field.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> Reviewed-by: Thomas Huth
> ---
> hw/scsi/vmw_pvscsi.c | 30 +-
> 1 file changed, 1 insertion(+), 29 deletions(-)
Reviewed-by: Zhao Liu
> Simplify replacing pvscsi_realize() by pvscsi_instance_init(),
> removing the need for device_class_set_parent_realize().
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/scsi/vmw_pvscsi.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Zhao Liu
hilippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/net/vmxnet3.c | 20 ++--
> 1 file changed, 6 insertions(+), 14 deletions(-)
Reviewed-by: Zhao Liu
thieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/net/vmxnet3.c | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
Reviewed-by: Zhao Liu
rging vmxnet3_realize() within vmxnet3_instance_init(),
> removing the need for device_class_set_parent_realize().
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Daniel P. Berrangé
> ---
> hw/net/vmxnet3.c | 15 +--
> 1 file changed, 1 insertion(+), 14 deletions(-)
Reviewed-by: Zhao Liu
On Wed, May 28, 2025 at 10:09:56AM +0800, Xiaoyao Li wrote:
> Date: Wed, 28 May 2025 10:09:56 +0800
> From: Xiaoyao Li
> Subject: Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid
> field
>
> On 5/12/2025 4:39 PM, Philippe Mathieu-Daudé wrote:
> > The X86CPU::check_cpuid boolean w
et-info-qapi.h | 21 +
> include/qemu/target-info.h | 2 +-
> hw/core/machine-qmp-cmds.c | 8 +++-
> target-info.c | 8 ++++++++
> 4 files changed, 33 insertions(+), 6 deletions(-)
> create mode 100644 include/qemu/target-info-qapi.h
Reviewed-by: Zhao Liu
ouvier
> ---
> hw/core/null-machine.c | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
Reviewed-by: Zhao Liu
60 matches
Mail list logo
