Re: [PATCH 0/3] hw/sh4: Remove the deprecated SHIX machine

2024-09-06 Thread Yoshinori Sato
/meson.build| 1 - > hw/sh4/Kconfig | 7 - > hw/sh4/meson.build | 1 - > 12 files changed, 7 insertions(+), 401 deletions(-) > delete mode 100644 hw/block/tc58128.c > delete mode 100644 hw/sh4/shix.c > > -- > 2.45.2 > for hw/sh4 Reviewed-by: Yoshinori Sato -- Yosinori Sato

Re: [PATCH 1/2] target/sh4: Deprecate the shix machine

2024-01-09 Thread Yoshinori Sato
YPE_SH7750R_CPU; > +mc->deprecation_reason = "old and unmaintained - use a newer machine > instead"; > } > > DEFINE_MACHINE("shix", shix_machine_init) > -- > 2.42.0 > I can't maintain this either. Reviewed-by: Yoshinori Sato -- Yosinori Sato

Re: [PATCH v3 03/11] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary

2024-02-12 Thread Yoshinori Sato
{ > - sysbus_connect_irq(sci, i, s->irq[irqbase + i]); > +sysbus_connect_irq(sci, i, > + qdev_get_gpio_in(DEVICE(&s->icu), irqbase + i)); > } > sysbus_mmio_map(sci, 0, RX62N_SCI_BASE + unit * 0x08); > } > -- > 2.41.0 > Reviewed-by: Yoshinori Sato -- Yosinori Sato

Re: [PATCH v3 07/11] hw/sh4/r2d: Realize IDE controller before accessing it

2024-02-12 Thread Yoshinori Sato
sysbus_mmio_map(busdev, 1, 0x1400080c); > mmio_ide_init_drives(dev, dinfo, NULL); > -- > 2.41.0 > Reviewed-by: Yoshinori Sato -- Yosinori Sato

Re: [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h'

2024-02-12 Thread Yoshinori Sato
; +++ b/hw/rx/rx62n.c > @@ -23,6 +23,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qemu/error-report.h" > +#include "qemu/units.h" > #include "hw/rx/rx62n.h" > #include "hw/loader.h" > #include "hw/sysbus.h" > -- > 2.41.0 > Reviewed-by: Yoshinori Sato -- Yosinori Sato

Re: [PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-25 Thread Yoshinori Sato
On Fri, 20 Sep 2024 17:12:47 +0900, Thomas Huth wrote: > > On 20/09/2024 10.06, Yoshinori Sato wrote: > > On Wed, 18 Sep 2024 04:43:50 +0900, > > Thomas Huth wrote: > >> > >> Commit 0ea0538fae516f9b4 removed the default machine of the sh4 > >>

Re: [PATCH] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Yoshinori Sato
On Wed, 18 Sep 2024 04:43:50 +0900, Thomas Huth wrote: > > Commit 0ea0538fae516f9b4 removed the default machine of the sh4 > binaries, so a lot of iotests are failing now without such a default > machine. Teach the iotest harness to use the "r2d" machine instead > to fix this problem. > > Signed-