Re: [PULL 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-05-28 Thread Richard Henderson
On 5/27/24 23:12, Jeuk Kim wrote: From: Minwoo Im This patch adds support for MCQ defined in UFSHCI 4.0. This patch utilized the legacy I/O codes as much as possible to support MCQ. MCQ operation & runtime register is placed at 0x1000 offset of UFSHCI register statically with no spare space a

Re: [PULL v2 0/7] Block jobs patches for 2024-04-29

2024-05-28 Thread Richard Henderson
On 5/28/24 06:57, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit ad10b4badc1dd5b28305f9b9f1168cf0aa3ae946: Merge tag 'pull-error-2024-05-27' ofhttps://repo.or.cz/qemu/armbru into staging (2024-05-27 06:40:42 -0700) are available in the Git repository at: https:/

Re: [PULL v2 0/2] ufs queue

2024-06-03 Thread Richard Henderson
On 6/3/24 03:37, Jeuk Kim wrote: From: Jeuk Kim The following changes since commit 74abb45dac6979e7ff76172b7f0a24e869405184: Merge tag 'pull-target-arm-20240531' ofhttps://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-05-31 11:10:10 -0700) are available in the Git repository

Re: [PULL v2 0/2] NBD patches for 2024-05-30

2024-06-04 Thread Richard Henderson
On 6/3/24 09:21, Eric Blake wrote: The following changes since commit 3b2fe44bb7f605f179e5e7feb2c13c2eb3abbb80: Merge tag 'pull-request-2024-05-29' ofhttps://gitlab.com/thuth/qemu into staging (2024-05-29 08:38:20 -0700) are available in the Git repository at: https://repo.or.cz/qemu/e

Re: [PULL 0/8] Block layer patches

2024-06-13 Thread Richard Henderson
On 6/11/24 10:36, Kevin Wolf wrote: The following changes since commit 80e8f0602168f451a93e71cbb1d59e93d745e62e: Merge tag 'bsd-user-misc-2024q2-pull-request' of gitlab.com:bsdimp/qemu into staging (2024-06-09 11:21:55 -0700) are available in the Git repository at: https://repo.or.cz/qe

Re: [PULL 0/1] ufs queue

2024-06-30 Thread Richard Henderson
On 6/29/24 20:52, Jeuk Kim wrote: From: Jeuk Kim The following changes since commit 3665dd6bb9043bef181c91e2dce9e1efff47ed51: Merge tag 'for-upstream' ofhttps://gitlab.com/bonzini/qemu into staging (2024-06-28 16:09:38 -0700) are available in the Git repository at: https://gitlab.com/

Re: [PULL 0/4] Block layer patches (CVE-2024-4467)

2024-07-03 Thread Richard Henderson
On 7/2/24 09:39, Kevin Wolf wrote: The following changes since commit c80a339587fe4148292c260716482dd2f86d4476: Merge tag 'pull-target-arm-20240701' ofhttps://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-07-01 10:41:45 -0700) are available in the Git repository at: https

Re: [PULL 0/2] Block patches

2024-07-11 Thread Richard Henderson
On 7/11/24 02:17, Stefan Hajnoczi wrote: The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf: Merge tag 'pull-aspeed-20240709' ofhttps://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700) are available in the Git repository at: https://gitlab.com/

Re: [PULL 0/7] hw/nvme patches

2024-07-12 Thread Richard Henderson
On 7/11/24 11:04, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf: Merge tag 'pull-aspeed-20240709' ofhttps://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700) are available in the Git repository at:

Re: [PULL v2 0/1] ufs queue

2024-07-14 Thread Richard Henderson
On 7/14/24 01:24, Jeuk Kim wrote: From: Jeuk Kim The following changes since commit 37fbfda8f4145ba1700f63f0cb7be4c108d545de: Merge tag 'edgar/xen-queue-2024-07-12.for-upstream' ofhttps://gitlab.com/edgar.iglesias/qemu into staging (2024-07-12 09:53:22 -0700) are available in the Git rep

Re: [PULL 0/4] hw/nvme patches

2024-07-22 Thread Richard Henderson
On 7/23/24 02:40, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit a7ddb48bd1363c8bcdf42776d320289c42191f01: Merge tag 'pull-aspeed-20240721' ofhttps://github.com/legoater/qemu into staging (2024-07-22 07:52:05 +1000) are available in the Git repository at:

Re: [PULL 0/1] Block patches

2024-07-25 Thread Richard Henderson
On 7/26/24 06:12, Stefan Hajnoczi wrote: The following changes since commit 029e13a8a56a2931e7c24c0db52ae7256b932cb0: Merge tag 'bsd-user-for-9.1-pull-request' ofgitlab.com:bsdimp/qemu into staging (2024-07-25 09:53:57 +1000) are available in the Git repository at: https://gitlab.com/st

Re: [PATCH-for-9.1 1/5] hw/sd/sdcard: Explicit dummy byte value

2024-07-30 Thread Richard Henderson
ed to be static. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH-for-9.1 2/5] hw/sd/sdcard: Do not abort when reading DAT lines on invalid cmd state

2024-07-30 Thread Richard Henderson
eported-by: Zheyu Ma Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2454 Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH-for-9.1 3/5] hw/sd/sdhci: Reset @data_count index on invalid ADMA transfers

2024-07-30 Thread Richard Henderson
) Reported-by: Zheyu Ma Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2455 Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [PATCH-for-9.1 4/5] hw/sd/sdhci: Trace ADMA descriptors

2024-07-30 Thread Richard Henderson
/sd/sdhci.c @@ -693,6 +693,11 @@ typedef struct ADMADescr { uint8_t incr; } ADMADescr; +static void trace_adma_description(const char *type, const ADMADescr *dscr) +{ +trace_sdhci_adma_desc(type, dscr->addr, dscr->length, dscr->attr, dscr->incr); +} + Reviewed-by: Richa

Re: [PATCH-for-9.1 v2] hw/ide/pci.c: Remove dead code from bmdma_prepare_buf()

2024-08-05 Thread Richard Henderson
-off-by: Philippe Mathieu-Daudé --- v2: Break and return once at EOF --- hw/ide/pci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PULL 00/13] Block layer patches

2024-08-06 Thread Richard Henderson
On 8/6/24 07:08, Kevin Wolf wrote: The following changes since commit f9851d2ffef59b3a7f39513469263ab3b019480f: Merge tag 'migration-20240802-pull-request' ofhttps://gitlab.com/farosas/qemu into staging (2024-08-03 07:26:26 +1000) are available in the Git repository at: https://repo.or.

Re: [PULL v2 00/13] Block layer patches

2024-08-06 Thread Richard Henderson
On 8/6/24 18:02, Kevin Wolf wrote: The following changes since commit e7207a9971dd41618b407030902b0b2256deb664: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-08-06 08:02:34 +1000) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git

Re: [PULL v3 00/13] Block layer patches

2024-08-06 Thread Richard Henderson
On 8/7/24 04:23, Kevin Wolf wrote: The following changes since commit c659b7b3b4925f8cef486a3ee64e911519495782: Merge tag 'pull-riscv-to-apply-20240806-2' ofhttps://github.com/alistair23/qemu into staging (2024-08-06 17:35:51 +1000) are available in the Git repository at: https://repo.o

Re: [PULL 0/1] Block patches

2024-08-12 Thread Richard Henderson
On 8/13/24 01:55, Stefan Hajnoczi wrote: The following changes since commit 0f397dcfecc9211d12c2c720c01eb32f0eaa7d23: Merge tag 'pull-nbd-2024-08-08' ofhttps://repo.or.cz/qemu/ericb into staging (2024-08-09 08:40:37 +1000) are available in the Git repository at: https://gitlab.com/stefa

Re: [PULL for-9.1 0/1] hw/nvme late fix

2024-08-20 Thread Richard Henderson
On 8/20/24 14:45, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 48e4ba59a3756aad743982da16bf9b5120d91a0c: Merge tag 'pull-riscv-to-apply-20240819-1' ofhttps://github.com/alistair23/qemu into staging (2024-08-19 14:55:23 +1000) are available in the Git repos

Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-11 Thread Richard Henderson
On 9/11/24 08:25, Pierrick Bouvier wrote: On 9/11/24 05:51, Richard W.M. Jones wrote: Although it's unlikely to be used on any compiler that can also compile qemu, there is a third implementation of g_assert_not_reached that does nothing, see: https://gitlab.gnome.org/GNOME/glib/-/blob/927683eb

Re: [PULL v2 00/20] Block layer patches

2022-06-24 Thread Richard Henderson
On 6/24/22 08:40, Kevin Wolf wrote: The following changes since commit 3a821c52e1a30ecd9a436f2c67cc66b5628c829f: Merge tag 'nvme-next-pull-request' of git://git.infradead.org/qemu-nvme into staging (2022-06-23 14:52:30 -0700) are available in the Git repository at: git://repo.or.cz/qemu

Re: [PATCH 2/4] libvduse: Replace strcpy() with strncpy()

2022-06-27 Thread Richard Henderson
On 6/27/22 14:32, Xie Yongji wrote: -strcpy(dev_config->name, name); +strncpy(dev_config->name, name, VDUSE_NAME_MAX); +dev_config->name[VDUSE_NAME_MAX - 1] = '\0'; g_strlcpy r~

Re: [PATCH 3/4] libvduse: Pass positive value to strerror()

2022-06-27 Thread Richard Henderson
On 6/27/22 14:32, Xie Yongji wrote: The value passed to strerror() should be positive. So let's fix it. Fixes: Coverity CID 1490226, 1490223 Signed-off-by: Xie Yongji --- subprojects/libvduse/libvduse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Ri

Re: [PULL v2 0/9] Block jobs & NBD patches

2022-06-29 Thread Richard Henderson
On 6/29/22 13:45, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit ad4c7f529a279685da84297773b4ec8080153c2d: Merge tag 'pull-semi-20220628' of https://gitlab.com/rth7680/qemu into staging (2022-06-28 10:24:31 +0530) are available in the Git repository at: https://g

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-05 Thread Richard Henderson
On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- A

Re: [PULL 0/2] Block patches

2022-07-07 Thread Richard Henderson
On 7/7/22 13:42, Stefan Hajnoczi wrote: The following changes since commit 8e9398e3b1a860b8c29c670c1b6c36afe8d87849: Merge tag 'pull-ppc-20220706' of https://gitlab.com/danielhb/qemu into staging (2022-07-07 06:21:05 +0530) are available in the Git repository at: https://gitlab.com/stef

Re: [PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64

2022-07-07 Thread Richard Henderson
On 7/7/22 09:33, John Snow wrote: This checksum changes weekly; use a fixed point image and update the checksum so we don't have to re-download it quite so much. Note: Just like the centos.aarch64 test, this test currently seems very flaky when run as a TCG test. Signed-off-by: John Snow ---

Re: [PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-07 Thread Richard Henderson
On 7/7/22 09:33, John Snow wrote: 18.04 has fallen out of our support window, so move ubuntu.aarch64 forward to ubuntu 20.04, which is now our oldest supported Ubuntu release. Ah. Squash with patch 5? r~ Signed-off-by: John Snow --- tests/vm/ubuntu.aarch64 | 14 +++--- 1 file

Re: [PATCH v4 02/12] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-07-11 Thread Richard Henderson
tests/vm/centos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 04/12] tests/vm: switch centos.aarch64 to CentOS 8 Stream

2022-07-11 Thread Richard Henderson
file changed, 24 insertions(+), 150 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 05/12] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-11 Thread Richard Henderson
ts/vm/ubuntu.aarch64 | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 06/12] tests/vm: remove ubuntu.i386 VM test

2022-07-11 Thread Richard Henderson
), 42 deletions(-) delete mode 100755 tests/vm/ubuntu.i386 Reviewed-by: Richard Henderson r~

Re: [PATCH v4 03/12] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-07-11 Thread Richard Henderson
tions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 07/12] tests/vm: remove duplicate 'centos' VM test

2022-07-11 Thread Richard Henderson
(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v4 08/12] tests/vm: add 1GB extra memory per core

2022-07-11 Thread Richard Henderson
ss so that the config file, if provided, can still override it. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé --- tests/vm/basevm.py | 5 + 1 file changed, 5 insertions(+) Acked-by: Richard Henderson

Re: [PATCH v4 09/12] tests/vm: Remove docker cross-compile test from CentOS VM

2022-07-11 Thread Richard Henderson
emove this test as superfluous with our current CI infrastructure. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé --- tests/vm/centos | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-12 Thread Richard Henderson
On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- A

Re: [PATCH] iotests/copy-before-write: specify required_fmts

2022-07-12 Thread Richard Henderson
On 7/6/22 22:38, Vladimir Sementsov-Ogievskiy wrote: Declare that we need copy-before-write filter to avoid failure when filter is not whitelisted. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/copy-before-write | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

Re: [PULL 0/2] block: fix parallels block driver

2022-07-28 Thread Richard Henderson
On 7/27/22 12:06, Vladimir Sementsov-Ogievskiy wrote: The following changes since commit f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d: Merge tag 'pull-target-arm-20220726' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-26 08:32:01 -0700) are available in the Git repos

Re: [PULL for-7.1 0/3] hw/nvme fixes

2022-08-01 Thread Richard Henderson
On 8/1/22 03:05, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: gi

Re: [PULL 0/7] Block layer patches

2022-08-02 Thread Richard Henderson
On 8/2/22 06:37, Kevin Wolf wrote: The following changes since commit 60205b71421cbc529ca60b12c79e0eeace007319: Merge tag 'pull-aspeed-20220801' of https://github.com/legoater/qemu into staging (2022-08-01 13:55:11 -0700) are available in the Git repository at: git://repo.or.cz/qemu/kev

Re: [PULL for-7.1 0/1] Block patches

2022-08-04 Thread Richard Henderson
On 8/4/22 12:02, Stefan Hajnoczi wrote: The following changes since commit 2480f3bbd03814b0651a1f74959f5c6631ee5819: Merge tag 'linux-user-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-03 08:32:44 -0700) are available in the Git repository at: htt

Re: [PULL 0/1] Block layer patches

2022-08-23 Thread Richard Henderson
On 8/23/22 07:04, Kevin Wolf wrote: The following changes since commit ba58ccbef60338d0b7334c714589a6423a3e7f91: Merge tag 'for-7.1-hppa' of https://github.com/hdeller/qemu-hppa into staging (2022-08-19 09:35:29 -0700) are available in the Git repository at: git://repo.or.cz/qemu/kevin.

Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-30 Thread Richard Henderson
On 10/29/18 1:39 PM, Mark Cave-Ayland wrote: > You can install your own disk using debian-installer, with: > > ... > -M q800 \ > -serial none -serial mon:stdio \ > -m 1000M -drive file=m68k.qcow2,format=qcow2 \ > -net nic,model=dp83932,addr=09:00:07:12:34:57 \ > -append "co

Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] Remove deprecated load_image() function

2018-12-03 Thread Richard Henderson
image() > hw/i386/pc.c: Don't use load_image() > hw/i386/multiboot.c: Don't use load_image() > hw/block/tc58128.c: Don't use load_image() > device_tree.c: Don't use load_image() > hw/core/loader.c: Remove load_image() > include/hw/loader.h: Document load_im

Re: [Qemu-block] [PATCH 2/2] avoid TABs in files that only contain a few

2018-12-13 Thread Richard Henderson
On 12/13/18 4:37 PM, Paolo Bonzini wrote: > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. Acked-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v2 03/29] vhdx: use QEMU_ALIGN_DOWN

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vhdx-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard

Re: [Qemu-block] [Qemu-devel] [PATCH v2 07/29] dmg: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/qcow2-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard

Re: [Qemu-block] [Qemu-devel] [PATCH v2 10/29] vvfat: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:32 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vvfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard

Re: [Qemu-block] [Qemu-devel] [PATCH v2 09/29] vpc: use DIV_ROUND_UP

2017-07-14 Thread Richard Henderson
On 07/13/2017 06:31 AM, Marc-André Lureau wrote: I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau --- block/vpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard

Re: [Qemu-block] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-12 Thread Richard Henderson
On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote: > xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename > \"%s\"," > - " size %" PRId64 " (%" PRId64 " MB)\n", > + " size %" PRId64 " (%llu MB)\n", >blkdev->type, blkdev->fi

Re: [Qemu-block] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-12 Thread Richard Henderson
On 06/12/2018 11:04 AM, Eric Blake wrote: > On 06/12/2018 03:51 PM, Richard Henderson wrote: >> On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote: >>>   xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename >>> \"%s\&quo

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/9] util: Add UUID API

2016-08-10 Thread Richard Henderson
On 08/09/2016 12:19 PM, Fam Zheng wrote: +/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */ + +typedef struct { +unsigned char data[16]; +} QemuUUID; ... +void qemu_uuid_generate(QemuUUID *uuid) +{ +int i; +uint32_t *out = (uint32_t *)&uuid->data[0]; You can't do this cas

Re: [Qemu-block] [PATCH v4 1/9] util: Add UUID API

2016-08-11 Thread Richard Henderson
On 08/11/2016 05:50 AM, Fam Zheng wrote: +void qemu_uuid_bswap(QemuUUID *uuid) +{ +bswap32s((uint32_t *)&uuid->data[0]); +bswap16s((uint16_t *)&uuid->data[4]); +bswap16s((uint16_t *)&uuid->data[6]); +} You have alignment problems here too. Perhaps you really did want to add uint32

Re: [Qemu-block] [PATCH v4 1/9] util: Add UUID API

2016-08-11 Thread Richard Henderson
On 08/12/2016 03:01 AM, Fam Zheng wrote: On Thu, 08/11 23:21, Richard Henderson wrote: On 08/11/2016 05:50 AM, Fam Zheng wrote: +void qemu_uuid_bswap(QemuUUID *uuid) +{ +bswap32s((uint32_t *)&uuid->data[0]); +bswap16s((uint16_t *)&uuid->data[4]); +bswap16s((uint16_t *

Re: [Qemu-block] [PATCH v5 1/9] util: Add UUID API

2016-08-11 Thread Richard Henderson
On 08/12/2016 05:52 AM, Fam Zheng wrote: +/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */ + +typedef struct { +union { +unsigned char data[16]; +struct { +/* Generated in BE endian, can be swapped with qemu_uuid_bswap. */ Nit: BE endian is redundant.

Re: [Qemu-block] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-13 Thread Richard Henderson
On 06/13/2018 02:13 AM, Eric Blake wrote: > Or spell it UINT64_C(1) if you don't want a cast. Not unsigned is what I want most. r~

Re: [Qemu-block] [Qemu-devel] [PATCH v5 02/46] vdi: Use definitions from "qemu/units.h"

2018-06-26 Thread Richard Henderson
On 06/25/2018 05:41 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Stefan Weil > --- > block/vdi.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v5 13/46] hw/block: Use the IEC binary prefix definitions

2018-06-26 Thread Richard Henderson
off-by: Philippe Mathieu-Daudé > --- > hw/block/m25p80.c | 5 +++-- > hw/block/nvme.c| 3 ++- > hw/block/tc58128.c | 3 ++- > 3 files changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] block/qcow*: Don't take address of fields in packed structs

2018-10-09 Thread Richard Henderson
On 10/9/18 10:24 AM, Peter Maydell wrote: > Peter Maydell (3): > block/qcow2: Don't take address of fields in packed structs > block/qcow: Don't take address of fields in packed structs > block/qcow2-bitmap: Don't take address of fields in packed structs Rev

Re: [Qemu-block] [Qemu-devel] [PATCH 2/5] lockable: add QemuLockable

2018-02-03 Thread Richard Henderson
e of the builtin is such that it *must* eliminate the other branch; otherwise the types don't even match up. It might be worth using __attribute__((error("message"))) on the function too. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH 1/5] test-coroutine: add simple CoMutex test

2018-02-03 Thread Richard Henderson
test-coroutine.c | 50 > -- > 1 file changed, 48 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH 3/5] coroutine-lock: convert CoQueue to use QemuLockable

2018-02-03 Thread Richard Henderson
anged, 12 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] coroutine-lock: make qemu_co_enter_next thread-safe

2018-02-03 Thread Richard Henderson
+++-- > util/qemu-coroutine-lock.c | 10 -- > 3 files changed, 23 insertions(+), 10 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH 5/5] curl: convert to CoQueue

2018-02-03 Thread Richard Henderson
noczi > Signed-off-by: Paolo Bonzini > --- > block/curl.c | 20 > 1 file changed, 4 insertions(+), 16 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v1 16/23] tests/qemu-iotests/005: Add a sanity check for large sparse file support

2019-05-09 Thread Richard Henderson
lake > Reviewed-by: Eric Blake > Signed-off-by: Thomas Huth > Message-Id: <20190502084506.8009-2-th...@redhat.com> > Signed-off-by: Alex Bennée > --- > tests/qemu-iotests/005 | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v1 02/26] qemu-io-cmds: use clock_gettime for benchmarking

2019-05-30 Thread Richard Henderson
On 5/30/19 5:15 AM, Alex Bennée wrote: > -static struct timeval tsub(struct timeval t1, struct timeval t2) > +static struct timespec tsub(struct timespec t1, struct timespec t2) > { > -t1.tv_usec -= t2.tv_usec; > -if (t1.tv_usec < 0) { > -t1.tv_usec += 100; > +t1.tv_nsec -=

Re: [Qemu-block] [Qemu-devel] [PATCH v6 19/26] exec: Delete DEVICE_HOST_ENDIAN

2019-08-07 Thread Richard Henderson
On 8/7/19 3:22 AM, Paolo Bonzini wrote: > On 07/08/19 10:32, tony.ngu...@bt.com wrote: >> +#if defined(HOST_WORDS_BIGENDIAN) >> +    .endianness = MO_BE, >> +#else >> +    .endianness = MO_LE, >> +#endif > > Host endianness is just 0, isn't it? Yes. Just leaving a comment to that effect here for

Re: [Qemu-block] [Qemu-devel] [PATCH v6 03/26] memory: Introduce size_memop

2019-08-07 Thread Richard Henderson
ot; operand into a "MemOp op". > + */ > +return size; > +} > + Return type should remain unsigned until patch 11. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 10/26] cputlb: Access MemoryRegion with MemOp

2019-08-07 Thread Richard Henderson
tlb.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 11/26] memory: Access MemoryRegion with MemOp

2019-08-07 Thread Richard Henderson
9 + > memory.c | 7 +-- > 3 files changed, 23 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson > +/* MemOp to size in bytes. */ > +static inline unsigned memop_size(MemOp op) > +{ > +return 1 << ((op) & MO_SIZE); > +} s/(op)/op/ This is no longer a macro requiring such things. r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 13/26] target/mips: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread Richard Henderson
ith > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. > > Signed-off-by: Tony Nguyen > --- > target/mips/op_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread Richard Henderson
ith > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. > > Signed-off-by: Tony Nguyen > --- > hw/s390x/s390-pci-inst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 14/26] exec: Hard code size with MO_{8|16|32|64}

2019-08-07 Thread Richard Henderson
ith > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. > > Signed-off-by: Tony Nguyen > --- > memory_ldst.inc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp

2019-08-07 Thread Richard Henderson
2 files changed, 13 insertions(+), 15 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp

2019-08-07 Thread Richard Henderson
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote: > + &serial_mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 : > 1], This is of course "end != DEVICE_LITTLE_ENDIAN". r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 16/26] exec: Map device_endian onto MemOp

2019-08-07 Thread Richard Henderson
On 8/7/19 8:59 AM, Richard Henderson wrote: > On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote: >> + &serial_mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 : >> 1], > > This is of course "end != DEVICE_LITTLE_ENDIAN". And by that I mean drop the ?: operator. r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 17/26] exec: Replace device_endian with MemOp

2019-08-07 Thread Richard Henderson
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote: > Simplify endianness comparisons with consistent use of the more > expressive MemOp. > > Suggested-by: Richard Henderson > Signed-off-by: Tony Nguyen --- Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 18/26] exec: Delete device_endian

2019-08-07 Thread Richard Henderson
On 8/7/19 1:32 AM, tony.ngu...@bt.com wrote: > device_endian has been made redundant by MemOp. > > Signed-off-by: Tony Nguyen > --- > include/exec/cpu-common.h | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v6 21/26] cputlb: Replace size and endian operands for MemOp

2019-08-07 Thread Richard Henderson
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote: > @@ -1246,7 +1246,7 @@ typedef uint64_t FullLoadHelper(CPUArchState *env, > target_ulong addr, > > static inline uint64_t __attribute__((always_inline)) > load_helper(CPUArchState *env, target_ulong addr, TCGMemOpIdx oi, > -uintptr_t ret

Re: [Qemu-block] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness

2019-08-07 Thread Richard Henderson
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote: > @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, > hwaddr addr, > /* As length is under guest control, handle illegal values. */ > return; > } > +/* FIXME: memory_region_dispatch_write ignores MO_BS

Re: [Qemu-block] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness

2019-08-07 Thread Richard Henderson
On 8/7/19 11:00 AM, Paolo Bonzini wrote: > On 07/08/19 19:49, Richard Henderson wrote: >> On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote: >>> @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, >>> hwaddr addr, >>> /* As length is

Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE

2019-08-18 Thread Richard Henderson
On 8/16/19 7:28 AM, tony.ngu...@bt.com wrote: > Tony Nguyen (42): > configure: Define TARGET_ALIGNED_ONLY in configure > tcg: TCGMemOp is now accelerator independent MemOp > memory: Introduce size_memop > target/mips: Access MemoryRegion with MemOp > hw/s390x: Access MemoryRegion with Mem

Re: [Qemu-block] [Qemu-devel] [PATCH v7 36/42] memory: Access MemoryRegion with endianness

2019-08-18 Thread Richard Henderson
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote: > Preparation for collapsing the two byte swaps adjust_endianness and > handle_bswap into the former. > > Call memory_region_dispatch_{read|write} with endianness encoded into > the "MemOp op" operand. > > This patch does not change any behaviour as >

Re: [Qemu-block] [Qemu-devel] [PATCH v7 37/42] cputlb: Replace size and endian operands for MemOp

2019-08-18 Thread Richard Henderson
dr, val, oi, retaddr, 1, false); > +store_helper(env, addr, val, oi, retaddr, MO_8); > } MO_UB. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [Qemu-devel] [PATCH v7 38/42] memory: Single byte swap along the I/O path

2019-08-18 Thread Richard Henderson
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote: > +static void adjust_endianness(MemoryRegion *mr, uint64_t *data, MemOp op) > { > +if ((op & MO_BSWAP) != mr->ops->endianness) { > +switch (op & MO_SIZE) { You'll want to use devend_memop() here, as previously discussed. > @@ -2331,7 +23

Re: [Qemu-block] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Richard Henderson
On 8/19/19 11:29 AM, Paolo Bonzini wrote: > On 19/08/19 20:28, Paolo Bonzini wrote: >> On 16/08/19 12:12, Thomas Huth wrote: >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the >>> filter of the qemu-s390x list each time you send it. Please: >>> >>> 1) Try to break it up in m

Re: [PATCH 1/3] block/qcow2-bitmap: Remove unneeded variable assignment

2020-02-15 Thread Richard Henderson
t; > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé > --- > block/qcow2-bitmap.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 2/3] hw/display/qxl: Remove unneeded variable assignment

2020-02-15 Thread Richard Henderson
_t orig_io_port = io_port; >^~~~ ~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/qxl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 3/3] hw/block/pflash_cfi02: Remove unneeded variable assignment

2020-02-15 Thread Richard Henderson
t; > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/block/pflash_cfi02.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] configure: Avoid compiling system tools on user build by default

2020-02-15 Thread Richard Henderson
rtions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PULL 06/15] configure: Enable test and libs for zstd

2020-02-29 Thread Richard Henderson
> +## > +# zstd check > + > +if test "$zstd" != "no" ; then > +if $pkg_config --exist libzstd ; then The option is spelled --exists. This is generating an error during configure. r~

Re: [PATCH] target/rx/cpu: Use address_space_ldl() to read reset vector address

2020-03-15 Thread Richard Henderson
() > --- > target/rx/cpu.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

2020-03-15 Thread Richard Henderson
json | 42 --- > target/i386/cpu.c | 2 +- > target/i386/machine-stub.c | 22 +++ > target/i386/Makefile.objs | 3 ++- > 5 files changed, 70 insertions(+), 44 deletions(-) > create mode 100644 target/i386/machine-stub.c Acked-by: Richard Henderson r~

Re: [PATCH for-5.0 0/6] Several error use-after-free

2020-03-24 Thread Richard Henderson
ee of local_err > migration/ram: fix use after free of local_err > qga/commands-posix: fix use after free of local_err Whole series: Reviewed-by: Richard Henderson r~

Re: [Qemu-block] [PATCH 3/9] coroutine: add host specific coroutine backend for 64-bit x86

2019-05-05 Thread Richard Henderson
ns(+), 2 deletions(-) > create mode 100644 scripts/qemugdb/coroutine_asm.py > create mode 100644 util/coroutine-asm.c Reviewed-by: Richard Henderson r~

  1   2   3   4   5   >