Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-15 Thread Niklas Schnelle
On Fri, 2025-04-11 at 16:28 -0600, Alex Williamson wrote: > > > --- snip --- > > > Cc: folks related to that commit. > > > > > > The original issue that brought us ram_device was a very obscure > > > alignment of a memory region versus a device quirk only seen with > > > assignment of specific RT

Re: [PATCH v2 1/3] util: Add functions for s390x mmio read/write

2025-03-31 Thread Niklas Schnelle
good to me. Pretty much exactly matches what I did for rdma-core a while back. > + > +uint8_t s390x_pci_mmio_read_8(const void *ioaddr) > +{ > +uint8_t val = 0; > + > +if (is_mio_supported) { > +val = s390x_pcilgi(ioaddr, sizeof(val)); > +} else { > +syscall(__NR_s390_pci_mmio_read, ioaddr, &val, sizeof(val)); > +} > +return val; > +} > + > --- snip --- > + > +void s390x_pci_mmio_write_64(void *ioaddr, uint64_t val) > +{ > +if (is_mio_supported) { > +s390x_pcistgi(ioaddr, val, sizeof(val)); > +} else { > +syscall(__NR_s390_pci_mmio_write, ioaddr, &val, sizeof(val)); > +} > +} > + Thanks for the great work! Reviewed-by: Niklas Schnelle

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-03 Thread Niklas Schnelle
On Wed, 2025-04-02 at 11:51 -0400, Stefan Hajnoczi wrote: > On Tue, Apr 01, 2025 at 10:22:43AM -0700, Farhan Ali wrote: > > Hi, > > > > Recently on s390x we have enabled mmap support for vfio-pci devices [1]. > > Hi Alex, > I wanted to bring this to your attention. Feel free to merge it through >