at,
with that
Reviewed-by: Marc-André Lureau
>
>> or from QAPI to consistently stick the 'name' parameter next
>> to the Visitor parameter.
>>
>
> --
> Eric Blake eblake redhat com+1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Marc-André Lureau
Reviewed-by: Marc-André Lureau Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake wrote:
> JSON uses "name":value, but many of our visitor interfaces were
> called with visit_type_FOO(v, &value, name, errp). This can be
> a bit confusing to have to mentally swap the paramete
Hi
On Thu, Jun 23, 2022 at 5:43 PM Markus Armbruster wrote:
>
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > The generated visitor code includes abort() & assert(), we shouldn't
> > rely on the global "-i" headers
ively with the same "fs"
argument. That's probably why there is a if (!fs->name) check next. You may
want to check it too to avoid leaks and incorrect info.
> return;
> }
>
> --
> 2.34.3
>
>
>
--
Marc-André Lureau
Hi
On Thu, Jul 7, 2022 at 4:25 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Not needed outside monitor.c. Remove the needless stub.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> &g
Hi
On Thu, Jul 7, 2022 at 4:18 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > error_vprintf() is implemented in monitor.c, which overrides the
> > default implementation from stubs/, while avoiding a direct
Hi
On Thu, Jul 7, 2022 at 4:13 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Remove monitor dependency from error printing code, by allowing programs
> > to set a callback for when to use "detailed&qu
Hi
On Fri, Jul 8, 2022 at 5:56 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Thu, Jul 7, 2022 at 4:25 PM Markus Armbruster
> wrote:
> >
> >> marcandre.lur...@redhat.com writes:
> >>
> >> > From
information about.
>
> Instead of failing the entire fsinfo command, return stub information
> for these failed lookups.
>
> This allows test-qga to pass under docker tests, which are in turn used
> by the CentOS VM tests.
>
> Signed-off-by: John Snow
>
Reviewed-by
Hi
On Thu, Jul 7, 2022 at 10:05 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Jul 7, 2022 at 4:18 PM Markus Armbruster
> wrote:
>
>> marcandre.lur...@redhat.com writes:
>>
>> > From: Marc-André Lureau
>> >
>
Hi
On Tue, Jul 12, 2022 at 6:58 PM Warner Losh wrote:
>
>
>
> On Tue, Jul 12, 2022 at 3:36 AM wrote:
>>
>> From: Marc-André Lureau
>>
>> Add a new meson subproject to provide common code and scripts for QEMU
>> and tools. Initially, it will of
Hi
On Tue, Aug 2, 2022 at 3:04 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > Make QMP-dispatch code free from QEMU-specific OOB dispatch/async
> > coroutine handling. This will allow to move the base code
Hi
On Tue, Aug 2, 2022 at 5:28 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> >
> > On Tue, Jun 21, 2022 at 6:14 PM Markus Armbruster
> wrote:
> >>
> >> marcandre.lur...@redhat.com writes:
> >>
> >&
Hi
On Fri, Jul 29, 2022 at 5:01 PM Alberto Faria wrote:
>
> This series introduces a static analyzer for QEMU. It consists of a
> single static-analyzer.py script that relies on libclang's Python
> bindings, and provides a common framework on which arbitrary static
> analysis checks can be develo
Hi
On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster wrote:
> marcandre.lur...@redhat.com writes:
>
> > From: Marc-André Lureau
> >
> > This is just moving qapi-gen.py and related subdir to qemu-common, to
> > ease review and proceed step by step. The following
Hi
On Fri, Aug 5, 2022 at 2:39 PM Paolo Bonzini wrote:
> On 7/12/22 11:35, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > A subproject test may be simply in the "PROJECT" suite (such as
> > "qemu-common" with the follo
gned-off-by: Bin Meng
> Reviewed-by: Stefan Weil
>
lgtm
Reviewed-by: Marc-André Lureau
> ---
>
> Changes in v2:
> - change 'count' to unsigned
>
> util/aio-win32.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/util/aio-
Hi
On Thu, Aug 11, 2022 at 10:52 AM Markus Armbruster
wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster
> wrote:
> >
> >> marcandre.lur...@redhat.com writes:
> >>
> >> > From: M
On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Thu, Aug 11, 2022 at 10:52 AM Markus Armbruster
> > wrote:
> >
> >> Marc-André Lureau writes:
> >>
> >> > Hi
> >
Hi
On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell
wrote:
> On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau
> wrote:
> > On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster
> wrote:
> >> Your moves tear closely related code apart. This is going to be a drag
> >&
Hi
On Fri, Aug 12, 2022 at 7:49 PM Alberto Faria wrote:
>
> On Thu, Aug 4, 2022 at 12:44 PM Marc-André Lureau
> wrote:
> > On fc36, I had several dependencies I needed to install manually (imho
> > they should have been pulled by python3-clang), but more
Hi
On Thu, Aug 11, 2022 at 5:35 PM Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote:
> >> Hi
> >>
> >> On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell >
> >> wrote:
!tmpdir) {
> -tmpdir = "/var/tmp";
> -}
> +tmpdir = g_get_tmp_dir();
> +
> if (snprintf(filename, size, "%s/vl.XX", tmpdir) >= size) {
> return -EOVERFLOW;
> }
> @@ -891,7 +880,6 @@ int get_tmp_filename(char *filename, int size)
> return -errno;
> }
> return 0;
> -#endif
> }
>
> /*
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
5;
> -#endif
> +}
>
> mapping = insert_mapping(s, commit->param.mkdir.cluster,
> commit->param.mkdir.cluster + 1);
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
the file and reopen it.
> + */
> + close(ser_fd);
> +ser_fd = open(serialtmp, O_RDONLY);
> +g_assert(ser_fd != -1);
> +#endif
>
> if (test->kernel) {
> code = test->kernel;
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
gt; +
> /* Create temporary blkdebug instructions */
> -debug_path = g_strdup_printf("%s/qtest-blkdebug.XX",
> g_get_tmp_dir());
> +debug_path = g_strdup_printf("%s/qtest-blkdebug.XX", base);
> fd = mkstemp(debug_path);
> g_assert(fd >= 0);
> close(fd);
>
> /* Create a temporary raw image */
> -tmp_path = g_strdup_printf("%s/qtest.XX", g_get_tmp_dir());
> +tmp_path = g_strdup_printf("%s/qtest.XX", base);
> fd = mkstemp(tmp_path);
> g_assert(fd >= 0);
> ret = ftruncate(fd, TEST_IMAGE_SIZE);
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
atic void test_cdrom_dma(void)
> prdt[0].size = cpu_to_le32(len | PRDT_EOT);
>
> generate_pattern(pattern, ATAPI_BLOCK_SIZE * 16, ATAPI_BLOCK_SIZE);
> - fh = fopen(tmp_path, "w+");
> +fh = fopen(tmp_path, "wb+");
> ret = fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh);
> g_assert_cmpint(ret, ==, 16);
> fclose(fh);
> --
> 2.34.1
>
>
>
ack this part,
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Hi
On Fri, Sep 2, 2022 at 3:16 PM Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > Hi
> >
> > On Thu, Aug 11, 2022 at 5:35 PM Markus Armbruster
> wrote:
> >
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Aug 11
mp";
> -}
> +tmpdir = g_get_tmp_dir();
> +
> if (snprintf(filename, size, "%s/vl.XX", tmpdir) >= size) {
> return -EOVERFLOW;
> }
> @@ -891,7 +880,6 @@ int get_tmp_filename(char *filename, int size)
> return -errno;
> }
> return 0;
> -#endif
> }
>
> /*
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
ttach_node(void *obj, void
> *data,
> QVirtioSCSIPCI *scsi_pci = obj;
> QVirtioSCSI *scsi = &scsi_pci->scsi;
> QVirtioSCSIQueues *vs;
> -char tmp_path[] = "/tmp/qtest.XX";
> +g_autofree char *tmp_path;
> int fd;
> int ret;
>
> @@ -282,7 +282,7 @@ static void test_iothread_attach_node(void *obj, void
> *data,
> vs = qvirtio_scsi_init(scsi->vdev);
>
> /* Create a temporary qcow2 overlay*/
> -fd = mkstemp(tmp_path);
> +fd = g_file_open_tmp("qtest.XX", &tmp_path, NULL);
> g_assert(fd >= 0);
> close(fd);
>
> diff --git a/tests/unit/test-image-locking.c
> b/tests/unit/test-image-locking.c
> index ba057bd66c..d09ff43fcb 100644
> --- a/tests/unit/test-image-locking.c
> +++ b/tests/unit/test-image-locking.c
> @@ -76,10 +76,10 @@ static void check_locked_bytes(int fd, uint64_t
> perm_locks,
> static void test_image_locking_basic(void)
> {
> BlockBackend *blk1, *blk2, *blk3;
> -char img_path[] = "/tmp/qtest.XX";
> +g_autofree char *img_path;
> uint64_t perm, shared_perm;
>
> -int fd = mkstemp(img_path);
> +int fd = g_file_open_tmp("qtest.XX", &img_path, NULL);
> assert(fd >= 0);
>
> perm = BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ;
> @@ -117,10 +117,10 @@ static void test_image_locking_basic(void)
> static void test_set_perm_abort(void)
> {
> BlockBackend *blk1, *blk2;
> -char img_path[] = "/tmp/qtest.XX";
> +g_autofree char *img_path;
> uint64_t perm, shared_perm;
> int r;
> -int fd = mkstemp(img_path);
> +int fd = g_file_open_tmp("qtest.XX", &img_path, NULL);
> assert(fd >= 0);
>
> perm = BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ;
> diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
> index a05a4628ed..b73d231cd5 100644
> --- a/tests/unit/test-qga.c
> +++ b/tests/unit/test-qga.c
> @@ -59,7 +59,7 @@ fixture_setup(TestFixture *fixture, gconstpointer data,
> gchar **envp)
>
> fixture->loop = g_main_loop_new(NULL, FALSE);
>
> -fixture->test_dir = g_strdup("/tmp/qgatest.XX");
> +fixture->test_dir = g_strdup_printf("%s/qgatest.XX",
> g_get_tmp_dir());
> g_assert_nonnull(g_mkdtemp(fixture->test_dir));
>
> path = g_build_filename(fixture->test_dir, "sock", NULL);
> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
> index 9b1dab2f28..fecdf915e7 100644
> --- a/tests/vhost-user-bridge.c
> +++ b/tests/vhost-user-bridge.c
> @@ -631,7 +631,6 @@ static void *notifier_thread(void *arg)
> static void
> vubr_host_notifier_setup(VubrDev *dev)
> {
> -char template[] = "/tmp/vubr-XX";
> pthread_t thread;
> size_t length;
> void *addr;
> @@ -639,7 +638,7 @@ vubr_host_notifier_setup(VubrDev *dev)
>
> length = qemu_real_host_page_size() * VHOST_USER_BRIDGE_MAX_QUEUES;
>
> -fd = mkstemp(template);
> +fd = g_file_open_tmp("vubr-XX", NULL, NULL);
> if (fd < 0) {
> vubr_die("mkstemp()");
> }
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
gt; the codes without #ifdefs.
>
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
> ---
>
> Changes in v2:
> - Change to use g_mkdir()
>
> block/vvfat.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/block/vvfat.c b/bl
parse filenames.
>
> Signed-off-by: Bin Meng
>
I don't have a much better solution to propose at this point (to actually
use a temp directory), so:
Reviewed-by: Marc-André Lureau
> ---
>
> (no changes since v1)
>
> tests/qtest/ahci-test.c | 21 ++---
On Sun, Sep 25, 2022 at 3:49 PM Bin Meng wrote:
> From: Bin Meng
>
> This case was written to use hardcoded /tmp directory for temporary
> files. Update to use g_file_open_tmp() for a portable implementation.
>
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
On Sun, Sep 25, 2022 at 3:56 PM Bin Meng wrote:
> From: Bin Meng
>
> This case was written to use hardcoded /tmp directory for temporary
> files. Update to use g_file_open_tmp() for a portable implementation.
>
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
On Sun, Sep 25, 2022 at 4:09 PM Bin Meng wrote:
> From: Bin Meng
>
> This case was written to use hardcoded /tmp directory for temporary
> files. Update to use g_file_open_tmp() for a portable implementation.
>
> Signed-off-by: Bin Meng
>
Reviewed-by: Marc-André Lureau
sts/qtest/vhost-user-blk-test.c | 3 +-
> tests/qtest/vhost-user-test.c | 10 +-
> tests/qtest/virtio-blk-test.c | 4 +-
> tests/qtest/virtio-net-failover.c | 9 +-
> tests/qtest/virtio-net-test.c | 13 +-
> tests/qtest/virtio-scsi-test.c | 4 +-
> tests/unit/test-image-locking.c | 8 +-
> tests/unit/test-qga.c | 2 +-
> tests/vhost-user-bridge.c | 3 +-
> util/osdep.c| 33 +
> util/qemu-sockets.c | 5 +-
> .gitlab-ci.d/windows.yml| 8 +-
> accel/meson.build | 1 +
> accel/qtest/meson.build | 1 +
> tests/qtest/meson.build | 42 +++
> 45 files changed, 452 insertions(+), 240 deletions(-)
>
> --
> 2.34.1
>
>
>
--
Marc-André Lureau
t;, &img_path, NULL);
> assert(fd >= 0);
>
> perm = BLK_PERM_WRITE | BLK_PERM_CONSISTENT_READ;
> @@ -140,6 +140,8 @@ static void test_set_perm_abort(void)
> check_locked_bytes(fd, perm, ~shared_perm);
> blk_unref(blk1);
> blk_unref(blk2);
> +close(fd);
> +unlink(img_path);
>
Perhaps we should use g_unlink() instead for better portability? although
this is pre-existing.
otherwise, lgtm
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
>
> Signed-off-by: Eric Blake
>
Reviewed-by: Marc-André Lureau
---
>
> Doc-only, so safe for 2.8. But we're also close enough to -rc3
> that I'm fine if it has to go in later via -stable.
>
> qapi/block.json | 2 +-
> 1 file changed, 1 insertion(+), 1 del
03154757.36140-6-vsement...@virtuozzo.com>
> [eblake: add CVE details]
> Signed-off-by: Eric Blake
>
Reviewed-by: Marc-André Lureau
> ---
> nbd/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nbd/client.c b/nbd/client.c
> index ffb0743..0d
ock layer if we gather
> all the information into a struct, rather than adding yet more
> pointer parameters during negotiation.
>
> Signed-off-by: Eric Blake
>
Reviewed-by: Marc-André Lureau
>
> ---
> v4: rebase to master
> v3: new patch
> ---
> block/nbd-c
reading
> a value from the top BDS; where that value was picked via
> bdrv_refresh_limits() to reflect the overall constraints of
> the entire BDS chain.
>
> Signed-off-by: Eric Blake
>
Reviewed-by: Marc-André Lureau
>
> ---
> v4: retitle, as part of rebasing to
Doing this points out a debug message in server.c that got
> parameters mixed up.
>
> Signed-off-by: Eric Blake
>
Reviewed-by: Marc-André Lureau
>
> ---
> v4: new patch
> ---
> include/block/nbd.h | 34 +++---
> nbd/nbd-inte
Hi
On Mon, Oct 15, 2018 at 9:34 PM Max Reitz wrote:
>
> This adds some whitespace into the option help (including indentation)
> and replaces '=' by ': ' (not least because '=' should be used for
> values, not types).
Without strong preference, I like the '=' better: it's the expected
syntax for
he descriptions with " - " instead of putting them in
> parentheses, because that is what we do everywhere else. This does look
> a bit funny here because basically all bits have the description
> "on/off", but funny does not mean it is less readable.
>
> Signed-
in terminal terms.
>
> Finally, this patch amends the reference output of iotest 082 to match
> the changes (and thus makes it pass again).
>
> Signed-off-by: Max Reitz
Reviewed-by: Marc-André Lureau
> ---
> include/qemu/option.h | 2 +-
> qemu-img.c
On Fri, Oct 19, 2018 at 8:49 PM Max Reitz wrote:
>
> Following the example of qemu_opts_print_help(), indent all entries in
> the list of character devices.
>
> Signed-off-by: Max Reitz
Reviewed-by: Marc-André Lureau
> ---
> chardev/char.c | 2 +-
> 1 file changed, 1
On Fri, Oct 19, 2018 at 8:50 PM Max Reitz wrote:
>
> There is no good reason why there should be a newline in this
> description, so remove it.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
> ---
> vl.c | 2
every object name in the list of available objects.
>
> Signed-off-by: Max Reitz
Reviewed-by: Marc-André Lureau
> ---
> vl.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index ac3ed17de4..ecddbb6b8e 100644
>
can replace
strncpy() with qemu strpadcpy(), so that the destination string is
still NUL-ending in cases where the destination is larger than the
source string.
Some warnings can be shut up with assert() lines in some cases.
Marc-André Lureau (3):
sheepdog: fix stringop-truncation warning
equals
destination size [-Werror=stringop-truncation]
strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
^~
cc1: all warnings being treated as errors
Signed-off-by: Marc-André Lureau
---
block/sheepdog.c | 1 +
1 file changed, 1 i
Replace strcpy() that don't mind about having dest not ending with NUL
char by qemu strpadcpy().
Signed-off-by: Marc-André Lureau
---
hw/acpi/aml-build.c | 6 --
hw/acpi/core.c | 13 +++--
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/aml-build.c
]
strncpy((char *)global_state.runstate,
^~
state, sizeof(global_state.runstate));
~
cc1: all warnings being treated as errors
(alternatively, we could hard-code "running")
Signed-off-by: Mar
Hi
On Tue, Nov 20, 2018 at 9:22 PM Dr. David Alan Gilbert
wrote:
>
> * Eric Blake (ebl...@redhat.com) wrote:
> > On 11/20/18 9:27 AM, Marc-André Lureau wrote:
> > > Adding an assert is enough to silence GCC.
> > >
> > > ~/src/qem
Take a VhostUserState* that can be pre-allocated, and initialize it
with the associated chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Tiwei Bie
---
include/hw/virtio/vhost-user-blk.h | 2 +-
include/hw/virtio/vhost-user-scsi.h | 2 +-
include/hw/virtio/vhost-user.h | 2
;
> Signed-off-by: Peter Maydell
Reviewed-by: Marc-André Lureau
> ---
> include/qemu/uuid.h | 2 +-
> block/vdi.c | 16
> hw/acpi/vmgenid.c| 6 ++
> tests/vmgenid-test.c | 2 +-
> util/uuid.c | 10 +-
> 5 files changed,
tringop-truncation"
> around, disable the warning globally using -Wno-stringop-truncation,
> but since QEMU provides the strpadcpy() which does the same purpose,
> simply use it to avoid the annoying warning.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
The function does the same initialization, and matches with
scsi_free_scsi_task() usage, and qemu doesn't need to know the
allocator details.
Signed-off-by: Marc-André Lureau
---
block/iscsi.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vhdx-log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 3f4c2aa095..6125ea4c6d
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/dmg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/dmg.c b/block/dmg.c
index 900ae5a678..6c0711f563 100644
--- a/block
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 4240ba9d1c..f52a7c0f0f 100644
--- a
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vvfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 426ca70e35..877f71dcdc 100644
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/qcow2-cluster.c | 2 +-
block/qcow2-refcount.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b
or: calling function
'block_job_pause_point' requires holding role '_coroutine_fn' exclusively
[-Werror,-Wthread-safety-analysis]
block_job_pause_point(job);
^
Signed-off-by: Marc-André Lureau
---
include/block/blockjob_int.h | 4 ++--
blockjob.c | 6 --
2 fil
Some functions are both regular and coroutine. They may call coroutine
functions in some cases, if it is known to be running in a coroutine.
Signed-off-by: Marc-André Lureau
---
block.c | 2 ++
block/block-backend.c | 2 ++
block/io.c | 16
Signed-off-by: Marc-André Lureau
---
block/qcow2.h | 6 --
block/qcow.c | 4 +++-
block/qcow2-cluster.c | 11 +++
block/qcow2.c | 15 ++-
4 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index
Signed-off-by: Marc-André Lureau
---
include/block/block_int.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 15fa602150..93eb2a9528 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
Signed-off-by: Marc-André Lureau
---
include/block/block_backup.h | 4 ++--
block/backup.c | 9 ++---
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/block/block_backup.h b/include/block/block_backup.h
index 8a759477a3..415cf8519d 100644
--- a/include
Signed-off-by: Marc-André Lureau
---
block/rbd.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 9da02cdceb..7b4d548cd2 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -348,7 +348,8 @@ static QemuOptsList runtime_opts
Signed-off-by: Marc-André Lureau
---
block/quorum.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/block/quorum.c b/block/quorum.c
index 55ba916655..b086d70daa 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -264,7 +264,8 @@ static void
Signed-off-by: Marc-André Lureau
---
block/vmdk.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 55581b03fe..f8422e8971 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1334,7 +1334,8 @@ static int64_t coroutine_fn
Signed-off-by: Marc-André Lureau
---
block/ssh.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 52964416da..03a8ebe6f7 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -813,7 +813,8 @@ static QemuOptsList ssh_create_opts
Signed-off-by: Marc-André Lureau
---
block/null.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/block/null.c b/block/null.c
index 876f90965b..4c8afe16d7 100644
--- a/block/null.c
+++ b/block/null.c
@@ -167,7 +167,8 @@ static inline BlockAIOCB *null_aio_common
Signed-off-by: Marc-André Lureau
---
block/nbd-client.h | 10 +-
block/nbd-client.c | 24
block/nbd.c| 3 ++-
nbd/server.c | 3 ++-
4 files changed, 25 insertions(+), 15 deletions(-)
diff --git a/block/nbd-client.h b/block/nbd-client.h
index
Called from coroutine.
Signed-off-by: Marc-André Lureau
---
include/block/block_int.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 93eb2a9528..a183c72b7c 100644
--- a/include/block/block_int.h
+++ b/include
Signed-off-by: Marc-André Lureau
---
block/crypto.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/crypto.c b/block/crypto.c
index 10e5ddccaa..0e30a4ea06 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -568,7 +568,8 @@ static int block_crypto_open_luks
Signed-off-by: Marc-André Lureau
---
block/raw-format.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/raw-format.c b/block/raw-format.c
index 0d185fe41b..402d3b9fba 100644
--- a/block/raw-format.c
+++ b/block/raw-format.c
@@ -361,7 +361,8 @@ static void
Signed-off-by: Marc-André Lureau
---
block/nfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/nfs.c b/block/nfs.c
index c3c5de0113..3f393a95a4 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -679,7 +679,8 @@ static QemuOptsList nfs_create_opts
Signed-off-by: Marc-André Lureau
---
block/gluster.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/gluster.c b/block/gluster.c
index addceed6eb..dea8ab43a5 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -965,7 +965,8 @@ static coroutine_fn int
Signed-off-by: Marc-André Lureau
---
block/file-posix.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 3927fabf06..adafbbb6a0 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1483,7 +1483,8 @@ static
Signed-off-by: Marc-André Lureau
---
block/curl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/curl.c b/block/curl.c
index 2a244e2439..d3719dc086 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -855,7 +855,8 @@ out_noclean:
return -EINVAL;
}
-static void
Signed-off-by: Marc-André Lureau
---
block/qed.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/qed.c b/block/qed.c
index 385381a78a..dd2859a1c9 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -622,7 +622,8 @@ out:
return ret;
}
-static int bdrv_qed_create
Signed-off-by: Marc-André Lureau
---
block/mirror.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 68744a17e8..2f0a9946d9 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -224,7 +224,8 @@ static int mirror_cow_align
Signed-off-by: Marc-André Lureau
---
block/iscsi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 54067e2620..e16311cb4a 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1005,7 +1005,8 @@ static void iscsi_ioctl_handle_emulated
Signed-off-by: Marc-André Lureau
---
block/vhdx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 8b270b57c9..56b54f3ed7 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1787,7 +1787,8 @@ exit
Signed-off-by: Marc-André Lureau
---
block/sheepdog.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 83bc43dde4..64ff275db9 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -481,7 +481,8 @@ static inline
Signed-off-by: Marc-André Lureau
---
block/vdi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/vdi.c b/block/vdi.c
index 79af47763b..53cd7f64d8 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -716,7 +716,8 @@ vdi_co_pwritev(BlockDriverState *bs, uint64_t offset
Signed-off-by: Marc-André Lureau
---
block/parallels.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 8be46a7d48..213e42b9d2 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -472,7 +472,8 @@ static int parallels_check
Signed-off-by: Marc-André Lureau
---
block/blkdebug.c | 15 ++-
block/blkverify.c | 3 ++-
block/io.c| 9 ++---
3 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index a1b24b9b0d..d55e2e69c8 100644
--- a/block
Signed-off-by: Marc-André Lureau
---
block/vpc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/vpc.c b/block/vpc.c
index 4240ba9d1c..1b4aba20bd 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -872,7 +872,8 @@ static int create_fixed_disk(BlockBackend *blk, uint8_t
Signed-off-by: Marc-André Lureau
---
include/sysemu/block-backend.h | 4 ++--
block/block-backend.c | 36
2 files changed, 26 insertions(+), 14 deletions(-)
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index
ame .bdrv_create() to .bdrv_co_create()
> qcow2: make qcow2_co_create2() a coroutine_fn
>
I came to the same changes with my series, so
Reviewed-by: Marc-André Lureau
> include/block/block_int.h | 3 ++-
> block.c | 4 ++--
> block/crypto.c
- Original Message -
> On 05/07/2017 00:03, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau
> > ---
> > include/block/block_int.h | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/in
Hi
- Original Message -
>
>
> On 05/07/2017 16:21, Marc-André Lureau wrote:
> >>
> >> They are, but it's an implementation detail. Why is this patch necessary?
> > I didn't think this would be controversial :) well, the checks I added to
Hi
- Original Message -
>
>
> On 05/07/2017 18:06, Marc-André Lureau wrote:
> >>> coroutine_fn too)
> >> It's not controversial, I would not have expected the functions to call
> >> coroutine_fn. :) How do they do that?
> >>
&g
Hi
- Original Message -
> On Wed, Jul 05, 2017 at 12:03:13AM +0200, Marc-André Lureau wrote:
> > Some functions are both regular and coroutine. They may call coroutine
> > functions in some cases, if it is known to be running in a coroutine.
> >
> > Signe
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vhdx-log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 01278f3fc9..ad70706b99
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Hajnoczi
---
block/dmg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/dmg.c b/block/dmg.c
index 900ae5a678
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 9a6f8173a5..c88dc72491 100644
--- a
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/vvfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 4fd28e1e87..c08c4fb525 100644
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau
---
block/qcow2-cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index f06c08f64c
1 - 100 of 267 matches
Mail list logo
