Thanks for your contribution!
There are only two minor comments.
Please check it and send patch v2.
Thank you!
On 5/21/2024 8:05 PM, Minwoo Im wrote:
@@ -1288,12 +1717,21 @@ static void ufs_exit(PCIDevice *pci_dev)
ufs_clear_req(&u->req_list[i]);
}
g_free(u->req_list);
++--
hw/ufs/ufs.h| 98 -
include/block/ufs.h | 131 +++-
4 files changed, 702 insertions(+), 22 deletions(-)
Thank you for the patch.
Reviewed-by: Jeuk Kim
From: Jeuk Kim
The following changes since commit ad10b4badc1dd5b28305f9b9f1168cf0aa3ae946:
Merge tag 'pull-error-2024-05-27' of https://repo.or.cz/qemu/armbru into
staging (2024-05-27 06:40:42 -0700)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qem
From: Minwoo Im
This patch is a prep patch for the following MCQ support patch for
hw/ufs. This patch updated minimal mandatory fields to support MCQ
based on UFSHCI 4.0.
Signed-off-by: Minwoo Im
Reviewed-by: Jeuk Kim
Message-Id: <20240528023106.856777-2-minwoo...@samsung.com>
Signed-
(48B):
UfsMcqSqReg, UfsMcqSqIntReg, UfsMcqCqReg, UfsMcqCqIntReg
The maxinum number of queue is 32 as per spec, and the default
MAC(Multiple Active Commands) are 32 in the device.
Example:
-device ufs,serial=foo,id=ufs0,mcq=true,mcq-maxq=8
Signed-off-by: Minwoo Im
Reviewed-by: Jeuk Kim
Mes
On 5/29/2024 2:06 AM, Richard Henderson wrote:
On 5/27/24 23:12, Jeuk Kim wrote:
From: Minwoo Im
This patch adds support for MCQ defined in UFSHCI 4.0. This patch
utilized the legacy I/O codes as much as possible to support MCQ.
MCQ operation & runtime register is placed at 0x1000 of
(48B):
UfsMcqSqReg, UfsMcqSqIntReg, UfsMcqCqReg, UfsMcqCqIntReg
The maxinum number of queue is 32 as per spec, and the default
MAC(Multiple Active Commands) are 32 in the device.
Example:
-device ufs,serial=foo,id=ufs0,mcq=true,mcq-maxq=8
Signed-off-by: Minwoo Im
Reviewed-by: Jeuk Kim
Mes
From: Jeuk Kim
The following changes since commit 74abb45dac6979e7ff76172b7f0a24e869405184:
Merge tag 'pull-target-arm-20240531' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-05-31
11:10:10 -0700)
are available in the Git repository at:
https://gitlab.
From: Minwoo Im
This patch is a prep patch for the following MCQ support patch for
hw/ufs. This patch updated minimal mandatory fields to support MCQ
based on UFSHCI 4.0.
Signed-off-by: Minwoo Im
Reviewed-by: Jeuk Kim
Message-Id: <20240528023106.856777-2-minwoo...@samsung.com>
Signed-
On 6/8/2024 12:02 AM, Peter Maydell wrote:
On Mon, 3 Jun 2024 at 09:38, Jeuk Kim wrote:
From: Minwoo Im
This patch adds support for MCQ defined in UFSHCI 4.0. This patch
utilized the legacy I/O codes as much as possible to support MCQ.
MCQ operation & runtime register is placed at 0x
(uint32_t *) to
represent we are accessing the MMIO registers by dword-sized only.
[1]
https://lore.kernel.org/qemu-devel/cafeaca82l-wznhmw0x+dr40bhm-evq2zh4dg4pdqop4xxdp...@mail.gmail.com/
Cc: Jeuk Kim
Reported-by: Peter Maydell
Signed-off-by: Minwoo Im
Reviewed-by: Jeuk Kim
Reviewed-by: Peter
From: Jeuk Kim
The following changes since commit 3665dd6bb9043bef181c91e2dce9e1efff47ed51:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
(2024-06-28 16:09:38 -0700)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qemu.git tag
buffer. So fix it.
Fixes: 5c079578d2e4 ("hw/ufs: Add support MCQ of UFSHCI 4.0")
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index 683fff5840..cf0edd281c 100644
--- a/hw/ufs/ufs.c
++
From: Jeuk Kim
The function ufs_is_mcq_reg() only evaluated the range of the
mcq_op_reg offset, which is defined as a constant.
Therefore, it was possible for ufs_is_mcq_reg() to return true
despite ufs device is configured to not support the mcq.
This could cause ufs_mmio_read()/ufs_mmio_write
From: Jeuk Kim
The following changes since commit b9ee1387e0cf0fba5a73a610d31cb9cead457dc0:
Merge tag 'sdmmc-20240706' of https://github.com/philmd/qemu into staging
(2024-07-07 10:34:52 -0700)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qemu.git tag
I'm so sorry. I forgot to add something to the patch, I'll add it and
resend it to you.
Sorry again.
On 7/8/2024 10:31 AM, Jeuk Kim wrote:
From: Jeuk Kim
The following changes since commit b9ee1387e0cf0fba5a73a610d31cb9cead457dc0:
Merge tag 'sdmmc-20240706' of https
()/ufs_mmio_write() to result in
Null-pointer-dereference.
So fix it.
Resolves: #2428
Fixes: 5c079578d2e4 ("hw/ufs: Add support MCQ of UFSHCI 4.0")
Reported-by: Zheyu Ma
Signed-off-by: Jeuk Kim
Reviewed-by: Minwoo Im
---
hw/ufs/ufs.c | 16 ++--
1 file changed, 14 insert
From: Jeuk Kim
The following changes since commit 37fbfda8f4145ba1700f63f0cb7be4c108d545de:
Merge tag 'edgar/xen-queue-2024-07-12.for-upstream' of
https://gitlab.com/edgar.iglesias/qemu into staging (2024-07-12 09:53:22 -0700)
are available in the Git repository at:
https://
From: Jeuk Kim
The function ufs_is_mcq_reg() and ufs_is_mcq_op_reg() only evaluated
the range of the mcq_reg and mcq_op_reg offset, which is defined as
a constant. Therefore, it was possible for them to return true
even though the ufs device is configured to not support the mcq.
This could cause
error caused by writing an
invalid value, allocating an invalid selector and permission issues.
Signed-off-by: Yoochan Jeong
Reviewed-by: Jeuk Kim
Signed-off-by: Jeuk Kim
---
tests/qtest/ufs-test.c | 137 +
1 file changed, 137 insertions(+)
diff --git a/
From: Kyoungrul Kim
Modify to fill the opcode, idn, index, selector information of
all Query Response UPIU. because attr and flag operation of query
response upiu need these information too.
Signed-off-by: KyoungrulKim
Reviewed-by: Minwoo Im
Reviewed-by: Jeuk Kim
Signed-off-by: Jeuk Kim
From: Jeuk Kim
The following changes since commit 7b87a25f49a301d3377f3e71e0b4a62540c6f6e4:
Merge tag 'edgar/xen-queue-2024-09-04.for-upstream' of
https://gitlab.com/edgar.iglesias/qemu into staging (2024-09-05 13:02:26 +0100)
are available in the Git repository at:
https://
error caused by
permission issues.
Signed-off-by: Yoochan Jeong
Reviewed-by: Jeuk Kim
Signed-off-by: Jeuk Kim
---
tests/qtest/ufs-test.c | 83 ++
1 file changed, 83 insertions(+)
diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
index 9cc9e57
From: Yoochan Jeong
Minor bugs and errors related to ufs-test are resolved. Some
permissions and code implementations that are not synchronized
with the ufs spec are edited.
Signed-off-by: Yoochan Jeong
Reviewed-by: Jeuk Kim
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 19
nce,
except for configuration descriptors (which are not implemented yet.)
There are some testcases that are intended to make an error caused by
an invalid index value or an invalid selector value.
Signed-off-by: Yoochan Jeong
Reviewed-by: Jeuk Kim
Signed-off-by: Jeuk Kim
---
tests/qtest/u
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
---
MAINTAINERS |6 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build |1 +
hw/ufs/trace-events | 33 +
hw/ufs/trace.h
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1441 ++
hw/ufs
it works with Windows 10.
Jeuk Kim (3):
hw/ufs: Initial commit for emulated Universal-Flash-Storage
hw/ufs: Support for Query Transfer Requests
hw/ufs: Support for UFS logical unit
MAINTAINERS |6 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 967 ++-
hw/ufs/ufs.h | 45 +++
2
On 26/05/2023 15:37, Thomas Huth wrote:
>On 26/05/2023 07.05, Jeuk Kim wrote:
>> Universal Flash Storage (UFS) is a high-performance mass storage device
>> with a serial interface. It is primarily used as a high-performance
>> data storage device for embedded application
Hi Philippe,
>Hi Jeuk,
>
>[+Alistair]
>
>On 26/5/23 07:05, Jeuk Kim wrote:
>> Universal Flash Storage (UFS) is a high-performance mass storage device
>> with a serial interface. It is primarily used as a high-performance
>> data storage device for embedded
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 968 ++-
hw/ufs/ufs.h | 45 +++
2
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1441 ++
hw/ufs
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
---
MAINTAINERS |6 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build |1 +
hw/ufs/trace-events | 33 ++
hw/ufs/trace.h
confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Kim (3):
hw/ufs: Initial commit for emulated Universal-Flash-Storage
hw/ufs: Support for Query Transfer Requests
hw/ufs: Support for UFS logical uni
On Fri, Jun 16, 2023, Stefan Hajnoczi wrote:
>On Fri, Jun 16, 2023 at 03:58:21PM +0900, Jeuk Kim wrote:
>> Universal Flash Storage (UFS) is a high-performance mass storage device
>> with a serial interface. It is primarily used as a high-performance
>> data storage device for
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote:
>On Fri, Jun 16, 2023 at 03:58:25PM +0900, Jeuk Kim wrote:
>> This commit makes the UFS device support query
>> and nop out transfer requests.
>>
>> The next patch would be support for UFS logical
>> unit
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote:
>On Fri, Jun 16, 2023 at 03:58:27PM +0900, Jeuk Kim wrote:
>> This commit adds support for ufs logical unit.
>> The LU handles processing for the SCSI command,
>> unit descriptor query request.
>>
>> This commit enable
(PCI_DEVICE_ID_REDHAT_UFS) is not registered
in the Linux kernel yet, so it does not work right away, but I confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Kim (3):
hw/ufs: Initial commit for emulated Universal-Flash
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst |2 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build |1 +
hw/ufs/trace-events
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/trace-events |1 +
hw/ufs/ufs.c| 1005
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1441 ++
hw/ufs
From: Jeuk Kim
Since v3:
- Replace softmmu_ss -> system_ss in meson
Since v2:
Addressed review comment from Stefan Hajnoczi. The main fixes are as
follows.
- Use of SPDX licence identifiers
- fixed endianness error
- removed memory leak
- fixed DMA error handling logic
Since v1:
- use mac
From: Jeuk Kim
Universal Flash Storage (UFS) is a high-performance mass storage device
with a serial interface. It is primarily used as a high-performance
data storage device for embedded applications.
This commit contains code for UFS device to be recognized
as a UFS PCI device.
Patches to
From: Jeuk Kim
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/trace-events |1 +
hw/ufs/ufs.c| 1005
From: Jeuk Kim
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1441
Hi,
Any more reviews...?
Dear Stefan
If you don't mind, Could you give it "reviewed-by"?
And is there anything else I should do...?
Thanks,
Jeuk
On 2023-07-04 오후 5:33, Jeuk Kim wrote:
From: Jeuk Kim
Since v3:
- Replace softmmu_ss -> system_ss in meson
Since v2:
Addres
On 2023-07-19 오전 3:56, Stefan Hajnoczi wrote:
On Tue, Jul 11, 2023 at 07:31:02PM +0900, Jeuk Kim wrote:
Hi,
Any more reviews...?
Dear Stefan
If you don't mind, Could you give it "reviewed-by"?
And is there anything else I should do...?
Sorry for the late reply. I was on
ay, but I confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Kim (3):
hw/ufs: Initial commit for emulated Universal-Flash-Storage
hw/ufs: Support for Query Transfer Requests
hw/ufs: Support for UFS lo
From: Jeuk Kim
Universal Flash Storage (UFS) is a high-performance mass storage device
with a serial interface. It is primarily used as a high-performance
data storage device for embedded applications.
This commit contains code for UFS device to be recognized
as a UFS PCI device.
Patches to
From: Jeuk Kim
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1439
From: Jeuk Kim
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c| 980
On 7/21/2023 3:49 AM, Stefan Hajnoczi wrote:
Hi,
I'm ready to merge this but encountered a bug when testing:
$ qemu-system-x86_64 --device ufs --device ufs-lu
Segmentation fault (core dumped)
Please ensure there is an error message like with SCSI disks:
$ qemu-system-x86_64 --device v
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1439 ++
hw/ufs
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst |2 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build |1 +
hw/ufs/trace-events
UFS device.
The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered
in the Linux kernel yet, so it does not work right away, but I confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Kim (3):
hw
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c| 980
On 7/21/2023 8:01 PM, Stefan Hajnoczi wrote:
Is there a test case along the lines of tests/qtest/ahci-test.c that
exercises this new code?
It's important to have at least a basic test that initializes the
device and performs a write followed by a read to verify that I/O is
working. This will all
0:0:0/scsi-disk" and ":00:04.0/0:0:0/scsi-disk")
>
> Fixes: 096434fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem")
> Signed-off-by: Akinobu Mita
Reviewed-by: Jeuk Kim
Thank you!
Hi Philippe,
Thank you for informing me.
I want this issue is fixed for the 8.2 release.
I created an issue like you said, but I couldn't assign the milestone (I'm
guessing it's a permission problem).
https://gitlab.com/qemu-project/qemu/-/issues/2018
Could you help me with this?
Regardless, I'
From: Jeuk Kim
The following changes since commit 1664d74c50739401c8b40e8b514d12b5fc250067:
tests/avocado: Update yamon-bin-02.22.zip URL (2023-12-04 08:17:35 -0500)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231205
for you to fetch
6434fea13a ("hw/ufs: Modify lu.c to share codes with SCSI subsystem")
Signed-off-by: Akinobu Mita
Reviewed-by: Jeuk Kim
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20231204150543.48252-1-akinobu.m...@gmail.com>
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 8
1 file ch
I've already done all the ufs related review.
If the SCSI maintainers approve this patchset, I'll put it in my tree
and create a pull request.
Thank you,
Jeuk
On 12/8/2023 3:09 PM, Daejun Park wrote:
This patch enables zoned support for UFS devices.
By applying this patch, a QEMU run can
This patch allows the qemu ufs to raise an interrupt on
the DME_SET (PA_PWRMODE) command.
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c| 15 ++-
include/block/ufs.h | 65 +
2 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/hw
a
Signed-off-by: Jeuk Kim
---
hw/ufs/ufs.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index eccdb852a0..bac78a32bb 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -126,6 +126,10 @@ static MemTxResult ufs_dma_read_req_upiu(UfsRequest *req)
co
From: Jeuk Kim
The following changes since commit fd87be1dada5672f877e03c2ca8504458292c479:
Merge tag 'accel-20240426' of https://github.com/philmd/qemu into staging
(2024-04-26 15:28:13 -0700)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qemu.git tag
From: Jeuk Kim
It fixes the buffer overflow vulnerability in the ufs device.
The bug was detected by sanitizers.
You can reproduce it by:
cat << EOF |\
qemu-system-x86_64 \
-display none -machine accel=qtest -m 512M -M q35 -nodefaults -drive \
file=null-co://,if=none,id=disk0 -device
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c| 980
for a new PCI-based UFS device.
The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered
in the Linux kernel yet, so it does not work right away, but I confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Ki
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
---
hw/ufs/lu.c | 1445 ++
hw/ufs
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst |2 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build |1 +
hw/ufs/trace-events
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
---
MAINTAINERS | 1 +
tests/qtest/meson.build | 1 +
tests/qtest/ufs-test.c | 575
On 7/26/2023 4:21 PM, Thomas Huth wrote:
Hi!
On 26/07/2023 07.30, Jeuk Kim wrote:
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
On 7/27/2023 4:36 AM, Stefan Hajnoczi wrote:
On Wed, Jul 26, 2023 at 02:30:49PM +0900, Jeuk Kim wrote:
Since v6:
- Add tests/qtest/ufs-test.c to test ufs initialisation and I/O
- Add struct UtpTaskReqDesc to include/block/ufs.h
- Fix ufs_log2() logic
- Fix ufs-lu to use 4K as default block size
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c| 980
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/lu.c | 1445
s adds support for a new PCI-based UFS device.
The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered
in the Linux kernel yet, so it does not work right away, but I confirmed
that it works with Linux when the UFS pci device id is registered.
I have also verified that it works with Windows 10.
Jeuk Kim (4):
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst |2 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
Acked-by: Thomas Huth
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS | 1 +
tests
ndian systems,
I just skip the test for now, and leave it as a TODO.
Jeuk Kim (4):
hw/ufs: Initial commit for emulated Universal-Flash-Storage
hw/ufs: Support for Query Transfer Requests
hw/ufs: Support for UFS logical unit
tests/qtest: Introduce tests for UFS
MAINTAINERS |
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
Acked-by: Thomas Huth
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS | 1 +
tests
unit and Transfer Request will follow.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS |6 +
docs/specs/pci-ids.rst |2 +
hw/Kconfig |1 +
hw/meson.build |1 +
hw/ufs/Kconfig |4 +
hw/ufs/meson.build
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/lu.c | 1445
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c| 980
On 23. 8. 30. 20:38, Stefan Hajnoczi wrote:
On Thu, 3 Aug 2023 at 07:49, Jeuk Kim wrote:
Dear Stefan,
I'm really sorry, but could you please put this patch series
instead of v8, which was previously merged into block-next?
The fixes from v8 are below.
Please let me know if you hav
From: Jeuk Kim
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/lu.c | 1445
ind_first_bit() function on big endian host pc.
This fixes
https://gitlab.com/qemu-project/qemu/-/jobs/4977256030
which is qos-test failure on s390x hosts.
Please let me know if there are any problems.
Thank you very much!
Jeuk
Jeuk Kim (4):
hw/ufs: Initial commit for emulated Universal-Flash-Sto
From: Jeuk Kim
This patch includes the following tests
Test mmio read
Test ufs device initialization and ufs-lu recognition
Test I/O (Performs a write followed by a read to verify)
Signed-off-by: Jeuk Kim
Acked-by: Thomas Huth
Reviewed-by: Stefan Hajnoczi
---
MAINTAINERS
From: Jeuk Kim
Universal Flash Storage (UFS) is a high-performance mass storage device
with a serial interface. It is primarily used as a high-performance
data storage device for embedded applications.
This commit contains code for UFS device to be recognized
as a UFS PCI device.
Patches to
From: Jeuk Kim
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off-by: Jeuk Kim
Reviewed-by: Stefan Hajnoczi
---
hw/ufs/trace-events | 1 +
hw/ufs/ufs.c
On 23. 9. 15. 02:31, Paolo Bonzini wrote:
On 9/7/23 20:16, Stefan Hajnoczi wrote:
From: Jeuk Kim
This commit adds support for ufs logical unit.
The LU handles processing for the SCSI command,
unit descriptor query request.
This commit enables the UFS device to process
IO requests.
Signed
On 23. 9. 14. 23:40, Peter Maydell wrote:
On Thu, 7 Sept 2023 at 19:17, Stefan Hajnoczi wrote:
From: Jeuk Kim
This commit makes the UFS device support query
and nop out transfer requests.
The next patch would be support for UFS logical
unit and scsi command transfer request.
Signed-off
From: Jeuk Kim
Fixed four ufs-related coverity issues.
The coverity issues and fixes are as follows
1. CID 1519042: Security issue with the rand() function
Changed to use a fixed value (0xab) instead of rand() as
the value for testing
2. CID 1519043: Dereference after null check
Removed
On 2023-09-15 16:59, Paolo Bonzini wrote:
On 9/15/23 00:19, Jeuk Kim wrote:
First, ufs-lu has a feature called "unit descriptor". This feature
shows the status of the ufs-lu
and only works with UFS-specific "query request" commands, not SCSI
commands.
This looks like s
On 2023-09-18 오후 1:41, Jeuk Kim wrote:
On 2023-09-15 16:59, Paolo Bonzini wrote:
On 9/15/23 00:19, Jeuk Kim wrote:
First, ufs-lu has a feature called "unit descriptor". This feature
shows the status of the ufs-lu
and only works with UFS-specific "query request" commands
On 2023-09-15 4:59 PM, Paolo Bonzini wrote:
On 9/15/23 00:19, Jeuk Kim wrote:
First, ufs-lu has a feature called "unit descriptor". This feature
shows the status of the ufs-lu
and only works with UFS-specific "query request" commands, not SCSI
commands.
This looks lik
Dear Paolo
This is a ping for the following.
If you don't mind, could you give me some feedback?
Thank you very much.
Jeuk
On 23. 9. 21. 17:38, Jeuk Kim wrote:
Dear Paolo
Hi. I've been looking into how ufs-lu can share code with scsi-hd.
I have verified that ufs-lu can use scsi
From: Jeuk Kim
This patch fixes invalid ufs register fields.
This fixes an issue reported by Bin Meng that
caused ufs to fail over riscv.
Signed-off-by: Jeuk Kim
---
include/block/ufs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/block/ufs.h b/include/block
From: Jeuk Kim
This patch fixes invalid ufs register fields.
This fixes an issue reported by Bin Meng that
caused ufs to fail over riscv.
Fixes: bc4e68d362ec ("hw/ufs: Initial commit for emulated
Universal-Flash-Storage")
Signed-off-by: Jeuk Kim
Reported-by: Bin Meng
Reviewed-by
From: Jeuk Kim
The following changes since commit a51e5124a655b3dad80b36b18547cb1eca2c5eb2:
Merge tag 'pull-omnibus-111023-1' of https://gitlab.com/stsquad/qemu into
staging (2023-10-11 09:43:10 -0400)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qem
1 - 100 of 114 matches
Mail list logo
