Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached()

Huth > Signed-off-by: Pierrick Bouvier > --- > include/hw/s390x/cpu-topology.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Farman

[Qemu-block] [PATCH 2/3] block: Fix target variable of BLKSECTGET ioctl

systems, we can find ourselves accidentally shifting the result to a much larger value. (On s390x, a short is 16 bits while an int is 32 bits.) Signed-off-by: Eric Farman --- block/file-posix.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c b/block

[Qemu-block] [PATCH 1/3] hw/scsi: Fix debug message of cdb structure in scsi-generic

: scsi-generic: Command: data=0x12 0x00 0x00 0x01 0x00 0x00 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Data ready tag=0x0 len=164 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Command complete 0x0x10a452d0 tag=0x0 status=0 Signed-off-by: Eric Farman --- hw/scsi/scsi

[Qemu-block] [RFC PATCH 0/3] scsi-generic and BLKSECTGET

al kernel git commit [2] kernel commit 44ec95425c1d9dce6e4638c29e4362cfb44814e7 [3] https://lkml.org/lkml/2012/6/27/78 [4] qemu commit 6f6071745bd0366221f5a0160ed7d18d0e38b9f7 [5] qemu commit 5def6b80e1eca696c1fc6099e7f4d36729686402 Eric Farman (3): hw/scsi: Fix debug message of cdb structure in scsi-generic block: Fix target var

[Qemu-block] [PATCH 3/3] block: get max_transfer limit for char (scsi-generic) devices

converted from blocks as happens for block devices. Signed-off-by: Eric Farman --- block/file-posix.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 2115155..c0843c2 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -679,6 +679,13

Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] block: get max_transfer limit for char (scsi-generic) devices

On 01/17/2017 02:04 AM, Fam Zheng wrote: On Mon, 01/16 22:12, Eric Farman wrote: Commit 6f607174 introduced a routine to get the maximum number of bytes for a single I/O transfer for block devices, however scsi generic devices are character devices, not block. Add a condition for this, with

[Qemu-block] [PATCH v2 3/3] block: get max_transfer limit for char (scsi-generic) devices

, because the block and sg ioctls return values in different scales (sectors versus bytes). So adjust hdev_get_max_transfer_length such that it always returns a value in bytes. Signed-off-by: Eric Farman --- block/file-posix.c| 10 ++ include/block/block.h | 1 + 2 files changed, 7

[Qemu-block] [PATCH v2 2/3] block: Fix target variable of BLKSECTGET ioctl

systems, we can find ourselves accidentally shifting the result to a much larger value. (On s390x, a short is 16 bits while an int is 32 bits.) Signed-off-by: Eric Farman --- block/file-posix.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c b/block

[Qemu-block] [PATCH v2 1/3] hw/scsi: Fix debug message of cdb structure in scsi-generic

: scsi-generic: Command: data=0x12 0x00 0x00 0x01 0x00 0x00 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Data ready tag=0x0 len=164 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Command complete 0x0x10a452d0 tag=0x0 status=0 Signed-off-by: Eric Farman --- hw/scsi/scsi

[Qemu-block] [PATCH v2 0/3] scsi-generic and BLKSECTGET

kernel git commit [2] kernel commit 44ec95425c1d9dce6e4638c29e4362cfb44814e7 [3] https://lkml.org/lkml/2012/6/27/78 [4] qemu commit 6f6071745bd0366221f5a0160ed7d18d0e38b9f7 [5] qemu commit 5def6b80e1eca696c1fc6099e7f4d36729686402 Eric Farman (3): hw/scsi: Fix debug message of cdb structure in scsi-gen

Re: [Qemu-block] [Qemu-devel] [PATCH v2 3/3] block: get max_transfer limit for char (scsi-generic) devices

On 01/20/2017 04:53 AM, Fam Zheng wrote: On Fri, 01/20 17:31, Fam Zheng wrote: diff --git a/block/file-posix.c b/block/file-posix.c index 2115155..94068ca 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -657,9 +657,11 @@ static int hdev_get_max_transfer_length(BlockDriverState *bs

[Qemu-block] [PATCH v3 1/3] hw/scsi: Fix debug message of cdb structure in scsi-generic

: scsi-generic: Command: data=0x12 0x00 0x00 0x01 0x00 0x00 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Data ready tag=0x0 len=164 scsi-generic: scsi_read_data tag=0x0 scsi-generic: Command complete 0x0x10a452d0 tag=0x0 status=0 Signed-off-by: Eric Farman --- hw/scsi/scsi

[Qemu-block] [PATCH v3 3/3] block: get max_transfer limit for char (scsi-generic) devices

interface can return the same data. Signed-off-by: Eric Farman --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 9f83725..2134e0e 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -674,7 +674,7 @@ static

[Qemu-block] [PATCH v3 2/3] block: Fix target variable of BLKSECTGET ioctl

, while sg returns bytes), so some tweaking of the outputs is required such that hdev_get_max_transfer_length returns a value in a consistent set of units. Signed-off-by: Eric Farman --- block/file-posix.c| 17 ++--- include/block/block.h | 1 + 2 files changed, 11 insertions(+), 7

[Qemu-block] [PATCH v3 0/3] scsi-generic and BLKSECTGET

7 [3] https://lkml.org/lkml/2012/6/27/78 [4] qemu commit 6f6071745bd0366221f5a0160ed7d18d0e38b9f7 [5] qemu commit 5def6b80e1eca696c1fc6099e7f4d36729686402 Eric Farman (3): hw/scsi: Fix debug message of cdb structure in scsi-generic block: Fix target variable of BLKSECTGET ioctl block: get m

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET

On 01/24/2017 07:09 AM, Fam Zheng wrote: On Tue, 01/24 12:23, Paolo Bonzini wrote: On 22/01/2017 15:29, Fam Zheng wrote: On Fri, 01/20 17:25, Eric Farman wrote: Changes: v2->v3: - Move byte/sector conversions to patch 2 [Fam Zheng] - Rename "max_sectors" when holding

Re: [Qemu-block] [PATCH v3 2/3] block: Fix target variable of BLKSECTGET ioctl

On 01/31/2017 07:25 PM, Max Reitz wrote: On 20.01.2017 17:25, Eric Farman wrote: Commit 6f6071745bd0 ("raw-posix: Fetch max sectors for host block device") introduced a routine to call the kernel BLKSECTGET ioctl, which stores the result back to user space. However, the size o

Re: [PATCH v2 14/19] hw/scsi/scsi-bus: Inline two uses of scsi_bus_from_device()

On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Eric Farman > --- >  hw/s390x/ipl.c | 7 ++- >  hw/scsi/scsi-bus.c | 2 +- >  include/hw/scsi/scsi.h | 5 - >  3 files changed, 3 insertion

Re: [PATCH v2 15/19] hw/s390x/event-facility: Replace DO_UPCAST(SCLPEvent) by SCLP_EVENT()

On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote: > Use the SCLP_EVENT() QOM type-checking macro to avoid DO_UPCAST(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Farman > --- >  hw/s390x/event-facility.c | 3 +-- >  1 file changed, 1 inserti

Re: [PATCH v2 16/19] hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()

On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote: > Use the VFIO_CCW() QOM type-checking macro to avoid DO_UPCAST(). > > Signed-off-by: Philippe Mathieu-Daudé > --- >  hw/vfio/ccw.c | 35 --- >  1 file changed, 16 insertions(+), 19 deletions(-) > > d

Re: [PATCH v2 16/19] hw/vfio/ccw: Replace DO_UPCAST(VFIOCCWDevice) by VFIO_CCW()

On Mon, 2023-02-13 at 17:10 +0100, Philippe Mathieu-Daudé wrote: > On 13/2/23 16:51, Philippe Mathieu-Daudé wrote: > > On 13/2/23 16:29, Eric Farman wrote: > > > On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote: > > > > Use the VFIO_CCW() QO

Re: [PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

> - void qemu_bql_unlock(void) > - bool qemu_bql_locked(void) > > There are more APIs with "iothread" in their names. Subsequent > patches > will rename them. There are also comments and documentation that will > be > updated in later patches. > > Signed-off-by: Stefan Hajnoczi Acked-by: Eric Farman

Re: [PATCH v1 5/8] virtio-ccw: Handle extra notification data

d to virtio-pci devices. > > > > Acked-by: Thomas Huth > > Signed-off-by: Jonah Palmer > > --- > >  hw/s390x/s390-virtio-ccw.c | 16 > >  1 file changed, 12 insertions(+), 4 deletions(-) Acked-by: Eric Farman (I see a v2 is coming for the ioeventfd side, but I was going through this series today and thought that would affect the next patch rather than this one.)