Re: [PATCH v2 30/58] ahci: Move QOM macros to header

t > --- > Changes series v1 -> v2: new patch in series v2 > > Cc: John Snow > Cc: qemu-block@nongnu.org > Cc: qemu-de...@nongnu.org > --- > hw/ide/ahci_internal.h | 5 - > include/hw/ide/ahci.h | 3 +++ > 2 files changed, 3 insertions(+), 5 deletions(-)

Re: [PATCH v2 32/58] ahci: Move QOM macro to header

v2: new patch in series v2 > > Cc: John Snow > Cc: qemu-block@nongnu.org > Cc: qemu-de...@nongnu.org > --- > include/hw/ide/ahci.h | 2 ++ > hw/ide/ahci-allwinner.c | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, D

Re: [PATCH 0/2] nbd: build qemu-nbd on Windows

On Mon, Aug 24, 2020 at 06:02:16PM +0100, Daniel P. Berrangé wrote: > We are already building the NBD client and server on Windows when it is > used via the main system emulator binaries. This demonstrates there is > no fundamental blocker to buildig the qemu-nbd binary too. > >

Re: [PATCH v4 2/6] util: refactor qemu_open_old to split off variadic args handling

On Tue, Aug 25, 2020 at 04:56:40PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > This simple refactoring prepares for future patches. The variadic args > > handling is split from the main bulk of the open logic. The duplicated > > calls to open()

Re: [PATCH v4 5/6] util: give a specific error message when O_DIRECT doesn't work

On Tue, Aug 25, 2020 at 05:19:53PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > A common error scenario is to tell QEMU to use O_DIRECT in combination > > with a filesystem that doesn't support it. To aid users to diagnosing > > their mista

Re: [PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

On Tue, Aug 25, 2020 at 05:14:21PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Instead of relying on the limited information from errno, we can now > > also provide detailed error messages. > > The more detailed error messages are currently always

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: > Sorry for taking so long to reply. > > Daniel P. Berrangé writes: > > > A followup to: > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html > > > > When Q

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

On Wed, Aug 26, 2020 at 07:28:24PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: > > Open questions: > > > > * Do we want the QMP command to delete existing snapshots with > > conflicting tag / ID, like HMP sav

Re: [PATCH v7 8/8] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test

ank > instance won't be unregistered and when running the next test-case > yank_register_instance will abort, because the yank instance is > already/still registered. > > Signed-off-by: Lukas Straub > --- > tests/test-char.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH v7 1/8] Introduce yank feature

| 45 +++ > util/Makefile.objs | 1 + > util/yank.c | 184 > 4 files changed, 310 insertions(+) > create mode 100644 include/qemu/yank.h > create mode 100644 util/yank.c Reviewed-by: Daniel P. Berrangé Regards

Re: [PATCH v7 2/8] block/nbd.c: Add yank feature

--- > block/nbd.c | 129 > 1 file changed, 80 insertions(+), 49 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.or

Re: [PATCH v7 3/8] chardev/char-socket.c: Add yank feature

sertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v7 4/8] migration: Add yank feature

ration.c | 25 - > migration/multifd.c | 10 ++ > migration/qemu-file-channel.c | 6 ++ > migration/savevm.c| 6 ++ > tests/Makefile.include| 2 +- > 6 files changed, 59 insertions(+), 2 deletions(-) Reviewed-by: D

Re: [PATCH v7 0/8] Introduce 'yank' oob qmp command to recover from hanging qemu

re creating > > > chardev" > > > > > > v6: > > > -add Reviewed-by and Acked-by tags > > > -rebase on master > > > -lots of changes in nbd due to rebase > > > -only take maintainership of util/yank.c and include/qemu/yank.h (Da

[PATCH v3 1/7] migration: improve error reporting of block driver state name

With blockdev, a BlockDriverState may not have a device name, so using a node name is required as an alternative. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 12 ++-- tests/qemu-iotests/267.out | 4 ++-- 2 files changed, 8

[PATCH v3 0/7] migration: bring improved savevm/loadvm/delvm to QMP

v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html When QMP was first introduced some 10+ years ago now, the snapshot related commands (savevm/loadvm/delvm) were not converted. This was primarily because

[PATCH v3 2/7] block: push error reporting into bdrv_all_*_snapshot functions

scenarios for some of these methods, which will benefit from fine grained error message reporting. So it is helpful to push error reporting down a level. Signed-off-by: Daniel P. Berrangé --- block/monitor/block-hmp-cmds.c | 7 ++-- block/snapshot.c | 77

[PATCH v3 3/7] migration: stop returning errno from load_snapshot()

None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 17 - 1 file

[PATCH v3 5/7] block: allow specifying name of block device for vmstate storage

: Daniel P. Berrangé --- block/monitor/block-hmp-cmds.c | 2 +- block/snapshot.c | 17 +++-- include/block/snapshot.h | 4 +++- migration/savevm.c | 4 ++-- 4 files changed, 21 insertions(+), 6 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c b

[PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

l is still blocking. The intention that the blocking problem is fixed later. None the less applications using these new commands should assume that they are asynchronous and thus wait for the job status change event to indicate completion. Signed-off-by: Daniel P. Berrangé --- include/migration/

[PATCH v3 4/7] block: add ability to specify list of blockdevs during snapshot

to be a way for the mgmt app to provide an explicit list of blockdevs to perform snapshots across. This can be achieved by passing a list of node names that should be used. Signed-off-by: Daniel P. Berrangé --- block/monitor/block-hmp-cmds.c | 4 +- block/snapshot.c | 167

[PATCH v3 6/7] iotests: add support for capturing and matching QMP events

ull events cached in $QEMU_EVENTS variable, and if none are found, will then read more from QMP. Signed-off-by: Daniel P. Berrangé --- tests/qemu-iotests/common.qemu | 107 - 1 file changed, 106 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.qemu

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

On Thu, Aug 27, 2020 at 01:04:43PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, Aug 26, 2020 at 05:52:06PM +0200, Markus Armbruster wrote: > > From the POV of practicality, making a design that unifies internal > > and external snapshots is s

Re: [PATCH 4/6] block, migration: add bdrv_finalize_vmstate helper

On Thu, Jul 09, 2020 at 04:26:42PM +0300, Denis V. Lunev wrote: > Right now bdrv_fclose() is just calling bdrv_flush(). > > The problem is that migration code is working inefficiently from block > layer terms and are frequently called for very small pieces of > unaligned data. Block layer is capab

Re: [PATCH 4/6] block, migration: add bdrv_finalize_vmstate helper

On Thu, Aug 27, 2020 at 04:02:38PM +0300, Denis V. Lunev wrote: > On 8/27/20 3:58 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 09, 2020 at 04:26:42PM +0300, Denis V. Lunev wrote: > >> Right now bdrv_fclose() is just calling bdrv_flush(). > >> > >> The probl

Re: [PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

On Wed, Aug 26, 2020 at 01:03:19PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Aug 25, 2020 at 05:14:21PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > Instead of relying on the limited info

Re: [PATCH v7 1/8] Introduce yank feature

On Thu, Aug 27, 2020 at 02:37:00PM +0200, Markus Armbruster wrote: > I apologize for not reviewing this much earlier. > > Lukas Straub writes: > > > The yank feature allows to recover from hanging qemu by "yanking" > > at various parts. Other qemu systems can register themselves and > > multiple

Re: [PATCH v8 1/8] Introduce yank feature

| 62 +++ > util/meson.build| 1 + > util/yank.c | 187 > 4 files changed, 331 insertions(+) > create mode 100644 include/qemu/yank.h > create mode 100644 util/yank.c Reviewed-by: Daniel P. Berrangé Regards

Re: [PATCH v8 6/8] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown

y: Stefan Hajnoczi > --- > include/io/channel.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

Re: [PATCH v8 4/8] migration: Add yank feature

; migration/migration.c | 25 + > migration/multifd.c | 10 ++ > migration/qemu-file-channel.c | 6 ++ > migration/savevm.c| 6 ++ > 5 files changed, 59 insertions(+) Reviewed-by: Daniel P. Berrangé Regards

Re: [PATCH v2 (BROKEN) 0/6] migration: bring improved savevm/loadvm/delvm to QMP

On Tue, Sep 01, 2020 at 03:22:24PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Aug 27, 2020 at 01:04:43PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Wed, Aug 26, 2020 at 05:52:06PM +

Re: [PATCH v8 1/8] Introduce yank feature

On Tue, Sep 01, 2020 at 04:38:46PM +0200, Markus Armbruster wrote: > One more question... > > Lukas Straub writes: > > > The yank feature allows to recover from hanging qemu by "yanking" > > at various parts. Other qemu systems can register themselves and > > multiple yank functions. Then all ya

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > savevm, loadvm and delvm are some of the few HMP commands that have never > > been converted to use QMP. The primary reason for this lack of conversion > > is that the

Re: [PATCH] qemu-iotests: move check-block back to Makefiles

On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote: > check-block has its own test harness, unlike every other test. If > we capture its output, as is in general nicer to do without V=1, > there will be no sign of progress. So for lack of a better option > just move the invocation of t

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

On Wed, Sep 02, 2020 at 11:27:17AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > savevm, loadvm and delvm are so

[PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry

monitor_fdset_get_fd entirely. Signed-off-by: Daniel P. Berrangé --- include/monitor/monitor.h | 3 +- include/qemu/osdep.h | 1 + monitor/misc.c| 58 +-- stubs/fdset.c | 8 ++ util/osdep.c | 19 ++--- 5 files

[PATCH v5 0/8] block: improve error reporting for unsupported O_DIRECT

arg checking Improved in v2: - Mention that qemu_open_err is preferred over qemu_open - Get rid of obsolete error_report call - Simplify O_DIRECT handling - Fixup iotests for changed error message text Daniel P. Berrangé (8): monitor: simplify functions for getting a dup'd fdset en

[PATCH v5 4/8] util: refactor qemu_open_old to split off variadic args handling

This simple refactoring prepares for future patches. The variadic args handling is split from the main bulk of the open logic. The duplicated calls to open() are removed in favour of updating the "flags" variable to have O_CLOEXEC. Signed-off-by: Daniel P. Berrangé --- util/os

[PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting

Instead of relying on the limited information from errno, we can now also provide detailed error messages to callers that ask for it. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util

[PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag

We're going to have multiple callers to open() from qemu_open() soon. Readability would thus benefit from having a helper for dealing with O_CLOEXEC. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --

[PATCH v5 3/8] util: rename qemu_open() to qemu_open_old()

We want to introduce a new version of qemu_open() that uses an Error object for reporting problems and make this it the preferred interface. Rename the existing method to release the namespace for the new impl. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P

[PATCH v5 7/8] util: give a specific error message when O_DIRECT doesn't work

A common error scenario is to tell QEMU to use O_DIRECT in combination with a filesystem that doesn't support it. To aid users to diagnosing their mistake we want to provide a clear error message when this happens. Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Dan

[PATCH v5 6/8] util: introduce qemu_open and qemu_create with error reporting

arguments which would prevent 'errp' from being the last argument. It also gives us a guarantee that the 'mode' is given when creating files, avoiding a latent security bug. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- include/qemu/osdep.h | 6 +++

Re: [PATCH v4 5/6] util: give a specific error message when O_DIRECT doesn't work

On Wed, Aug 26, 2020 at 01:19:53PM +0200, Markus Armbruster wrote: > Now back to my dislike of the #ifdeffery I voiced in reply to PATCH 2. > > Code now: > > #ifdef O_CLOEXEC > flags |= O_CLOEXEC; > #endif /* O_CLOEXEC */ > > ret = open(name, flags, mode); > > #ifnd

[PATCH v5 8/8] block/file: switch to use qemu_open/qemu_create for improved errors

ot;error": { "class": "GenericError", "desc": "Unable to open '/tmp/foo.img': filesystem does not support O_DIRECT" } Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Daniel

Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands

On Thu, Sep 03, 2020 at 12:17:29PM +0200, Kevin Wolf wrote: > Am 03.09.2020 um 11:48 hat Markus Armbruster geschrieben: > > If having to map from drive ID to node-name really is too much of a > > burden, we can look for ways to make it easier, or we can make savem > > optionally accept drive IDs in

Re: [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry

On Thu, Sep 03, 2020 at 10:52:40AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Currently code has to call monitor_fdset_get_fd, then dup > > the return fd, and then add the duplicate FD back into the > > fdset. This dance is overly verbose for the c

Re: [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting

On Thu, Sep 03, 2020 at 11:03:52AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Instead of relying on the limited information from errno, we can now > > also provide detailed error messages to callers that ask for it. > > > > Sig

[PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT

Fixup iotests for changed error message text Daniel P. Berrangé (8): monitor: simplify functions for getting a dup'd fdset entry util: split off a helper for dealing with O_CLOEXEC flag util: rename qemu_open() to qemu_open_old() util: refactor qemu_open_old to split off variadic arg

[PATCH v6 6/8] util: introduce qemu_open and qemu_create with error reporting

arguments which would prevent 'errp' from being the last argument. It also gives us a guarantee that the 'mode' is given when creating files, avoiding a latent security bug. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- include/qemu/osdep.h | 6 +++

[PATCH v6 5/8] util: add Error object for qemu_open_internal error reporting

Instead of relying on the limited information from errno, we can now also provide detailed error messages to callers that ask for it. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v6 2/8] util: split off a helper for dealing with O_CLOEXEC flag

We're going to have multiple callers to open() from qemu_open() soon. Readability would thus benefit from having a helper for dealing with O_CLOEXEC. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 23 +++ 1 file changed, 15 inser

[PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry

monitor_fdset_get_fd entirely. Signed-off-by: Daniel P. Berrangé --- include/monitor/monitor.h | 3 +- include/qemu/osdep.h | 1 + monitor/misc.c| 58 +-- stubs/fdset.c | 8 ++ util/osdep.c | 19 ++--- 5 files

[PATCH v6 7/8] util: give a specific error message when O_DIRECT doesn't work

A common error scenario is to tell QEMU to use O_DIRECT in combination with a filesystem that doesn't support it. To aid users to diagnosing their mistake we want to provide a clear error message when this happens. Reviewed-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Dan

[PATCH v6 3/8] util: rename qemu_open() to qemu_open_old()

Armbruster Signed-off-by: Daniel P. Berrangé --- accel/kvm/kvm-all.c| 2 +- backends/rng-random.c | 2 +- backends/tpm/tpm_passthrough.c | 8 block/file-posix.c | 14 +++--- block/file-win32.c | 5 +++-- block/vvfat.c

[PATCH v6 4/8] util: refactor qemu_open_old to split off variadic args handling

This simple refactoring prepares for future patches. The variadic args handling is split from the main bulk of the open logic. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff

[PATCH v6 8/8] block/file: switch to use qemu_open/qemu_create for improved errors

ot;error": { "class": "GenericError", "desc": "Unable to open '/tmp/foo.img': filesystem does not support O_DIRECT" } Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Daniel

Re: [PATCH 1/2] tests: Trying fixes test-replication.c on msys2/mingw.

On Sun, Sep 06, 2020 at 08:13:19PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Sun, Sep 6, 2020 at 5:49 AM Stefan Weil wrote: > > > Am 05.09.20 um 23:10 schrieb Yonggang Luo: > > > > > On Windows there is no path like /tmp/s_local_disk.XX > > > > > > Signed-off-by: Yonggang Luo > > > --- > > > tes

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > Disable following tests on msys2/mingw > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', > 'pkix_asn1_tab.c', >tasn1, crypto], > 'test-crypto-tlssession': ['crypto-tls-x509-hel

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

On Wed, Sep 09, 2020 at 03:48:18AM +0800, Yonggang Luo wrote: > freebsd 1 hour limit not hit anymore How long does the combined job take with this change ? If it is within 10 minutes of the limit, then we still want the split, as transient changes in the CI system can push it over the limit making

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote: > > > Disable following tests on msys2/mingw > > > 't

Re: [PATCH 07/16] tests: Trying fixes test-replication.c on msys2/mingw.

On Wed, Sep 09, 2020 at 03:48:11AM +0800, Yonggang Luo wrote: > On Windows there is no path like /tmp/s_local_disk.XX > > Signed-off-by: Yonggang Luo > --- > tests/test-replication.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/tests/test-replicatio

Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus

On Wed, Sep 09, 2020 at 03:48:10AM +0800, Yonggang Luo wrote: > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be > updated. > There is no need of --cross-prefix, open mingw64.

Re: [PATCH 11/16] meson: disable crypto tests are empty under win32

On Wed, Sep 09, 2020 at 04:30:26PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:22 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 04:17:22PM +0800, 罗勇刚(Yonggang Luo) wrote: > > > On Wed, Sep 9, 2020 at 4:11 PM Daniel P. Berrangé > > >

Re: [PATCH 14/16] cirrus: Building freebsd in a single short

On Wed, Sep 09, 2020 at 04:24:00PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:17 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:18AM +0800, Yonggang Luo wrote: > > > freebsd 1 hour limit not hit anymore > > > > How long

Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus

On Wed, Sep 09, 2020 at 05:36:49PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 4:27 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 03:48:10AM +0800, Yonggang Luo wrote: > > > Install msys2 in a proper way refer to > > https://github.com/ci

Re: [PATCH v2 01/21] block: Fixes nfs compiling error on msys2/mingw

blocks in struct _stat64, so we use > consistence st_size instead. > > Signed-off-by: Yonggang Luo > --- > block/nfs.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 02/21] ci: fixes msys2 build by upgrading capstone to 4.0.2

On Wed, Sep 09, 2020 at 05:45:58PM +0800, Yonggang Luo wrote: > The currently random version capstone have the following compiling issue: > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > make[1]: *** No rule to make target > “/c/work/xemu/qemu/build/capstone/capstone.lib”。 Stop. > > Su

Re: [PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses

On Wed, Sep 09, 2020 at 05:45:59PM +0800, Yonggang Luo wrote: > The mingw pkg-config are showing following absolute path and contains : as > the separator, > so we must handling : properly. > > -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L > -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/i

Re: [PATCH v2 04/21] curses: Fixes curses compiling errors.

ed-off-by: Yonggang Luo > Reviewed-by: Peter Maydell > Reviewed-by: Gerd Hoffmann > --- > ui/curses.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/

Re: [PATCH v2 05/21] tests: disable /char/stdio/* tests in test-char.c on win32

On Wed, Sep 09, 2020 at 05:46:01PM +0800, Yonggang Luo wrote: > These tests are blocking test-char to be finished. > Merge three #ifndef _WIN32 > > Signed-off-by: Yonggang Luo > --- > tests/test-char.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH v2 06/21] ci: Enable msys2 ci in cirrus

On Wed, Sep 09, 2020 at 05:46:02PM +0800, Yonggang Luo wrote: > Install msys2 in a proper way refer to > https://github.com/cirruslabs/cirrus-ci-docs/issues/699 > The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be > updated. > There is no need of --cross-prefix, open mingw64.

Re: [PATCH v2 07/21] tests: Trying fixes test-replication.c on msys2/mingw.

, 14 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé > @@ -571,6 +571,11 @@ static void setup_sigabrt_handler(void) > int main(int argc, char **argv) > { > int ret; > +const char *tmpdir = g_get_tmp_dir(); > +p_local_disk = g_strdup_printf("%s/p_loca

Re: [PATCH v2 08/21] tests: test-replication disable /replication/secondary/* on msys2/mingw.

quot;, test_secondary_stop); > g_test_add_func("/replication/secondary/continuous_replication", > @@ -605,6 +608,7 @@ int main(int argc, char **argv) > test_secondary_do_checkpoint); > g_test_add_func("/replication/secondary/get_erro

Re: [PATCH v2 09/21] osdep: These function are only available on Non-Win32 system.

mu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive); > int qemu_unlock_fd(int fd, int64_t start, int64_t len); > int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive); > bool qemu_has_ofd_lock(void); > +#endif Reviewed-by: Daniel P. Berrangé Regards, Dani

Re: [PATCH v2 10/21] meson: Use -b to ignore CR vs. CR-LF issues on Windows

gned-off-by: Yonggang Luo > Reviewed-by: Eric Blake > --- > tests/qapi-schema/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange

Re: [PATCH v2 12/21] meson: remove empty else and duplicated gio deps

On Wed, Sep 09, 2020 at 05:46:08PM +0800, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > meson.build | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/phot

Re: [PATCH v2 11/21] meson: disable crypto tests are empty under win32

t plan > > Because on win32 those test case are all disabled. > > Signed-off-by: Yonggang Luo > --- > tests/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -

Re: [PATCH v2 13/21] vmstate: Fixes test-vmstate.c on msys2/mingw

g_strdup_printf("%s/vmst.test.XX", > g_get_tmp_dir()); Could do with a line break before the arg. I'm surprised 'checkpatch.pl' didn't complain about this. With the line break Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [PATCH v3 14/21] cirrus: Building freebsd in a single short

uming are little > We should not hide the error by split them > > Signed-off-by: Yonggang Luo > --- > .cirrus.yml | 35 --- > 1 file changed, 8 insertions(+), 27 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https:/

Re: [PATCH v2 15/21] tests: Convert g_free to g_autofree macro in test-logging.c

On Wed, Sep 09, 2020 at 05:46:11PM +0800, Yonggang Luo wrote: > g_autofree are prefer than g_free when possible. > > Signed-off-by: Yonggang Luo > Reviewed-by: Philippe Mathieu-Daudé > --- > tests/test-logging.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH v2 17/21] tests: Fixes test-io-channel-socket.c tests under msys2/mingw

gt; > Signed-off-by: Yonggang Luo > --- > tests/test-io-channel-socket.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v2 19/21] tests: Fixes test-io-channel-file by mask only owner file state mask bits

On Wed, Sep 09, 2020 at 05:46:15PM +0800, Yonggang Luo wrote: > This is the error on msys2/mingw > Running test test-io-channel-file > ** > ERROR:../tests/test-io-channel-file.c:59:test_io_channel_file_helper: > assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) > ERROR test-i

Re: [PATCH v2 20/21] tests: fix test-util-sockets.c

_ADDRESS_TYPE_FD socket type > > Signed-off-by: Yonggang Luo > --- > tests/test-util-sockets.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/db

Re: [PATCH v2 21/21] tests: Fixes test-qdev-global-props.c

tions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 03/21] configure: Fixes ncursesw detection under msys2/mingw and enable curses

On Wed, Sep 09, 2020 at 08:55:15PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Wed, Sep 9, 2020 at 8:51 PM Daniel P. Berrangé > wrote: > > > On Wed, Sep 09, 2020 at 05:45:59PM +0800, Yonggang Luo wrote: > > > The mingw pkg-config are showing following absolute path and contain

Re: [PATCH v4 24/24] ci: Enable msys2 ci in cirrus

-snappy > +mingw-w64-x86_64-libusb > +mingw-w64-x86_64-usbredir > +mingw-w64-x86_64-libtasn1 > +mingw-w64-x86_64-libnfs > +mingw-w64-x86_64-nettle > +mingw-w64-x86_64-cyrus-sasl > +mingw-w64-x86_64-curl > +mingw-w

Re: [PATCH v2 14/21] cirrus: Building freebsd in a single short

On Wed, Sep 09, 2020 at 01:32:04PM -0400, Ed Maste wrote: > On Wed, 9 Sep 2020 at 05:47, Yonggang Luo wrote: > > > > freebsd 1 hour limit not hit anymore > > > > Signed-off-by: Yonggang Luo > > Reviewed-by: Ed Maste > > > When its running properly, the consumed time are little, but when tests

Re: [PATCH v6 25/25] meson: guard the minimal meson version to 0.55.1

On Thu, Sep 10, 2020 at 02:42:37AM +0800, Yonggang Luo wrote: > So we can removal usage of unstable-keyval > > Signed-off-by: Yonggang Luo > --- > meson.build | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) This prevents the use on Fedora which has 0.55.0 only. This is not desi

Re: [PATCH v6 0/8] block: improve error reporting for unsupported O_DIRECT

didn't see failures On Thu, Sep 03, 2020 at 04:22:02PM +0100, Daniel P. Berrangé wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00589.html > v3: https://lists.gnu.org/archive/html/qemu-dev

Re: [PATCH v7 17/25] cirrus: Building freebsd in a single short

On Thu, Sep 10, 2020 at 04:18:10PM +0200, Thomas Huth wrote: > On 10/09/2020 12.37, Yonggang Luo wrote: > > This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba > > ("cirrus.yml: Split FreeBSD job into two parts"). > > > > freebsd 1 hour limit not hit anymore > > > > I think we going to a

Re: [PATCH v3 0/7] migration: bring improved savevm/loadvm/delvm to QMP

On Fri, Sep 11, 2020 at 12:52:04PM +0100, Dr. David Alan Gilbert wrote: > Kevin: > While we're still arguing about details of the last commit; can we get > the first few commits in - they seem to be generally nice cleanups/error > handling. I'm going to try to send a update next week which just

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

On Tue, Aug 11, 2020 at 09:54:08PM +0800, Zhenyu Ye wrote: > Hi Kevin, > > On 2020/8/10 23:38, Kevin Wolf wrote: > > Am 10.08.2020 um 16:52 hat Zhenyu Ye geschrieben: > >> Before doing qmp actions, we need to lock the qemu_global_mutex, > >> so the qmp actions should not take too long time. > >> >

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 11:58:24PM +0800, 罗勇刚(Yonggang Luo) wrote: > On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth > > > wrote: > > >> > > >> On 13/09/

Re: [PATCH 2/2] block: file-posix: Replace posix_fallocate with fallocate

On Mon, Aug 31, 2020 at 05:01:27PM +0300, Nir Soffer wrote: > If fallocate() is not supported, posix_fallocate() falls back to > inefficient allocation, writing one byte for every 4k bytes[1]. This is > very slow compared with writing zeros. In oVirt we measured ~400% > improvement in allocation ti

[PATCH v4 2/9] migration: stop returning errno from load_snapshot()

None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 17 - 1 file

[PATCH v4 0/9] migration: bring improved savevm/loadvm/delvm to QMP

v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html This series aims to provide a better designed replacement for the savevm/loadvm

[PATCH v4 6/9] migration: wire up support for snapshot device selection

Modify load_snapshot/save_snapshot to accept the device list and vmstate node name parameters previously added to the block layer. Signed-off-by: Daniel P. Berrangé --- include/migration/snapshot.h | 12 ++-- migration/savevm.c | 24 ++-- monitor/hmp-cmds.c

[PATCH v4 5/9] migration: control whether snapshots are ovewritten

The traditional HMP "savevm" command will overwrite an existing snapshot if it already exists with the requested name. This new flag allows this to be controlled allowing for safer behaviour with a future QMP command. Signed-off-by: Daniel P. Berrangé --- include/migration/snap

[PATCH v4 4/9] block: allow specifying name of block device for vmstate storage

: Daniel P. Berrangé --- block/monitor/block-hmp-cmds.c | 2 +- block/snapshot.c | 23 --- include/block/snapshot.h | 3 ++- migration/savevm.c | 4 ++-- 4 files changed, 25 insertions(+), 7 deletions(-) diff --git a/block/monitor/block-hmp-cmds.c

<    4   5   6   7   8   9   10   11   12   13   >