On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzini wrote:
> On 07/01/20 13:18, Thomas Huth wrote:
> > I don't think we need a separate priority parameter here. But IMHO it's
> > really rather common practice to prioritize the last option. So while
> > it might be more "self-explanatory" to a
On Tue, Jan 07, 2020 at 03:14:52PM +0100, Thomas Huth wrote:
> On 07/01/2020 13.54, Daniel P. Berrangé wrote:
> > On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzini wrote:
> >> On 07/01/20 13:18, Thomas Huth wrote:
> >>> I don't think we need a separate pri
On Tue, Jan 07, 2020 at 03:20:40PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/7/20 3:14 PM, Thomas Huth wrote:
> > On 07/01/2020 13.54, Daniel P. Berrangé wrote:
> > > On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzini wrote:
> > > > On 07/01/20 13:18, Thomas
On Wed, Jan 08, 2020 at 01:41:59PM +0100, Paolo Bonzini wrote:
> On 08/01/20 11:58, Thomas Huth wrote:
> >> "-accel default" could be considered to have vibes of Do The Right
> >> Thing (tm) and could in time actually become so!
> >
> > "-accel default" sounds like the default behavior that you'd a
On Tue, Jan 14, 2020 at 06:49:45PM +0100, Christophe de Dinechin wrote:
>
>
> > On 13 Jan 2020, at 17:25, Paolo Bonzini wrote:
> >
> > On 13/01/20 17:17, Markus Armbruster wrote:
> >> Perfect opportunity to change the default to something more useful.
> >
> > I am not sure acutally if it's tha
On Tue, Jan 14, 2020 at 07:27:31PM +0100, Kevin Wolf wrote:
> Some QMP command handlers can block the main loop for a relatively long
> time, for example because they perform some I/O. This is quite nasty.
> Allowing such handlers to run in a coroutine where they can yield (and
> therefore release
ntsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
block/sheepdog.c | 14 ++
configure | 5 +++--
docs/system/deprecated.rst | 9 +
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/block/she
-off-by: Daniel P. Berrangé
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b76fb31861..c7d6601adf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2874,7 +2874,6 @@ F: block/rbd.c
Sheepdog
M: Liu Yuan
L: qemu-block@nongnu.org
-L: sheep
entirely.
See the rationale in the second patch commit message.
Changes in v3:
- A few minor text changes
- Don't initialize static variable to false
Daniel P. Berrangé (2):
block: drop moderated sheepdog mailing list from MAINTAINERS file
block: deprecate the sheepdog block d
On Mon, Sep 21, 2020 at 01:16:16PM -0500, Eric Blake wrote:
> On 9/16/20 3:17 AM, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > > savevm, loadvm and delvm are some of the few HMP commands that have never
> > > been converted to use QMP. The r
scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 7 ++--
block/snapshot.c | 77
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html
This s
None of the callers care about the errno value since there is a full
Error object populated. This gives consistency with save_snapshot()
which already just returns -1.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 17 -
1 file
to be a way for the mgmt app to provide an explicit
list of blockdevs to perform snapshots across. This can be achieved
by passing a list of node names that should be used.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 4 +-
block/snapshot.c | 180
Modify load_snapshot/save_snapshot to accept the device list and vmstate
node name parameters previously added to the block layer.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 12 ++--
migration/savevm.c | 28 +---
monitor/hmp
Make snapshot deletion consistent with the snapshot save
and load commands by using a wrapper around the blockdev
layer. The main difference is that we get upfront validation
of the passed in device list (if any).
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 4
The traditional HMP "savevm" command will overwrite an existing snapshot
if it already exists with the requested name. This new flag allows this
to be controlled allowing for safer behaviour with a future QMP command.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snaps
ull events
cached in $QEMU_EVENTS variable, and if none are found, will
then read more from QMP.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.qemu | 107 -
1 file changed, 106 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.qemu
error, 0 if no snapshot is found and 1 if snapshot is found.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 19 ---
include/block/snapshot.h | 6 +++---
migration/savevm.c | 7 ++-
4 files changed
: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 26 +++---
include/block/snapshot.h | 3 ++-
migration/savevm.c | 4 ++--
tests/qemu-iotests/267.out | 12 ++--
5 files changed, 34 insertions(+), 13
k, the new commands require the
caller to be explicit about all the block device nodes used in the
snapshot operations, with no built-in default heuristics in use.
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 184 +
qapi/job.json | 9 +-
qapi/migr
On Mon, Oct 05, 2020 at 09:26:54AM +0200, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 10/2/20 11:27 AM, Daniel P. Berrangé wrote:
> >
> > Do we have a query- command handy to easily learn which snapshot names
> > are even available to attempt deleti
On Fri, Oct 02, 2020 at 02:46:07PM -0500, Eric Blake wrote:
> On 10/2/20 11:27 AM, Daniel P. Berrangé wrote:
> > savevm, loadvm and delvm are some of the few HMP commands that have never
> > been converted to use QMP. The reasons for the lack of conversion are
> > that they
On Mon, Oct 05, 2020 at 12:54:40PM +0200, Philippe Mathieu-Daudé wrote:
> While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
> by a device only available using system-mode (fw_cfg), it is
> implemented by a crypto component (tls-cipher-suites) which
> is always available when crypto is used
ull events
cached in $QEMU_EVENTS variable, and if none are found, will
then read more from QMP.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.qemu | 107 -
1 file changed, 106 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.qemu
to be a way for the mgmt app to provide an explicit
list of blockdevs to perform snapshots across. This can be achieved
by passing a list of node names that should be used.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 4 +-
block/snapshot.c | 180
Modify load_snapshot/save_snapshot to accept the device list and vmstate
node name parameters previously added to the block layer.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 12 ++--
migration/savevm.c | 28 +---
monitor/hmp
None of the callers care about the errno value since there is a full
Error object populated. This gives consistency with save_snapshot()
which already just returns -1.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 15 +++
1 file
error, 0 if no snapshot is found and 1 if snapshot is found.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 19 ---
include/block/snapshot.h | 6 +++---
migration/savevm.c | 7 ++-
replay/replay
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html
v5: ht
scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 7 ++--
block/snapshot.c | 77
: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 26 +++---
include/block/snapshot.h | 3 ++-
migration/savevm.c | 4 ++--
replay/replay-debugging.c | 2 +-
tests/qemu-iotests/267.out | 12 ++--
6
y: Markus Armbruster
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 184 +
qapi/job.json | 9 +-
qapi/migration.json| 121 +++
tests/qemu-iotests/310 | 385 +++
tests/qemu-i
Make snapshot deletion consistent with the snapshot save
and load commands by using a wrapper around the blockdev
layer. The main difference is that we get upfront validation
of the passed in device list (if any).
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 4
The traditional HMP "savevm" command will overwrite an existing snapshot
if it already exists with the requested name. This new flag allows this
to be controlled allowing for safer behaviour with a future QMP command.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snaps
ping: for anyone in the block or migration maintainers teams to
review this, since Markus has acked the QAPI design side of it.
On Thu, Oct 08, 2020 at 04:49:51PM +0100, Daniel P. Berrangé wrote:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html
> v2:
On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote:
> On Wed, 2020-10-14 at 10:29 -0400, John Snow wrote:
> > Python infrastructure as it exists today is not capable reliably of
> > single-sourcing a package version from a parent directory. The authors
> > of pip are working to correc
On Tue, Oct 20, 2020 at 10:52:14AM +0200, Andrea Bolognani wrote:
> On Mon, 2020-10-19 at 11:02 +0100, Daniel P. Berrangé wrote:
> > On Mon, Oct 19, 2020 at 11:45:09AM +0200, Andrea Bolognani wrote:
> > > With that in mind, I think it would be unwise for qemu.* not to do
On Mon, Oct 12, 2020 at 02:27:42PM +0200, Philippe Mathieu-Daudé wrote:
> Just for consistency, following the example documented since
> commit e3fe3988d7 ("error: Document Error API usage rules"),
> return a boolean value indicating an error is set or not.
>
> Acked-by: Pavel Dovgalyuk
> Signed-
On Mon, Oct 12, 2020 at 02:27:43PM +0200, Philippe Mathieu-Daudé wrote:
> From: Daniel P. Berrangé
>
> None of the callers care about the errno value since there is a full
> Error object populated. This gives consistency with save_snapshot()
> which already just returns
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html
v5: ht
scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Signed-off-by: Daniel P. Berrangé
[PMD: Initialize variables]
Signed-off-by: Philippe Mathieu-Daudé
---
block/monitor/block-hmp-cmds.c | 7
From: Philippe Mathieu-Daudé
Just for consistency, following the example documented since
commit e3fe3988d7 ("error: Document Error API usage rules"),
return a boolean value indicating an error is set or not.
Acked-by: Pavel Dovgalyuk
Signed-off-by: Philippe Mathieu-Daudé
---
include/migratio
Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 26 +++---
include/block/snapshot.h | 3 ++-
migration/savevm.c | 4 ++--
replay/replay-debugging.c | 2 +-
tests/qemu-iotests/267.out
error, 0 if no snapshot is found and 1 if snapshot is found.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 19 ---
include/block/snapshot.h | 6 +++---
migration/savevm.c | 7
ull events
cached in $QEMU_EVENTS variable, and if none are found, will
then read more from QMP.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.qemu | 107 -
1 file changed, 106 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.qemu
y: Markus Armbruster
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 184 +
qapi/job.json | 9 +-
qapi/migration.json| 121 +++
tests/qemu-iotests/310 | 385 +++
tests/qemu-i
None of the callers care about the errno value since there is a full
Error object populated. This gives consistency with save_snapshot()
which already just returns a boolean value.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
[PMD: Return false/true instead of -1/0
to be a way for the mgmt app to provide an explicit
list of blockdevs to perform snapshots across. This can be achieved
by passing a list of node names that should be used.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 4 +-
block/snapshot.c
The traditional HMP "savevm" command will overwrite an existing snapshot
if it already exists with the requested name. This new flag allows this
to be controlled allowing for safer behaviour with a future QMP command.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
--
Modify load_snapshot/save_snapshot to accept the device list and vmstate
node name parameters previously added to the block layer.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 18 --
migration/savevm.c | 28 +---
monitor
Make snapshot deletion consistent with the snapshot save
and load commands by using a wrapper around the blockdev
layer. The main difference is that we get upfront validation
of the passed in device list (if any).
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 13
On Fri, Oct 23, 2020 at 12:12:16PM +0200, Kevin Wolf wrote:
> While the qemu-storage-daemon command line is still considered unstable,
> let's change --chardev from the old QemuOpts-based parser to QAPI, so
> that it becomes a simple mapping of chardev-add to the command line and
> will fit in a fu
From: AlexChen
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: AlexChen
Signed-off-by: Daniel P. Berrangé
---
io/channel-websock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index bb545fa327..03c1f7cb62 100644
--- a/io
comment section.
Signed-off-by: Chetan Pant
Signed-off-by: Daniel P. Berrangé
---
authz/base.c| 2 +-
authz/list.c| 2 +-
authz/listfile.c| 2 +-
authz/pamacct.c | 2 +-
authz/simple.c | 2 +-
include/authz/base.h
comment section.
Signed-off-by: Chetan Pant
Signed-off-by: Daniel P. Berrangé
---
tests/test-crypto-afsplit.c | 2 +-
tests/test-crypto-block.c | 2 +-
tests/test-crypto-cipher.c | 2 +-
tests/test-crypto-hash.c| 2 +-
tests/test-crypto-ivgen.c | 2 +-
tests/test-crypto-secret.c |
comment section.
Signed-off-by: Chetan Pant
Signed-off-by: Daniel P. Berrangé
---
include/io/channel-buffer.h | 2 +-
include/io/channel-command.h| 2 +-
include/io/channel-file.h | 2 +-
include/io/channel-socket.h | 2 +-
include/io/channel-tls.h| 2 +-
includ
missing in their kernel build (IPv6, VSock in particular).
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/162.out | 4 ++--
util/qemu-sockets.c| 32 +++-
2 files changed, 21 insertions(+), 15 deletions(-)
diff --g
The following changes since commit bbc48d2bcb9711614fbe751c2c5ae13e172fbca8:
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20201027' =
into staging (2020-10-28 16:25:31 +)
are available in the Git repository at:
https://gitlab.com/berrange/qemu tags/misc-next-pull-requ
Update some docs and test cases to use 'on' | 'off' as the preferred
value for bool options.
Signed-off-by: Daniel P. Berrangé
---
docs/system/vnc-security.rst | 6 +++---
include/authz/listfile.h | 2 +-
qemu-options.hx | 4 ++--
tests/qemu-iotests/233
Update some docs and test cases to use 'on' | 'off' as the preferred
value for bool options.
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
docs/system/vnc-security.rst | 10 +-
include/authz/listfile.h | 2
On Wed, Nov 04, 2020 at 05:48:40PM +0200, Nir Soffer wrote:
> The docs[1] say:
>
> - The optional iothread attribute assigns the disk to an IOThread as defined
> by
> the range for the domain iothreads value. Multiple disks may be assigned to
> the same IOThread and are numbered from 1 to the
On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote:
> cURL 7.16.0 was released in October 2006. Just remove code that is
> in all likelihood not being used anywhere.
Rather than assuming that, we should be picking our minimum version
and enforcing that in configure/meson.
Currently, w
On Tue, Nov 17, 2020 at 01:40:56PM +0100, Paolo Bonzini wrote:
> On 17/11/20 12:46, Daniel P. Berrangé wrote:
> > On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote:
> > > cURL 7.16.0 was released in October 2006. Just remove code that is
> > > in all likelih
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00866.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg07523.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg07076.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05221.html
v5: ht
scenarios for some of these methods, which
will benefit from fine grained error message reporting. So it is
helpful to push error reporting down a level.
Signed-off-by: Daniel P. Berrangé
[PMD: Initialize variables]
Signed-off-by: Philippe Mathieu-Daudé
---
block/monitor/block-hmp-cmds.c | 7
error, 0 if no snapshot is found and 1 if snapshot is found.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 19 ---
include/block/snapshot.h | 6 +++---
migration/savevm.c | 7
Make snapshot deletion consistent with the snapshot save
and load commands by using a wrapper around the blockdev
layer. The main difference is that we get upfront validation
of the passed in device list (if any).
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 13
From: Philippe Mathieu-Daudé
Just for consistency, following the example documented since
commit e3fe3988d7 ("error: Document Error API usage rules"),
return a boolean value indicating an error is set or not.
Acked-by: Pavel Dovgalyuk
Signed-off-by: Philippe Mathieu-Daudé
---
include/migratio
to be a way for the mgmt app to provide an explicit
list of blockdevs to perform snapshots across. This can be achieved
by passing a list of node names that should be used.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 4 +-
block/snapshot.c
Blake
Signed-off-by: Daniel P. Berrangé
---
block/monitor/block-hmp-cmds.c | 2 +-
block/snapshot.c | 26 +++---
include/block/snapshot.h | 3 ++-
migration/savevm.c | 4 ++--
replay/replay-debugging.c | 2 +-
tests/qemu-iotests/267.out
Modify load_snapshot/save_snapshot to accept the device list and vmstate
node name parameters previously added to the block layer.
Signed-off-by: Daniel P. Berrangé
---
include/migration/snapshot.h | 18 --
migration/savevm.c | 28 +---
monitor
y: Markus Armbruster
Signed-off-by: Daniel P. Berrangé
---
migration/savevm.c | 184 +
qapi/job.json | 9 +-
qapi/migration.json| 121 +++
tests/qemu-iotests/310 | 385 +++
tests/qemu-i
The traditional HMP "savevm" command will overwrite an existing snapshot
if it already exists with the requested name. This new flag allows this
to be controlled allowing for safer behaviour with a future QMP command.
Reviewed-by: Eric Blake
Signed-off-by: Daniel P. Berrangé
--
ull events
cached in $QEMU_EVENTS variable, and if none are found, will
then read more from QMP.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/common.qemu | 107 -
1 file changed, 106 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.qemu
None of the callers care about the errno value since there is a full
Error object populated. This gives consistency with save_snapshot()
which already just returns a boolean value.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Daniel P. Berrangé
[PMD: Return false/true instead of -1/0
On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote:
> ImageInfo has an optional member @compressed:
>
> ##
> # @ImageInfo:
> [...]
> # @compressed: true if the image is compressed (Since 1.7)
>
> Doc bug: neglects to specify the default. I guess it's false.
>
> Th
On Mon, Nov 30, 2020 at 03:58:23PM +0100, Paolo Bonzini wrote:
> On 30/11/20 13:25, Kevin Wolf wrote:
> > This series adds a QAPI type for the properties of all user creatable
> > QOM types and finally makes QMP object-add use the new ObjectOptions
> > union so that QAPI introspection can be used f
On Mon, Nov 30, 2020 at 05:13:57PM +0100, Kevin Wolf wrote:
> Am 30.11.2020 um 16:30 hat Daniel P. Berrangé geschrieben:
> > On Mon, Nov 30, 2020 at 03:58:23PM +0100, Paolo Bonzini wrote:
> > > On 30/11/20 13:25, Kevin Wolf wrote:
> > > > This series adds a QAPI type for the properties of all us
On Fri, Nov 27, 2020 at 05:52:09PM +0100, Markus Armbruster wrote:
> Kevin Wolf writes:
>
> > Am 27.11.2020 um 13:21 hat Markus Armbruster geschrieben:
> >> >> I fell down this (thankfully shallow) rabbit hole because we also have
> >> >>
> >> >> { 'enum': 'MultiFDCompression',
> >> >>
On Tue, Dec 08, 2020 at 08:59:37PM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test th
On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote:
> Am 08.12.2020 um 13:59 hat Li Feng geschrieben:
> > This patch addresses this issue:
> > When accessing a volume on an NFS filesystem without supporting the file
> > lock,
> > tools, like qemu-img, will complain "Failed to lock byte 100
On Thu, Dec 10, 2020 at 10:56:59PM +0800, Li Feng wrote:
> Kevin Wolf 于2020年12月10日周四 上午1:43写道：
> >
> > Am 09.12.2020 um 10:33 hat Daniel P. Berrangé geschrieben:
> > > On Tue, Dec 08, 2020 at 03:38:22PM +0100, Kevin Wolf wrote:
> > > > Am 08.12.2
On Thu, Dec 10, 2020 at 11:53:09PM +0800, Feng Li wrote:
> My mistake, you are not on the receiver list of my v2.
> I use the get_maintainer.sh to generate the cc list.
> I will resend it to you.
No, need. I've seen 2, but didn't think you were referring to that
as it still has most of the flaws I
On Wed, Dec 09, 2020 at 12:54:48PM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test th
On Fri, Dec 11, 2020 at 12:38:19AM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> Add a new function 'qemu_has_file_lock' to detect if the
On Tue, Dec 15, 2020 at 03:09:28PM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test th
se a new function instead.
> v2: remove the refactoring.
> ---
> block/file-posix.c | 61 +++-
> include/qemu/osdep.h | 1 +
> util/osdep.c | 14 ++
> 3 files changed, 47 insertions(+), 29 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|:
On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 15.12.2020 13:53, Li Feng wrote:
> > This patch addresses this issue:
> > When accessing a volume on an NFS filesystem without supporting the file
> > lock,
> > tools, like qemu-img, will complain "Failed to lock byte
On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 16.12.2020 12:49, Daniel P. Berrangé wrote:
> > On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > 15.12.2020 13:53, Li Feng wrote:
> > >
On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 16.12.2020 13:41, Daniel P. Berrangé wrote:
> > On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > 16.12.2020 12:49, Daniel P. Berrangé wrote:
> > >
On Mon, May 18, 2020 at 03:20:27PM +0300, Maxim Levitsky wrote:
> Hi!
> Here is the updated series of my patches, incorporating all the feedback I
> received.
>
> This implements the API interface that we agreed upon except that I merged the
> LUKSKeyslotActive/LUKSKeyslotInactive union into a st
On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> The yank feature allows to recover from hanging qemu by "yanking"
> at various parts. Other qemu systems can register themselves and
> multiple yank functions. Then all yank functions for selected
> instances can be called by the 'yank
+
> block/nbd.c | 101 --
> 2 files changed, 65 insertions(+), 37 deletions(-)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.or
On Mon, May 25, 2020 at 05:44:26PM +0200, Lukas Straub wrote:
> Register a yank function which shuts down the socket and sets
> s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
> error occured.
>
> Signed-off-by: Lukas Straub
> ---
> Makefile.objs | 1 +
> block/nbd.c | 101 ++
tions(+)
Reviewed-by: Daniel P. Berrangé
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> The yank feature allows to recover from hanging qemu by "yanking"
> at various parts. Other qemu systems can register themselves and
> multiple yank functions. Then all yank functions for selected
> instances can be called by the 'yank
ration.c | 18 +-
> migration/multifd.c | 10 ++
> migration/qemu-file-channel.c | 6 ++
> migration/savevm.c| 2 ++
> tests/Makefile.include| 2 +-
> 7 files changed, 49 insertions(+), 2 deletions(-)
Reviewed-by: D
On Fri, Jun 19, 2020 at 06:29:24PM +0200, Lukas Straub wrote:
> On Wed, 17 Jun 2020 16:12:40 +0100
> Stefan Hajnoczi wrote:
>
> > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > > +static struct YankInstance *yank_find_instance(char *name)
> >
> > There are const char * -> ch
On Fri, Jun 19, 2020 at 04:23:50PM +0200, Lukas Straub wrote:
> On Tue, 16 Jun 2020 15:39:57 +0100
> Daniel P. Berrangé wrote:
>
> > On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > > The yank feature allows to recover from hanging qemu by "yanking&q
601 - 700 of 1885 matches
Mail list logo
