On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
>
> Andrey Drobyshev (11):
> qcow2: make function update_refcount_discard() global
> qcow2: simplify L2 entries accounting for discard-no-unref
>
On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
> On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
>> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
>>
>> Andrey Drobyshev (11):
>> qcow2: make function update_refcount_discard() global
>> qcow
On 6/10/24 11:53 AM, Andrey Drobyshev wrote:
> On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
>> On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
>>> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
>>>
>>> Andrey Drobyshev (11):
>>>
On 6/17/24 9:39 AM, Andrey Drobyshev wrote:
> On 6/10/24 11:53 AM, Andrey Drobyshev wrote:
>> On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
>>> On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
>>>> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
On 6/24/24 10:43 AM, Andrey Drobyshev wrote:
> On 6/17/24 9:39 AM, Andrey Drobyshev wrote:
>> On 6/10/24 11:53 AM, Andrey Drobyshev wrote:
>>> On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
>>>> On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
>>>>> v1: htt
7;re other operations which are run
outside of the coroutine context and which also modify the file_end
field, e.g. preallocate_set_perm() and preallocate_child_perm().
Comments on how to protect the field properly regardless of the context
are welcome.
Andrey Drobyshev (1):
iotests/298: add testcase
esult into a race within the preallocation filter which would zeroize
some clusters after actually writing data to them.
Note: the test doesn't fail in 100% cases as there's a race involved,
but the failures are pretty consistent so it should be good enough for
detecting the problem.
S
only once it is detected that the preallocation
is really required. This is not a frequent case due to the preallocation
nature thus the patch should not have performance impact.
Originally-by: Denis V. Lunev
Co-authored-by: Andrey Drobyshev
Signed-off-by: Denis V. Lunev
Signed-off-by: And
this area and they will not proceed thanks to overlapping
requests mechanics. If preallocation will fail, we will just switch
to the normal expand-by-write behavior and that is not a problem
except performance.
Signed-off-by: Denis V. Lunev
Tested-by: Andrey Drobyshev
---
block/preallocate.c |
esult into a race within the preallocation filter which would zeroize
some clusters after actually writing data to them.
Note: the test doesn't fail in 100% cases as there's a race involved,
but the failures are pretty consistent so it should be good enough for
detecting the problem.
S
the operations performed in other coroutines (e.g.
truncate) and outside of the coroutine context (preallocate_set_perm() /
preallocate_child_perm()). So the comments on this are most welcome.
v1: https://lists.nongnu.org/archive/html/qemu-block/2024-07/msg00384.html
Andrey Drobyshev (1):
iotests/
On 7/8/24 10:06 AM, Andrey Drobyshev wrote:
> On 6/24/24 10:43 AM, Andrey Drobyshev wrote:
>> On 6/17/24 9:39 AM, Andrey Drobyshev wrote:
>>> On 6/10/24 11:53 AM, Andrey Drobyshev wrote:
>>>> On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
>>>>> On 5/13/
;t work with partitions built on top of LVM.
Partitions on LVM would require another level of mapping.
Signed-off-by: Andrey Drobyshev
---
scripts/filev2p.py | 311 +
1 file changed, 311 insertions(+)
create mode 100755 scripts/filev2p.py
diff --gi
On 7/16/24 4:32 PM, Denis V. Lunev wrote:
> On 7/12/24 13:55, Vladimir Sementsov-Ogievskiy wrote:
>> On 12.07.24 12:46, Andrey Drobyshev wrote:
>>> From: "Denis V. Lunev"
>>>
>>> We have observed that some clusters in the QCOW2 files are zeroed
>
this area and they will not proceed thanks to overlapping
requests mechanics. If preallocation will fail, we will just switch
to the normal expand-by-write behavior and that is not a problem
except performance.
Signed-off-by: Denis V. Lunev
Tested-by: Andrey Drobyshev
---
block/preallocate.c |
esult into a race within the preallocation filter which would zeroize
some clusters after actually writing data to them.
Note: the test doesn't fail in 100% cases as there's a race involved,
but the failures are pretty consistent so it should be good enough for
detecting the problem.
S
;t work with partitions built on top of LVM.
Partitions on LVM would require another level of mapping.
Signed-off-by: Andrey Drobyshev
---
scripts/filev2p.py | 311 +
1 file changed, 311 insertions(+)
create mode 100755 scripts/filev2p.py
diff --gi
ets. The script was used to
initially track down the data corruption problem, so it's included
here.
v2: https://lists.nongnu.org/archive/html/qemu-block/2024-07/msg00413.html
Andrey Drobyshev (2):
iotests/298: add testcase for async writes with preallocation filter
scri
On 7/22/24 10:18 AM, Thomas Huth wrote:
> [Вы нечасто получаете письма от th...@redhat.com. Узнайте, почему это
> важно, по адресу https://aka.ms/LearnAboutSenderIdentification ]
>
> On 31/10/2023 19.58, Kevin Wolf wrote:
>> From: Andrey Drobyshev
>>
>> As the pre
m the output.
This is a fixup for the commit f93e65ee51 ("iotests/{024, 271}: add
testcases for qemu-img rebase").
Found-by: Thomas Huth
Signed-off-by: Andrey Drobyshev
---
tests/qemu-iotests/024 | 2 +-
tests/qemu-iotests/024.out | 1 -
2 files changed, 1 insertion(+), 2 deletion
On 8/5/24 3:04 PM, Kevin Wolf wrote:
> Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
>> The testcase simply creates a 64G image with 1M clusters, generates a list
>> of 1M aligned offsets and feeds aio_write commands with those offsets to
>> qemu-io run with &#
On 8/5/24 3:29 PM, Kevin Wolf wrote:
> Am 16.07.2024 um 16:41 hat Andrey Drobyshev geschrieben:
>> The script is basically a wrapper around "filefrag" utility. This might
>> be used to map virtual offsets within the file to the underlying block
>> device offsets.
) and that with the option enabled cluster is still marked as
allocated in "qemu-img map" output. We also check that the option
doesn't work with qcow2 v2 images.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Reviewed-by: Alberto Garcia
---
tests/
We are going to need it for discarding separate subclusters. The
function itself doesn't do anything with the refcount tables, it simply
adds a discard request to the queue, so rename it to qcow2_queue_discard().
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Reviewed-by:
When zeroizing the last non-zero subclusters within single cluster, it
makes sense to go zeroize the entire cluster and go down zero_in_l2_slice()
path right away. That way we'd also update the corresponding refcount
table.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Rev
v2: https://lists.nongnu.org/archive/html/qemu-devel/2024-05/msg02396.html
v2 -> v3:
* Added patch 12/12 "qcow2: add discard-subclusters option" which
makes subcluster-based discards optional;
* Added a bunch of R-b's.
Andrey Drobyshev (12):
qcow2: make function updat
check
for the presence of external data files for us and redirect request to
underlying data_file. Here we want to do the same but avoid refcount updates,
thus we perform the same checks.
Suggested-by: Hanna Czenczek
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
---
block/
Move the definition from iotests/250 to common.rc. This is used to
detect real disk usage of sparse files. In particular, we want to use
it for checking subclusters-based discards.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Reviewed-by: Alberto Garcia
---
tests/qemu
make all discard/unmap operations enable trace point 'file_do_fallocate'
so that actual fallocate() calls are visible.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
---
tests/qemu-iotests/271 | 70 +-
tests/qemu-iotests/27
with subclusters enabled.
Also rename qcow2_cluster_discard() -> qcow2_subcluster_discard() to
reflect the change.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
---
block/qcow2-cluster.c | 106 +
block/qcow2-snapshot.c | 6 +--
block
This would ease debugging of write zeroes and discard operations.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Reviewed-by: Alberto Garcia
---
block/file-posix.c | 1 +
block/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/block/file-posix.c b/block/file
eally test subcluster
based discards.
Signed-off-by: Andrey Drobyshev
---
block/qcow2.c | 21 -
block/qcow2.h | 2 ++
tests/qemu-iotests/271 | 10 ++
3 files changed, 28 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index
atter whether we unmap or zeroize the cluster. For that OR'ing with
the old entry is enough.
This patch doesn't change the logic and is pure refactoring.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
Reviewed-by: Alberto Garcia
---
block/qcow2
ation.
Also introduce struct SubClusterRangeInfo, which would contain all the
needed params.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
---
block/qcow2-cluster.c | 140 --
1 file changed, 108 insertions(+), 32 deletions(-)
diff --git a/
quot; will
lead to actual unmap.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Alexander Ivanov
---
block/qcow2-cluster.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 3c134a7e80..53e04eff93
On 9/13/24 7:39 PM, Andrey Drobyshev wrote:
> Introduce Qcow2 runtime boolean option "discard-subclusters". This
> option influences discard alignment value (either cluster_size or
> subcluster_size) and essentially makes subcluster-based discard optional.
> We disable it
On 5/24/23 11:30, Denis V. Lunev wrote:
> On 5/23/23 18:24, Andrey Drobyshev wrote:
>> In case when we're rebasing within one backing chain, and when target
>> image
>> is larger than old backing file, bdrv_is_allocated_above() ends up
>> setting
>> *pnum
On 5/25/23 21:02, Andrey Drobyshev wrote:
> v1 -> v2:
>
> * Avoid breaking the loop just yet, as the offsets beyond the old
> backing size need to be explicitly zeroed;
> * Amend the commit message accordingly;
> * Alter the added test case to take the las
On 6/2/23 00:18, Michael Tokarev wrote:
> 01.06.2023 22:28, Andrey Drobyshev via пишет:
>> In case when we're rebasing within one backing chain, and when target
>> image
>> is larger than old backing file, bdrv_is_allocated_above() ends up
>> setting
>> *pnum
On 6/21/23 20:46, Denis V. Lunev wrote:
> On 6/21/23 19:08, Denis V. Lunev wrote:
>> On 6/7/23 17:26, Andrey Drobyshev wrote:
>>> Functions qcow2_get_host_offset(), get_cluster_offset() explicitly
>>> report compressed cluster types when data is compressed. However, th
On 6/21/23 21:12, Denis V. Lunev wrote:
> On 6/7/23 17:26, Andrey Drobyshev wrote:
>> Right now "qemu-img map" reports compressed blocks as containing data
>> but having no host offset. This is not very informative. Instead,
>> let's add another boolean f
On 6/30/23 13:54, Denis V. Lunev wrote:
> On 6/1/23 21:28, Andrey Drobyshev wrote:
>> This series is adding [-c | --compress] option to "qemu-img rebase"
>> command, which might prove useful for saving some disk space when, for
>> instance, manipulating chains of
On 6/26/23 19:08, Andrey Drobyshev wrote:
> This series makes IO requests performed with copy-on-read to be aligned
> to subclusters rather than clusters. It also affects mirror job requests
> alignment.
>
> The initial reason for that change is the following crash discovered
On 7/10/23 22:47, Eric Blake wrote:
> On Mon, Jun 26, 2023 at 07:08:33PM +0300, Andrey Drobyshev via wrote:
>> When target image is using subclusters, and we align the request during
>> copy-on-read, it makes sense to align to subcluster_size rather than
>> cluster_size. Oth
Hello Hanna,
Sorry for the delay and thanks for your thorough and detailed review.
On 10/31/23 17:53, Hanna Czenczek wrote:
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> This helper simply obtains the l2 table parameters of the cluster which
>> contains the given subclusters ra
On 11/3/23 17:20, Hanna Czenczek wrote:
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> Move the definition from iotests/250 to common.rc. This is used to
>> detect real disk usage of sparse files. In particular, we want to use
>> it for checking subclusters-based discards
On 10/31/23 18:32, Hanna Czenczek wrote:
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> This commit makes the discard operation work on the subcluster level
>> rather than cluster level. It introduces discard_l2_subclusters()
>> function and makes use of it in qcow2 discard
On 11/3/23 17:59, Hanna Czenczek wrote:
> On 03.11.23 16:51, Hanna Czenczek wrote:
>> On 20.10.23 23:56, Andrey Drobyshev wrote:
>
> [...]
>
>>> @@ -528,6 +543,14 @@ for use_backing_file in yes no; do
>>> else
>>> _make_test_img -o ex
On 11/3/23 17:51, Hanna Czenczek wrote:
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> Add _verify_du_delta() checker which is used to check that real disk
>> usage delta meets the expectations. For now we use it for checking that
>> subcluster-based discard/unmap operation
On 11/3/23 17:19, Hanna Czenczek wrote:
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> When zeroizing subclusters within single cluster, detect usage of the
>> BDRV_REQ_MAY_UNMAP flag and fall through to the subcluster-based discard
>> operation, much like it's d
On 10/31/23 18:33, Hanna Czenczek wrote:
> (Sorry, opened another reply window, forgot I already had one open...)
>
> On 20.10.23 23:56, Andrey Drobyshev wrote:
>> This commit makes the discard operation work on the subcluster level
>> rather than cluster
default) (deprecated)".
To fix potential issues here, let's relax that requirement and detect
the mere presence of " (default)" line instead.
Signed-off-by: Andrey Drobyshev
---
tests/qemu-iotests/testenv.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
#x27;s just allocate the buffer using qemu_blockalign0() instead.
Signed-off-by: Andrey Drobyshev
---
block/file-posix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index b862406c71..cee8de510b 100644
--- a/block/file-posix.c
+++
ment
* 308, file-io-error: use fuse exports. Though fuse does have
'direct-io' mode (see https://docs.kernel.org/filesystems/fuse-io.html)
we aren't using it yet, thus getting errors like:
qemu-io: can't open device /path/to/t.qcow2.fuse: Could not open
'/path/to
On 12/11/23 13:27, Denis V. Lunev wrote:
> On 12/11/23 11:55, Andrey Drobyshev wrote:
>> In case we're truncating an image opened with O_DIRECT, we might get
>> -EINVAL on write with unaligned buffer. In particular, when running
>> iotests/298 with '-nocache&#x
On 12/11/23 15:32, Andrey Drobyshev wrote:
> There're tests whose logic implies running without O_DIRECT set,
> otherwise they fail when running iotests in '-nocache' mode. For these
> tests let's add _require_no_o_direct() helper which can be put in the
> preabml
ff-by: Andrey Drobyshev
---
tests/qemu-iotests/277 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/277 b/tests/qemu-iotests/277
index 24833e7eb6..4224202ac2 100755
--- a/tests/qemu-iotests/277
+++ b/tests/qemu-iotests/277
@@ -27,7 +27,8 @@ from iotests import file
ff-by: Andrey Drobyshev
---
tests/qemu-iotests/264 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264
index c532ccd809..c6ba2754e2 100755
--- a/tests/qemu-iotests/264
+++ b/tests/qemu-iotests/264
@@ -25,7 +25,8 @@ import os
import io
On 1/24/24 19:59, Denis V. Lunev wrote:
> On 1/24/24 18:43, Eric Blake wrote:
>> On Wed, Jan 24, 2024 at 06:22:57PM +0200, Andrey Drobyshev wrote:
>>> If socket path is too long (longer than 108 bytes), socket can't be
>>> opened. This might lead to failure w
On 1/11/24 14:53, Andrey Drobyshev wrote:
> On 12/11/23 15:32, Andrey Drobyshev wrote:
>> There're tests whose logic implies running without O_DIRECT set,
>> otherwise they fail when running iotests in '-nocache' mode. For these
>> tests let's add _require
On 1/11/24 14:53, Andrey Drobyshev wrote:
> On 12/11/23 13:27, Denis V. Lunev wrote:
>> On 12/11/23 11:55, Andrey Drobyshev wrote:
>>> In case we're truncating an image opened with O_DIRECT, we might get
>>> -EINVAL on write with unaligned buffer. In particular, w
On 1/26/24 12:24, Kevin Wolf wrote:
> Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben:
>> There're tests whose logic implies running without O_DIRECT set,
>> otherwise they fail when running iotests in '-nocache' mode. For these
>> tests let's ad
On 1/25/24 18:46, Vladimir Sementsov-Ogievskiy wrote:
> On 11.12.23 13:55, Andrey Drobyshev wrote:
>> In case we're truncating an image opened with O_DIRECT, we might get
>> -EINVAL on write with unaligned buffer. In particular, when running
>> iotests/298 with '
On 10/27/23 14:10, Jean-Louis Dupond wrote:
> [...]
>
> I've checked all the code paths, and as far as I see it nowhere breaks
> the discard_no_unref option.
> It's important that we don't introduce new code paths that can make
> holes in the qcow2 image when this option is enabled :)
>
> If you
Hi everyone,
When making an external snapshot, we end up in a situation when 2 block
graph nodes related to the same image file (format and storage nodes)
have different RO flags set on them.
E.g.
# ls -la /proc/PID/fd
lrwx-- 1 root qemu 64 Apr 24 20:14 12 -> /path/to/harddisk.hdd
# virsh q
On 4/24/24 21:00, Andrey Drobyshev wrote:
> Hi everyone,
>
> When making an external snapshot, we end up in a situation when 2 block
> graph nodes related to the same image file (format and storage nodes)
> have different RO flags set on them.
>
> E.g.
>
> # ls -la
When zeroizing the last non-zero subclusters within single cluster, it
makes sense to go zeroize the entire cluster and go down zero_in_l2_slice()
path right away. That way we'd also update the corresponding refcount
table.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Hanna Czenczek
---
) and that with the option enabled cluster is still marked as
allocated in "qemu-img map" output. We also check that the option
doesn't work with qcow2 v2 images.
Signed-off-by: Andrey Drobyshev
---
tests/qemu-iotests/290 | 34 ++
tests/
atter whether we unmap or zeroize the cluster. For that OR'ing with
the old entry is enough.
This patch doesn't change the logic and is pure refactoring.
Signed-off-by: Andrey Drobyshev
---
block/qcow2-cluster.c | 34 +++---
1 file changed, 15 insertions(+
with subclusters enabled.
Also rename qcow2_cluster_discard() -> qcow2_subcluster_discard() to
reflect the change.
Signed-off-by: Andrey Drobyshev
---
block/qcow2-cluster.c | 106 +
block/qcow2-snapshot.c | 6 +--
block/qcow2.c | 25 +
We are going to need it for discarding separate subclusters. The
function itself doesn't do anything with the refcount tables, it simply
adds a discard request to the queue, so rename it to qcow2_queue_discard().
Signed-off-by: Andrey Drobyshev
Reviewed-by: Hanna Czenczek
---
block/
make all discard/unmap operations enable trace point 'file_do_fallocate'
so that actual fallocate() calls are visible.
Signed-off-by: Andrey Drobyshev
---
tests/qemu-iotests/271 | 70 +-
tests/qemu-iotests/271.out | 69 ++
ation.
Also introduce struct SubClusterRangeInfo, which would contain all the
needed params.
Signed-off-by: Andrey Drobyshev
---
block/qcow2-cluster.c | 140 --
1 file changed, 108 insertions(+), 32 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/
Move the definition from iotests/250 to common.rc. This is used to
detect real disk usage of sparse files. In particular, we want to use
it for checking subclusters-based discards.
Signed-off-by: Andrey Drobyshev
---
tests/qemu-iotests/250 | 5 -
tests/qemu-iotests/common.rc | 6
quot; will
lead to actual unmap.
Signed-off-by: Andrey Drobyshev
---
block/qcow2-cluster.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 3c134a7e80..53e04eff93 100644
--- a/block/qcow2-cl
check
for the presence of external data files for us and redirect request to
underlying data_file. Here we want to do the same but avoid refcount updates,
thus we perform the same checks.
Suggested-by: Hanna Czenczek
Signed-off-by: Andrey Drobyshev
---
block/qcow2-cluster.c
This would ease debugging of write zeroes and discard operations.
Signed-off-by: Andrey Drobyshev
---
block/file-posix.c | 1 +
block/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 35684f7e21..45134f0eef 100644
--- a/block/file
v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
Andrey Drobyshev (11):
qcow2: make function update_refcount_discard() global
qcow2: simplify L2 entries accounting for discard-no-unref
qcow2: put discard requests in the common queue when discard-no-unref
On 6/30/23 13:54, Denis V. Lunev wrote:
> On 6/1/23 21:28, Andrey Drobyshev wrote:
>> This series is adding [-c | --compress] option to "qemu-img rebase"
>> command, which might prove useful for saving some disk space when, for
>> instance, manipulating chains of
On 7/11/23 20:25, Andrey Drobyshev wrote:
> v1 --> v2:
> * Fixed line indentation;
> * Fixed wording in a comment;
> * Added R-b.
>
> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00606.html
>
> Andrey Drobyshev (3):
> block: add subcluster
On 7/6/23 19:30, Andrey Drobyshev wrote:
> v1 --> v2:
> * Add vmdk format to the 1st commit. Tweak commit message accordingly;
> * Make "compressed" field in MapEntry optional.
>
> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00184.html
>
&g
On 7/24/23 16:11, Andrey Drobyshev wrote:
> On 6/30/23 13:54, Denis V. Lunev wrote:
>> On 6/1/23 21:28, Andrey Drobyshev wrote:
>>> This series is adding [-c | --compress] option to "qemu-img rebase"
>>> command, which might prove useful for saving s
On 7/24/23 16:10, Andrey Drobyshev wrote:
> On 7/6/23 19:30, Andrey Drobyshev wrote:
>> v1 --> v2:
>> * Add vmdk format to the 1st commit. Tweak commit message accordingly;
>> * Make "compressed" field in MapEntry optional.
>>
>> v1: https://li
On 7/24/23 16:11, Andrey Drobyshev wrote:
> On 7/11/23 20:25, Andrey Drobyshev wrote:
>> v1 --> v2:
>> * Fixed line indentation;
>> * Fixed wording in a comment;
>> * Added R-b.
>>
>> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-
On 7/31/23 17:51, Andrey Drobyshev wrote:
> On 7/24/23 16:11, Andrey Drobyshev wrote:
>> On 7/11/23 20:25, Andrey Drobyshev wrote:
>>> v1 --> v2:
>>> * Fixed line indentation;
>>> * Fixed wording in a comment;
>>> * Added R-b.
>>>
>>
On 7/31/23 17:45, Andrey Drobyshev wrote:
> On 7/24/23 16:10, Andrey Drobyshev wrote:
>> On 7/6/23 19:30, Andrey Drobyshev wrote:
>>> v1 --> v2:
>>> * Add vmdk format to the 1st commit. Tweak commit message accordingly;
>>> * Make "compressed&qu
On 7/31/23 17:43, Andrey Drobyshev wrote:
> On 7/24/23 16:11, Andrey Drobyshev wrote:
>> On 6/30/23 13:54, Denis V. Lunev wrote:
>>> On 6/1/23 21:28, Andrey Drobyshev wrote:
>>>> This series is adding [-c | --compress] option to "qemu-img rebase"
>>&
On 8/16/23 12:22, Andrey Drobyshev wrote:
> On 7/31/23 17:51, Andrey Drobyshev wrote:
>> On 7/24/23 16:11, Andrey Drobyshev wrote:
>>> On 7/11/23 20:25, Andrey Drobyshev wrote:
>>>> v1 --> v2:
>>>> * Fixed line indentation;
>>>> * Fi
On 8/16/23 12:22, Andrey Drobyshev wrote:
> On 7/31/23 17:43, Andrey Drobyshev wrote:
>> On 7/24/23 16:11, Andrey Drobyshev wrote:
>>> On 6/30/23 13:54, Denis V. Lunev wrote:
>>>> On 6/1/23 21:28, Andrey Drobyshev wrote:
>>>>> This series is adding
On 8/16/23 12:22, Andrey Drobyshev wrote:
> On 7/31/23 17:45, Andrey Drobyshev wrote:
>> On 7/24/23 16:10, Andrey Drobyshev wrote:
>>> On 7/6/23 19:30, Andrey Drobyshev wrote:
>>>> v1 --> v2:
>>>> * Add vmdk format to the 1st commit. Tweak commit m
On 8/22/23 22:58, John Snow wrote:
> On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev
> wrote:
>>
>> On 8/16/23 12:22, Andrey Drobyshev wrote:
>>> On 7/31/23 17:51, Andrey Drobyshev wrote:
>>>> On 7/24/23 16:11, Andrey Drobyshev wrote:
>>>>&g
On 8/24/23 17:32, Stefan Hajnoczi wrote:
> On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote:
>> On 8/22/23 22:58, John Snow wrote:
>>> On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev
>>> wrote:
>>>>
>>>> On 8/16/23 12:22, And
On 8/25/23 17:14, Hanna Czenczek wrote:
> On 06.07.23 18:30, Andrey Drobyshev wrote:
>> Right now "qemu-img map" reports compressed blocks as containing data
>> but having no host offset. This is not very informative. Instead,
>> let's add another boolean f
On 8/25/23 17:29, Hanna Czenczek wrote:
> On 01.06.23 21:28, Andrey Drobyshev via wrote:
>> Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for
>> the data read from the old and new backing files are aligned using
>> BlockDriverState (or BlockBac
On 8/25/23 18:00, Hanna Czenczek wrote:
> On 01.06.23 21:28, Andrey Drobyshev via wrote:
>> When rebasing an image from one backing file to another, we need to
>> compare data from old and new backings. If the diff between that data
>> happens to be unaligned to the target c
On 9/6/23 12:43, Denis V. Lunev wrote:
> On 7/11/23 19:25, Andrey Drobyshev wrote:
>> Add testcase which checks that allocations during copy-on-read are
>> performed on the subcluster basis when subclusters are enabled in target
>> image.
>>
>> This testcase also t
On 9/15/23 00:17, Eric Blake wrote:
> On Fri, Sep 08, 2023 at 12:02:26AM +0300, Andrey Drobyshev wrote:
>> Right now "qemu-img map" reports compressed blocks as containing data
>> but having no host offset. This is not very informative. Instead,
>> let&#x
On 9/15/23 21:39, Eric Blake wrote:
> On Fri, Sep 15, 2023 at 07:20:11PM +0300, Andrey Drobyshev wrote:
>> Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for
>> the data read from the old and new backing files are aligned using
>> BlockDriver
On 9/16/23 00:52, Eric Blake wrote:
> On Fri, Sep 15, 2023 at 07:20:13PM +0300, Andrey Drobyshev wrote:
>> When rebasing an image from one backing file to another, we need to
>> compare data from old and new backings. If the diff between that data
>> happens to be unaligned
On 9/19/23 11:18, Hanna Czenczek wrote:
> On 15.09.23 18:20, Andrey Drobyshev wrote:
>> Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for
>> the data read from the old and new backing files are aligned using
>> BlockDriverState (or BlockBac
1 - 100 of 181 matches
Mail list logo
