Re: [PATCH 00/10] Enable QEMU to run on browsers

2025-04-09 Thread Stefan Hajnoczi
On Mon, Apr 07, 2025 at 11:45:51PM +0900, Kohei Tokunaga wrote: > This patch series enables QEMU's system emulator to run in a browser using > Emscripten. > It includes implementations and workarounds to address browser environment > limitations, as shown in the following. I think it would be grea

Re: [PATCH] hw/nvme: fix attachment of private namespaces

2025-04-09 Thread Klaus Jensen
On Apr 8 20:56, Philippe Mathieu-Daudé wrote: > On 8/4/25 12:20, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Fix regression when attaching private namespaces that gets attached to > > the wrong controller. > > > > Keep track of the original controller "owner" of private namespaces, and >

Re: [PATCH 0/1] hw/nvme: create parameter to enable/disable cmic on subsystem

2025-04-09 Thread alan . adamson
On 4/8/25 11:47 PM, Klaus Jensen wrote: On Apr 8 15:56, Alan Adamson wrote: While testing Linux atomic writes with qemu-nvme v10.0.0-rc1, Linux was incorrectly displaying atomic_write_max_bytes # cat /sys/block/nvme0n1/queue/atomic_write_max_bytes 0 # nvme id-ctrl /dev/nvme0n1 | grep awupf aw

[PATCH 1/2] file-posix: probe discard alignment on Linux block devices

2025-04-09 Thread Stefan Hajnoczi
Populate the pdiscard_alignment block limit so the block layer is able align discard requests correctly. Signed-off-by: Stefan Hajnoczi --- block/file-posix.c | 56 +- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/block/file-posix.c b/b

Re: [PATCH 07/10] tcg: Add a TCG backend for WebAssembly

2025-04-09 Thread Kohei Tokunaga
> Eh TBH this is too much to review as a single patch. > > Do you already have an idea how different the wasm64 implementation can be? Sorry for the large patch. I'll split it into smaller patches in the next version of the series. With wasm64, instructions that manipulate pointers (e.g., ld/st,

[PATCH 0/2] block: discard alignment fixes

2025-04-09 Thread Stefan Hajnoczi
Two discard alignment issues were identified in https://issues.redhat.com/browse/RHEL-86032: 1. pdiscard_alignment is not populated for host_device in file-posix.c. 2. Misaligned head/tail discard requests are not skipped when file-posix.c returns -EINVAL. This causes an undesired pause when gue

[PATCH 2/2] block/io: skip head/tail requests on EINVAL

2025-04-09 Thread Stefan Hajnoczi
When guests send misaligned discard requests, the block layer breaks them up into a misaligned head, an aligned main body, and a misaligned tail. The file-posix block driver on Linux returns -EINVAL on misaligned discard requests. This causes bdrv_co_pdiscard() to fail and guests configured with w

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-09 Thread Kohei Tokunaga
Hi Philippe, thank you for the comments. > > +static gpointer g_qtest_set_command_cb( > > +bool (*pc_cb)(CharBackend *chr, gchar **words)) > > +{ > > Why not use a GThreadFunc prototype, casting the argument? Sure, I'll fix this. > OK for the rest, but it might help to merge by corresponding

Re: [PATCH 05/10] meson: Add wasm build in build scripts

2025-04-09 Thread Paolo Bonzini
On 4/9/25 12:55, Philippe Mathieu-Daudé wrote: Cc'ing Pierrick On 7/4/25 16:45, Kohei Tokunaga wrote: has_int128_type is set to false on emscripten as of now to avoid errors by libffi. What is the error here? How hard would it be to test for it? And tests aren't integrated with Wasm execut

Re: [PULL 0/4] Block layer patches

2025-04-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v3 1/2] qapi: synchronize jobs and block-jobs documentation

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
Actualize documentation and synchronize it for commands which actually call the same functions internally. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 61 ++-- qapi/job.json| 30 -- 2 files changed, 64

[PATCH v3 2/2] qapi/block-core: deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() checks whether the found job is a block-job. Th

[PATCH v3 0/2] deprecate some block-job- APIs

2025-04-09 Thread Vladimir Sementsov-Ogievskiy
This is for 10.1, of course. v3: fix wording, typos v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsement...@yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and blo

Re: [PATCH 01/10] various: Fix type conflict of GLib function pointers

2025-04-09 Thread Philippe Mathieu-Daudé
Hi Kohei, On 7/4/25 16:45, Kohei Tokunaga wrote: On emscripten, function pointer casts can cause function call failure. This commit fixes the function definition to match to the type of the function call. - qtest_set_command_cb passed to g_once should match to GThreadFunc - object_class_cmp and

Re: [PATCH 05/10] meson: Add wasm build in build scripts

2025-04-09 Thread Philippe Mathieu-Daudé
Cc'ing Pierrick On 7/4/25 16:45, Kohei Tokunaga wrote: has_int128_type is set to false on emscripten as of now to avoid errors by libffi. And tests aren't integrated with Wasm execution environment as of now so this commit disables tests. Signed-off-by: Kohei Tokunaga --- configs/meson/emscr

Re: [PATCH v6] block/file-posix.c: Use pwritev2() with RWF_DSYNC for FUA

2025-04-09 Thread Kevin Wolf
Am 07.04.2025 um 17:47 hat Pinku Deb Nath geschrieben: > Full Unit Access (FUA) is an optimization where a disk write with the > flag set will be persisted to disk immediately instead of potentially > remaining in the disk's write cache. > > This commit address the todo task > for using pwritev2()