Re: [PATCH] Skip resizing image to the same size

2025-01-21 Thread Fahrzin Hemmati
I'm running packer, and with a qcow2 source image sized at 75000MB (but only 5GB on disk) when it runs "qemu-img resize ... 75000MB" it takes about 10 seconds on my system. I guess it's not reading the whole disk since me nvme isn't that fast, but it's a non-trivial amount of work. It also runs a q

Re: [PATCH v3 2/3] hw/sd/sdhci: Introduce a new Write Protected pin inverted property

2025-01-21 Thread Cédric Le Goater
Jamin, +Bernhard On 11/14/24 10:48, Jamin Lin wrote: The Write Protect pin of SDHCI model is default active low to match the SDHCI spec. So, write enable the bit 19 should be 1 and write protected the bit 19 should be 0 at the Present State Register (0x24). However, some boards are design Write

Re: [PATCH] Skip resizing image to the same size

2025-01-21 Thread Kevin Wolf
Am 20.01.2025 um 23:21 hat Fahrzin Hemmati geschrieben: > Happy to wait until your patchset is in. > > Yes, this is a no-op, but it reads the entire disk image to perform that > no-op, so this is merely a time-saving improvement, not a behavior change. Can you give more context on what exactly yo

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Pierrick Bouvier
On 1/18/25 09:10, Michael Tokarev wrote: 05.01.2025 16:59, Volker Rümelin wrote: In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this

Re: [PATCH 0/9] hw/nvme: refactor/cleanup

2025-01-21 Thread Jesper Wendel Devantier
On 12/16/24 13:53, Klaus Jensen wrote: Apart from some random small fixes here and there, the major thing here is cleaning up how we handle command sets. Prior to this series, the controller would not correctly validate namespace command sets against CC.CSS. This is fixed here. The most clean wa

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Michael Tokarev
22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this one (which is correct, and works), and refactor this in a second time, so the current

RE: [PATCH v3 2/3] hw/sd/sdhci: Introduce a new Write Protected pin inverted property

2025-01-21 Thread Jamin Lin
Hi Cedric, > From: Cédric Le Goater > Sent: Tuesday, January 21, 2025 6:39 PM > To: Jamin Lin ; Peter Maydell > ; Steven Lee ; Troy > Lee ; Andrew Jeffery ; > Joel Stanley ; Philippe Mathieu-Daudé ; > Bin Meng ; open list:ASPEED BMCs > ; open list:All patches CC here > ; open list:SD (Secure Car

Re: [PATCH] vvfat: fix out of bounds array write

2025-01-21 Thread Pierrick Bouvier
On 1/21/25 19:47, Michael Tokarev wrote: 22.01.2025 02:14, Pierrick Bouvier wrote: .. I agree the existing code (and this patch) is pretty cryptic for anyone not familiar with FAT format. However, I think it could be a good thing to first merge this one (which is correct, and works), and refac