Re: [PATCH v18 01/14] hw/pci: Rename has_power to enabled

2025-01-05 Thread Philippe Mathieu-Daudé
On 4/1/25 08:52, Akihiko Odaki wrote: The renamed state will not only represent powering state of PFs, but also represent SR-IOV VF enablement in the future. Signed-off-by: Akihiko Odaki --- include/hw/pci/pci.h| 7 ++- include/hw/pci/pci_device.h | 2 +- hw/pci/pci.c

Re: [PATCH v18 13/14] hw/pci: Use -1 as the default value for rombar

2025-01-05 Thread Philippe Mathieu-Daudé
On 4/1/25 08:52, Akihiko Odaki wrote: vfio_pci_size_rom() distinguishes whether rombar is explicitly set to 1 by checking dev->opts, bypassing the QOM property infrastructure. Use -1 as the default value for rombar to tell if the user explicitly set it to 1. The property is also converted from u

[PATCH v6 1/2] memory: Update inline documentation

2025-01-05 Thread Akihiko Odaki
Do not refer to "memory region's reference count" - Now MemoryRegions do have their own reference counts, but they will not be used when their owners are not themselves. However, the documentation of memory_region_ref() says it adds "1 to a memory re

[PATCH v6 0/2] Fix check-qtest-ppc64 sanitizer errors

2025-01-05 Thread Akihiko Odaki
I saw various sanitizer errors when running check-qtest-ppc64. While I could just turn off sanitizers, I decided to tackle them this time. Unfortunately, GLib versions older than 2.81.0 do not free test data in some cases so some sanitizer errors remain. All sanitizer errors will be gone with this

[PATCH v6 2/2] memory: Do not create circular reference with subregion

2025-01-05 Thread Akihiko Odaki
memory_region_update_container_subregions() used to call memory_region_ref(), which creates a reference to the owner of the subregion, on behalf of the owner of the container. This results in a circular reference if the subregion and container have the same owner. memory_region_ref() creates a ref

Re: [PATCH v5 1/2] memory: Update inline documentation

2025-01-05 Thread Akihiko Odaki
On 2025/01/04 21:51, BALATON Zoltan wrote: On Sat, 4 Jan 2025, Akihiko Odaki wrote: Do not refer to "memory region's reference count" - Now MemoryRegions do have their own reference counts, but they will not be used when their owners are not thems

[PATCH] vvfat: fix out of bounds array write

2025-01-05 Thread Volker Rümelin
In function create_long_filname(), the array name[8 + 3] in struct direntry_t is used as if it were defined as name[32]. This is intentional and works. It's nevertheless an out of bounds array access. To avoid this problem, this patch adds a struct lfn_direntry_t with multiple name arrays. A direct