Re: [PATCH 0/2] support block encryption/decryption in parallel

2024-12-13 Thread Guoyi Tu
Hi Kevin and Hanna, could you share your thoughts on this patch? I’d greatly appreciate your feedback -- Guoyi On 2024/11/28 18:51, t...@chinatelecom.cn wrote: From: Guoyi Tu Currently, disk I/O encryption and decryption operations are performed sequentially in the main thread or IOthread.

[PATCH 43/71] hw/nvme: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 2 +- hw/nvme/subsys.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index ec75419566..33a3062466 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8927,7 +

[PATCH 55/71] hw/scsi: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/scsi/megasas.c | 6 +++--- hw/scsi/mptsas.c | 2 +- hw/scsi/scsi-bus.c| 2 +- hw/scsi/scsi-disk.c | 6 +++--- hw/scsi/scsi-generic.c| 2 +- hw/scsi/spapr_vscsi.c | 2 +- hw/scsi/vhost-scsi.c | 2 +- hw/scsi/vhost-

[PATCH 19/71] hw/block: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/block/fdc-isa.c| 2 +- hw/block/fdc-sysbus.c | 4 ++-- hw/block/fdc.c| 2 +- hw/block/m25p80.c | 2 +- hw/block/nand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Paolo Bonzini
Il ven 13 dic 2024, 17:06 Richard W.M. Jones ha scritto: > On Fri, Dec 13, 2024 at 05:03:55PM +0100, Paolo Bonzini wrote: > > On 12/13/24 16:51, Richard W.M. Jones wrote: > > >The libnfs asynch API has changed type signature in this new version. > > >This change breaks qemu and it wasn't immediat

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Richard W.M. Jones
On Fri, Dec 13, 2024 at 07:37:10PM +0100, Paolo Bonzini wrote: > Yeah, and I don't think it should be merged, unless libnfs support is dropped > from the QEMU build in rawhide. Sure if there's no easy fix on the horizon, we can remove libnfs support temporarily. The upgrade path won't be smooth b

[PATCH 56/71] hw/sd: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sd/allwinner-sdhost.c | 2 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/sd.c | 6 +++--- hw/sd/sdhci-pci.c| 2 +- hw/sd/sdhci.c| 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/sd/allwinner-sdhost.c b/h

[PATCH 30/71] hw/ide: Constify all Property

2024-12-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ide/ahci.c| 2 +- hw/ide/cf.c | 2 +- hw/ide/cmd646.c | 2 +- hw/ide/ide-dev.c | 6 +++--- hw/ide/isa.c | 2 +- hw/ide/macio.c | 2 +- hw/ide/mmio.c| 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw

[PATCH 18/71] hw/block/xen-block: Unexport PropertyInfo

2024-12-13 Thread Richard Henderson
xen_block_prop_vdev is not used outside the file. Signed-off-by: Richard Henderson --- hw/block/xen-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index aed1d5c330..72cfd6893a 100644 --- a/hw/block/xen-block.c +++ b/hw/bloc

Re: [PATCH v14 00/15] macOS PV Graphics and new vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
Sigh… apologies for re-sending v13 together with v14 here. Please ignore v13 of course. git send-email is not my friend… On Fri, 13 Dec 2024 at 16:24, Phil Dennis-Jordan wrote: > > This patch series has been through months of review and > refinement. It now has end-to-end Reviewed-by: tags and

Re: [PATCH v4 1/2] hw/ide/ahci: Decouple from PCI

2024-12-13 Thread Philippe Mathieu-Daudé
On 12/12/24 12:09, Bernhard Beschow wrote: In some adhoc profiling booting Linux VMs, it's observed that ahci_irq_lower() can be a hot path (1+ triggers until login prompt appears). Even though the parent device never changes, this method re-determines whether the parent device is a PCI devic

Re: [PATCH v4 0/2] AHCI cleanup

2024-12-13 Thread Philippe Mathieu-Daudé
On 12/12/24 12:09, Bernhard Beschow wrote: Bernhard Beschow (2): hw/ide/ahci: Decouple from PCI hw/ide/ahci: Extract TYPE_SYSBUS_AHCI into dedicated file Reviewed-by: Philippe Mathieu-Daudé and queued, thanks!

[PATCH v14 13/15] hw/vmapple/virtio-blk: Add support for apple virtio-blk

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Apple has its own virtio-blk PCI device ID where it deviates from the official virtio-pci spec slightly: It puts a new "apple type" field at a static offset in config space and introduces a new barrier command. This patch first creates a mechanism for virtio-blk downstream c

[PATCH v13 14/15] hw/block/virtio-blk: Replaces request free function with g_free

2024-12-13 Thread Phil Dennis-Jordan
The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki --- hw/block/virtio-blk.c | 43 ++

[PATCH v13 00/15] macOS PV Graphics and new vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
This patch series has been through months of review and refinement. It now has end-to-end Reviewed-by: tags and all code patches but one have Tested-by: tags. No significant issues have been found via review for some weeks. The patch set creates two new subsystems: hw/display/apple-gfx hw/vmapple

[PATCH v13 07/15] hw/misc/pvpanic: Add MMIO interface

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf In addition to the ISA and PCI variants of pvpanic, let's add an MMIO platform device that we can use in embedded arm environments. Signed-off-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Phil Dennis-Jordan Revie

[PATCH v13 06/15] hw: Add vmapple subdir

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Ak

[PATCH v13 08/15] hvf: arm: Ignore writes to CNTP_CTL_EL0

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf MacOS unconditionally disables interrupts of the physical timer on boot and then continues to use the virtual one. We don't really want to support a full physical timer emulation, so let's just ignore those writes. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jo

[PATCH v13 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Apple defines a new "vmapple" machine type as part of its proprietary macOS Virtualization.Framework vmm. This machine type is similar to the virt one, but with subtle differences in base devices, a few special vmapple device additions and a vastly different boot chain. This

[PATCH v13 13/15] hw/vmapple/virtio-blk: Add support for apple virtio-blk

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Apple has its own virtio-blk PCI device ID where it deviates from the official virtio-pci spec slightly: It puts a new "apple type" field at a static offset in config space and introduces a new barrier command. This patch first creates a mechanism for virtio-blk downstream c

[PATCH v13 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-12-13 Thread Phil Dennis-Jordan
MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only provides and receives c

[PATCH v13 10/15] hw/vmapple/aes: Introduce aes engine

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko

[PATCH v13 12/15] hw/vmapple/cfg: Introduce vmapple cfg region

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Instead of device tree or other more standardized means, VMApple passes platform configuration to the first stage boot loader in a binary encoded format that resides at a dedicated RAM region in physical address space. This patch models this configuration space as a qdev dev

[PATCH v14 12/15] hw/vmapple/cfg: Introduce vmapple cfg region

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Instead of device tree or other more standardized means, VMApple passes platform configuration to the first stage boot loader in a binary encoded format that resides at a dedicated RAM region in physical address space. This patch models this configuration space as a qdev dev

[PATCH v14 00/15] macOS PV Graphics and new vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
This patch series has been through months of review and refinement. It now has end-to-end Reviewed-by: tags and all code patches but one have Tested-by: tags. No significant issues have been found via review for some weeks. The patch set creates two new subsystems: hw/display/apple-gfx hw/vmapple

[PATCH v14 14/15] hw/block/virtio-blk: Replaces request free function with g_free

2024-12-13 Thread Phil Dennis-Jordan
The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki --- hw/block/virtio-blk.c | 43 ++

libnfs 6.0.0 breaks qemu compilation (was: Re: libnfs soname bump)

2024-12-13 Thread Richard W.M. Jones
The libnfs asynch API has changed type signature in this new version. This change breaks qemu and it wasn't immediately obvious to me how to fix it. In particular the new API requires a buffer to be passed, but it's unclear what that would be. Old signature: EXTERN int nfs_pread_async(struct nfs

[PATCH v14 10/15] hw/vmapple/aes: Introduce aes engine

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko

[PATCH v14 05/15] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

2024-12-13 Thread Phil Dennis-Jordan
I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Roman Bolshakov --- MAINTAINE

[PATCH v14 06/15] hw: Add vmapple subdir

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki Tested-by: Ak

[PATCH v14 08/15] hvf: arm: Ignore writes to CNTP_CTL_EL0

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf MacOS unconditionally disables interrupts of the physical timer on boot and then continues to use the virtual one. We don't really want to support a full physical timer emulation, so let's just ignore those writes. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jo

[PATCH v14 11/15] hw/vmapple/bdif: Introduce vmapple backdoor interface

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf The VMApple machine exposes AUX and ROOT block devices (as well as USB OTG emulation) via virtio-pci as well as a special, simple backdoor platform device. This patch implements this backdoor platform device to the best of my understanding. I left out any USB OTG parts; they

[PATCH v14 04/15] hw/display/apple-gfx: Adds configurable mode list

2024-12-13 Thread Phil Dennis-Jordan
This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for example: -device '{"driver":"apple-gfx-pci", "di

[PATCH v14 03/15] hw/display/apple-gfx: Adds PCI implementation

2024-12-13 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Ak

[PATCH v14 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Apple defines a new "vmapple" machine type as part of its proprietary macOS Virtualization.Framework vmm. This machine type is similar to the virt one, but with subtle differences in base devices, a few special vmapple device additions and a vastly different boot chain. This

[PATCH v13 04/15] hw/display/apple-gfx: Adds configurable mode list

2024-12-13 Thread Phil Dennis-Jordan
This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for example: -device '{"driver":"apple-gfx-pci", "di

[PATCH v14 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-12-13 Thread Phil Dennis-Jordan
MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only provides and receives c

[PATCH v13 09/15] gpex: Allow more than 4 legacy IRQs

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Paolo Bonzini
On 12/13/24 16:51, Richard W.M. Jones wrote: The libnfs asynch API has changed type signature in this new version. This change breaks qemu and it wasn't immediately obvious to me how to fix it. In particular the new API requires a buffer to be passed, but it's unclear what that would be. Old si

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Richard W.M. Jones
On Fri, Dec 13, 2024 at 05:03:55PM +0100, Paolo Bonzini wrote: > On 12/13/24 16:51, Richard W.M. Jones wrote: > >The libnfs asynch API has changed type signature in this new version. > >This change breaks qemu and it wasn't immediately obvious to me how to > >fix it. In particular the new API requ

Re: [PATCH 0/2] support block encryption/decryption in parallel

2024-12-13 Thread Daniel P . Berrangé
On Thu, Nov 28, 2024 at 06:51:20PM +0800, t...@chinatelecom.cn wrote: > From: Guoyi Tu > > Currently, disk I/O encryption and decryption operations are performed > sequentially > in the main thread or IOthread. When the number of I/O requests increases, > this becomes a performance bottleneck. >

[PATCH v14 07/15] hw/misc/pvpanic: Add MMIO interface

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf In addition to the ISA and PCI variants of pvpanic, let's add an MMIO platform device that we can use in embedded arm environments. Signed-off-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Phil Dennis-Jordan Revie

[PATCH v14 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-12-13 Thread Phil Dennis-Jordan
macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch, the main dispatch queue must be handling events on the main thread as well. So far, this has affected Qemu in both the Cocoa and SDL UIs, although in

[PATCH v14 09/15] gpex: Allow more than 4 legacy IRQs

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

[PATCH v13 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-12-13 Thread Phil Dennis-Jordan
macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch, the main dispatch queue must be handling events on the main thread as well. So far, this has affected Qemu in both the Cocoa and SDL UIs, although in

[PATCH v13 03/15] hw/display/apple-gfx: Adds PCI implementation

2024-12-13 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Ak

[PATCH v13 05/15] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

2024-12-13 Thread Phil Dennis-Jordan
I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Roman Bolshakov --- MAINTAINE

[PATCH v13 11/15] hw/vmapple/bdif: Introduce vmapple backdoor interface

2024-12-13 Thread Phil Dennis-Jordan
From: Alexander Graf The VMApple machine exposes AUX and ROOT block devices (as well as USB OTG emulation) via virtio-pci as well as a special, simple backdoor platform device. This patch implements this backdoor platform device to the best of my understanding. I left out any USB OTG parts; they

Re: [PATCH v4 1/2] hw/ide/ahci: Decouple from PCI

2024-12-13 Thread Bernhard Beschow
Am 13. Dezember 2024 14:41:46 UTC schrieb "Philippe Mathieu-Daudé" : >On 12/12/24 12:09, Bernhard Beschow wrote: >> In some adhoc profiling booting Linux VMs, it's observed that >> ahci_irq_lower() >> can be a hot path (1+ triggers until login prompt appears). Even though >> the >> parent