Re: [PATCH v2 2/6] docs/devel: add git-publish for patch submitting

2024-12-06 Thread Daniel P . Berrangé
On Thu, Dec 05, 2024 at 02:22:37PM -0800, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier > --- > docs/devel/submitting-a-patch.rst | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/docs/devel/submitting-a-patch.rst > b/docs/devel/submitting-a-patch.rst > i

Re: [PATCH v2 2/6] docs/devel: add git-publish for patch submitting

2024-12-06 Thread Peter Maydell
On Fri, 6 Dec 2024 at 11:32, Daniel P. Berrangé wrote: > > On Thu, Dec 05, 2024 at 02:22:37PM -0800, Pierrick Bouvier wrote: > > Signed-off-by: Pierrick Bouvier > > --- > > docs/devel/submitting-a-patch.rst | 19 +++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/docs/

Re: [PATCH v2 2/6] docs/devel: add git-publish for patch submitting

2024-12-06 Thread Daniel P . Berrangé
On Fri, Dec 06, 2024 at 11:43:11AM +, Peter Maydell wrote: > On Fri, 6 Dec 2024 at 11:32, Daniel P. Berrangé wrote: > > > > On Thu, Dec 05, 2024 at 02:22:37PM -0800, Pierrick Bouvier wrote: > > > Signed-off-by: Pierrick Bouvier > > > --- > > > docs/devel/submitting-a-patch.rst | 19 +

[PATCH v2 1/6] migration: Add helper to get target runstate

2024-12-06 Thread Peter Xu
In 99% cases, after QEMU migrates to dest host, it tries to detect the target VM runstate using global_state_get_runstate(). There's one outlier so far which is Xen that won't send global state. That's the major reason why global_state_received() check was always there together with global_state_g

[PATCH v2 6/6] migration/block: Rewrite disk activation

2024-12-06 Thread Peter Xu
This patch proposes a flag to maintain disk activation status globally. It mostly rewrites disk activation mgmt for QEMU, including COLO and QMP command xen_save_devices_state. Backgrounds === We have two problems on disk activations, one resolved, one not. Problem 1: disk activation re

[PATCH v2 0/6] migration/block: disk activation rewrite

2024-12-06 Thread Peter Xu
CI: https://gitlab.com/peterx/qemu/-/pipelines/1577280033 (note: it's a pipeline of two patchsets, to save CI credits and time) v1: https://lore.kernel.org/r/20241204005138.702289-1-pet...@redhat.com This is v2 of the series, removing RFC tag, because my goal is to have them (or some newer versi

[PATCH v2 4/6] migration/block: Apply late-block-active behavior to postcopy

2024-12-06 Thread Peter Xu
Postcopy never cared about late-block-active. However there's no mention in the capability that it doesn't apply to postcopy. Considering that we _assumed_ late activation is always good, do that too for postcopy unconditionally, just like precopy. After this patch, we should have unified the be

[PATCH v2 3/6] migration/block: Make late-block-active the default

2024-12-06 Thread Peter Xu
Migration capability 'late-block-active' controls when the block drives will be activated. If enabled, block drives will only be activated until VM starts, either src runstate was "live" (RUNNING, or SUSPENDED), or it'll be postponed until qmp_cont(). Let's do this unconditionally. There's no ha

[PATCH v2 5/6] migration/block: Fix possible race with block_inactive

2024-12-06 Thread Peter Xu
Src QEMU sets block_inactive=true very early before the invalidation takes place. It means if something wrong happened during setting the flag but before reaching qemu_savevm_state_complete_precopy_non_iterable() where it did the invalidation work, it'll make block_inactive flag inconsistent. For

[PATCH v2 2/6] qmp/cont: Only activate disks if migration completed

2024-12-06 Thread Peter Xu
As the comment says, the activation of disks is for the case where migration has completed, rather than when QEMU is still during migration (RUN_STATE_INMIGRATE). Move the code over to reflect what the comment is describing. Cc: Kevin Wolf Cc: Markus Armbruster Signed-off-by: Peter Xu --- mon

Re: [PATCH v2 2/6] docs/devel: add git-publish for patch submitting

2024-12-06 Thread Pierrick Bouvier
On 12/6/24 03:43, Peter Maydell wrote: On Fri, 6 Dec 2024 at 11:32, Daniel P. Berrangé wrote: On Thu, Dec 05, 2024 at 02:22:37PM -0800, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 19 +++ 1 file changed, 19 insertions(+)

[PATCH v3 0/6] Enhance documentation for new developers

2024-12-06 Thread Pierrick Bouvier
This series extends our documentation with new pages to help developers onboarding on QEMU. It focuses on providing a big picture of QEMU (to a modest extend). As such, it was written to be simple, short, easy to understand, and pointing to more details. It provides another way to dive into detail

[PATCH v3 6/6] docs: add a glossary

2024-12-06 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/control-flow-integrity.rst | 2 + docs/devel/multi-thread-tcg.rst | 2 + docs/glossary.rst | 280 ++ docs/index.rst| 1 + docs/system/arm/virt.rst | 2 + d

[PATCH v3 1/6] docs/devel: remove dead video link for sourcehut submit process

2024-12-06 Thread Pierrick Bouvier
Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 10b062eec26..03b2ac298aa 100644 --- a/docs/devel/sub

[PATCH v3 5/6] docs: add a codebase section

2024-12-06 Thread Pierrick Bouvier
Present the various parts of QEMU and organization of codebase. Signed-off-by: Pierrick Bouvier --- docs/about/emulation.rst | 2 + docs/devel/codebase.rst| 218 + docs/devel/decodetree.rst | 2 + docs/devel/ebpf_rss.rst

[PATCH v3 2/6] docs/devel: add git-publish for patch submitting

2024-12-06 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 03b2ac298aa..69df7682c5e 100644 --- a/docs/devel/submitting-a-patch.rst

[PATCH v3 3/6] docs/devel: add b4 for patch retrieval

2024-12-06 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 69df7682c5e..1ef7d137320 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/dev

[PATCH v3 4/6] docs/devel: add information on how to setup build environments

2024-12-06 Thread Pierrick Bouvier
MacOS and Linux are straightforward, but Windows needs a bit more details. Signed-off-by: Pierrick Bouvier --- docs/about/build-platforms.rst | 4 +- docs/devel/build-environment.rst | 118 +++ docs/devel/index-build.rst | 1 + 3 files changed, 122 inserti