Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability

2024-11-27 Thread Tomoyuki HIROSE
Hi, thank you for your comment. On 2024/11/27 20:23, Peter Maydell wrote: On Wed, 27 Nov 2024 at 04:34, Tomoyuki HIROSE wrote: I would be happy to receive your comments. ping. Hi; this one is on my to-review list (along, sadly, with 23 other series); I had a quick look a while back and it see

Re: [PATCH 4/5] migration: Activate block devices if VM is paused when migrating

2024-11-27 Thread Andrey Drobyshev
On 11/25/24 7:07 PM, Peter Xu wrote: > On Mon, Nov 25, 2024 at 11:46:11AM -0300, Fabiano Rosas wrote: >> Currently a VM that has been target of a migration using >> late-block-activate will crash at the end of a new migration (with it >> as source) when releasing ownership of the disks due to the V

Re: [PATCH 4/5] migration: Activate block devices if VM is paused when migrating

2024-11-27 Thread Andrey Drobyshev
On 11/25/24 4:46 PM, Fabiano Rosas wrote: > Currently a VM that has been target of a migration using > late-block-activate will crash at the end of a new migration (with it > as source) when releasing ownership of the disks due to the VM having > never taken ownership of the disks in the first plac

[PATCH v11 10/15] hw/vmapple/aes: Introduce aes engine

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko

[PATCH v11 07/15] hw/misc/pvpanic: Add MMIO interface

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf In addition to the ISA and PCI variants of pvpanic, let's add an MMIO platform device that we can use in embedded arm environments. Signed-off-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Phil Dennis-Jordan Revie

[PATCH v11 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-27 Thread Phil Dennis-Jordan
macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch, the main dispatch queue must be handling events on the main thread as well. So far, this has affected Qemu in both the Cocoa and SDL UIs, although in

[PATCH v11 11/15] hw/vmapple/bdif: Introduce vmapple backdoor interface

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf The VMApple machine exposes AUX and ROOT block devices (as well as USB OTG emulation) via virtio-pci as well as a special, simple backdoor platform device. This patch implements this backdoor platform device to the best of my understanding. I left out any USB OTG parts; they

[PATCH v11 12/15] hw/vmapple/cfg: Introduce vmapple cfg region

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf Instead of device tree or other more standardized means, VMApple passes platform configuration to the first stage boot loader in a binary encoded format that resides at a dedicated RAM region in physical address space. This patch models this configuration space as a qdev dev

[PATCH v11 13/15] hw/vmapple/virtio-blk: Add support for apple virtio-blk

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf Apple has its own virtio-blk PCI device ID where it deviates from the official virtio-pci spec slightly: It puts a new "apple type" field at a static offset in config space and introduces a new barrier command. This patch first creates a mechanism for virtio-blk downstream c

[PATCH v11 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-11-27 Thread Phil Dennis-Jordan
MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only provides and receives c

[PATCH v11 00/15] macOS PV Graphics and new vmapple machine type

2024-11-27 Thread Phil Dennis-Jordan
This patch set introduces a new ARM and macOS HVF specific machine type called "vmapple", as well as a family of display devices based on the ParavirtualizedGraphics.framework in macOS. One of the display adapter variants, apple-gfx-mmio, is required for the new machine type, while apple-gfx-pci ca

[PATCH v11 03/15] hw/display/apple-gfx: Adds PCI implementation

2024-11-27 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan --- v4: * Th

[PATCH v11 04/15] hw/display/apple-gfx: Adds configurable mode list

2024-11-27 Thread Phil Dennis-Jordan
This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for example: -device '{"driver":"apple-gfx-pci", "di

[PATCH v11 08/15] hvf: arm: Ignore writes to CNTP_CTL_EL0

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf MacOS unconditionally disables interrupts of the physical timer on boot and then continues to use the virtual one. We don't really want to support a full physical timer emulation, so let's just ignore those writes. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jo

[PATCH v11 06/15] hw: Add vmapple subdir

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki --- MAINTAIN

[PATCH v11 09/15] gpex: Allow more than 4 legacy IRQs

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

[PATCH v11 05/15] MAINTAINERS: Add myself as maintainer for apple-gfx, reviewer for HVF

2024-11-27 Thread Phil Dennis-Jordan
I'm happy to take responsibility for the macOS PV graphics code. As HVF patches don't seem to get much attention at the moment, I'm also adding myself as designated reviewer for HVF and x86 HVF to try and improve that. I anticipate that the resulting workload should be covered by the funding I'm r

[PATCH v11 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-11-27 Thread Phil Dennis-Jordan
From: Alexander Graf Apple defines a new "vmapple" machine type as part of its proprietary macOS Virtualization.Framework vmm. This machine type is similar to the virt one, but with subtle differences in base devices, a few special vmapple device additions and a vastly different boot chain. This

[PATCH v11 14/15] hw/block/virtio-blk: Replaces request free function with g_free

2024-11-27 Thread Phil Dennis-Jordan
The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki --- hw/block/virtio-blk.c | 43 +++---

Re: [PATCH for-9.2 0/4] fixes for hw/nvme

2024-11-27 Thread Jesper Wendel Devantier
On 11/18/24 11:14, Klaus Jensen wrote: A set of misc fixes related to SR-IOV compliance and MSI-X. Signed-off-by: Klaus Jensen --- Klaus Jensen (4): hw/nvme: fix msix_uninit with exclusive bar hw/nvme: fix use/unuse of msix vectors hw/nvme: SR-IOV VFs must hardwire pci inter

RE: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2024-11-27 Thread Jamin Lin
Hi Philippe, > Subject: Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted > property > > On 27/11/24 10:44, Cédric Le Goater wrote: > > On 11/14/24 10:48, Jamin Lin wrote: > >> change from v1: > >> 1. Support RTC for AST2700. > >> 2. Support SDHCI write protected pin inverted for AS

Re: [PATCH v1 1/1] hw/nvme: Add OCP SMART / Health Information Extended Log Page

2024-11-27 Thread Klaus Jensen
Hi Stephen, On Nov 21 15:23, Stephen Bates wrote: > The Open Compute Project [1] includes a Datacenter NVMe > SSD Specification [2]. The most recent version of this specification > (as of November 2024) is 2.6.1. This specification layers on top of > the NVM Express specifications [3] to provide a

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2024-11-27 Thread Cédric Le Goater
On 11/14/24 10:48, Jamin Lin wrote: change from v1: 1. Support RTC for AST2700. 2. Support SDHCI write protected pin inverted for AST2500 and AST2600. 3. Introduce Capabilities Register 2 for SD slot 0 and 1. 4. Support create flash devices via command line for AST1030. change from v2: replace w

Re: [PATCH v10 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-11-27 Thread Phil Dennis-Jordan
On Wed, 27 Nov 2024 at 07:45, Akihiko Odaki wrote: > > +s->pgdev = PGNewDeviceWithDescriptor(desc); > > + > > +disp_desc = apple_gfx_prepare_display_descriptor(s); > > +s->pgdisp = [s->pgdev newDisplayWithDescriptor:disp_desc > > + port:0 s

Re: [PATCH v10 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-11-27 Thread Phil Dennis-Jordan
On Wed, 27 Nov 2024 at 07:18, Akihiko Odaki wrote: > On 2024/11/13 23:23, Phil Dennis-Jordan wrote: > […] > > +static void apple_gfx_render_new_frame(AppleGFXState *s) > > +{ > > +bool managed_texture = s->using_managed_texture_storage; > > +uint32_t width = surface_width(s->surface); > >

Re: [RFC PATCH 0/5] support unaligned access to xHCI Capability

2024-11-27 Thread Peter Maydell
On Wed, 27 Nov 2024 at 04:34, Tomoyuki HIROSE wrote: > > I would be happy to receive your comments. > ping. Hi; this one is on my to-review list (along, sadly, with 23 other series); I had a quick look a while back and it seemed good (the testing support you've added looks great), but I need to s

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2024-11-27 Thread Philippe Mathieu-Daudé
On 27/11/24 10:44, Cédric Le Goater wrote: On 11/14/24 10:48, Jamin Lin wrote: change from v1: 1. Support RTC for AST2700. 2. Support SDHCI write protected pin inverted for AST2500 and AST2600. 3. Introduce Capabilities Register 2 for SD slot 0 and 1. 4. Support create flash devices via command

Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2024-11-27 Thread Cédric Le Goater
Having to modify sdhci.c internals is dubious, since inversion occurs out of this block. If this is the soc/board layer, isn't better to model at this level? Smth like: -- >8 -- diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index be3eb70cdd7..aad9be66b75 100644 --- a/hw/arm/as