Re: backing storage for eMMC boot partitions

2024-11-18 Thread Cédric Le Goater
Yes. That's a "problem" to fix for emmc/sd devices. They should only be created when defaults_enabled(), just like the flash devices. This is -nodefaults, right? The man-page for that says: -nodefaults Don't create default devices. Normally, QEMU sets the de‐ fault dev

[PATCH for-9.2 1/4] hw/nvme: fix msix_uninit with exclusive bar

2024-11-18 Thread Klaus Jensen
From: Klaus Jensen Commit fa905f65c554 introduced a machine compatibility parameter to enable an exclusive bar for msix. It failed to account for this when cleaning up. Make sure that if an exclusive bar is enabled, we use the proper cleanup routine. Cc: qemu-sta...@nongnu.org Fixes: fa905f65c55

[PATCH for-9.2 0/4] fixes for hw/nvme

2024-11-18 Thread Klaus Jensen
A set of misc fixes related to SR-IOV compliance and MSI-X. Signed-off-by: Klaus Jensen --- Klaus Jensen (4): hw/nvme: fix msix_uninit with exclusive bar hw/nvme: fix use/unuse of msix vectors hw/nvme: SR-IOV VFs must hardwire pci interrupt pin register to zero hw/nvme: ta

[PATCH for-9.2 2/4] hw/nvme: fix use/unuse of msix vectors

2024-11-18 Thread Klaus Jensen
From: Klaus Jensen Only call msix_{un,}use_vector() when interrupts are actually enabled for a completion queue. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 13898d58278ed2155d45a9

Re: [PATCH v4 0/5] block: allow commit to unmap zero blocks

2024-11-18 Thread Vladimir Sementsov-Ogievskiy
On 26.10.24 19:30, Vincent Vanlaer wrote: This patch series adds support for zero blocks in non-active commits. The first three patches in the series refactor the relevant code, patch four makes the actual changes, and the last patch adds a test for the new functionality. --- Changes since v3:

Re: [PATCH v2] vpc: Read images exported from Azure correctly

2024-11-18 Thread Eric Blake
On Mon, Nov 18, 2024 at 03:36:46PM +0100, Vitaly Kuznetsov wrote: > It was found that 'qemu-nbd' is not able to work with some disk images > exported from Azure. Looking at the 512b footer (which contains VPC > metadata): > > 63 6f 6e 65 63 74 69 78 00 00 00 02 00 01 00 00 |conectix...

Re: [PATCH] vpc: Read images exported from Azure correctly

2024-11-18 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > It was found that 'qemu-nbd' is not able to work with some disk images > exported from Azure. Looking at the 512b footer (which contains VPC > metadata): > > 63 6f 6e 65 63 74 69 78 00 00 00 02 00 01 00 00 |conectix| > 0010 ff ff ff ff ff ff ff

[PATCH v2] vpc: Read images exported from Azure correctly

2024-11-18 Thread Vitaly Kuznetsov
It was found that 'qemu-nbd' is not able to work with some disk images exported from Azure. Looking at the 512b footer (which contains VPC metadata): 63 6f 6e 65 63 74 69 78 00 00 00 02 00 01 00 00 |conectix| 0010 ff ff ff ff ff ff ff ff 2e c7 9b 96 77 61 00 00 |

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-18 Thread Jakub Jelen
Hi Kevin, Sorry for the delay, my gmail filters will need some love to handle this high-traffic mailing lists so I can catch replies ... On Thu, Nov 14, 2024 at 6:49 PM Kevin Wolf wrote: > [...] > Hm, after looking some more at the code, I agree that it can't have > worked, for the simple reason

Re: [PATCH] nbd-server: Silence server warnings on port probes

2024-11-18 Thread Eric Blake
On Mon, Nov 18, 2024 at 11:08:51AM -0600, Eric Blake wrote: > On Fri, Nov 15, 2024 at 01:55:53PM -0600, Eric Blake wrote: > > While testing the use of qemu-nbd in a Pod of a Kubernetes cluster, I > > got LOTS of log messages of the forms: > > > > qemu-nbd: option negotiation failed: Failed to read

Re: backing storage for eMMC boot partitions

2024-11-18 Thread Cédric Le Goater
Hello, [ ... ] also boots from the emmc controller. How do I provide the bus and bus index ? "bus=sdhci-bus.2" doesn't work for me. There is "sd-bus", but it does not have an index. Yes. Changes are required in the sdhci model and in the boards using it. I've not really understood how to as

[PATCH 3/7] docs/devel: add b4 for patch retrieval

2024-11-18 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 953682f20cb..d25c677d996 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/dev

[PATCH 6/7] docs: add a glossary

2024-11-18 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/control-flow-integrity.rst | 2 + docs/devel/multi-thread-tcg.rst | 2 + docs/glossary/index.rst | 238 ++ docs/index.rst| 1 + docs/system/arm/virt.rst | 2 + d

[PATCH 5/7] docs: add a codebase section

2024-11-18 Thread Pierrick Bouvier
Present the various parts of QEMU and organization of codebase. Signed-off-by: Pierrick Bouvier --- docs/about/emulation.rst | 2 + docs/codebase/index.rst| 211 + docs/devel/decodetree.rst | 2 + docs/devel/ebpf_rss.rst

[PATCH 4/7] docs/devel: add information on how to setup build environments

2024-11-18 Thread Pierrick Bouvier
MacOS and Linux are straightforward, but Windows needs a bit more details. Signed-off-by: Pierrick Bouvier --- docs/about/build-platforms.rst | 4 +- docs/devel/build-environment.rst | 114 +++ docs/devel/index-build.rst | 1 + 3 files changed, 118 inserti

[PATCH 7/7] docs: add a how to section

2024-11-18 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/build-system.rst | 2 + docs/how-to/index.rst | 146 docs/index.rst | 1 + 3 files changed, 149 insertions(+) create mode 100644 docs/how-to/index.rst diff --git a/docs/devel/build-system.

[PATCH 2/7] docs/devel: add git-publish for patch submitting

2024-11-18 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 349c32ee3a9..953682f20cb 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs

[PATCH 0/7] Enhance documentation for new developers

2024-11-18 Thread Pierrick Bouvier
This series extends our documentation with new pages to help developers onboarding on QEMU. It focuses on providing a big picture of QEMU (to a modest extend). As such, it was written to be simple, short, easy to understand, and pointing to more details. It provides another way to dive into detail

Re: [PATCH v2] vpc: Read images exported from Azure correctly

2024-11-18 Thread Vitaly Kuznetsov
Eric Blake writes: > On Mon, Nov 18, 2024 at 03:36:46PM +0100, Vitaly Kuznetsov wrote: >> It was found that 'qemu-nbd' is not able to work with some disk images >> exported from Azure. Looking at the 512b footer (which contains VPC >> metadata): >> >> 63 6f 6e 65 63 74 69 78 00 00 00

Re: [PATCH] nbd-server: Silence server warnings on port probes

2024-11-18 Thread Eric Blake
On Fri, Nov 15, 2024 at 01:55:53PM -0600, Eric Blake wrote: > While testing the use of qemu-nbd in a Pod of a Kubernetes cluster, I > got LOTS of log messages of the forms: > > qemu-nbd: option negotiation failed: Failed to read flags: Unexpected > end-of-file before all data were read > qemu-nbd

[PATCH 1/7] docs/devel: remove dead video link for sourcehut submit process

2024-11-18 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- docs/devel/submitting-a-patch.rst | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 83e9092b8c0..349c32ee3a9 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/

[PULL 1/1] nbd-server: Silence server warnings on port probes

2024-11-18 Thread Eric Blake
While testing the use of qemu-nbd in a Pod of a Kubernetes cluster, I got LOTS of log messages of the forms: qemu-nbd: option negotiation failed: Failed to read flags: Unexpected end-of-file before all data were read qemu-nbd: option negotiation failed: Failed to read flags: Unable to read from

Re: backing storage for eMMC boot partitions

2024-11-18 Thread Jan Lübbe
Hi, On Mon, 2024-11-18 at 10:14 +0100, Cédric Le Goater wrote: > > > also boots from the emmc controller. How do I provide the > > > bus and bus index ? "bus=sdhci-bus.2" doesn't work for me. > > > There is "sd-bus", but it does not have an index. > > Yes. Changes are required in the sdhci model

[PATCH for-9.2 3/4] hw/nvme: SR-IOV VFs must hardwire pci interrupt pin register to zero

2024-11-18 Thread Klaus Jensen
From: Klaus Jensen The PCI Interrupt Pin Register does not apply to VFs and MUST be hardwired to zero. Fixes: 44c2c09488db ("hw/nvme: Add support for SR-IOV") Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.

[PATCH for-9.2 4/4] hw/nvme: take a reference on the subsystem on vf realization

2024-11-18 Thread Klaus Jensen
From: Klaus Jensen Make sure we grab a reference on the subsystem when a VF is realized. Otherwise, the subsytem will be unrealized automatically when the VFs are unregistered and unreffed. This fixes a latent bug but was not exposed until commit 08f632848008 ("pcie: Release references of virtua