[PULL 6/8] python: silence pylint raising-non-exception error

2024-11-14 Thread Kevin Wolf
From: John Snow As of (at least) pylint 3.3.1, this code trips pylint up into believing we are raising something other than an Exception. We are not: the first two values may indeed be "None", but the last and final value must by definition be a SystemExit exception. Signed-off-by: John Snow Me

[PULL 2/8] parallels: fix possible int overflow

2024-11-14 Thread Kevin Wolf
From: Dmitry Frolov The sum "cluster_index + count" may overflow uint32_t. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov Message-ID: <20241106080521.219255-2-fro...@swemel.ru> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/parall

[PULL 1/8] migration: Check current_migration in migration_is_running()

2024-11-14 Thread Kevin Wolf
From: Peter Xu Report shows that commit 34a8892dec broke iotest 055: https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org When replacing migration_is_idle() with "!migration_is_running()", it was overlooked that the idle helper also checks for current_migration being availa

[PULL 4/8] iotests: correct resultclass type in ReproducibleTestRunner

2024-11-14 Thread Kevin Wolf
From: John Snow I have a vague memory that I suggested this base class to Vladimir and said "Maybe someday it will break, and I'll just fix it then." Guess that's today. Fixes various mypy errors in the "make check-tox" python test for at least Python3.8; seemingly requires a fairly modern mypy

[PULL 7/8] qdev-monitor: avoid QemuOpts in QMP device_add

2024-11-14 Thread Kevin Wolf
From: Stefan Hajnoczi The QMP device_add monitor command converts the QDict arguments to QemuOpts and then back again to QDict. This process only supports scalar types. Device properties like virtio-blk-pci's iothread-vq-mapping (an array of objects) are silently dropped by qemu_opts_from_qdict()

[PULL 0/8] Block layer patches

2024-11-14 Thread Kevin Wolf
The following changes since commit f0a5a31c33a8109061c2493e475c8a2f4d022432: Update version for v9.2.0-rc0 release (2024-11-13 21:44:45 +) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 378a645b2f6125b1bdbd1fae3

[PULL 3/8] iotests: reflow ReproducibleTestRunner arguments

2024-11-14 Thread Kevin Wolf
From: John Snow Trivial reflow to let the type names breathe. (I need to add a longer type name.) Signed-off-by: John Snow Message-ID: <20241101173700.965776-2-js...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 11 +++ 1 file chan

[PULL 5/8] python: disable too-many-positional-arguments warning

2024-11-14 Thread Kevin Wolf
From: John Snow Newest versions of pylint complain about specifically positional arguments in addition to too many in general. We already disable the general case, so silence this new warning too. Signed-off-by: John Snow Message-ID: <20241101173700.965776-4-js...@redhat.com> Reviewed-by: Kevin

[PULL 8/8] vl: use qmp_device_add() in qemu_create_cli_devices()

2024-11-14 Thread Kevin Wolf
From: Stefan Hajnoczi qemu_create_cli_devices() should use qmp_device_add() to match the behavior of the QMP monitor. A comment explained that libvirt changes implementing strict CLI syntax were needed. Peter Krempa has confirmed that modern libvirt uses the same JSON for -device (CLI) and devi

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Kevin Wolf
Am 14.11.2024 um 17:49 hat Jakub Jelen geschrieben: > Hello, > comments inline below. > > On Thu, Nov 14, 2024 at 4:21 PM Kevin Wolf wrote: > > [...] > > > > > I'll just note that I'm only forwarding on the patch from Jakub. > > > I didn't write it. > > > > > > I did lightly test it, and it seems

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Jakub Jelen
Hello, comments inline below. On Thu, Nov 14, 2024 at 4:21 PM Kevin Wolf wrote: > [...] > > > I'll just note that I'm only forwarding on the patch from Jakub. > > I didn't write it. > > > > I did lightly test it, and it seems to work. However it seems also > > likely that it is causing qemu to b

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread Phil Dennis-Jordan
On Thu, 14 Nov 2024 at 14:38, BALATON Zoltan wrote: > On Thu, 14 Nov 2024, Phil Dennis-Jordan wrote: > > On Wed, 13 Nov 2024 at 19:16, BALATON Zoltan wrote: > >> On Wed, 13 Nov 2024, Phil Dennis-Jordan wrote: > >>> macOS's Cocoa event handling must be done on the initial (main) thread > >>> of t

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread Phil Dennis-Jordan
On Wed, 13 Nov 2024 at 17:38, Paolo Bonzini wrote: > On 11/13/24 15:23, Phil Dennis-Jordan wrote: > > macOS's Cocoa event handling must be done on the initial (main) thread > > of the process. Furthermore, if library or application code uses > > libdispatch, the main dispatch queue must be handli

[PATCH v3 0/3] Introduce a new Write Protected pin inverted property

2024-11-14 Thread Jamin Lin via
change from v1: 1. Support RTC for AST2700. 2. Support SDHCI write protected pin inverted for AST2500 and AST2600. 3. Introduce Capabilities Register 2 for SD slot 0 and 1. 4. Support create flash devices via command line for AST1030. change from v2: replace wp-invert with wp-inverted and fix revi

[PATCH v3 1/3] hw/sd/sdhci: Fix coding style

2024-11-14 Thread Jamin Lin via
Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater --- hw/sd/sdhci.c | 64 +-- 1 file changed, 42 insertions(+), 22 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index dbe5c2340c..37875c02c

[PATCH v3 2/3] hw/sd/sdhci: Introduce a new Write Protected pin inverted property

2024-11-14 Thread Jamin Lin via
The Write Protect pin of SDHCI model is default active low to match the SDHCI spec. So, write enable the bit 19 should be 1 and write protected the bit 19 should be 0 at the Present State Register (0x24). However, some boards are design Write Protected pin active high. In other words, write enable

[PATCH v3 3/3] hw/arm/aspeed: Invert sdhci write protected pin for AST2600 EVB

2024-11-14 Thread Jamin Lin via
The Write Protect pin of SDHCI model is default active low to match the SDHCI spec. So, write enable the bit 19 should be 1 and write protected the bit 19 should be 0 at the Present State Register (0x24). According to the design of AST2600 EVB, the Write Protected pin is active high by default. To

RE: [PATCH v2 2/3] hw/sd/sdhci: Introduce a new Write Protected pin inverted property

2024-11-14 Thread Jamin Lin
Hi Cedric, > > On 11/4/24 04:21, Jamin Lin wrote: > > The Write Protect pin of SDHCI model is default active low to match > > the SDHCI spec. So, write enable the bit 19 should be 1 and write > > protected the bit 19 should be 0 at the Present State Register (0x24). > > However, some boards are d

RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode

2024-11-14 Thread Jamin Lin
Hi Cedric, > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode > > Hello Jamin, > > On 11/14/24 06:30, Jamin Lin wrote: > > Hi Cedric, > > > >> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in > >> user mode > >> > >> Hi Cedric, > >> > >>> Subject

RE: [PATCH v2 0/3] Introduce a new Write Protected pin inverted property

2024-11-14 Thread Jamin Lin
Hi Cedric, > > Hello Jamin, > > On 11/14/24 06:32, Jamin Lin wrote: > > Hi Cedric, Andrew > > > >> Subject: [PATCH v2 0/3] Introduce a new Write Protected pin inverted > >> property > >> > >> change from v1: > >> 1. Support RTC for AST2700. > >> 2. Support SDHCI write protected pin inverted for

Re: "relaxed" `-hda file.qcow2` equivalent ?

2024-11-14 Thread lacsaP Patatetom
Le jeu. 14 nov. 2024 à 15:11, lacsaP Patatetom a écrit : > hi, > what is the "relaxed" equivalent of the `-hda file.qcow2` command line > argument to control file locking (`locking=off`) ? > the documentation says that `-hda a` can be replaced by `-drive file=a` > and that locking can be controll

Re: "relaxed" `-hda file.qcow2` equivalent ?

2024-11-14 Thread lacsaP Patatetom
Le jeu. 14 nov. 2024 à 16:15, lacsaP Patatetom a écrit : > Le jeu. 14 nov. 2024 à 15:11, lacsaP Patatetom a > écrit : > >> hi, >> what is the "relaxed" equivalent of the `-hda file.qcow2` command line >> argument to control file locking (`locking=off`) ? >> the documentation says that `-hda a` c

"relaxed" `-hda file.qcow2` equivalent ?

2024-11-14 Thread lacsaP Patatetom
hi, what is the "relaxed" equivalent of the `-hda file.qcow2` command line argument to control file locking (`locking=off`) ? the documentation says that `-hda a` can be replaced by `-drive file=a` and that locking can be controlled with the `locking` option of the `blockdev` argument : how to link

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread Phil Dennis-Jordan
On Thu, 14 Nov 2024 at 14:27, Paolo Bonzini wrote: > On Thu, Nov 14, 2024 at 11:32 AM Phil Dennis-Jordan > wrote: > >> I checked what GTK+ does and, either way, you have to create another > >> thread: timers are handled with a CFRunLoopTimer, but file descriptors > >> are polled in a separate th

Re: "relaxed" `-hda file.qcow2` equivalent ?

2024-11-14 Thread lacsaP Patatetom
Le jeu. 14 nov. 2024 à 15:11, lacsaP Patatetom a écrit : > hi, > what is the "relaxed" equivalent of the `-hda file.qcow2` command line > argument to control file locking (`locking=off`) ? > the documentation says that `-hda a` can be replaced by `-drive file=a` > and that locking can be controll

Re: [PATCH ssh] ssh: Do not switch session to non-blocking mode

2024-11-14 Thread Kevin Wolf
Am 13.11.2024 um 14:00 hat Richard W.M. Jones geschrieben: > On Wed, Nov 13, 2024 at 03:02:59PM +0300, Michael Tokarev wrote: > > Heh. I was creating a qemu bug report on gitlab when this email arrived :) > > > > 13.11.2024 14:49, Richard W.M. Jones wrote: > > >From: Jakub Jelen > > > > > >The li

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread Phil Dennis-Jordan
On Wed, 13 Nov 2024 at 19:16, BALATON Zoltan wrote: > On Wed, 13 Nov 2024, Phil Dennis-Jordan wrote: > > macOS's Cocoa event handling must be done on the initial (main) thread > > of the process. Furthermore, if library or application code uses > > libdispatch, the main dispatch queue must be han

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread Paolo Bonzini
On Thu, Nov 14, 2024 at 11:32 AM Phil Dennis-Jordan wrote: >> I checked what GTK+ does and, either way, you have to create another >> thread: timers are handled with a CFRunLoopTimer, but file descriptors >> are polled in a separate thread and sent to the main thread with a >> single CFRunLoopSour

Re: [PATCH v10 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-14 Thread BALATON Zoltan
On Thu, 14 Nov 2024, Phil Dennis-Jordan wrote: On Wed, 13 Nov 2024 at 19:16, BALATON Zoltan wrote: On Wed, 13 Nov 2024, Phil Dennis-Jordan wrote: macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch,

[PATCH] vpc: Read images exported from Azure correctly

2024-11-14 Thread Vitaly Kuznetsov
It was found that 'qemu-nbd' is not able to work with some disk images exported from Azure. Looking at the 512b footer (which contains VPC metadata): 63 6f 6e 65 63 74 69 78 00 00 00 02 00 01 00 00 |conectix| 0010 ff ff ff ff ff ff ff ff 2e c7 9b 96 77 61 00 00 |