Re: [PATCH v9 01/16] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread Phil Dennis-Jordan
On Mon, 11 Nov 2024 at 05:45, Akihiko Odaki wrote: > > On 2024/11/11 6:55, Phil Dennis-Jordan wrote: > > macOS's Cocoa event handling must be done on the initial (main) thread > > of the process. Furthermore, if library or application code uses > > libdispatch, the main dispatch queue must be hand

[PATCH] block: Fix leak in send_qmp_error_event

2024-11-11 Thread Fabiano Rosas
ASAN detected a leak when running the ahci-test /ahci/io/dma/lba28/retry: Direct leak of 35 byte(s) in 1 object(s) allocated from: #0 in malloc #1 in __vasprintf_internal #2 in vasprintf #3 in g_vasprintf #4 in g_strdup_vprintf #5 in g_strdup_printf #6 in object_get_can

Re: [PATCH] block: Fix leak in send_qmp_error_event

2024-11-11 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > On 11/11/24 14:52, Fabiano Rosas wrote: >> ASAN detected a leak when running the ahci-test >> /ahci/io/dma/lba28/retry: >> >> Direct leak of 35 byte(s) in 1 object(s) allocated from: >> #0 in malloc >> #1 in __vasprintf_internal >> #2 in vasprintf

Re: [PATCH v8 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread BALATON Zoltan
On Mon, 11 Nov 2024, Phil Dennis-Jordan wrote: On Mon, 11 Nov 2024 at 13:41, BALATON Zoltan wrote: On Mon, 11 Nov 2024, Phil Dennis-Jordan wrote: On Mon, 11 Nov 2024 at 10:08, Daniel P. Berrangé wrote: On Sun, Nov 10, 2024 at 08:08:16AM +0100, Phil Dennis-Jordan wrote: On Sun 10. Nov 2024

Re: [PATCH v8 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread Phil Dennis-Jordan
On Mon, 11 Nov 2024 at 13:41, BALATON Zoltan wrote: > On Mon, 11 Nov 2024, Phil Dennis-Jordan wrote: > > On Mon, 11 Nov 2024 at 10:08, Daniel P. Berrangé > > wrote: > > > >> On Sun, Nov 10, 2024 at 08:08:16AM +0100, Phil Dennis-Jordan wrote: > >>> On Sun 10. Nov 2024 at 08:01, Akihiko Odaki > >

Re: [PATCH v8 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread Phil Dennis-Jordan
On Mon, 11 Nov 2024 at 10:08, Daniel P. Berrangé wrote: > On Sun, Nov 10, 2024 at 08:08:16AM +0100, Phil Dennis-Jordan wrote: > > On Sun 10. Nov 2024 at 08:01, Akihiko Odaki > > wrote: > > > > > On 2024/11/08 23:46, Phil Dennis-Jordan wrote: > > > > macOS's Cocoa event handling must be done on t

Re: [PATCH v8 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread Daniel P . Berrangé
On Sun, Nov 10, 2024 at 08:08:16AM +0100, Phil Dennis-Jordan wrote: > On Sun 10. Nov 2024 at 08:01, Akihiko Odaki > wrote: > > > On 2024/11/08 23:46, Phil Dennis-Jordan wrote: > > > macOS's Cocoa event handling must be done on the initial (main) thread > > > of the process. Furthermore, if librar

Re: [PATCH v8 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-11-11 Thread BALATON Zoltan
On Mon, 11 Nov 2024, Phil Dennis-Jordan wrote: On Mon, 11 Nov 2024 at 10:08, Daniel P. Berrangé wrote: On Sun, Nov 10, 2024 at 08:08:16AM +0100, Phil Dennis-Jordan wrote: On Sun 10. Nov 2024 at 08:01, Akihiko Odaki wrote: On 2024/11/08 23:46, Phil Dennis-Jordan wrote: macOS's Cocoa event

Re: [PATCH] block: Fix leak in send_qmp_error_event

2024-11-11 Thread Philippe Mathieu-Daudé
On 11/11/24 14:52, Fabiano Rosas wrote: ASAN detected a leak when running the ahci-test /ahci/io/dma/lba28/retry: Direct leak of 35 byte(s) in 1 object(s) allocated from: #0 in malloc #1 in __vasprintf_internal #2 in vasprintf #3 in g_vasprintf #4 in g_strdup_vprintf

[PATCH v2 1/2] block: Improve blk_get_attached_dev_id() docstring

2024-11-11 Thread Philippe Mathieu-Daudé
Expose the method docstring in the header, and mention returned value must be free'd by caller. Reported-by: Fabiano Rosas Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/block-backend-io.h | 7 +++ block/block-backend.c | 12 2 files changed, 15 insertion

[PATCH v2 0/2] block: Fix leak in send_qmp_error_event

2024-11-11 Thread Philippe Mathieu-Daudé
Respin of Fabiano patch using g_autofree, and clarifying method docstrings. Fabiano Rosas (1): block: Fix leak in send_qmp_error_event Philippe Mathieu-Daudé (1): block: Improve blk_get_attached_dev_id() docstring include/sysemu/block-backend-io.h | 7 +++ block/block-backend.c

[PATCH v2 2/2] block: Fix leak in send_qmp_error_event

2024-11-11 Thread Philippe Mathieu-Daudé
From: Fabiano Rosas ASAN detected a leak when running the ahci-test /ahci/io/dma/lba28/retry: Direct leak of 35 byte(s) in 1 object(s) allocated from: #0 in malloc #1 in __vasprintf_internal #2 in vasprintf #3 in g_vasprintf #4 in g_strdup_vprintf #5 in g_strdup_printf