Re: [PATCH] migration: Check current_migration in migration_is_running()

2024-11-06 Thread Pierrick Bouvier
On 11/6/24 01:43, Thomas Huth wrote: On 05/11/2024 19.27, Peter Xu wrote: Report shows that commit 34a8892dec broke iotest 055: https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org FWIW, this patch also fixes a lot of other broken iotests (vmdk and vpc) that occur when ru

Re: [PATCH v7 0/3] vhost-user-blk: live resize additional APIs

2024-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2024 at 02:18:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > v7: update QAPI version 9.1 -> 9.2 Not like this. ypur patches are merged, pls post a fix patch on top. Thanks! > Vladimir Sementsov-Ogievskiy (3): > qdev-monitor: add option to report GenericError from find_devic

Re: [PATCH] block: fix possible int overflow

2024-11-06 Thread Kevin Wolf
[ Cc: qemu-block ] Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben: > The sum "cluster_index + count" may overflow uint32_t. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Frolov Thanks, applied to the block branch. While trying to check i

Re: [PATCH 0/4] python: update linting for new mypy/pylint releases

2024-11-06 Thread Kevin Wolf
Am 01.11.2024 um 18:36 hat John Snow geschrieben: > Various python tests in the "check-python-tox" test case on GitLab have > begun failing due to newer package versions. This patch set corrects > those issues and also improves the reliability of local developer tests > which may be using these too

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-06 Thread Klaus Jensen
On Nov 4 17:32, Waldek Kozaczuk wrote: > I have run my tests on the OSv side with small queue sizes like 3,4,5 and I > could NOT replicate the issue. So it looks like the V2 version of this > patch fixes the problem. > Thanks for testing Waldek! May I add a Tested-by tag to the commit for you?

Re: [PATCH] migration: Check current_migration in migration_is_running()

2024-11-06 Thread Thomas Huth
On 05/11/2024 19.27, Peter Xu wrote: Report shows that commit 34a8892dec broke iotest 055: https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org FWIW, this patch also fixes a lot of other broken iotests (vmdk and vpc) that occur when running "make check SPEED=thorough".

Re: [PATCH v7 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-11-06 Thread Akihiko Odaki
On 2024/11/06 18:10, Phil Dennis-Jordan wrote: On Wed, 6 Nov 2024 at 08:42, Akihiko Odaki > wrote: On 2024/11/06 0:30, Phil Dennis-Jordan wrote: > From: Alexander Graf mailto:g...@amazon.com>> > > Apple defines a new "vmapple" machine type a

[PATCH v7 0/3] vhost-user-blk: live resize additional APIs

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
v7: update QAPI version 9.1 -> 9.2 Vladimir Sementsov-Ogievskiy (3): qdev-monitor: add option to report GenericError from find_device_state vhost-user-blk: split vhost_user_blk_sync_config() qapi: introduce device-sync-config hw/block/vhost-user-blk.c | 27 ++-- hw/virtio/v

Re: [PATCH] block: fix possible int overflow

2024-11-06 Thread Kevin Wolf
Am 06.11.2024 um 16:45 hat Denis V. Lunev geschrieben: > On 11/6/24 10:53, Kevin Wolf wrote: > > [ Cc: qemu-block ] > > > > Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben: > > > The sum "cluster_index + count" may overflow uint32_t. > > > > > > Found by Linux Verification Center (linuxtesti

[PATCH v7 3/3] qapi: introduce device-sync-config

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not triggered interrupt to the guest or just not available (not supported by vhost-user server). Command result is racy if allow it during migration. Let's not allo

Re: [PATCH] block: fix possible int overflow

2024-11-06 Thread Denis V. Lunev
On 11/6/24 10:53, Kevin Wolf wrote: [ Cc: qemu-block ] Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben: The sum "cluster_index + count" may overflow uint32_t. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov Thanks, applied to the block bra

[PATCH v7 1/3] qdev-monitor: add option to report GenericError from find_device_state

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
Here we just prepare for the following patch, making possible to report GenericError as recommended. This patch doesn't aim to prevent further use of DeviceNotFound by future interfaces: - find_device_state() is used in blk_by_qdev_id() and qmp_get_blk() functions, which may lead to spread of

Re: [PATCH v7 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-11-06 Thread Phil Dennis-Jordan
On Wed, 6 Nov 2024 at 08:42, Akihiko Odaki wrote: > On 2024/11/06 0:30, Phil Dennis-Jordan wrote: > > From: Alexander Graf > > > > Apple defines a new "vmapple" machine type as part of its proprietary > > macOS Virtualization.Framework vmm. This machine type is similar to the > > virt one, but w

Re: [PATCH] migration: Check current_migration in migration_is_running()

2024-11-06 Thread Thomas Huth
On 06/11/2024 18.18, Pierrick Bouvier wrote: On 11/6/24 01:43, Thomas Huth wrote: On 05/11/2024 19.27, Peter Xu wrote: Report shows that commit 34a8892dec broke iotest 055: https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org FWIW, this patch also fixes a lot of other br

Re: [PATCH v3 6/7] qapi/block-core: deprecate block-job-change

2024-11-06 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > That's a first step to move on newer job-* APIs. > > The difference between block-job-change and job-change is in > find_block_job_locked() vs find_job_locked() functions. What's > different? > > 1. find_block_job_locked() finds only block jobs, whereas >

Re: [PATCH v7 15/15] hw/vmapple/vmapple: Add vmapple machine type

2024-11-06 Thread Phil Dennis-Jordan
On Wed, 6 Nov 2024 at 10:16, Akihiko Odaki wrote: > On 2024/11/06 18:10, Phil Dennis-Jordan wrote: > > > > > > On Wed, 6 Nov 2024 at 08:42, Akihiko Odaki > > wrote: > > > > On 2024/11/06 0:30, Phil Dennis-Jordan wrote: > > > From: Alexander Graf mailto:g

Re: [PATCH 2/2] hw/sd: Remove legacy sd_enable()

2024-11-06 Thread Philippe Mathieu-Daudé
On 9/9/24 16:26, Peter Maydell wrote: On Tue, 3 Sept 2024 at 21:04, Philippe Mathieu-Daudé wrote: sd_enable() was only used by omap_mmc_enable() which got recently removed. Time to remove it. Since the SDState::enable boolean is now always %true, we can remove it and simplify. Signed-off-by:

Re: [PATCH v4 00/26] E500 Cleanup

2024-11-06 Thread Bernhard Beschow
Am 5. November 2024 22:55:20 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Bernhard, > >On 3/11/24 14:33, Bernhard Beschow wrote: >> This series is part of a bigger series exploring data-driven machine creation >> using device tree blobs on top of the e500 machines [1]. It contains patches >> to

[PATCH v7 2/3] vhost-user-blk: split vhost_user_blk_sync_config()

2024-11-06 Thread Vladimir Sementsov-Ogievskiy
Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz Reviewed-by: Stefano Garzarella --- hw/block/vhost-user-blk.c | 26 +++--- 1 file c