Re: [PATCH] hw/sd/sdcard: Fix calculation of size when using eMMC boot partitions

2024-11-04 Thread Philippe Mathieu-Daudé
On 2/11/24 12:06, Cédric Le Goater wrote: Philippe, I can take this patch through the aspeed branch. I missed this patch because it was deeply buried in a long thread. Since you mentioned this feature will be reworked in the next cycle: Acked-by: Philippe Mathieu-Daudé Thanks, C. On 10

[PULL 2/3] hw/nvme: add NPDAL/NPDGL

2024-11-04 Thread Klaus Jensen
From: Ayush Mishra Add the NPDGL and NPDAL fields to support large alignment and granularities. Signed-off-by: Ayush Mishra Reviewed-by: Klaus Jensen Link: https://lore.kernel.org/r/20241001012833.3551820-1-ayush@samsung.com [k.jensen: renamed the enum values] Signed-off-by: Klaus Jensen

[PULL 1/3] hw/nvme: i/o cmd set independent namespace data structure

2024-11-04 Thread Klaus Jensen
From: Arun Kumar Add support for the I/O Command Set Independent Namespace Data Structure (CNS 8h and 1fh). Signed-off-by: Arun Kumar Reviewed-by: Klaus Jensen Link: https://lore.kernel.org/r/20240925004407.3521406-1-arun@samsung.com Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c |

[PULL 3/3] hw/nvme: remove dead code

2024-11-04 Thread Klaus Jensen
From: Arun Kumar Remove dead code which always returns success, since PRCHK will have a value of zero. Signed-off-by: Arun Kumar Reviewed-by: Klaus Jensen Link: https://lore.kernel.org/r/2024102105.3609223-1-arun@samsung.com Signed-off-by: Klaus Jensen --- hw/nvme/dif.c | 5 - 1

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Klaus Jensen
On Oct 29 13:15, Klaus Jensen wrote: > From: Klaus Jensen > > If a host chooses to use the SQHD "hint" in the CQE to know if there is > room in the submission queue for additional commands, it may result in a > situation where there are not enough internal resources (struct > NvmeRequest) availab

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Keith Busch
On Tue, Oct 29, 2024 at 01:15:19PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > If a host chooses to use the SQHD "hint" in the CQE to know if there is > room in the submission queue for additional commands, it may result in a > situation where there are not enough internal resources (stru

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Waldek Kozaczuk
I have run my tests on the OSv side with small queue sizes like 3,4,5 and I could NOT replicate the issue. So it looks like the V2 version of this patch fixes the problem. Thanks a lot, Waldemar Kozaczuk On Mon, Nov 4, 2024 at 1:57 PM Keith Busch wrote: > On Tue, Oct 29, 2024 at 01:15:19PM +010

[PULL 23/65] qapi: introduce device-sync-config

2024-11-04 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not triggered interrupt to the guest or just not available (not supported by vhost-user server). Command result is racy if allo

[PULL 22/65] vhost-user-blk: split vhost_user_blk_sync_config()

2024-11-04 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy Split vhost_user_blk_sync_config() out from vhost_user_blk_handle_config_change(), to be reused in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Raphael Norwitz Message-Id: <20240920094936.450987-3-vsement...@yandex-team.ru> Revi

Re: [PATCH v4 15/26] hw/net/fsl_etsec/miim: Reuse MII constants

2024-11-04 Thread Akihiko Odaki
On 2024/11/03 22:34, Bernhard Beschow wrote: Instead of defining redundant constants and using magic numbers reuse the existing MII constants. Signed-off-by: Bernhard Beschow cc: Akihiko Odaki Reviewed-by: Akihiko Odaki

Re: [PATCH v1 6/8] hw/sd/aspeed_sdhci: Introduce Capabilities Register 2 for SD slot 0 and 1

2024-11-04 Thread Philippe Mathieu-Daudé
On 29/10/24 06:17, Jamin Lin wrote: The size of SDHCI capabilities register is 64bits, so introduces new Capabilities Register 2 for SD slot 0 (0x144) and SD slot1 (0x244). Signed-off-by: Jamin Lin --- hw/sd/aspeed_sdhci.c | 40 +--- 1 file changed, 29 ins

Re: [PATCH v4 22/26] hw/i2c/smbus_eeprom: Prefer DEFINE_TYPES() macro

2024-11-04 Thread Corey Minyard
On Sun, Nov 03, 2024 at 02:34:08PM +0100, Bernhard Beschow wrote: > Reviewed-by: Cédric Le Goater > Signed-off-by: Bernhard Beschow Yeah, I think this is best. Acked-by: Corey Minyard > --- > hw/i2c/smbus_eeprom.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) >

Re: [PATCH v4 12/26] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro

2024-11-04 Thread Corey Minyard
On Sun, Nov 03, 2024 at 02:33:58PM +0100, Bernhard Beschow wrote: > Reviewed-by: Cédric Le Goater > Signed-off-by: Bernhard Beschow Acked-by: Corey Minyard > --- > hw/i2c/mpc_i2c.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/hw/i2c/mpc_i2c.c