Re: [PATCH] raw-format: Fix error message for invalid offset/size

29.08.2024 21:55, Kevin Wolf wrote: s->offset and s->size are only set at the end of the function and still contain the old values when formatting the error message. Print the parameters with the new values that we actually checked instead. Fixes: 500e2434207d ('raw-format: Split raw_read_option

[PATCH v4 10/15] hw/vmapple/aes: Introduce aes engine

From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan --- v3: * Rebased

[PATCH v4 06/15] hw: Add vmapple subdir

From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki --- MAINTAIN

[PATCH v4 09/15] gpex: Allow more than 4 legacy IRQs

From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

[PATCH v4 14/15] hw/block/virtio-blk: Replaces request free function with g_free

The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan --- hw/block/virtio-blk.c | 43 +++--- hw/vmapple/virtio-blk.c

Re: [PATCH] hw/nvme: fix handling of over-committed queues

On Fri, Oct 25, 2024 at 12:50:45PM +0200, Klaus Jensen wrote: > @@ -1520,9 +1520,16 @@ static void nvme_post_cqes(void *opaque) > nvme_inc_cq_tail(cq); > nvme_sg_unmap(&req->sg); > + > +if (QTAILQ_EMPTY(&sq->req_list) && !nvme_sq_empty(sq)) { > +qemu_bh_schedul

[PATCH] hw/nvme: fix handling of over-committed queues

edule(sq->bh); -} -qemu_bh_schedule(cq->bh); -} if (cq->tail == cq->head) { if (cq->irq_enabled) { --- base-commit: e67b7aef7c7f67ecd0282e903e0daff806d5d680 change-id: 20241025-issue-2388-bd047487f74c Best regards, -- Klaus Jensen

Re: [PATCH v4 13/15] hw/vmapple/virtio-blk: Add support for apple virtio-blk

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: From: Alexander Graf Apple has its own virtio-blk PCI device ID where it deviates from the official virtio-pci spec slightly: It puts a new "apple type" field at a static offset in config space and introduces a new barrier command. This patch firs

Re: [PATCH v4 14/15] hw/block/virtio-blk: Replaces request free function with g_free

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki

Re: [PATCH v4 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

On 2024/10/26 4:43, Phil Dennis-Jordan wrote: On Fri, 25 Oct 2024 at 08:03, Akihiko Odaki > wrote: On 2024/10/24 19:28, Phil Dennis-Jordan wrote: > MacOS provides a framework (library) that allows any vmm to implement a > paravirtualized 3d g

Re: [PATCH 0/2] arm: Add collie and sx functional tests

On 10/25/24 21:47, Philippe Mathieu-Daudé wrote: On 25/10/24 12:25, Jan Lübbe wrote: On Fri, 2024-10-25 at 06:59 -0700, Guenter Roeck wrote: On 10/25/24 02:57, Jan Lübbe wrote: On Fri, 2024-10-25 at 08:55 +0200, Cédric Le Goater wrote: On 10/24/24 19:59, Philippe Mathieu-Daudé wrote: Cc'ing

Re: [PATCH v4 03/15] hw/display/apple-gfx: Adds PCI implementation

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. S

Re: [PATCH 0/2] arm: Add collie and sx functional tests

On 25/10/24 12:25, Jan Lübbe wrote: On Fri, 2024-10-25 at 06:59 -0700, Guenter Roeck wrote: On 10/25/24 02:57, Jan Lübbe wrote: On Fri, 2024-10-25 at 08:55 +0200, Cédric Le Goater wrote: On 10/24/24 19:59, Philippe Mathieu-Daudé wrote: Cc'ing Jan. On 22/10/24 12:04, Guenter Roeck wrote: I

Re: [PATCH v4 04/15] hw/display/apple-gfx: Adds configurable mode list

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for

Re: [PATCH v4 09/15] gpex: Allow more than 4 legacy IRQs

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they

Re: [PATCH v4 15/15] hw/vmapple/vmapple: Add vmapple machine type

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: From: Alexander Graf Apple defines a new "vmapple" machine type as part of its proprietary macOS Virtualization.Framework vmm. This machine type is similar to the virt one, but with subtle differences in base devices, a few special vmapple device a

Re: [PATCH v4 10/15] hw/vmapple/aes: Introduce aes engine

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: From: Alexander Graf VMApple contains an "aes" engine device that it uses to encrypt and decrypt its nvram. It has trivial hard coded keys it uses for that purpose. Add device emulation for this device model. Signed-off-by: Alexander Graf Signed

Re: [PATCH v4 12/15] hw/vmapple/cfg: Introduce vmapple cfg region

On 2024/10/24 19:28, Phil Dennis-Jordan wrote: From: Alexander Graf Instead of device tree or other more standardized means, VMApple passes platform configuration to the first stage boot loader in a binary encoded format that resides at a dedicated RAM region in physical address space. This pa

Re: [PATCH v4 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

On Fri, 25 Oct 2024 at 08:03, Akihiko Odaki wrote: > On 2024/10/24 19:28, Phil Dennis-Jordan wrote: > > MacOS provides a framework (library) that allows any vmm to implement a > > paravirtualized 3d graphics passthrough to the host metal stack called > > ParavirtualizedGraphics.Framework (PVG). T

Re: [PATCH] hw/nvme: fix handling of over-committed queues

); > > -start_sqs = nvme_cq_full(cq) ? 1 : 0; > cq->head = new_head; > if (!qid && n->dbbuf_enabled) { > stl_le_pci_dma(pci, cq->db_addr, cq->head, > MEMTXATTRS_UNSPECIFIED); > } > - if (start_sqs