Re: [PATCH v2 19/23] hw/block/pflash_cfi01: Prefer DEFINE_TYPES() macro

2024-10-18 Thread Kevin Wolf
Am 05.10.2024 um 21:45 hat Bernhard Beschow geschrieben: > Reviewed-by: Cédric Le Goater > Signed-off-by: Bernhard Beschow Reviewed-by: Kevin Wolf

Re: [SPAM] [PATCH v1 02/16] hw/block:m25p80: Fix coding style

2024-10-18 Thread Cédric Le Goater
On 10/18/24 07:30, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/block/m25p80.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/block/m25p80.c b/hw/b

Re: [PATCH v3 0/2] throttling for BLOCK_IO_ERROR

2024-10-18 Thread Kevin Wolf
Am 02.10.2024 um 17:18 hat Vladimir Sementsov-Ogievskiy geschrieben: > v2: switch to qom-path as discriminator, for this, add patch 01. > > Leonid Kaplan (1): > block-backend: per-device throttling of BLOCK_IO_ERROR reports > > Vladimir Sementsov-Ogievskiy (1): > qapi: add qom-path to BLOCK_I

Re: [PATCH v9 4/7] qapi: add blockdev-replace command

2024-10-18 Thread Kevin Wolf
Am 04.10.2024 um 19:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 02.10.24 17:41, Vladimir Sementsov-Ogievskiy wrote: > > On 26.06.24 14:53, Vladimir Sementsov-Ogievskiy wrote: > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > > index df5e07debd..0a6f08a6e0 100644 > > > ---

Re: [PATCH v2] block/file-posix: optimize append write

2024-10-18 Thread Kevin Wolf
Am 04.10.2024 um 12:41 hat Sam Li geschrieben: > When the file-posix driver emulates append write, it holds the lock > whenever accessing wp, which limits the IO queue depth to one. > > The write IO flow can be optimized to allow concurrent writes. The lock > is held in two cases: > 1. Assumed tha

Re: [PATCH 0/2] fix backup-discard-source test for XFS

2024-10-18 Thread Kevin Wolf
Am 03.10.2024 um 08:39 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi Kevin! > > Now I revisit my old series, and looking here I see that I forget add you > into CC. > > Does it still make sense? Oops, I missed this one indeed. Thanks, applied to the block branch. Kevin

Re: [PATCH] hw/sd/sdcard: Allow user creation of eMMCs

2024-10-18 Thread Peter Maydell
On Tue, 15 Oct 2024 at 14:57, Jan Luebbe wrote: > > For testing eMMC-specific functionality (such as handling boot > partitions), it would be very useful to attach them to generic VMs such > as x86_64 via the sdhci-pci device: > ... > -drive if=none,id=emmc-drive,file=emmc.img,format=raw \ > -d

Re: [PATCH] vmdk:truncate more one sector in init extent

2024-10-18 Thread Kevin Wolf
Am 22.08.2024 um 12:52 hat luzhipeng geschrieben: > issue:https://gitlab.com/qemu-project/qemu/-/issues/1357 > empty vmdk only contains metadata, ovftool failed. > So it allocates more one sector for empty disk. the ovftool > command line: ovftool input.ovf output.ova > > Signed-off-by: luzhipeng

Re: [PATCH v2 0/4] block: Miscellaneous minor Coverity fixes

2024-10-18 Thread Kevin Wolf
Am 08.10.2024 um 18:47 hat Peter Maydell geschrieben: > This patchset is the remaining stragglers from my > first set of "minor Coverity fixes" patches posted a > couple of months back: > https://patchew.org/QEMU/20240731143617.3391947-1-peter.mayd...@linaro.org/ > Of that series, patches 3, 4, 5 a

Re: [PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style

2024-10-18 Thread Thomas Huth
On 18/10/2024 07.31, Jamin Lin wrote: Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin --- tests/qtest/aspeed_smc-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index c713a3700b