[PATCH v1 08/16] test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function

2024-10-17 Thread Jamin Lin via
So far, the test cases are used for testing SMC model with AST2400 BMC. However, AST2400 is end off live and ASPEED is no longer support this SOC. To test SMC model for AST2500, AST2600 and AST1030, move the test cases from main to test_palmetto_bmc function. Signed-off-by: Jamin Lin --- tests/q

[PATCH v1 06/16] hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB

2024-10-17 Thread Jamin Lin via
Currently, the default fmc_model was "sst25vf032b" whose size was 4MB for ast1030-a1 EVB. However, according to the schematic of ast1030-a1 EVB, ASPEED shipped default flash of fmc_cs0 and fmc_cs1 were "w25q80bl" and "w25q256", respectively. The size of w25q80bl is 1MB and the size of w25q256 is 32

Re: [PATCH v16 04/13] s390x/pci: Avoid creating zpci for VFs

2024-10-17 Thread Akihiko Odaki
On 2024/10/14 17:43, Cédric Le Goater wrote: Hello Akihiko, On 10/12/24 13:05, Akihiko Odaki wrote: On 2024/10/11 0:44, Cédric Le Goater wrote: Hello Akihiko, Sorry for the late reply. On 9/18/24 17:32, Akihiko Odaki wrote: On 2024/09/18 17:02, Cédric Le Goater wrote: Hello, On 9/13/24 05

Re: [PATCH] hw/nvme: Remove references to PCI IRQ "pulsing" when asserting

2024-10-17 Thread Julia
Actually, it seems that trace_pci_nvme_irq_pin is emitted even if the IRQ is not asserted due to a setting of the interrupt masks. Which is weird because there's no corresponding one for deasserting. Possibly this should be reworded for 'interrupt is high (but might be masked?)', or just leave

[PATCH v1 12/16] test/qtest/aspeed_smc-test: Support to test AST2500

2024-10-17 Thread Jamin Lin via
Add test_ast2500_evb function and reused testcases for AST2500 testing. The spi base address, flash base address and ce index of fmc_cs0 are 0x1E62, 0x2000 and 0, respectively. The default flash model of fmc_cs0 is "mx25l25635e" whose size is 32MB, so set jedec_id 0xc22019. Signed-off-by:

[PATCH v1 09/16] test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs

2024-10-17 Thread Jamin Lin via
Currently, these test cases are only used for testing fmc_cs0 for AST2400. To test others BMC SOCs, introduces a new TestData structure. Users can set the spi base address, flash base address, jedesc id and so on for different BMC SOCs and flash model testing. Introduce new helper functions to mak

[PATCH v1 14/16] test/qtest/aspeed_smc-test: Support to test AST1030

2024-10-17 Thread Jamin Lin via
Add test_ast1030_evb function and reused testcases for AST1030 testing. The base address, flash base address and ce index of fmc_cs0 are 0x7E62, 0x8000 and 0, respectively. The default flash model of fmc_cs0 is "w25q80bl" whose size is 1MB, so set jedec_id 0xef4014. Signed-off-by: Jamin Li

[PATCH v1 10/16] test/qtest/aspeed_smc-test: Support to test all CE pins

2024-10-17 Thread Jamin Lin via
Currently, these test cases only support to test CE0. To test all CE pins, introduces new ce and node members in TestData structure. The ce member is used for saving the ce index and node member is used for saving the node path, respectively. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_smc-t

[PATCH v1 05/16] hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB.

2024-10-17 Thread Jamin Lin via
Currently, the default spi_model was "sst25vf032b" whose size was 4MB for ast1030-a1 EVB. However, according to the schematic of ast1030-a1 EVB, ASPEED shipped default flash of spi1 and spi2 were w25q256 whose size was 32MB. Correct spi_model default flash to w25q256 for ast1030-a1 EVB. Signed-of

[PATCH v1 13/16] test/qtest/aspeed_smc-test: Support to test AST2600

2024-10-17 Thread Jamin Lin via
Add test_ast2600_evb function and reused testcases for AST2600 testing. The spi base address, flash base address and ce index of fmc_cs0 are 0x1E62, 0x2000 and 0, respectively. The default flash model of fmc_cs0 is "mx66u51235f" whose size is 64MB, so set jedec_id 0xc2253a. Signed-off-by:

[PATCH v1 01/16] aspeed/smc: Fix write incorrect data into flash in user mode

2024-10-17 Thread Jamin Lin via
According to the design of ASPEED SPI controllers user mode, users write the data to flash, the SPI drivers set the Control Register(0x10) bit 0 and 1 enter user mode. Then, SPI drivers send flash commands for writing data. Finally, SPI drivers set the Control Register (0x10) bit 2 to stop active c

[PATCH v1 03/16] hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq

2024-10-17 Thread Jamin Lin via
According to the w25q01jv datasheet at page 16, it is required to set QE bit in "Status Register 2" to enable quad mode. Currently, m25p80 support users utilize "Write Status Register 1(0x01)" command to set QE bit in "Status Register 2" and utilize "Read Status Register 2(0x35)" command to get th

[PATCH v1 02/16] hw/block:m25p80: Fix coding style

2024-10-17 Thread Jamin Lin via
Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin --- hw/block/m25p80.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index f7123f9e68..3f55b8f385 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m

[PATCH v1 11/16] test/qtest/aspeed_smc-test: Support to test all flash models

2024-10-17 Thread Jamin Lin via
Currently, these test cases used the hardcode offset 0x140 (0x14000 * 256) which was beyond the 16MB flash size for flash page read/write command testing. However, the default fmc flash model of ast1030-a1 EVB is "w25q80bl" whose size is 1MB. To test all flash models, introduces a new page_addr

[PATCH v1 04/16] hw/block/m25p80: Add SFDP table for w25q80bl flash

2024-10-17 Thread Jamin Lin via
Add the SFDP table for the Windbond w25q80bl flash. Signed-off-by: Jamin Lin --- hw/block/m25p80.c | 3 ++- hw/block/m25p80_sfdp.c | 36 hw/block/m25p80_sfdp.h | 2 +- 3 files changed, 39 insertions(+), 2 deletions(-) diff --git a/hw/block/m25p80.c b/

[PATCH v1 00/16] Fix write incorrect data into flash in user mode

2024-10-17 Thread Jamin Lin via
change from v1: 1. Fix write incorrect data into flash in user mode. 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 and AST1030. 3. Add ast2700 smc qtest testcase to support AST2700. QEMU version: https://github.com/qemu/qemu/commit/95a16ee753d6da651fce8df876333bf7fcf134d9

[PATCH v1 07/16] test/qtest/aspeed_smc-test: Fix coding style

2024-10-17 Thread Jamin Lin via
Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin --- tests/qtest/aspeed_smc-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index c713a3700b..4673371d95 100644 --- a/tests/qtest/aspe

[PATCH v1 16/16] test/qtest/ast2700-smc-test: Support to test AST2700

2024-10-17 Thread Jamin Lin via
Add test_ast2700_evb function and reused testcases which are from aspeed_smc-test.c for AST2700 testing. The base address, flash base address and ce index of fmc_cs0 are 0x1400, 0x1 and 0, respectively. The default flash model of fmc_cs0 is "w25q01jvq" whose size is 128MB, so set jedec_

[PATCH v1 15/16] test/qtest/aspeed_smc-test: Support write page command with QPI mode

2024-10-17 Thread Jamin Lin via
Add a new testcase for write page command with QPI mode testing. Currently, only run this testcase for AST2500, AST2600 and AST1030. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_smc-test.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/tests/qtest/asp