Re: [PATCH v5 00/18] tests/qtest: Enable running qtest on Windows

2022-10-19 Thread Bin Meng
On Wed, Oct 19, 2022 at 12:00 AM Alex Bennée wrote: > > > Bin Meng writes: > > > Hi Alex, > > > > On Fri, Oct 7, 2022 at 1:31 PM Bin Meng wrote: > >> > >> On Fri, Oct 7, 2022 at 4:35 AM Alex Bennée wrote: > >> > > >> > > >> > Bin Meng writes: > >> > > >> > > In preparation to adding virtio-9p

Re: [PATCH v3 3/3] util/aio-win32: Correct the event array size in aio_poll()

2022-10-19 Thread Daniel P . Berrangé
On Wed, Aug 24, 2022 at 04:52:31PM +0800, Bin Meng wrote: > From: Bin Meng > > WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS > object handles. Correct the event array size in aio_poll() and > add a assert() to ensure it does not cause out of bound access. > > Signed-off-by: Bin

Re: [PATCH v7 02/13] blkio: add libblkio block driver

2022-10-19 Thread Stefano Garzarella
On Thu, Oct 13, 2022 at 02:58:57PM -0400, Stefan Hajnoczi wrote: libblkio (https://gitlab.com/libblkio/libblkio/) is a library for high-performance disk I/O. It currently supports io_uring, virtio-blk-vhost-user, and virtio-blk-vhost-vdpa with additional drivers under development. One of the rea

Re: [PATCH v7 09/13] block: add BlockRAMRegistrar

2022-10-19 Thread Stefano Garzarella
On Thu, Oct 13, 2022 at 02:59:04PM -0400, Stefan Hajnoczi wrote: Emulated devices and other BlockBackend users wishing to take advantage of blk_register_buf() all have the same repetitive job: register RAMBlocks with the BlockBackend using RAMBlockNotifier. Add a BlockRAMRegistrar API to do this

Re: [PATCH v7 12/13] blkio: implement BDRV_REQ_REGISTERED_BUF optimization

2022-10-19 Thread Stefano Garzarella
On Thu, Oct 13, 2022 at 02:59:07PM -0400, Stefan Hajnoczi wrote: Avoid bounce buffers when QEMUIOVector elements are within previously registered bdrv_register_buf() buffers. The idea is that emulated storage controllers will register guest RAM using bdrv_register_buf() and set the BDRV_REQ_REGI

Re: [PATCH v7 13/13] virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization hint

2022-10-19 Thread Stefano Garzarella
On Thu, Oct 13, 2022 at 02:59:08PM -0400, Stefan Hajnoczi wrote: Register guest RAM using BlockRAMRegistrar and set the BDRV_REQ_REGISTERED_BUF flag so block drivers can optimize memory accesses in I/O requests. This is for vdpa-blk, vhost-user-blk, and other I/O interfaces that rely on DMA mapp

Re: [PATCH v7 00/13] blkio: add libblkio BlockDriver

2022-10-19 Thread Stefano Garzarella
I reviewed some patches (the others I do not feel confident of my knowledge). But I think we are in a very good shape and can merge from my point of view. Thanks again for this work, Stefano On Thu, Oct 13, 2022 at 02:58:55PM -0400, Stefan Hajnoczi wrote: v7: - Add nvme-io_uring and virtio-bl

[PATCH v4 3/3] util/aio-win32: Correct the event array size in aio_poll()

2022-10-19 Thread Bin Meng
From: Bin Meng WaitForMultipleObjects() can only wait for MAXIMUM_WAIT_OBJECTS object handles. Correct the event array size in aio_poll() and add a assert() to ensure it does not cause out of bound access. Signed-off-by: Bin Meng Reviewed-by: Stefan Weil Reviewed-by: Marc-André Lureau Reviewe

Re: [PATCH v3 2/2] error handling: Use RETRY_ON_EINTR() macro where applicable

2022-10-19 Thread Christian Schoenebeck
On Tuesday, October 18, 2022 10:43:41 AM CEST Nikita Ivanov wrote: > There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h > which handles the same while loop. > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415 > > Signed-off-by: Nikita Ivanov > --- > block/file-posix.c| 3

RE: [RFC 7/7] migration: call qemu_savevm_state_pending_exact() with the guest stopped

2022-10-19 Thread Yishai Hadas
> From: Qemu-devel bounces+yishaih=nvidia@nongnu.org> On Behalf Of Jason Gunthorpe > Sent: Tuesday, 18 October 2022 15:23 > To: Joao Martins > Cc: quint...@redhat.com; Alex Williamson ; > Eric Blake ; Stefan Hajnoczi ; > Fam Zheng ; qemu-s3...@nongnu.org; Cornelia Huck > ; Thomas Huth ; Vladi