Re: [PATCH v2 1/2] file-posix: add the tracking of the zones wp

2022-10-05 Thread Damien Le Moal
On 10/5/22 10:44, Damien Le Moal wrote: > On 9/29/22 18:31, Sam Li wrote: >> Since Linux doesn't have a user API to issue zone append operations to >> zoned devices from user space, the file-posix driver is modified to add >> zone append emulation using regular writes. To do this, the file-posix >>

Re: [PATCH v2 1/2] file-posix: add the tracking of the zones wp

2022-10-05 Thread Sam Li
Damien Le Moal 于2022年10月5日周三 15:34写道: > > On 10/5/22 10:44, Damien Le Moal wrote: > > On 9/29/22 18:31, Sam Li wrote: > >> Since Linux doesn't have a user API to issue zone append operations to > >> zoned devices from user space, the file-posix driver is modified to add > >> zone append emulation

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Andrey Zhadchenko
On 10/4/22 21:13, Stefan Hajnoczi wrote: On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio-blk is quite fast, there is still some room for improvements. Disk latency can be reduced if we handle virito-blk requests in host kernel so we avoid a lot of syscalls

Re: [PATCH v6] 9pfs: use GHashTable for fid table

2022-10-05 Thread Christian Schoenebeck
On Dienstag, 4. Oktober 2022 14:54:16 CEST Christian Schoenebeck wrote: > On Dienstag, 4. Oktober 2022 12:41:21 CEST Linus Heckemann wrote: > > The previous implementation would iterate over the fid table for > > lookup operations, resulting in an operation with O(n) complexity on > > the number of

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Andrey Zhadchenko
On 10/4/22 21:26, Stefan Hajnoczi wrote: On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio-blk is quite fast, there is still some room for improvements. Disk latency can be reduced if we handle virito-blk requests in host kernel so we avoid a lot of sysca

Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-05 Thread Kevin Wolf
Am 22.09.2022 um 10:49 hat Paolo Bonzini geschrieben: > Callers of coroutine_fn must be coroutine_fn themselves, or the call > must be within "if (qemu_in_coroutine())". Apply coroutine_fn to > functions where this holds. > > Reviewed-by: Alberto Faria > Reviewed-by: Eric Blake > Signed-off-by:

Re: [PATCH 13/26] parallels: add missing coroutine_fn annotations

2022-10-05 Thread Kevin Wolf
Am 22.09.2022 um 10:49 hat Paolo Bonzini geschrieben: > Callers of coroutine_fn must be coroutine_fn themselves, or the call > must be within "if (qemu_in_coroutine())". Apply coroutine_fn to > functions where this holds. > > Reviewed-by: Alberto Faria > Signed-off-by: Paolo Bonzini > --- > bl

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Andrey Zhadchenko
On 10/4/22 22:00, Stefan Hajnoczi wrote: On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio-blk is quite fast, there is still some room for improvements. Disk latency can be reduced if we handle virito-blk requests in host kernel so we avoid a lot of sysca

Re: [RFC PATCH 1/1] block: add vhost-blk backend

2022-10-05 Thread Andrey Zhadchenko
Thanks for the review! On 10/4/22 21:45, Stefan Hajnoczi wrote: On Mon, Jul 25, 2022 at 11:55:27PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio is quite fast, there is still some room for improvements. Disk latency can be reduced if we handle virito-blk requests in host kernel istead of

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2022 at 01:28:14PM +0300, Andrey Zhadchenko wrote: > > > On 10/4/22 21:26, Stefan Hajnoczi wrote: > > On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: > > > Although QEMU virtio-blk is quite fast, there is still some room for > > > improvements. Disk latency can

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2022 at 12:14:18PM +0300, Andrey Zhadchenko wrote: > On 10/4/22 21:13, Stefan Hajnoczi wrote: > > On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: > > > Although QEMU virtio-blk is quite fast, there is still some room for > > > improvements. Disk latency can be red

Re: [RFC patch 0/1] block: vhost-blk backend

2022-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2022 at 02:50:06PM +0300, Andrey Zhadchenko wrote: > > > On 10/4/22 22:00, Stefan Hajnoczi wrote: > > On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: > > > Although QEMU virtio-blk is quite fast, there is still some room for > > > improvements. Disk latency can

Re: [RFC PATCH 1/1] block: add vhost-blk backend

2022-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2022 at 04:06:58PM +0300, Andrey Zhadchenko wrote: > Thanks for the review! > > On 10/4/22 21:45, Stefan Hajnoczi wrote: > > On Mon, Jul 25, 2022 at 11:55:27PM +0300, Andrey Zhadchenko wrote: > > > Although QEMU virtio is quite fast, there is still some room for > > > improvements.

Re: [PATCH 02/26] block: add missing coroutine_fn annotations

2022-10-05 Thread Alberto Campinho Faria
On Sat, Sep 24, 2022 at 2:42 PM Paolo Bonzini wrote: > Because at the time I wrote the patch, blk_pwrite_zeroes() was a > coroutine_fn. :) > > It is called from bdrv_co_create_opts_simple which is coroutine_fn and > performs I/O, so it should be a coroutine_fn. I have a few more patches > to not g

Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations

2022-10-05 Thread Paolo Bonzini
Il mer 5 ott 2022, 06:32 Kevin Wolf ha scritto: > Hm... blkdebug_debug_event() is called from bdrv_debug_event(), which is > not coroutine_fn. And I think that it's not coroutine_fn is correct: > For example, with 'qemu-img snapshot -c' you get img_snapshot() -> > bdrv_snapshot_create() -> qcow2_

Re: [PATCH v2 1/2] file-posix: add the tracking of the zones wp

2022-10-05 Thread Damien Le Moal
On 10/5/22 17:30, Sam Li wrote: > Damien Le Moal 于2022年10月5日周三 15:34写道: >> >> On 10/5/22 10:44, Damien Le Moal wrote: >>> On 9/29/22 18:31, Sam Li wrote: Since Linux doesn't have a user API to issue zone append operations to zoned devices from user space, the file-posix driver is modifie