Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-04 Thread Akihiko Odaki
On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > pci_add_capability appears most PCI devices. Its error handling required > > lots of code, and led to inconsistent behaviors such as: > > - passing error_abort > > - passing error_fatal > > - asserting the ret

Re: [PATCH] 9pfs: use GHashMap for fid table

2022-09-04 Thread Philippe Mathieu-Daudé via
Hi Linus, On 3/9/22 17:03, Linus Heckemann wrote: The previous implementation would iterate over the fid table for lookup operations, resulting in an operation with O(n) complexity on the number of open files and poor cache locality -- for nearly every open, stat, read, write, etc operation. Th

Re: [PATCH 6/8] tests: Fix error strings

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 18:51, Juan Quintela wrote: They were copy-pasted from e1000e and never changed. Signed-off-by: Juan Quintela --- tests/qtest/e1000-test.c | 2 +- tests/qtest/es1370-test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/8] qtest: Set "-net none" in qtest_init()

2022-09-04 Thread Philippe Mathieu-Daudé via
On 2/9/22 18:51, Juan Quintela wrote: This way, we don't have networking by default. If test needs it, configure it. Signed-off-by: Juan Quintela --- tests/qtest/bios-tables-test.c | 2 +- tests/qtest/libqtest.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

Re: [PATCH 2/2] vvfat: allow spaces in file names

2022-09-04 Thread Philippe Mathieu-Daudé via
On 3/9/22 18:23, Hervé Poussineau wrote: In R/W mode, files with spaces were never created on host side. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1176 Fixes: c79e243ed67683d6d06692bd7040f7394da178b0 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2 +- 1 file changed, 1 in

Re: [PATCH v2 1/8] virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size

2022-09-04 Thread Raphael Norwitz
> I can squash the first four if that would be better. I think so. Just may be easier for other reviewers :)