Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-10 Thread Paolo Bonzini
On 8/6/22 17:32, Vladimir Sementsov-Ogievskiy wrote: if I understand correctly you suggest: .prepare = check and then change aiocontext .abort = revert aiocontext change .commit = nothing Yes. And that's is how it used actually now in transactions, for example:   bdrv_attach_child_common (whi

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-10 Thread Stefan Berger
On 8/3/22 04:52, Cédric Le Goater wrote: On 8/3/22 04:32, Iris Chen wrote: From: Iris Chen A commit log telling us about this new device would be good to have. Signed-off-by: Iris Chen ---   configs/devices/arm-softmmu/default.mak |   1 +   hw/arm/Kconfig  |   5 +

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-10 Thread Stefan Berger
On 8/3/22 04:52, Cédric Le Goater wrote: On 8/3/22 04:32, Iris Chen wrote: From: Iris Chen +++ b/hw/tpm/tpm_tis_spi.c @@ -0,0 +1,311 @@ +#include "qemu/osdep.h" +#include "hw/qdev-properties.h" +#include "migration/vmstate.h" +#include "hw/acpi/tpm.h" +#include "tpm_prop.h" +#include "t

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-10 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > This is just moving qapi-gen.py and related subdir to qemu-common, to >> > ease review and proceed step by step. The fol