Re: [PATCH v2] hw/nvme: Add helper functions for qid-db conversion

2022-08-04 Thread Klaus Jensen
On Aug 3 09:58, Jinhao Fan wrote: > With the introduction of shadow doorbell and ioeventfd, we need to do > frequent conversion between qid and its doorbell offset. The original > hard-coded calculation is confusing and error-prone. Add several helper > functions to do this task. > > Signed-off-b

Re: [PATCH v2 2/2] virtio: remove unnecessary host_features in ->get_features()

2022-08-04 Thread Cornelia Huck
On Wed, Aug 03 2022, Stefan Hajnoczi wrote: > Since at least commit 6b8f1020540c27246277377aa2c3331ad2bfb160 ("virtio: > move host_features") the ->get_features() function has been called with > host_features as an argument. > > Some devices manually add host_features in ->get_features() although

Re: [PATCH v2 1/2] virtio: document vdc->get_features() callback

2022-08-04 Thread Cornelia Huck
On Wed, Aug 03 2022, Stefan Hajnoczi wrote: > Suggested-by: Cornelia Huck > Signed-off-by: Stefan Hajnoczi > --- > include/hw/virtio/virtio.h | 20 > 1 file changed, 20 insertions(+) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index db1c0ddf6

Re: [RFC v2 00/10] Introduce an extensible static analyzer

2022-08-04 Thread Marc-André Lureau
Hi On Fri, Jul 29, 2022 at 5:01 PM Alberto Faria wrote: > > This series introduces a static analyzer for QEMU. It consists of a > single static-analyzer.py script that relies on libclang's Python > bindings, and provides a common framework on which arbitrary static > analysis checks can be develo

Re: [PATCH v10 08/21] jobs: add job lock in find_* functions

2022-08-04 Thread Kevin Wolf
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > Both blockdev.c and job-qmp.c have TOC/TOU conditions, because > they first search for the job and then perform an action on it. > Therefore, we need to do the search + action under the same > job mutex critical section. > > Note

Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests

2022-08-04 Thread Kevin Wolf
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > Add missing job synchronization in the unit tests, with > explicit locks. > > We are deliberately using _locked functions wrapped by a guard > instead of a normal call because the normal call will be removed > in future, as the o

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 28 Jul 2022 at 15:50, Markus Armbruster wrote: >> Kevin Wolf writes: >> > >> > But if you have more than one device, it becomes hard to predict which >> > device gets which backend - it depends on the initialisation order in >> > the code then, >> >> Really? Boa

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Daniel P . Berrangé
On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote: > On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: > > > > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: > > > An OTP device isn't really a parallel flash, and neither are eFuses. > > > More fast-and-lose use of IF_PFLASH ma

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote: >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: >> > >> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: >> > > An OTP device isn't really a parallel flash, and neither are eFuses. >> > > Mo

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Daniel P . Berrangé
On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote: > >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: > >> > > >> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: > >> >

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote: >> >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote: >> >> > >> >> > Am 18.07.2022 um 11:49 hat

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-04 Thread Daniel P . Berrangé
On Thu, Aug 04, 2022 at 05:30:40PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Peter Maydell wrote: > >> >> On Wed, 27

Re: [PATCH v10 10/21] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU

2022-08-04 Thread Kevin Wolf
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > Once job lock is used and aiocontext is removed, mirror has > to perform job operations under the same critical section, > using the helpers prepared in previous commit. > > Note: at this stage, job_{lock/unlock} and job lock gua

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-04 Thread Dan Zhang
On Tue, Aug 2, 2022 at 7:25 AM Cédric Le Goater wrote: > > On 7/31/22 00:06, Peter Delevoryas wrote: > > On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: > >> On 7/29/22 19:30, Peter Delevoryas wrote: > >>> On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > H

Re: [PATCH v10 11/21] jobs: group together API calls under the same job lock

2022-08-04 Thread Kevin Wolf
Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > Now that the API offers also _locked() functions, take advantage > of it and give also the caller control to take the lock and call > _locked functions. > > This makes sense especially when we have for loops, because it > makes n

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Dan Zhang
On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > > On 8/3/22 04:32, Iris Chen wrote: > > > From: Iris Chen > > > > A commit log telling us about this new device would be good to have. > > > > > > > Signed-off-by: Iris

Re: [PATCH] util/aio: Defer disabling poll mode as long as possible

2022-08-04 Thread Stefan Hajnoczi
On Sun, Jul 10, 2022 at 08:08:49PM +0800, Chao Gao wrote: > When we measure FIO read performance (cache=writethrough, bs=4k, > iodepth=64) in VMs, ~80K/s notifications (e.g., EPT_MISCONFIG) are observed > from guest to qemu. > > It turns out those frequent notificatons are caused by interference f

[PULL for-7.1 1/1] virtiofsd: Fix format strings

2022-08-04 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Message-Id: <20220804074833.892604-1...@weilnetz.de> Signed-off-by: Stefan Hajnoczi --- tools/virtiofsd/fuse_lowlevel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lo

[PULL for-7.1 0/1] Block patches

2022-08-04 Thread Stefan Hajnoczi
The following changes since commit 2480f3bbd03814b0651a1f74959f5c6631ee5819: Merge tag 'linux-user-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-03 08:32:44 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block

Re: [PATCH v2 09/15] util: move 256-by-128 division helpers to int128

2022-08-04 Thread Lucas Mateus Martins Araujo e Castro
On 12/07/2022 06:35, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Break a cyclic dependency between int128 and host-utils. Reviewed-by: Lucas Mateus Castro Signed-off-by: Marc-André Lureau --- include/qemu/host-utils.h | 3 - include/qemu/int128.h | 3 + util/host-

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Peter Delevoryas
On Thu, Aug 04, 2022 at 11:07:10AM -0700, Dan Zhang wrote: > On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > > > On 8/3/22 04:32, Iris Chen wrote: > > > > From: Iris Chen > > > > > > A commit log telling us about

Re: [PULL for-7.1 0/1] Block patches

2022-08-04 Thread Richard Henderson
On 8/4/22 12:02, Stefan Hajnoczi wrote: The following changes since commit 2480f3bbd03814b0651a1f74959f5c6631ee5819: Merge tag 'linux-user-for-7.1-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-08-03 08:32:44 -0700) are available in the Git repository at: htt

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Dan Zhang
On Thu, Aug 4, 2022 at 4:21 PM Peter Delevoryas wrote: > > On Thu, Aug 04, 2022 at 11:07:10AM -0700, Dan Zhang wrote: > > On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > > > > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > > > > On 8/3/22 04:32, Iris Chen wrote: