With the introduction of shadow doorbell and ioeventfd, we need to do
frequent conversion between qid and its doorbell offset. The original
hard-coded calculation is confusing and error-prone. Add several helper
functions to do this task.
Signed-off-by: Jinhao Fan
---
hw/nvme/ctrl.c | 61 +++
From: Klaus Jensen
A set of fixes/changes to the ioeventfd support.
Klaus Jensen (3):
hw/nvme: skip queue processing if notifier is cleared
hw/nvme: unregister the event notifier handler on the main loop
hw/nvme: do not enable ioeventfd by default
hw/nvme/ctrl.c | 12 +---
1 file
From: Klaus Jensen
While it is safe to process the queues when they are empty, skip it if
the event notifier callback was invoked spuriously.
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl
From: Klaus Jensen
Make sure the notifier handler is unregistered in the main loop prior to
cleaning it up.
Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/nvme/ctr
From: Klaus Jensen
Do not enable ioeventfd by default. Let the feature mature a bit before
we consider enabling it by default.
Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Am 27.07.2022 um 17:56 hat Alex Bennée geschrieben:
> This bit is unused in actual VirtIO feature negotiation and should
> only appear in the vhost-user messages between master and slave.
>
> [AJB: experiment, this doesn't break the tests but I'm not super
> confident of the range of tests]
>
> S
On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
>
> Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
> > An OTP device isn't really a parallel flash, and neither are eFuses.
> > More fast-and-lose use of IF_PFLASH may exist in the tree, and maybe of
> > other interface types, too.
> >
> >
Kevin Wolf writes:
> Am 27.07.2022 um 17:56 hat Alex Bennée geschrieben:
>> This bit is unused in actual VirtIO feature negotiation and should
>> only appear in the vhost-user messages between master and slave.
>>
>> [AJB: experiment, this doesn't break the tests but I'm not super
>> confident
Jason Wang writes:
> 在 2022/7/27 03:21, Alex Bennée 写道:
>> This bit is unused in actual VirtIO feature negotiation and should
>> only appear in the vhost-user messages between master and slave.
>
>
> I might be wrong, but this is actually used between master and slave
> not the device and drive
On 7/27/22 12:06, Vladimir Sementsov-Ogievskiy wrote:
The following changes since commit f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d:
Merge tag 'pull-target-arm-20220726' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-26
08:32:01 -0700)
are available in the Git repos
Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben:
> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
> >
> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
> > > An OTP device isn't really a parallel flash, and neither are eFuses.
> > > More fast-and-lose use of IF_PFLASH may exist i
On Thu, 28 Jul 2022 at 14:30, Kevin Wolf wrote:
>
> Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben:
> > On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
> > > If the existing types aren't good enough (I don't have an opinion on
> > > whether IF_PFLASH is a good match), let's add a new one. B
On 7/28/22 15:29, Kevin Wolf wrote:
Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben:
On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
An OTP device isn't really a parallel flash, and neither are eFuses.
More fast-and-lose use of I
On 7/11/22 14:07, Denis V. Lunev wrote:
Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from
the first glance, but it has changed things a lot. 'libvirt' uses it to
detect that it should follow new initialization way and this changes
things considerably. With this procedure fo
On Thu, 28 Jul 2022 at 15:50, Markus Armbruster wrote:
> Kevin Wolf writes:
> >
> > But if you have more than one device, it becomes hard to predict which
> > device gets which backend - it depends on the initialisation order in
> > the code then,
>
> Really? Board code should use IF_OTHER devic
Kevin Wolf writes:
> Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben:
>> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
>> >
>> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
>> > > An OTP device isn't really a parallel flash, and neither are eFuses.
>> > > More fast-and-lose
On Thu, Jul 28, 2022 at 10:25:19AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> A set of fixes/changes to the ioeventfd support.
Series looks good.
Reviewed-by: Keith Busch
at 4:25 PM, Klaus Jensen wrote:
> From: Klaus Jensen
>
> A set of fixes/changes to the ioeventfd support.
>
> Klaus Jensen (3):
> hw/nvme: skip queue processing if notifier is cleared
> hw/nvme: unregister the event notifier handler on the main loop
> hw/nvme: do not enable ioeventfd by def
On Thu, Jul 28, 2022 at 7:28 AM Andrey Zhadchenko
wrote:
> On 7/27/22 16:06, Stefano Garzarella wrote:
> > On Tue, Jul 26, 2022 at 04:15:48PM +0200, Denis V. Lunev wrote:
> >> On 26.07.2022 15:51, Michael S. Tsirkin wrote:
> >>> On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote:
>
Am 28.07.2022 um 16:50 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 28.07.2022 um 11:46 hat Peter Maydell geschrieben:
> >> On Wed, 27 Jul 2022 at 20:03, Kevin Wolf wrote:
> >> >
> >> > Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben:
> >> > > An OTP device isn't rea
On 28.07.2022 16:42, Vladimir Sementsov-Ogievskiy wrote:
On 7/11/22 14:07, Denis V. Lunev wrote:
Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from
the first glance, but it has changed things a lot. 'libvirt' uses it to
detect that it should follow new initialization way an
Hey everyone,
I have been working on a project to add support for SPI-based TPMs in QEMU.
Currently, most of our vboot platforms using a SPI-based TPM use the Linux
SPI-GPIO driver to "bit-bang" the SPI protocol. This is because the Aspeed
SPI controller (modeled in QEMU under hw/ssi/aspeed_smc.
With SPI-GPIO we don't have the input bits until
all 8 bits of the output have been shifted out,
so we have to prime the MISO with bogus values (0xFF).
Signed-off-by: Iris Chen
---
hw/block/m25p80.c| 29 -
hw/ssi/ssi.c | 4
include/hw/ssi/ssi.h | 5
Signed-off-by: Iris Chen
---
hw/ssi/spi_gpio.c | 166 ++
include/hw/ssi/spi_gpio.h | 38 +
2 files changed, 204 insertions(+)
create mode 100644 hw/ssi/spi_gpio.c
create mode 100644 include/hw/ssi/spi_gpio.h
diff --git a/hw/ssi/spi_gpio.c b/
On Thu, Jul 28, 2022 at 04:23:19PM -0700, Iris Chen wrote:
> Hey everyone,
>
> I have been working on a project to add support for SPI-based TPMs in QEMU.
> Currently, most of our vboot platforms using a SPI-based TPM use the Linux
> SPI-GPIO driver to "bit-bang" the SPI protocol. This is because
25 matches
Mail list logo
