[PULL 03/54] acpi: fdc-isa: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

2022-06-10 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Acked-by: Gerd Hoffmann Message-Id: <20220608135340.3304695-4-imamm...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/fdc-isa.c | 16 ++-- hw/i386/acpi-build.c | 1 - 2 files changed,

[PULL 53/54] hw/vhost-user-scsi|blk: set `supports_config` flag correctly

2022-06-10 Thread Michael S. Tsirkin
From: Changpeng Liu Currently vhost-user-scsi driver doesn't allow to change the configuration space of virtio_scsi, while vhost-user-blk support that, so here we set the flag in vhost-user-blk driver and unset it in vhost-user-scsi. Signed-off-by: Changpeng Liu Message-Id: <20220525125540.5097

Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

2022-06-10 Thread Peter Maydell
On Thu, 9 Jun 2022 at 22:41, Hao Wu wrote: > > Creating 1GB image for a simple qtest is unnecessary > and could lead to failures. We reduce the image size > to 1MB to reduce the test overhead. > > Signed-off-by: Hao Wu > --- > tests/qtest/npcm7xx_sdhci-test.c | 2 +- > 1 file changed, 1 insertio

Re: [PATCH] tests/qtest: Reduce npcm7xx_sdhci test image size

2022-06-10 Thread Philippe Mathieu-Daudé via
On 9/6/22 23:41, Hao Wu wrote: Creating 1GB image for a simple qtest is unnecessary and could lead to failures. We reduce the image size to 1MB to reduce the test overhead. Signed-off-by: Hao Wu --- tests/qtest/npcm7xx_sdhci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Revi

Re: [PATCH] qsd: Do not use error_report() before monitor_init

2022-06-10 Thread Philippe Mathieu-Daudé via
On 9/6/22 14:28, Hanna Reitz wrote: error_report() only works once monitor_init_globals_core() has been called, which is not the case when parsing the --daemonize option. Use fprintf(stderr, ...) instead. Fixes: 2525edd85fec53e23fda98974a15e3b3c8957596 ("qsd: Add --daemonize") Signed-off-by: Ha

Re: [PATCH] qsd: Do not use error_report() before monitor_init

2022-06-10 Thread Peter Maydell
On Thu, 9 Jun 2022 at 15:26, Hanna Reitz wrote: > > error_report() only works once monitor_init_globals_core() has been > called, which is not the case when parsing the --daemonize option. Use > fprintf(stderr, ...) instead. > > Fixes: 2525edd85fec53e23fda98974a15e3b3c8957596 ("qsd: Add --daemoni

[RFC PATCH v2 0/7] tests: run python tests under a venv

2022-06-10 Thread John Snow
Hi, here's another RFC for bringing external Python dependencies to the QEMU test suite. This patchset is not without some problems that need to be solved, but I've been sitting on these long enough and they need to see the light of day. Problems I am aware of, and there's a few: - Ubuntu 18.04

[RFC PATCH v2 7/7] iotests: self-bootstrap testing venv

2022-06-10 Thread John Snow
When iotests are invoked manually from e.g. $build/tests/qemu-iotests/check, it is not necessarily guaranteed that we'll have run 'check-venv' yet. With this patch, teach testenv.py how to create its own environment. Note: this self-bootstrapping is fairly rudimentary and will miss certain trigge

[RFC PATCH v2 4/7] tests/vm: add venv pre-requisites to VM building recipes

2022-06-10 Thread John Snow
Ubuntu needs "python3-venv" in order to create virtual environments, and NetBSD needs "py37-pip" in order to do the same. Signed-off-by: John Snow --- tests/vm/netbsd | 1 + tests/vm/ubuntu.i386 | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/vm/netbsd b/

[RFC PATCH v2 5/7] tests: add 'check-venv' as a dependency of 'make check'

2022-06-10 Thread John Snow
This patch adds the 'check-venv' target as a requisite of all meson driven check-* targets. As of this commit, it will only install the "qemu" namespace package from the source tree, and nothing else. In the future, the "qemu" namespace package in qemu.git will begin to require an external qemu.qm

[RFC PATCH v2 6/7] iotests: use tests/venv for running tests

2022-06-10 Thread John Snow
Essentially, the changes to testenv.py here mimic the changes that occur when you "source venv/bin/activate.fish" or similar. (1) update iotest's internal notion of which python binary to use, (2) export the VIRTUAL_ENV variable, (3) front-load the venv/bin directory to PATH. If the venv director

[RFC PATCH v2 3/7] tests: Remove spurious pip warnings on Ubuntu20.04

2022-06-10 Thread John Snow
The version of pip ("20.0.2") that ships with Ubuntu 20.04 has a bug where it will try to attempt building a wheel even if the "wheel" python package that enables it to do so is not installed. Even though pip continues gracefully from source, The result is a lot of irrelevant failure output. Upstr

[RFC PATCH v2 2/7] tests: pythonize test venv creation

2022-06-10 Thread John Snow
This splits the venv creation logic out of the Makefile and into a Python script. One reason for doing this is to be able to call the venv bootstrapper from places outside of the Makefile, e.g. configure and iotests. Another reason is to be able to add "offline" logic to modify the behavior of the

[RFC PATCH v2 1/7] tests: create optional tests/venv dependency groups

2022-06-10 Thread John Snow
This patch uses a dummy package and setup.cfg/setup.py files to manage optional dependency groups for the test venv specification. Now, there's a core set of dependencies which for now includes just "qemu" (but soon, qemu.qmp) and a separate, optional 'avocado' group that includes avocado-framework