Re: [PATCH v5 00/16] host: Support macOS 12

On 18/2/22 16:26, Peter Maydell wrote: On Mon, 14 Feb 2022 at 18:56, Philippe Mathieu-Daudé wrote: Few patches to be able to build QEMU on macOS 12 (Monterey). This basically consists of adapting deprecated APIs. CI job added to avoid bitrotting. Hi; I'm going to take the "obviously correc

Re: [PATCH v5 00/16] host: Support macOS 12

On Fri, 25 Feb 2022 at 09:26, Philippe Mathieu-Daudé wrote: > If there is no objections I'll send a PR with the non-cocoa macOS > fixes for 7.0, so Monterey users can build QEMU without having to > disable failing features and flooded by hundreds of warnings. We should definitely get this in for

Re: [PULL 0/6] Python patches

On Wed, 23 Feb 2022 at 22:09, John Snow wrote: > > The following changes since commit 31e3caf21b6cdf54d11f3744b8b341f07a30b5d7: > > Merge remote-tracking branch > 'remotes/lvivier-gitlab/tags/trivial-branch-for-7.0-pull-request' into > staging (2022-02-22 20:17:09 +) > > are available in t

Re: [PATCH v4] tests/qtest: add qtests for npcm7xx sdhci

On Thu, 24 Feb 2022 at 19:03, Hao Wu wrote: > > From: Shengtan Mao > > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Signed-off-by: Shengtan Mao > Signed-off-by: Patrick Venture > Signed-off-by: Hao Wu > --- > v4: > * use strncmp to compare fixed length strings > v3: > * fixup compilati

Re: [PATCH v5 13/16] ui/cocoa: Add Services menu

On Mon, 14 Feb 2022 at 18:58, Philippe Mathieu-Daudé wrote: > > From: Akihiko Odaki > > Services menu functionality of Cocoa is described at: > https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ > > Signed-off-by: Akihiko Odaki > Reviewed-by: Philippe Mathie

Re: [PATCH v5 16/16] gitlab-ci: Support macOS 12 via cirrus-run

On Mon, 14 Feb 2022 at 18:58, Philippe Mathieu-Daudé wrote: > > Add support for macOS 12 build on Cirrus-CI, similarly to commit > 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"), > but with the following differences: > - Enable modules (configure --enable-modules) > - Do not run

Re: [PATCH v5 15/16] lcitool: refresh

On Mon, 14 Feb 2022 at 18:58, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/ubuntu1804.docker | 2 -- > tests/docker/dockerfiles/ubuntu2004.docker | 2 -- > 2 files changed, 4 deletions(-) What's happening here? The commit message only

Re: [PATCH v5 05/16] hvf: Fix OOB write in RDTSCP instruction decode

On Mon, 14 Feb 2022 at 18:57, Philippe Mathieu-Daudé wrote: > > From: Cameron Esfahani > > A guest could craft a specific stream of instructions that will have QEMU > write 0xF9 to inappropriate locations in memory. Add additional asserts > to check for this. Generate a #UD if there are more th

Re: [PATCH v4] tests/qtest: add qtests for npcm7xx sdhci

I have sent an updated version that uses memcmp() On Fri, Feb 25, 2022 at 3:44 AM Peter Maydell wrote: > On Thu, 24 Feb 2022 at 19:03, Hao Wu wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: Patrick

[PATCH v5] tests/qtest: add qtests for npcm7xx sdhci

From: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Signed-off-by: Shengtan Mao Signed-off-by: Patrick Venture --- v5 * use memcmp to compare whether strings are expected v4 * use strncmp instead of strcmp v3: * fixup compilation from missing macro value v2: * update copyright

Re: [PATCH v2 2/3] iotests: Allow using QMP with the QSD

On Wed, Feb 16, 2022 at 11:53:54AM +0100, Hanna Reitz wrote: > Add a parameter to optionally open a QMP connection when creating a > QemuStorageDaemon instance. > > Signed-off-by: Hanna Reitz > --- > tests/qemu-iotests/iotests.py | 32 +++- > 1 file changed, 31 insert

Re: [PATCH v4] tests/qtest: add qtests for npcm7xx sdhci

On Fri, Feb 25, 2022 at 9:45 AM Hao Wu wrote: > I have sent an updated version that uses memcmp() > > On Fri, Feb 25, 2022 at 3:44 AM Peter Maydell > wrote: > >> On Thu, 24 Feb 2022 at 19:03, Hao Wu wrote: >> > >> > From: Shengtan Mao >> > >> > Reviewed-by: Hao Wu >> > Reviewed-by: Chris Raue

[PATCH v3 00/11] blockdev-replace

Hi all! Finally, that's a proposal for new interface for filter insertion, which provides generic way for inserting between different block graph nodes, like BDS nodes, block exports and block devices. v3: - add transaction support - add test, that shows transactional filter insertion in diff

[PATCH v3 01/11] block-backend: blk_root(): drop const specifier on return type

We'll need get non-const child pointer for graph modifications in further commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 2 +- block/block-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sysemu/block-bac

[PATCH v3 06/11] qapi: add x-blockdev-replace transaction action

Support blockdev-replace in a transaction. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/transaction.json | 14 +- blockdev.c| 34 ++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/qapi/transaction.json b/qapi/transac

[PATCH v3 02/11] block/export: add blk_by_export_id()

Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 1 + block/export/export.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index 904d70f49c..250c7465a5 100644 --- a/

[PATCH v3 04/11] block: bdrv_replace_child_bs(): move to external transaction

We'll need this functionality as part of external transaction, so make the whole function to be transaction action. For this we need to introduce a transaction action helper: bdrv_drained(), which calls bdrv_drained_begin() and postpone bdrv_drained_end() to .clean() phase. Signed-off-by: Vladimir

[PATCH v3 07/11] block: bdrv_get_xdbg_block_graph(): report export ids

Currently for block exports we report empty blk names. That's not good. Let's try to find corresponding block export and report its id. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/export.h | 1 + block.c | 4 block/export/export.c | 13

[PATCH v3 05/11] qapi: add x-blockdev-replace command

Add a command that can replace bs in following BdrvChild structures: - qdev blk root child - block-export blk root child - any child BlockDriverState selected by child-name Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 62 b

[PATCH v3 03/11] block: make bdrv_find_child() function public

To be reused soon. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 1 + block.c | 13 + blockdev.c| 14 -- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/block/block_int.h b/include/b

[PATCH v3 09/11] iotests.py: introduce VM.assert_edges_list() method

Add an alternative method to check block graph, to be used in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index c

[PATCH v3 08/11] iotests.py: qemu_img_create: use imgfmt by default

Less typing: let's use imgfmt by default if user doesn't specify neither -f nor --image-opts. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 6b

[PATCH v3 10/11] iotests.py: add VM.qmp_check() helper

I'm tired of this pattern being everywhere. Let's add a helper. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 1b48c5b9c9..dd33970454 100644

[PATCH v3 11/11] iotests: add filter-insertion

Demonstrate new API for filter insertion and removal. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/filter-insertion | 253 ++ tests/qemu-iotests/tests/filter-insertion.out | 5 + 2 files changed, 258 insertions(+) create mode 100755 tests/qemu-i

Re: [PATCH v3 00/11] blockdev-replace

26.02.2022 02:42, Vladimir Sementsov-Ogievskiy wrote: Hi all! Finally, that's a proposal for new interface for filter insertion, which provides generic way for inserting between different block graph nodes, like BDS nodes, block exports and block devices. v3: - add transaction support - ad

Re: [PATCH 1/3] util & iothread: Introduce event-loop abstract class

On 2/24/22 10:48, Stefan Hajnoczi wrote: On Mon, Feb 21, 2022 at 06:08:43PM +0100, Nicolas Saenz Julienne wrote: diff --git a/qom/meson.build b/qom/meson.build index 062a3789d8..c20e5dd1cb 100644 --- a/qom/meson.build +++ b/qom/meson.build @@ -4,6 +4,7 @@ qom_ss.add(files( 'object.c', 'o