Re: [PATCH v8 8/8] hmp: add virtio commands

2021-11-05 Thread Markus Armbruster
Jonah Palmer writes: > From: Laurent Vivier > > This patch implements the HMP versions of the virtio QMP commands. > > Signed-off-by: Jonah Palmer > --- > docs/system/monitor.rst | 2 + > hmp-commands-virtio.hx | 250 ++ > hmp-commands.hx | 10 ++ >

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: >> This series introduces new QMP/HMP commands to dump the status of a >> virtio device at different levels. >> >> [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches >> are from Laurent

Re: [PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio

2021-11-05 Thread Jonah Palmer
On 11/4/21 11:15, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command lists all the instances of VirtIODevice with their QOM paths and virtio type/name. Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 +++

Re: [PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status

2021-11-05 Thread Jonah Palmer
On 11/4/21 11:37, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature bi

Re: [PATCH v8 8/8] hmp: add virtio commands

2021-11-05 Thread Jonah Palmer
On 11/5/21 03:23, Markus Armbruster wrote: Jonah Palmer writes: From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 250 ++ hmp-

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-05 Thread Łukasz Gieryk
On Thu, Nov 04, 2021 at 04:48:43PM +0100, Łukasz Gieryk wrote: > On Wed, Nov 03, 2021 at 01:07:31PM +0100, Klaus Jensen wrote: > > On Oct 7 18:24, Lukasz Maniak wrote: > > > From: Łukasz Gieryk > > > > > > With two new properties (sriov_max_vi_per_vf, sriov_max_vq_per_vf) one > > > can configure

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Markus Armbruster
This series increases total size (text + data + bss) by 134KiB for me. QAPI clearly was not designed for space efficiency. Still, it's a drop in the bucket. If debugging commands ever become a burden for certain use cases, we can think about making them compile-time optional.

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-11-05 Thread Jonah Palmer
On 11/5/21 03:26, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Ori

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-05 Thread Łukasz Gieryk
On Fri, Nov 05, 2021 at 09:46:28AM +0100, Łukasz Gieryk wrote: > On Thu, Nov 04, 2021 at 04:48:43PM +0100, Łukasz Gieryk wrote: > > On Wed, Nov 03, 2021 at 01:07:31PM +0100, Klaus Jensen wrote: > > > On Oct 7 18:24, Lukasz Maniak wrote: > > > > From: Łukasz Gieryk > > > > > > > > With two new pr

Re: [PATCH 5/7] block: Pass BdrvChild ** to replace_child_noperm

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > bdrv_replace_child_noperm() modifies BdrvChild.bs, and can potentially > set it to NULL. That is dangerous, because BDS parents generally assume > that their children's .bs pointer is never NULL. We therefore want to > let bdrv_replace_child_n

Re: [PATCH 0/7] block: Attempt on fixing 030-reported errors

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > Hanna Reitz (7): > stream: Traverse graph after modification > block: Manipulate children list in .attach/.detach > block: Unite remove_empty_child and child_free > block: Drop detached child from ignore list > block: Pass BdrvChild **

Re: [PATCH 6/7] block: Let replace_child_noperm free children

2021-11-05 Thread Kevin Wolf
Am 04.11.2021 um 11:38 hat Hanna Reitz geschrieben: > In most of the block layer, especially when traversing down from other > BlockDriverStates, we assume that BdrvChild.bs can never be NULL. When > it becomes NULL, it is expected that the corresponding BdrvChild pointer > also becomes NULL and t

Re: [PATCH v4 3/3] qapi: deprecate drive-backup

2021-11-05 Thread Eric Blake
On Thu, Nov 04, 2021 at 09:58:11AM +0100, Markus Armbruster wrote: > From: Vladimir Sementsov-Ogievskiy > > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > As example of drive-backup problems consider the following: > > User o

Re: [PATCH v4 5/7] blockdev: Add a new IF type IF_OTHER

2021-11-05 Thread Markus Armbruster
Hao Wu writes: > This type is used to represent block devs that are not suitable to > be represented by other existing types. Hinting at intended use wouldn't hurt: ", such as " > > Signed-of-by: Hao Wu > --- > blockdev.c| 3 ++- > include/sysemu/blockdev.h | 1 + > meson

Re: [PATCH v4 6/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards

2021-11-05 Thread Markus Armbruster
Hao Wu writes: > We made 3 changes to the at24c_eeprom_init function in > npcm7xx_boards.c: > > 1. We allow the function to take a I2CBus* as parameter. This allows >us to attach an EEPROM device behind an I2C mux which is not >possible with the old method. > > 2. We make at24c EEPROMs ar