On Oct 27 18:49, Lukasz Maniak wrote:
> On Tue, Oct 26, 2021 at 08:20:12PM +0200, Klaus Jensen wrote:
> > On Oct 7 18:23, Lukasz Maniak wrote:
> > > Hi,
> > >
> > > This series of patches is an attempt to add support for the following
> > > sections of NVMe specification revision 1.4:
> > >
> >
Emanuele Giuseppe Esposito wrote:
> init_dirty_bitmap_migration assumes the iothread lock (BQL)
> to be held, but instead it isn't.
>
> Instead of adding the lock to qemu_savevm_state_setup(),
> follow the same pattern as the other ->save_setup callbacks
> and lock+unlock inside dirty_bitmap_save_
Juan Quintela wrote:
> Emanuele Giuseppe Esposito wrote:
>> init_dirty_bitmap_migration assumes the iothread lock (BQL)
>> to be held, but instead it isn't.
>>
>> Instead of adding the lock to qemu_savevm_state_setup(),
>> follow the same pattern as the other ->save_setup callbacks
>> and lock+un
Am 29.10.2021 um 15:07 hat Eric Blake geschrieben:
> On Mon, Oct 25, 2021 at 07:25:25AM +0200, Markus Armbruster wrote:
> > Add special feature 'unstable' everywhere the name starts with 'x-',
> > except for InputBarrierProperties member x-origin and
> > MemoryBackendProperties member x-use-canonic
On 11/1/21 1:29 PM, John Snow wrote:
The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e:
Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into
staging (2021-10-30 11:31:41 -0700)
are available in the Git repository at:
https://gitlab.com/jsnow
On Fri, Oct 29, 2021 at 12:38:59PM -0400, Emanuele Giuseppe Esposito wrote:
> RFC: not sure if the current patch organization is correct.
> Bisecting in patches in between this serie would cause tests
> to deadlock.
Patch series must be bisectable. It will be necessary to fix this.
Stefan
signa
On Fri, Oct 29, 2021 at 12:39:00PM -0400, Emanuele Giuseppe Esposito wrote:
> job-common.h contains all struct and common function that currently
> are in job.h and will be shared by job-monitor and job-driver in
> the next commits.
>
> No functional change intended.
>
> Signed-off-by: Emanuele G
On Fri, Oct 29, 2021 at 12:39:01PM -0400, Emanuele Giuseppe Esposito wrote:
> job mutex will be used to protect the job struct elements and list,
> replacing AioContext locks.
>
> Right now use a shared lock for all jobs, in order to keep things
> simple. Once the AioContext lock is gone, we can i
On Fri, Oct 29, 2021 at 12:39:02PM -0400, Emanuele Giuseppe Esposito wrote:
> Categorize the fields in struct Job to understand which need
> to be protected by the job muutex and which not.
s/muutex/mutex/
(__)
`\--(oo)
||(__) .o( moo-tex )
||w--||
BTW "which ones nee
29.10.2021 19:39, Emanuele Giuseppe Esposito wrote:
job_event_* functions can be all static, as they are not used
outside job.c
Add also missing notifier initialization for the on_idle
list in job_create().
Signed-off-by: Emanuele Giuseppe Esposito
---
job.c | 13 +++--
1 file chang
29.10.2021 19:39, Emanuele Giuseppe Esposito wrote:
These functions will be useful when job_lock is globally applied,
as they will allow drivers to access the job struct fields
without worrying about the job lock.
Now that we are done with the job API header split, update also
the comments in bl
On 02/11/2021 12.34, Paolo Bonzini wrote:
On 28/10/21 20:59, Thomas Huth wrote:
Checking for xfsctl() can be done more easily in meson.build. Also,
this is not a "real" feature like the other features that we provide
with the "--enable-xxx" and "--disable-xxx" switches for the
configure script,
Am 26.10.2021 um 11:07 hat Hanna Reitz geschrieben:
> Similarly to e7e588d432d31ecebc26358e47201dd108db964c, there is a
> warning in block/block-backend.c that qiov->size <= INT64_MAX is always
> true on machines where size_t is narrower than a uint64_t. In said
> commit, we silenced this warning
Am 17.09.2021 um 20:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 17.09.2021 17:49, Hanna Reitz wrote:
> > On 15.09.21 16:45, Hanna Reitz wrote:
> > > On 14.09.21 12:25, Vladimir Sementsov-Ogievskiy wrote:
> > > > These series makes tests pass with
> > > >
> > > > IMGOPTS='compression_typ
On Wed, Oct 27, 2021 at 03:06:37PM +0200, Kevin Wolf wrote:
Am 27.10.2021 um 11:23 hat Stefano Garzarella geschrieben:
On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote:
> Stefano Garzarella writes:
>
> > Commit d7ddd0a161 ("linux-aio: limit the batch size using
> > `aio-max-bat
On 02/11/21 12:38, Thomas Huth wrote:
struct dioattr {
u32 d_mem; /* data buffer memory alignment */
u32 d_miniosz; /* min xfer size */
u32 d_maxiosz; /* max xfer size */
};
#define XFS_IO
Am 26.10.2021 um 18:23 hat Stefano Garzarella geschrieben:
> v1:
> https://lore.kernel.org/qemu-devel/20210923143100.182979-1-sgarz...@redhat.com
> v2:
> - @aio-max-batch documentation rewrite [Stefan, Kevin]
> - added Stefan and Kevin R-b tags
>
> Commit d7ddd0a161 ("linux-aio: limit the batch s
Am 07.10.2021 um 15:34 hat Philippe Mathieu-Daudé geschrieben:
> On 10/7/21 15:29, Stefan Hajnoczi wrote:
> > On Wed, Oct 06, 2021 at 06:49:31PM +0200, Philippe Mathieu-Daudé wrote:
> >> nvme_create_queue_pair() allocates resources with qemu_vfio_dma_map(),
> >> but we never release them. Do it in
On 11/2/21 13:33, Kevin Wolf wrote:
> Am 07.10.2021 um 15:34 hat Philippe Mathieu-Daudé geschrieben:
>> On 10/7/21 15:29, Stefan Hajnoczi wrote:
>>> On Wed, Oct 06, 2021 at 06:49:31PM +0200, Philippe Mathieu-Daudé wrote:
nvme_create_queue_pair() allocates resources with qemu_vfio_dma_map(),
>>
Hmm. subject looks like it's safe to remove aiocontext locks from any qmp
command?
For example, commit 91005a495e228eb added aiocontext locks back to qmp bitmap
add/remove commands because otherwise they crashed.
So, I'm not sure that being under BQL is enough to drop aiocontext locking..
29
On 28.10.21 12:24, Vladimir Sementsov-Ogievskiy wrote:
With new option qemu-img compare will not stop at first mismatch, but
instead calculate statistics: how many clusters with different data,
how many clusters with equal data, how many clusters were unallocated
but become data and so on.
We co
On 28.10.21 12:24, Vladimir Sementsov-Ogievskiy wrote:
Let's detect block-size automatically if not specified by user:
If both files define cluster-size, use minimum to be more precise.
If both files don't specify cluster-size, use default of 64K
If only one file specify cluster-size, just
29.10.2021 19:39, Emanuele Giuseppe Esposito wrote:
Introduce the job locking mechanism through the whole job API,
following the comments and requirements of job-monitor (assume
lock is held) and job-driver (lock is not held).
At this point, we do not care if the job lock is inside or outside
th
29.10.2021 19:38, Emanuele Giuseppe Esposito wrote:
In this series, we want to remove the AioContext lock and instead
use the already existent job_mutex to protect the job structures
and list. This is part of the work to get rid of AioContext lock
usage in favour of smaller granularity locks.
In
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50:
Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into
staging (2021-11-02 05:53:45 -0400)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2021-11-02
f
On Oct 7 18:24, Lukasz Maniak wrote:
> From: Łukasz Gieryk
>
> This patch implements the FLR, a feature currently not implemented for
> the Nvme device, while listed as a mandatory ("shall") in the 1.4 spec.
>
> The implementation reuses FLR-related building blocks defined for the
> pci-bridge
From: Eric Blake
Use consistent capitalization, and fix a missed line (we duplicate the
qemu-img synopses in too many places).
Fixes: 1899bf4737 (qemu-img: Add -F shorthand to convert)
Signed-off-by: Eric Blake
Message-Id: <20210921142812.2631605-1-ebl...@redhat.com>
Reviewed-by: Vladimir Semen
From: Emanuele Giuseppe Esposito
Test 297 in tests/qemu-iotests currently fails: pylint has
learned new things to check, or we simply missed them.
All fixes in this patch are related to additional spaces used
or wrong indentation. No functional change intended.
Signed-off-by: Emanuele Giuseppe
On 02/11/2021 14:08, Vladimir Sementsov-Ogievskiy wrote:
29.10.2021 19:38, Emanuele Giuseppe Esposito wrote:
In this series, we want to remove the AioContext lock and instead
use the already existent job_mutex to protect the job structures
and list. This is part of the work to get rid of AioC
From: Thomas Huth
The code in vpc.c uses BDRVVPCState->footer.type in various places
to decide whether the image is a fixed-size (VHD_FIXED) or a dynamic
(VHD_DYNAMIC) image. However, we never check that this field really
contains VHD_FIXED if we detected a fixed size image in vpc_open(),
so a wr
From: Thomas Weißschuh
VMDK files support an attribute that represents the version of the guest
tools that are installed on the disk.
This attribute is used by vSphere before a machine has been started to
determine if the VM has the guest tools installed.
This is important when configuring "Opera
On Oct 7 18:23, Lukasz Maniak wrote:
> This patch implements initial support for Single Root I/O Virtualization
> on an NVMe device.
>
> Essentially, it allows to define the maximum number of virtual functions
> supported by the NVMe controller via sriov_max_vfs parameter.
>
> Passing a non-zero
On Oct 7 18:23, Lukasz Maniak wrote:
> Implementation of Primary Controller Capabilities data
> structure (Identify command with CNS value of 14h).
>
> Currently, the command returns only ID of a primary controller.
> Handling of remaining fields are added in subsequent patches
> implementing vir
On Oct 7 18:23, Lukasz Maniak wrote:
> Introduce handling for Secondary Controller List (Identify command with
> CNS value of 15h).
>
> Secondary controller ids are unique in the subsystem, hence they are
> reserved by it upon initialization of the primary controller to the
> number of sriov_max_
02.11.2021 17:13, Emanuele Giuseppe Esposito wrote:
On 02/11/2021 14:08, Vladimir Sementsov-Ogievskiy wrote:
29.10.2021 19:38, Emanuele Giuseppe Esposito wrote:
In this series, we want to remove the AioContext lock and instead
use the already existent job_mutex to protect the job structures
a
Am 02.11.2021 um 13:36 hat Philippe Mathieu-Daudé geschrieben:
> On 11/2/21 13:33, Kevin Wolf wrote:
> > Am 07.10.2021 um 15:34 hat Philippe Mathieu-Daudé geschrieben:
> >> On 10/7/21 15:29, Stefan Hajnoczi wrote:
> >>> On Wed, Oct 06, 2021 at 06:49:31PM +0200, Philippe Mathieu-Daudé wrote:
>
On 11/2/21 16:14, Peter Maydell wrote:
> Does it make sense for a device/board to do drive_get_next(IF_NONE) ?
>
> At the moment we have exactly one user of this, which is
> hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable
> fuse, and the drive is providing the backing store for
Does it make sense for a device/board to do drive_get_next(IF_NONE) ?
At the moment we have exactly one user of this, which is
hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable
fuse, and the drive is providing the backing store for the fuse
contents. Borrowing an IF_NONE for this
On 11/2/21 15:50, Kevin Wolf wrote:
> Am 02.11.2021 um 13:36 hat Philippe Mathieu-Daudé geschrieben:
>> On 11/2/21 13:33, Kevin Wolf wrote:
>>> Should we still merge (parts of) this series for 6.2? Or does this mean
>>> that we don't want it at all?
>>
>> Patches #1-4 are cleanups welcome for 6.2
From: Ari Sundholm
AIO discards regressed as a result of the following commit:
0dfc7af2 block/file-posix: Optimize for macOS
When trying to run blkdiscard within a Linux guest, the request would
fail, with some errors in dmesg:
[ snip ]
[4.010070] sd 2:0:0:0: [sda] tag#0 F
From: Peter Lieven
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly in incorrect progress during block operations (e.g.
qemu-img convert with an rbd image as source).
This patch utilizes the rbd_diff_iterate2 call from librbd to detect
allocated and unall
From: Philippe Mathieu-Daudé
For debugging purpose it is helpful to know the CQ/SQ pointers.
We already have a trace event in nvme_free_queue_pair(), extend
it to report these pointer addresses.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20211006164931.172349-3-phi...@redhat.com>
Review
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50:
Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into
staging (2021-11-02 05:53:45 -0400)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fet
Using blockdev-snapshot to append a node as an overlay to itself, or to
any of its parents, causes crashes. Catch the condition and return an
error for these cases instead.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1824363
Signed-off-by: Kevin Wolf
Message-Id: <20211018134714.48438-1-kw.
From: Stefano Garzarella
This new parameter can be used by block devices to limit the
Linux AIO batch size more than the limit set by the AIO context.
file-posix backend supports this, passing its `aio-max-batch` option
previously added.
Add an helper function to calculate the maximum batch siz
From: Philippe Mathieu-Daudé
Instead of duplicating code, extract the common helper to free
a single queue.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20211006164931.172349-4-phi...@redhat.com>
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
---
block/nvme.c | 9 +++--
1 f
From: Samuel Thibault
The LBA28 capacity (at offsets 60/61 of identification) is supposed to
express the maximum size supported by LBA28 commands. If the device is
larger than this, we have to cap it to 2^28-1.
At least NetBSD happens to be using this value to determine whether to use
LBA28 or L
From: Fabrice Fontaine
Include linux/falloc.h if CONFIG_FALLOCATE_ZERO_RANGE is defined to fix
https://gitlab.com/qemu-project/qemu/-/commit/50482fda98bd62e072c30b7ea73c985c4e9d9bbb
and avoid the following build failure on musl:
../block/export/fuse.c: In function 'fuse_fallocate':
../block/expo
From: Hanna Reitz
Similarly to e7e588d432d31ecebc26358e47201dd108db964c, there is a
warning in block/block-backend.c that qiov->size <= INT64_MAX is always
true on machines where size_t is narrower than a uint64_t. In said
commit, we silenced this warning by casting to uint64_t.
The commit intr
From: Stefano Garzarella
Commit d7ddd0a161 ("linux-aio: limit the batch size using
`aio-max-batch` parameter") added a way to limit the batch size
of Linux AIO backend for the entire AIO context.
The same AIO context can be shared by multiple devices, so
latency-sensitive devices may want to lim
From: Stefano Garzarella
Between the submission of a request and the unplug, other devices
with larger limits may have been queued new requests without flushing
the batch.
Using the new `dev_max_batch` parameter, laio_io_unplug() can check
if the batch exceeds the device limit to flush the curre
From: Philippe Mathieu-Daudé
Since commit 4d324c0bf65 ("introduce QEMU_AUTO_VFREE") buffers
allocated by qemu_memalign() can automatically freed when using
the QEMU_AUTO_VFREE macro. Use it to simplify a bit.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20211006164931.172349-2-phi...@redh
On Tue, Nov 02, 2021 at 03:33:15PM +0100, Klaus Jensen wrote:
> On Oct 7 18:23, Lukasz Maniak wrote:
> > This patch implements initial support for Single Root I/O Virtualization
> > on an NVMe device.
> >
> > Essentially, it allows to define the maximum number of virtual functions
> > supported b
On 10/7/21 8:26 PM, Hao Wu wrote:
+static void write_sdread(QTestState *qts, const char *msg)
+{
+size_t len = strlen(msg);
+char *rmsg = g_malloc(len);
+
+/* write message to sd */
+int fd = open(sd_path, O_WRONLY);
+int ret;
+
+g_assert(fd > 0);
+ret = write(fd, msg,
This patch set implements the Nuvoton MMC device
for NPCM7XX boards.
The MMC device is compatible with the SDHCI interface
in QEMU. It allows the user to attach an SD card image
to it.
Changes since v2:
1. Fix an error use of strcmp in qtest.
Changes since v1:
1. Rearrange the "add SDHCI command
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Hao Wu
Reviewed-by: Chris Rauer
Reviewed-by: Tyrone Ting
Signed-off-by: Hao Wu
Reviewed-by: Peter Maydell
---
hw/sd/meson.build | 1 +
hw/sd/npcm7xx_sdhci.c | 182 ++
include/
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Hao Wu
Reviewed-by: Tyrone Ting
Signed-off-by: Hao Wu
Reviewed-by: Peter Maydell
---
hw/arm/npcm7xx_boards.c | 20
1 file changed, 20 insertions(+)
diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Hao Wu
Reviewed-by: Chris Rauer
Reviewed-by: Tyrone Ting
Signed-off-by: Hao Wu
Reviewed-by: Peter Maydell
---
hw/arm/npcm7xx.c | 12 +++-
include/hw/arm/npcm7xx.h | 2 ++
2 files changed, 13 insertions(+), 1 delet
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Hao Wu
Reviewed-by: Chris Rauer
Reviewed-by: Tyrone Ting
Signed-off-by: Hao Wu
Reviewed-by: Peter Maydell
---
tests/qtest/libqos/meson.build | 1 +
tests/qtest/libqos/sdhci-cmd.c | 116 +
tests/qt
From: Shengtan Mao
Signed-off-by: Shengtan Mao
Reviewed-by: Hao Wu
Reviewed-by: Chris Rauer
Reviewed-by: Tyrone Ting
Signed-off-by: Hao Wu
Reviewed-by: Peter Maydell
---
tests/qtest/meson.build | 1 +
tests/qtest/npcm7xx_sdhci-test.c | 209 +++
2 file
On 11/2/21 10:22 AM, Hanna Reitz wrote:
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50:
Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into
staging (2021-11-02 05:53:45 -0400)
are available in the Git repository at:
https://github.com/Xa
On 11/2/21 12:05 PM, Kevin Wolf wrote:
The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50:
Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into
staging (2021-11-02 05:53:45 -0400)
are available in the Git repository at:
git://repo.or.cz/qemu/
62 matches
Mail list logo
